60225 2011-05-04 16:05:14 -0700 [results.html] Hide the entire table if all failures are expected 2011-05-04 16:56:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric tony oldest_to_newest 398353 0 ojan 2011-05-04 16:05:14 -0700 [results.html] Hide the entire table if all failures are expected 398361 1 92340 ojan 2011-05-04 16:09:55 -0700 Created attachment 92340 Patch 398363 2 92340 eric 2011-05-04 16:11:02 -0700 Comment on attachment 92340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92340&action=review OK. > LayoutTests/fast/harness/results.html:387 > + if (globalState().results.uses_expectations_file) { Could we do this as a helper method so that this can jsut early return instead? 398407 3 ojan 2011-05-04 16:56:47 -0700 Committed r85809: <http://trac.webkit.org/changeset/85809> 92340 2011-05-04 16:09:55 -0700 2011-05-04 16:11:02 -0700 Patch bug-60225-20110504160954.patch text/plain 6579 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODU3OTgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2ZmIzYTNiMmVmZWQ5NTQyZThlNGI3 MWIxNmM0ZTRmZGQyMmUxZjlhLi4yYjIyYmViMjIxZjlkODcyMjNiZTk5NDVmYTkzZWYwYjc5YWYy M2Q0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDUtMDQgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbcmVzdWx0cy5odG1sXSBIaWRlIHRoZSBlbnRpcmUgdGFibGUgaWYgYWxsIGZhaWx1 cmVzIGFyZSBleHBlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjAyMjUKKworICAgICAgICBJZiBpbiBhIHBvcnQgdGhhdCB1c2VzIGV4cGVjdGVk IHJlc3VsdHMgYW5kIGFsbCBmYWlsdXJlcyBhcmUgZXhwZWN0ZWQsCisgICAgICAgIGhpZGUgdGhl IHRhYmxlIGFzIHdlbGwgYXMgdGhlIHJvd3Mgd2hlbiBoaWRpbmcgZXhwZWN0ZWQgZmFpbHVyZXMu CisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qczoKKyAg ICAgICAgKiBmYXN0L2hhcm5lc3MvcmVzdWx0cy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFz dC9oYXJuZXNzL3Jlc3VsdHMuaHRtbDoKKworMjAxMS0wNS0wNCAgT2phbiBWYWZhaSAgPG9qYW5A Y2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAg ICAgIFtyZXN1bHRzLmh0bWxdIHB1dCBmbGFreSB0ZXN0cyBpbnRvIHRoZWlyIG93biB0YWJsZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRl c3QuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5q cwppbmRleCBmODM0YmE3YjFmZDVkYjk5YTlmYTI4YjU1MTA0MjUxMDBjOGM2NzY4Li5mZDhjZjg0 Nzg4OTAzMjcwNzBmODNiYTkwZmFjNDlhYjNhYTUyNTJiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qcworKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qcwpAQCAtMjM4LDYgKzIzOCwx MiBAQCBmdW5jdGlvbiBydW5UZXN0cygpCiAgICAgICAgIGFzc2VydFRydWUoZG9jdW1lbnQucXVl cnlTZWxlY3RvckFsbCgnLnJlc3VsdHMtcm93JykubGVuZ3RoID09IDIpOwogICAgICAgICBhc3Nl cnRUcnVlKHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwo J3Rib2R5JylbMF0sIG51bGwpWydkaXNwbGF5J10gIT0gJ25vbmUnKTsKICAgICB9KTsKKyAgICAK KyAgICByZXN1bHRzID0gbW9ja1Jlc3VsdHMoKTsKKyAgICByZXN1bHRzLnRlc3RzWydvbmx5LWV4 cGVjdGVkLWZhaWwuaHRtbCddID0gbW9ja0V4cGVjdGF0aW9uKCdURVhUJywgJ1RFWFQnKTsKKyAg ICBydW5UZXN0KHJlc3VsdHMsIGZ1bmN0aW9uKCkgeworICAgICAgICBhc3NlcnRUcnVlKHdpbmRv dy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHRzLXRhYmxl JykucGFyZW50Tm9kZSwgbnVsbClbJ2Rpc3BsYXknXSA9PSAnbm9uZScpOworICAgIH0pOwogCiAg ICAgcnVuRGVmYXVsdFNpbmdsZVJvd1Rlc3QoJ2Jhci1za2lwLmh0bWwnLCAnVEVYVCcsICdTS0lQ JywgdHJ1ZSwgJycsICcnKTsKICAgICBydW5EZWZhdWx0U2luZ2xlUm93VGVzdCgnYmFyLWZsYWt5 LWZhaWwuaHRtbCcsICdQQVNTIEZBSUwnLCAnVEVYVCcsIHRydWUsICdleHBlY3RlZCBhY3R1YWwg ZGlmZiAnLCAnJyk7CkBAIC0zMDMsNiArMzA5LDcgQEAgZnVuY3Rpb24gcnVuVGVzdHMoKQogICAg IHN1YnRyZWVbJ2ZsYWt5LWZhaWwuaHRtbCddID0gbW9ja0V4cGVjdGF0aW9uKCdQQVNTIFRFWFQn LCAnSU1BR0UgUEFTUycpOwogICAgIHJlc3VsdHMudXNlc19leHBlY3RhdGlvbnNfZmlsZSA9IGZh bHNlOwogICAgIHJ1blRlc3QocmVzdWx0cywgZnVuY3Rpb24oKSB7CisgICAgICAgIGFzc2VydFRy dWUod2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3Vs dHMtdGFibGUnKS5wYXJlbnROb2RlLCBudWxsKVsnZGlzcGxheSddICE9ICdub25lJyk7CiAgICAg ICAgIGFzc2VydFRydWUoZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnI3Jlc3VsdHMtdGFibGUg dGJvZHkgdGQnKS5sZW5ndGggPT0gMyk7CiAgICAgICAgIGFzc2VydFRydWUoIWRvY3VtZW50LnF1 ZXJ5U2VsZWN0b3IoJ3Rib2R5LmV4cGVjdGVkJykpOwogICAgICAgICBhc3NlcnRUcnVlKCFkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgncGFzc2VzLXRhYmxlJykpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9oYXJuZXNzL3Jlc3VsdHMtZXhwZWN0ZWQudHh0CmluZGV4IDhmODkxOWE1YmZlOWQ0NDI0ZjA2 ZDQ0MGY5MThjODMzODQyYTJmNjUuLmRiYmU2ZDQ5YTAwNjRkNTRkYzMzOWY1NWRjOTJlMzkxZjk4 ZDY2ZjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRzLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy1leHBlY3RlZC50 eHQKQEAgLTQ1LDExICs0NSw2IEBAIFRFU1QtNjogUEFTUwogVEVTVC02OiBQQVNTCiBURVNULTY6 IFBBU1MKIFRFU1QtNzogUEFTUwotVEVTVC03OiBQQVNTCi1URVNULTc6IFBBU1MKLVRFU1QtNzog UEFTUwotVEVTVC03OiBQQVNTCi1URVNULTc6IFBBU1MKIFRFU1QtODogUEFTUwogVEVTVC04OiBQ QVNTCiBURVNULTg6IFBBU1MKQEAgLTk1LDMxICs5MCwzOCBAQCBURVNULTE0OiBQQVNTCiBURVNU LTE1OiBQQVNTCiBURVNULTE1OiBQQVNTCiBURVNULTE1OiBQQVNTCitURVNULTE1OiBQQVNTCitU RVNULTE1OiBQQVNTCitURVNULTE1OiBQQVNTCiBURVNULTE2OiBQQVNTCiBURVNULTE2OiBQQVNT CiBURVNULTE2OiBQQVNTCiBURVNULTE3OiBQQVNTCiBURVNULTE3OiBQQVNTCiBURVNULTE3OiBQ QVNTCi1URVNULTE3OiBQQVNTCitURVNULTE4OiBQQVNTCitURVNULTE4OiBQQVNTCiBURVNULTE4 OiBQQVNTCiBURVNULTE4OiBQQVNTCiBURVNULTE5OiBQQVNTCiBURVNULTE5OiBQQVNTCi1URVNU LTE5OiBQQVNTCi1URVNULTE5OiBQQVNTCitURVNULTIwOiBQQVNTCitURVNULTIwOiBQQVNTCitU RVNULTIwOiBQQVNTCiBURVNULTIwOiBQQVNTCiBURVNULTIwOiBQQVNTCiBURVNULTIxOiBQQVNT CiBURVNULTIxOiBQQVNTCiBURVNULTIyOiBQQVNTCitURVNULTIyOiBQQVNTCiBURVNULTIzOiBQ QVNTCi1URVNULTIzOiBQQVNTCitURVNULTI0OiBQQVNTCiBURVNULTI0OiBQQVNTCiBURVNULTI1 OiBQQVNTCiBURVNULTI2OiBQQVNTCiBURVNULTI3OiBQQVNTCi1URVNULTI3OiBQQVNTCi1URVNU LTI3OiBQQVNTCiBURVNULTI4OiBQQVNTCiBURVNULTI4OiBQQVNTCitURVNULTI4OiBQQVNTCitU RVNULTI5OiBQQVNTCitURVNULTI5OiBQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2hhcm5lc3MvcmVzdWx0cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMu aHRtbAppbmRleCAwMjBhMjc0NTE1MGI2ZTcwNzBiNTI4ZGE0ZjQ4YzBmMjdiMjI5NTI4Li44OTEw ODc0NDg0NjE4OGI1YTlmOTViMGFlMzE1NGYzMmFlNTZhNGZlIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGFy bmVzcy9yZXN1bHRzLmh0bWwKQEAgLTM4NCwxNiArMzg0LDE4IEBAIGZ1bmN0aW9uIHByb2Nlc3NH bG9iYWxTdGF0ZUZvcih0ZXN0T2JqZWN0KQogICAgIH0KIAogICAgIHZhciBleHBlY3RlZCA9IHRl c3RPYmplY3QuZXhwZWN0ZWQgfHwgJ1BBU1MnOwotICAgIHRlc3RPYmplY3QuaXNFeHBlY3RlZCA9 IHRydWU7Ci0gICAgaWYgKGFjdHVhbCAhPSAnU0tJUCcgJiYgZ2xvYmFsU3RhdGUoKS5yZXN1bHRz LnVzZXNfZXhwZWN0YXRpb25zX2ZpbGUpIHsKLSAgICAgICAgdmFyIGV4cGVjdGVkQXJyYXkgPSBl eHBlY3RlZC5zcGxpdCgnICcpOwotICAgICAgICB2YXIgYWN0dWFsQXJyYXkgPSBhY3R1YWwuc3Bs aXQoJyAnKTsKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBhY3R1YWxBcnJheS5sZW5ndGg7 IGkrKykgewotICAgICAgICAgICAgdmFyIGFjdHVhbFZhbHVlID0gYWN0dWFsQXJyYXlbaV07Ci0g ICAgICAgICAgICBpZiAoZXhwZWN0ZWRBcnJheS5pbmRleE9mKGFjdHVhbFZhbHVlKSA9PSAtMSAm JgotICAgICAgICAgICAgICAgIChleHBlY3RlZEFycmF5LmluZGV4T2YoJ0ZBSUwnKSA9PSAtMSB8 fAotICAgICAgICAgICAgICAgICAoYWN0dWFsVmFsdWUgIT0gJ0lNQUdFJyAmJiBhY3R1YWxWYWx1 ZSAhPSAnVEVYVCcgJiYgYWN0dWFsVmFsdWUgIT0gJ0lNQUdFK1RFWFQnKSkpCi0gICAgICAgICAg ICAgICAgdGVzdE9iamVjdC5pc0V4cGVjdGVkID0gZmFsc2U7CisgICAgaWYgKGdsb2JhbFN0YXRl KCkucmVzdWx0cy51c2VzX2V4cGVjdGF0aW9uc19maWxlKSB7CisgICAgICAgIHRlc3RPYmplY3Qu aXNFeHBlY3RlZCA9IHRydWU7CisgICAgICAgIGlmIChhY3R1YWwgIT0gJ1NLSVAnKSB7CisgICAg ICAgICAgICB2YXIgZXhwZWN0ZWRBcnJheSA9IGV4cGVjdGVkLnNwbGl0KCcgJyk7CisgICAgICAg ICAgICB2YXIgYWN0dWFsQXJyYXkgPSBhY3R1YWwuc3BsaXQoJyAnKTsKKyAgICAgICAgICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgYWN0dWFsQXJyYXkubGVuZ3RoOyBpKyspIHsKKyAgICAgICAgICAg ICAgICB2YXIgYWN0dWFsVmFsdWUgPSBhY3R1YWxBcnJheVtpXTsKKyAgICAgICAgICAgICAgICBp ZiAoZXhwZWN0ZWRBcnJheS5pbmRleE9mKGFjdHVhbFZhbHVlKSA9PSAtMSAmJgorICAgICAgICAg ICAgICAgICAgICAoZXhwZWN0ZWRBcnJheS5pbmRleE9mKCdGQUlMJykgPT0gLTEgfHwKKyAgICAg ICAgICAgICAgICAgICAgIChhY3R1YWxWYWx1ZSAhPSAnSU1BR0UnICYmIGFjdHVhbFZhbHVlICE9 ICdURVhUJyAmJiBhY3R1YWxWYWx1ZSAhPSAnSU1BR0UrVEVYVCcpKSkKKyAgICAgICAgICAgICAg ICAgICAgdGVzdE9iamVjdC5pc0V4cGVjdGVkID0gZmFsc2U7CisgICAgICAgICAgICB9CiAgICAg ICAgIH0KICAgICB9CiAKQEAgLTg5NiwyNCArODk4LDM0IEBAIGZ1bmN0aW9uIGZhaWxpbmdUZXN0 c1RhYmxlKHRlc3RzLCB0aXRsZSwgaWQpCiAgICAgaWYgKCF0ZXN0cy5sZW5ndGgpCiAgICAgICAg IHJldHVybiAnJzsKIAotICAgIHZhciBodG1sID0gJzxwPicgKyB0aXRsZSArICc6PC9wPicgKwor ICAgIHZhciB0YWJsZVJvd0h0bWwgPSAnJzsKKyAgICB2YXIgaGFzVW5leHBlY3RlZCA9IGZhbHNl OworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGVzdHMubGVuZ3RoOyBpKyspIHsKKyAgICAgICAg aWYgKCF0ZXN0c1tpXS5pc0V4cGVjdGVkKQorICAgICAgICAgICAgaGFzVW5leHBlY3RlZCA9IHRy dWU7CisgICAgICAgIHRhYmxlUm93SHRtbCArPSB0YWJsZVJvdyh0ZXN0c1tpXSk7CisgICAgfQor CisgICAgdmFyIGhlYWRlciA9ICc8ZGl2JzsKKyAgICBpZiAoIWhhc1VuZXhwZWN0ZWQpCisgICAg ICAgIGhlYWRlciArPSAnIGNsYXNzPWV4cGVjdGVkJzsKKworICAgIGhlYWRlciArPSAnPjxwPicg KyB0aXRsZSArICc6PC9wPicgKwogICAgICAgICAnPHRhYmxlIGlkPSInICsgaWQgKyAnIj48dGhl YWQ+PHRyPicgKwogICAgICAgICAnPHRoPnRlc3Q8L3RoPicgKwogICAgICAgICAnPHRoIGlkPSJ0 ZXh0LXJlc3VsdHMtaGVhZGVyIj5yZXN1bHRzPC90aD4nICsKICAgICAgICAgJzx0aCBpZD0iaW1h Z2UtcmVzdWx0cy1oZWFkZXIiPmltYWdlIHJlc3VsdHM8L3RoPic7CiAKICAgICBpZiAoZ2xvYmFs U3RhdGUoKS5yZXN1bHRzLnVzZXNfZXhwZWN0YXRpb25zX2ZpbGUpCi0gICAgICAgIGh0bWwgKz0g Jzx0aD5hY3R1YWwgZmFpbHVyZTwvdGg+PHRoPmV4cGVjdGVkIGZhaWx1cmU8L3RoPic7CisgICAg ICAgIGhlYWRlciArPSAnPHRoPmFjdHVhbCBmYWlsdXJlPC90aD48dGg+ZXhwZWN0ZWQgZmFpbHVy ZTwvdGg+JzsKIAogICAgIGlmIChpZCA9PSAnZmxha3ktdGVzdHMtdGFibGUnKQotICAgICAgICBo dG1sICs9ICc8dGg+ZmFpbHVyZXM8L3RoPic7CisgICAgICAgIGhlYWRlciArPSAnPHRoPmZhaWx1 cmVzPC90aD4nOwogCi0gICAgaHRtbCArPSAnPC90cj48L3RoZWFkPic7CisgICAgaGVhZGVyICs9 ICc8L3RyPjwvdGhlYWQ+JzsKIAotICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGVzdHMubGVuZ3Ro OyBpKyspCi0gICAgICAgIGh0bWwgKz0gdGFibGVSb3codGVzdHNbaV0pOwogCi0gICAgcmV0dXJu IGh0bWwgKyAnPC90YWJsZT4nOworICAgIHJldHVybiBoZWFkZXIgKyB0YWJsZVJvd0h0bWwgKyAn PC90YWJsZT48L2Rpdj4nOwogfQogCiAK