60224 2011-05-04 16:01:23 -0700 [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0. 2011-05-05 07:14:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 menard menard oldest_to_newest 398350 0 menard 2011-05-04 16:01:23 -0700 [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0. 398354 1 92339 menard 2011-05-04 16:05:52 -0700 Created attachment 92339 Patch 398358 2 menard 2011-05-04 16:06:34 -0700 See RenderTheme.cpp to double check what I'm saying. 398694 3 92339 kling 2011-05-05 06:43:48 -0700 Comment on attachment 92339 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92339&action=review Did you performance test this? > Source/WebCore/ChangeLog:9 > + but webkit already have a nullptr class if there is no c++0x support. webkit -> WebKit have -> has > Source/WebKit/qt/ChangeLog:9 > + We should use nullptr rather than 0. nullptr will be added in the new C++ standard > + but webkit already have a nullptr class if there is no c++0x support. Ditto. 398706 4 menard 2011-05-05 07:14:34 -0700 Committed r85851: <http://trac.webkit.org/changeset/85851> 92339 2011-05-04 16:05:52 -0700 2011-05-05 06:43:47 -0700 Patch bug-60224-20110504200558.patch text/plain 3810 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1ODAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDQgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW5kZXJUaGVtZVF0IGFuZCBEdW1w UmVuZGVyVHJlZVN1cHBvcnRRdCBzaG91bGQgdXNlIG51bGxwdHIgcmF0aGVyIHRoYW4gMC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMjI0CisKKyAg ICAgICAgV2Ugc2hvdWxkIHVzZSBudWxscHRyIHJhdGhlciB0aGFuIDAuIG51bGxwdHIgd2lsbCBi ZSBhZGRlZCBpbiB0aGUgbmV3IEMrKyBzdGFuZGFyZAorICAgICAgICBidXQgd2Via2l0IGFscmVh ZHkgaGF2ZSBhIG51bGxwdHIgY2xhc3MgaWYgdGhlcmUgaXMgbm8gYysrMHggc3VwcG9ydC4KKwor ICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyVGhlbWVRdDo6YWRqdXN0UHJvZ3Jlc3NCYXJTdHlsZSk6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUaGVtZVF0OjphZGp1c3RTbGlkZXJUcmFja1N0eWxlKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRoZW1lUXQ6OmFkanVzdFNsaWRlclRodW1iU3R5bGUpOgorCiAyMDExLTA1 LTA0ICBGcmlkcmljaCBTdHJiYSAgPGZyaWRyaWNoLnN0cmJhQGJsdWV3aW4uY2g+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1JlbmRlclRoZW1lUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCShyZXZpc2lvbiA4NTc5NykKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NTMs NyArODUzLDcgQEAgZG91YmxlIFJlbmRlclRoZW1lUXQ6OmFuaW1hdGlvbkR1cmF0aW9uRgogCiB2 b2lkIFJlbmRlclRoZW1lUXQ6OmFkanVzdFByb2dyZXNzQmFyU3R5bGUoQ1NTU3R5bGVTZWxlY3Rv ciosIFJlbmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0CiB7Ci0gICAgc3R5bGUtPnNl dEJveFNoYWRvdygwKTsKKyAgICBzdHlsZS0+c2V0Qm94U2hhZG93KG51bGxwdHIpOwogfQogCiBi b29sIFJlbmRlclRoZW1lUXQ6OnBhaW50UHJvZ3Jlc3NCYXIoUmVuZGVyT2JqZWN0KiBvLCBjb25z dCBQYWludEluZm8mIHBpLCBjb25zdCBJbnRSZWN0JiByKQpAQCAtOTUwLDcgKzk1MCw3IEBAIGJv b2wgUmVuZGVyVGhlbWVRdDo6cGFpbnRTbGlkZXJUcmFjayhSZW4KIAogdm9pZCBSZW5kZXJUaGVt ZVF0OjphZGp1c3RTbGlkZXJUcmFja1N0eWxlKENTU1N0eWxlU2VsZWN0b3IqLCBSZW5kZXJTdHls ZSogc3R5bGUsIEVsZW1lbnQqKSBjb25zdAogewotICAgIHN0eWxlLT5zZXRCb3hTaGFkb3coMCk7 CisgICAgc3R5bGUtPnNldEJveFNoYWRvdyhudWxscHRyKTsKIH0KIAogYm9vbCBSZW5kZXJUaGVt ZVF0OjpwYWludFNsaWRlclRodW1iKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBw aSwKQEAgLTk2Miw3ICs5NjIsNyBAQCBib29sIFJlbmRlclRoZW1lUXQ6OnBhaW50U2xpZGVyVGh1 bWIoUmVuCiAKIHZvaWQgUmVuZGVyVGhlbWVRdDo6YWRqdXN0U2xpZGVyVGh1bWJTdHlsZShDU1NT dHlsZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqIHN0eWxlLCBFbGVtZW50KikgY29uc3QKIHsKLSAg ICBzdHlsZS0+c2V0Qm94U2hhZG93KDApOworICAgIHN0eWxlLT5zZXRCb3hTaGFkb3cobnVsbHB0 cik7CiB9CiAKIGJvb2wgUmVuZGVyVGhlbWVRdDo6cGFpbnRTZWFyY2hGaWVsZChSZW5kZXJPYmpl Y3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGksCkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwkocmV2aXNpb24g ODU4MDApCisrKyBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE2IEBACisyMDExLTA1LTA0ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBv cGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gUmVuZGVyVGhlbWVRdCBhbmQgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQgc2hv dWxkIHVzZSBudWxscHRyIHJhdGhlciB0aGFuIDAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDIyNAorCisgICAgICAgIFdlIHNob3VsZCB1c2UgbnVs bHB0ciByYXRoZXIgdGhhbiAwLiBudWxscHRyIHdpbGwgYmUgYWRkZWQgaW4gdGhlIG5ldyBDKysg c3RhbmRhcmQKKyAgICAgICAgYnV0IHdlYmtpdCBhbHJlYWR5IGhhdmUgYSBudWxscHRyIGNsYXNz IGlmIHRoZXJlIGlzIG5vIGMrKzB4IHN1cHBvcnQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZVN1 cHBvcnRRdDo6YWRkVXNlclN0eWxlU2hlZXQpOgorCiAyMDExLTA1LTA0ICBBbGV4aXMgTWVuYXJk ICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgd2Fy bmluZyBmaXguCkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L1dlYkNv cmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAkocmV2aXNpb24gODU3OTcpCisr KyBTb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTM3LDcgKzkzNyw3IEBAIFFTdHJpbmcgRHVtcFJlbmRl clRyZWVTdXBwb3J0UXQ6OnBhZ2VQcm8KIAogdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6 YWRkVXNlclN0eWxlU2hlZXQoUVdlYlBhZ2UqIHBhZ2UsIGNvbnN0IFFTdHJpbmcmIHNvdXJjZUNv ZGUpCiB7Ci0gICAgcGFnZS0+aGFuZGxlKCktPnBhZ2UtPmdyb3VwKCkuYWRkVXNlclN0eWxlU2hl ZXRUb1dvcmxkKG1haW5UaHJlYWROb3JtYWxXb3JsZCgpLCBzb3VyY2VDb2RlLCBRVXJsKCksIDAs IDAsIFdlYkNvcmU6OkluamVjdEluQWxsRnJhbWVzKTsKKyAgICBwYWdlLT5oYW5kbGUoKS0+cGFn ZS0+Z3JvdXAoKS5hZGRVc2VyU3R5bGVTaGVldFRvV29ybGQobWFpblRocmVhZE5vcm1hbFdvcmxk KCksIHNvdXJjZUNvZGUsIFFVcmwoKSwgbnVsbHB0ciwgbnVsbHB0ciwgV2ViQ29yZTo6SW5qZWN0 SW5BbGxGcmFtZXMpOwogfQogCiB2b2lkIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzaW11bGF0 ZURlc2t0b3BOb3RpZmljYXRpb25DbGljayhjb25zdCBRU3RyaW5nJiB0aXRsZSkK