60222 2011-05-04 15:48:26 -0700 Web Inspector: searching for node does not result in bringToFront call. 2011-05-05 09:38:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 398333 0 pfeldman 2011-05-04 15:48:26 -0700 Patch to follow. 398339 1 92335 pfeldman 2011-05-04 15:52:30 -0700 Created attachment 92335 Patch 398704 2 92335 yurys 2011-05-05 07:13:19 -0700 Comment on attachment 92335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92335&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:285 > + m_inspectorFrontend = frontend->inspector(); InspectorDOMAgent is not supposed to access frontends other than DOMFrontend 398705 3 92335 yurys 2011-05-05 07:14:02 -0700 Comment on attachment 92335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92335&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:889 > + m_inspectorFrontend->bringToFront(); This should be handled on the front-end side. 398710 4 92414 pfeldman 2011-05-05 07:25:34 -0700 Created attachment 92414 Patch 398779 5 pfeldman 2011-05-05 09:38:45 -0700 Committed r85858: <http://trac.webkit.org/changeset/85858> 92335 2011-05-04 15:52:30 -0700 2011-05-05 07:25:30 -0700 Patch bug-60222-20110504155229.patch text/plain 2677 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODU3OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYWQzYWM3NWY2OWI3ZDVh YTM4NmUzZTZmN2Q5YjY1MWYxOWRiNDEwLi5kNzMzNmE5MGNhM2JhZDliZDhkMDlmZTI4NGMwMDli NWIyYjEyOGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDQgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc2VhcmNoaW5nIGZvciBu b2RlIGRvZXMgbm90IHJlc3VsdCBpbiBicmluZ1RvRnJvbnQgY2FsbC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMjIyCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y RE9NQWdlbnQ6OnNldEZyb250ZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFn ZW50OjpjbGVhckZyb250ZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50 OjpoYW5kbGVNb3VzZVByZXNzKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuaDoKKwogMjAxMS0wNS0wNCAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJv c3NhLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHdhcm5pbmcgZml4LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggYmU5NmM2MTJkM2Yw NjJhZmFjNDRjZDgyMjlmMzcyZDM2MWM4NTZhMS4uODFjNWE3YzgxNjA5N2IwZTM4ZmMwYjZlNDhh YTRlYzg3MGUzNzBmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckRPTUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y RE9NQWdlbnQuY3BwCkBAIC0yODIsNiArMjgyLDcgQEAgSW5zcGVjdG9yRE9NQWdlbnQ6On5JbnNw ZWN0b3JET01BZ2VudCgpCiB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpzZXRGcm9udGVuZChJbnNw ZWN0b3JGcm9udGVuZCogZnJvbnRlbmQpCiB7CiAgICAgQVNTRVJUKCFtX2Zyb250ZW5kKTsKKyAg ICBtX2luc3BlY3RvckZyb250ZW5kID0gZnJvbnRlbmQtPmluc3BlY3RvcigpOwogICAgIG1fZnJv bnRlbmQgPSBmcm9udGVuZC0+ZG9tKCk7CiAgICAgbV9pbnN0cnVtZW50aW5nQWdlbnRzLT5zZXRJ bnNwZWN0b3JET01BZ2VudCh0aGlzKTsKICAgICBtX2RvY3VtZW50ID0gbV9wYWdlQWdlbnQtPm1h aW5GcmFtZSgpLT5kb2N1bWVudCgpOwpAQCAtMjk4LDYgKzI5OSw3IEBAIHZvaWQgSW5zcGVjdG9y RE9NQWdlbnQ6OmNsZWFyRnJvbnRlbmQoKQogICAgIEVycm9yU3RyaW5nIGVycm9yOwogICAgIGhp ZGVIaWdobGlnaHQoJmVycm9yKTsKIAorICAgIG1faW5zcGVjdG9yRnJvbnRlbmQgPSAwOwogICAg IG1fZnJvbnRlbmQgPSAwOwogICAgIG1faW5zdHJ1bWVudGluZ0FnZW50cy0+c2V0SW5zcGVjdG9y RE9NQWdlbnQoMCk7CiAgICAgbV9pbnNwZWN0b3JTdGF0ZS0+c2V0Qm9vbGVhbihET01BZ2VudFN0 YXRlOjpkb2N1bWVudFJlcXVlc3RlZCwgZmFsc2UpOwpAQCAtODg0LDYgKzg4Niw3IEBAIGJvb2wg SW5zcGVjdG9yRE9NQWdlbnQ6OmhhbmRsZU1vdXNlUHJlc3MoKQogICAgICAgICBSZWZQdHI8Tm9k ZT4gbm9kZSA9IG1faGlnaGxpZ2h0ZWROb2RlOwogICAgICAgICBzZXRTZWFyY2hpbmdGb3JOb2Rl KGZhbHNlKTsKICAgICAgICAgaW5zcGVjdChub2RlLmdldCgpKTsKKyAgICAgICAgbV9pbnNwZWN0 b3JGcm9udGVuZC0+YnJpbmdUb0Zyb250KCk7CiAgICAgfQogICAgIHJldHVybiB0cnVlOwogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaAppbmRleCA1ZDFi MGE0YzYwOTc1YTQwY2E2ZmI1ZWIzNWM5YjYzMjkzYjlmZGYyLi43NzEyZDE3OGE5N2NjMDgwOWNl ODUxNDEwMGFjOGY2NzFkYTJjMzFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRE9NQWdlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRE9NQWdlbnQuaApAQCAtMjEzLDYgKzIxMyw3IEBAIHByaXZhdGU6CiAgICAgSW5zcGVj dG9yQ2xpZW50KiBtX2NsaWVudDsKICAgICBJbnNwZWN0b3JTdGF0ZSogbV9pbnNwZWN0b3JTdGF0 ZTsKICAgICBJbmplY3RlZFNjcmlwdE1hbmFnZXIqIG1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyOwor ICAgIEluc3BlY3RvckZyb250ZW5kOjpJbnNwZWN0b3IqIG1faW5zcGVjdG9yRnJvbnRlbmQ7CiAg ICAgSW5zcGVjdG9yRnJvbnRlbmQ6OkRPTSogbV9mcm9udGVuZDsKICAgICBET01MaXN0ZW5lciog bV9kb21MaXN0ZW5lcjsKICAgICBOb2RlVG9JZE1hcCBtX2RvY3VtZW50Tm9kZVRvSWRNYXA7Cg== 92414 2011-05-05 07:25:34 -0700 2011-05-05 07:33:10 -0700 Patch bug-60222-20110505072533.patch text/plain 1430 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODU3OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYWQzYWM3NWY2OWI3ZDVh YTM4NmUzZTZmN2Q5YjY1MWYxOWRiNDEwLi44OTgwOWIzZGVhM2IwMWE4MjgyZDNhYzg4MTJkMzRm ZjhiYjg4MjY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMDUgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc2VhcmNoaW5nIGZvciBu b2RlIGRvZXMgbm90IHJlc3VsdCBpbiBicmluZ1RvRnJvbnQgY2FsbC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMjIyCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RWxlbWVudHNQYW5lbC5wcm90b3R5cGUudXBkYXRlRm9jdXNlZE5vZGUpOgorCiAyMDExLTA1LTA0 ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQgd2FybmluZyBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggNGQ5NDFjYzk2Mjc1MzA3NjYyYjBl NjJhM2MxMmM0ZTE5YTk5MmFiMy4uNjA5YjcyNjA4NTdlYTBjOTg3MzlhYTUzNDRjMDY2M2U3OTZm NmFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVt ZW50c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxl bWVudHNQYW5lbC5qcwpAQCAtMTEyNiw3ICsxMTI2LDEwIEBAIFdlYkluc3BlY3Rvci5FbGVtZW50 c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB0aGlz LmZvY3VzZWRET01Ob2RlID0gbm9kZTsKLSAgICAgICAgdGhpcy5fbm9kZVNlYXJjaEJ1dHRvbi50 b2dnbGVkID0gZmFsc2U7CisgICAgICAgIGlmICh0aGlzLl9ub2RlU2VhcmNoQnV0dG9uLnRvZ2ds ZWQpIHsKKyAgICAgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5icmluZ1RvRnJvbnQoKTsK KyAgICAgICAgICAgIHRoaXMuX25vZGVTZWFyY2hCdXR0b24udG9nZ2xlZCA9IGZhbHNlOworICAg ICAgICB9CiAgICAgfSwKIAogICAgIF9zZXRTZWFyY2hpbmdGb3JOb2RlOiBmdW5jdGlvbihlbmFi bGVkKQo=