60221 2011-05-04 15:39:43 -0700 Windows build of WebKit GTK needs to be able to find SystemInfo.h 2011-05-04 17:43:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned commit-queue oldest_to_newest 398322 0 fridrich.strba 2011-05-04 15:39:43 -0700 The file Source/WebKit/gtk/webkit/webkitwebsettings.cpp includes on Windows SystemInfo.h, so add the path to this header to the 398326 1 92332 fridrich.strba 2011-05-04 15:43:42 -0700 Created attachment 92332 Patch 398334 2 92332 mrobinson 2011-05-04 15:48:40 -0700 Comment on attachment 92332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92332&action=review Seems okay, but the ChangeLog format does not look correct. > Source/WebCore/ChangeLog:10 > + Add Source/WebCore/platform/win to teh paths searched > + for headers, since Source/WebCore/platform/win/SystemInfo.h > + header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp > + on Windows. > + https://bugs.webkit.org/show_bug.cgi?id=60221 > + teh -> the The ChangeLog format should be <bug title> <bug url> <description> > Source/WebCore/ChangeLog:11 > + No new tests. (OOPS!) You should remove this line or, even better, replace it with a short sentence saying why tests are not necessary. :) 398346 3 92336 fridrich.strba 2011-05-04 15:58:23 -0700 Created attachment 92336 Patch 398347 4 92336 fridrich.strba 2011-05-04 15:59:00 -0700 Comment on attachment 92336 Patch Modified changelog according to the review 398444 5 92336 commit-queue 2011-05-04 17:43:10 -0700 Comment on attachment 92336 Patch Clearing flags on attachment: 92336 Committed r85815: <http://trac.webkit.org/changeset/85815> 398445 6 commit-queue 2011-05-04 17:43:15 -0700 All reviewed patches have been landed. Closing bug. 92332 2011-05-04 15:43:42 -0700 2011-05-04 15:58:16 -0700 Patch bug-60221-20110505004340.patch text/plain 1303 fridrich.strba SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Nzk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDQgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v d2luIHRvIHRlaCBwYXRocyBzZWFyY2hlZAorICAgICAgICBmb3IgaGVhZGVycywgc2luY2UgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1N5c3RlbUluZm8uaAorICAgICAgICBoZWFkZXIgaXMg bmVlZGVkIGJ5IFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAK KyAgICAgICAgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYwMjIxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAg ICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwogMjAxMS0wNS0wNCAgQWxleGlzIE1lbmFyZCAgPGFs ZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHdhcm5pbmcg Zml4LgpJbmRleDogU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDg1Nzg4KQorKysgU291cmNl L1dlYkNvcmUvR05VbWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDcgQEAg d2ViY29yZV9jcHBmbGFncyArPSBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3FsIFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0IFwKIAkt SSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3RyYW5zY29kZXIgXAorCS1J JChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbiBcCiAJLUkkKHNyY2RpcikvU291 cmNlL1dlYkNvcmUvcGx1Z2lucyBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy93aW4gXAogCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZyBcCg== 92336 2011-05-04 15:58:23 -0700 2011-05-04 17:43:10 -0700 Patch bug-60221-20110505005821.patch text/plain 1336 fridrich.strba SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Nzk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDQgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaW5kb3dzIGJ1aWxkIG9mIFdlYktpdCBHVEsg bmVlZHMgdG8gYmUgYWJsZSB0byBmaW5kIFN5c3RlbUluZm8uaAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAyMjEKKworICAgICAgICAqIEdOVW1ha2Vm aWxlLmFtOiBhZGQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luIHRvIHRoZSBwYXRocyBzZWFy Y2hlZAorICAgICAgICBmb3IgaGVhZGVycywgc2luY2UgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v d2luL1N5c3RlbUluZm8uaAorICAgICAgICBoZWFkZXIgaXMgbmVlZGVkIGJ5IFNvdXJjZS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKKyAgICAgICAgb24gV2luZG93cy4K KwogMjAxMS0wNS0wNCAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkIHdhcm5pbmcgZml4LgpJbmRleDogU291cmNlL1dlYkNv cmUvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvR05VbWFrZWZp bGUuYW0JKHJldmlzaW9uIDg1Nzg4KQorKysgU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0J KHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDcgQEAgd2ViY29yZV9jcHBmbGFncyArPSBcCiAJ LUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsIFwKIAktSSQoc3JjZGlyKS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS90ZXh0L3RyYW5zY29kZXIgXAorCS1JJChzcmNkaXIpL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3dpbiBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGx1Z2lucyBcCiAJ LUkkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4gXAogCS1JJChzcmNkaXIpL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZyBcCg==