60206 2011-05-04 13:23:28 -0700 Proper handling of HTTP 204 (No Content) status code 2024-10-28 14:49:09 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=281927 InRadar P2 Normal --- 1 luiz rbuis achristensen ahmad.saleem792 ap bburg beidson croelli danyao darin goran.karlic gordon.murray gyuyoung.kim japhet kidniki100 koivisto leandro mcatanzaro mike mrobinson psolanki rakuco sullivan webkit-bug-importer webkit.review.bot oldest_to_newest 398206 0 luiz 2011-05-04 13:23:28 -0700 from http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.5: 10.2.5 204 No Content The server has fulfilled the request but does not need to return an entity-body, and might want to return updated metainformation. The response MAY include new or updated metainformation in the form of entity-headers, which if present SHOULD be associated with the requested variant. If the client is a user agent, it SHOULD NOT change its document view from that which caused the request to be sent. This response is primarily intended to allow input for actions to take place without causing a change to the user agent's active document view, although any new or updated metainformation SHOULD be applied to the document currently in the user agent's active view. The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields. 398420 1 ap 2011-05-04 17:08:21 -0700 Could you please clarify what exactly is the bug to fix here? This report doesn't seem actionable in its current state. 398796 2 luiz 2011-05-05 10:11:52 -0700 (In reply to comment #1) > Could you please clarify what exactly is the bug to fix here? This report doesn't seem actionable in its current state. Responses containing HTTP code 204 should be ignored by the browser and the view should not be updated. I made it for Qt and added a test for it. The new test is http/tests/navigation/response204.html. Some platforms (Mac, Win and GTK) fail on this new test. But it seems that if this test fail in Mac or Win then hundreds of other tests fail as well. See https://bugs.webkit.org/show_bug.cgi?id=42529#c21 The test was skipped in those platforms by r85784. 398808 3 ap 2011-05-05 10:25:16 -0700 Here is how I tested: 1. Opened http://www.apple.com in Safari 5.0.5 (also tested with ToT). 2. Once that finished loading, changed address in address bar to <http://127.0.0.1:8000/navigation/resources/response204.pl>, and hit Enter. Results: The address reverted to http://www.apple.com, page content was not affected. This looks like expected behavior. I haven't investigated what's going on in the test, but there are no known issues with 204 responses (we track bug 4858 here, but it's not really about 204, it's about stopping timers too early on any load). 398838 4 luiz 2011-05-05 11:03:00 -0700 (In reply to comment #3) > Here is how I tested: > 1. Opened http://www.apple.com in Safari 5.0.5 (also tested with ToT). > 2. Once that finished loading, changed address in address bar to <http://127.0.0.1:8000/navigation/resources/response204.pl>, and hit Enter. > > Results: The address reverted to http://www.apple.com, page content was not affected. Good. I was expecting this test to fail in some platforms but it seems that Mac is ok with this 204 handling. > > This looks like expected behavior. I haven't investigated what's going on in the test, but there are no known issues with 204 responses (we track bug 4858 here, but it's not really about 204, it's about stopping timers too early on any load). Yeah, it may be then that I did not provide the proper test. The response204.is very simple, I will copy it here: <script> if (window.layoutTestController) { layoutTestController.dumpAsText(); layoutTestController.dumpBackForwardList(); layoutTestController.queueLoad("resources/response204.pl"); } </script> And this is the result that I was expecting: ============== Back Forward List ============== curr-> http://127.0.0.1:8000/navigation/response204.html **nav target** =============================================== Meaning that the response from resources/response204.pl was ignored. But it was not the result for SnowLeopard as you can see here http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r85783%20%2828972%29/http/tests/navigation/response204-diffs.txt : --- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/navigation/response204-expected.txt 2011-05-04 13:57:57.000000000 -0700 +++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/navigation/response204-actual.txt 2011-05-04 13:57:57.000000000 -0700 @@ -1,5 +1,6 @@ ============== Back Forward List ============== -curr-> http://127.0.0.1:8000/navigation/response204.html **nav target** + http://127.0.0.1:8000/navigation/response204.html **nav target** +curr-> http://127.0.0.1:8000/navigation/resources/response204.pl **nav target** =============================================== Nor for Leopard as you can see here http://build.webkit.org/results/Leopard%20Intel%20Release%20%28Tests%29/r85783%20%2831877%29/http/tests/navigation/response204-diffs.txt : --- /Volumes/Big/WebKit-BuildSlave/leopard-intel-release-tests/build/layout-test-results/http/tests/navigation/response204-expected.txt 2011-05-04 13:47:14.000000000 -0700 +++ /Volumes/Big/WebKit-BuildSlave/leopard-intel-release-tests/build/layout-test-results/http/tests/navigation/response204-actual.txt 2011-05-04 13:47:14.000000000 -0700 @@ -1,5 +1,6 @@ ============== Back Forward List ============== -curr-> http://127.0.0.1:8000/navigation/response204.html **nav target** + http://127.0.0.1:8000/navigation/response204.html **nav target** +curr-> http://127.0.0.1:8000/navigation/resources/response204.pl **nav target** =============================================== Is that test wrong? 398841 5 luiz 2011-05-05 11:06:36 -0700 BTW, I have tried the test in bug 4858 and did not reproduce the problem in safari 5.0.5 or in chromium 11.0.696.57 or QtTestBrowser r85857. :) 398875 6 ap 2011-05-05 11:42:29 -0700 I see. Turns out that Safari handles the policy for 204, not WebKit. I think that it should be implemented in WebCore. Seems strange that the test doesn't just use waitUntilDone/window.location="...", but there probably was a reason to use queued load machinery. Thanks for testing bug 4858! I'm surprised that it no longer fails, but it's great news. 398882 7 sullivan 2011-05-05 11:49:40 -0700 Safari does currently handle that code directly, but it seems fine to me to handle it in WebKit instead (Darin said the same thing once too). 398888 8 luiz 2011-05-05 12:00:46 -0700 The other question is why so many tests failed after running this test. It seems that if http/tests/navigation/response204.html fails then hundreds of other tests fail as well. https://bugs.webkit.org/show_bug.cgi?id=42529#c21 http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r85783%20%2828972%29/results.html http://build.webkit.org/results/Leopard%20Intel%20Release%20%28Tests%29/r85783%20%2831877%29/results.html 796769 9 mrobinson 2012-12-23 09:14:45 -0800 *** This bug has been marked as a duplicate of bug 104865 *** 797611 10 mrobinson 2012-12-27 10:27:35 -0800 Going to reverse the duplication graph here. 797613 11 mrobinson 2012-12-27 10:27:41 -0800 *** Bug 104865 has been marked as a duplicate of this bug. *** 797614 12 180810 mrobinson 2012-12-27 10:29:34 -0800 Created attachment 180810 Patch 797643 13 ap 2012-12-27 12:11:29 -0800 As mentioned in duplicate, this change looks good to me, but someone who worked on loader code more recently should review. 976882 14 180810 andersca 2014-02-05 11:01:44 -0800 Comment on attachment 180810 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 1111060 15 ap 2015-07-21 14:33:44 -0700 rdar://problem/21864977 1258109 16 gordon.murray 2016-12-09 02:27:28 -0800 This issue is still reproducable on iOS 10. The easiest way to reproduce is via the site: http://httpstat.us/ When you click the link "204 No Content" on a desktop browser it is handled correctly the browser does nothing to view as per HTTP spec. On iOS the view is changed. 1263180 17 kidniki100 2016-12-30 17:45:37 -0800 Does this patch work? In iOS 10, this is a huge issue and can easily be reproduced while using an Amazon s3 Form post. In every other browser, Chrome on android and all Desktop browsers, the current page view is kept when a 204 response is recieved. In both Chrome for iOS and Safari iOS, it redirects to a blank page, which it should not. Do we have to wait for Apple to update for this to work? 1263225 18 gordon.murray 2017-01-01 01:39:36 -0800 Have raised separate Bug 166633 - iOS browsers not correctly handling HTTP 204 response to flag the iOS handling issue. 1263244 19 ap 2017-01-01 13:35:16 -0800 *** Bug 166633 has been marked as a duplicate of this bug. *** 1263247 20 kidniki100 2017-01-01 14:13:04 -0800 I don't think this is a Webkit bug. Firefox on iOS has the exact same issue and it is Gecko based. This is an Apple bug it seems. I don't know what the browsers get from the OS but it seems to be telling them to actually render a blank page. I've tested this in every iOS browser and the same thing occurs, a blank page gets loaded. 1263264 21 180810 darin 2017-01-02 00:36:01 -0800 Comment on attachment 180810 Patch Patch looks good to me too. Someone should apply this and test to see if this change fixes things in Safari on iOS (could also try other WebKit-based iOS browsers such as Chrome and Firefox). 1263278 22 gordon.murray 2017-01-02 02:48:27 -0800 (In reply to comment #20) > I don't think this is a Webkit bug. Firefox on iOS has the exact same issue > and it is Gecko based. This is an Apple bug it seems. I don't know what > the browsers get from the OS but it seems to be telling them to actually > render a blank page. I've tested this in every iOS browser and the same > thing occurs, a blank page gets loaded. All web browsers on iOS are WebKit based including Firefox which would normally be based on Gecko. 1680596 23 goran.karlic 2020-08-14 23:44:24 -0700 Is this issue going to be resolved? It is an obvious violation of the HTTP standard and inconsistent with all on other platforms, so it should be resolved. 2062181 24 rbuis 2024-09-22 04:58:45 -0700 Pull request: https://github.com/WebKit/WebKit/pull/34059 2064804 25 ews-feeder 2024-10-02 01:42:32 -0700 Committed 284550@main (61909d6ad7cf): <https://commits.webkit.org/284550@main> Reviewed commits have been landed. Closing PR #34059 and removing active labels. 2069953 26 ahmad.saleem792 2024-10-22 18:02:03 -0700 Reverted in https://commits.webkit.org/285577@main https://github.com/WebKit/WebKit/commit/4eac02f13b2fbe5ee3ea4851b0e2c2883329206f 2071064 27 achristensen 2024-10-28 14:49:09 -0700 rdar://138793770 now tracks fixing this internally. Can we do it without changing the value of WKNavigationResponse.canShowMIMEType? 180810 2012-12-27 10:29:34 -0800 2014-02-05 11:01:44 -0800 Patch bug-60206-20121227102646.patch text/plain 9544 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQxMzNhODNiMmE3OTkw Nzg0MTI2OTY5NWQ2NGY4YzgyMzBiNjUwMS4uMDllYjZkMjlmNjVjZGNhNzY4Y2UwMjg5YjhkZTQw ZDRiMzFiOTlmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTI3ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBQcm9wZXIgaGFu ZGxpbmcgb2YgSFRUUCAyMDQgKE5vIENvbnRlbnQpIHN0YXR1cyBjb2RlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDIwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdGhlIGhhbmRsaW5nIG9mIDIw NCBhbmQgMjA1IHN0YXR1cyBjb2RlcyBoZXJlLCBzbyB0aGF0IGl0IGNhbiBiZSBzaGFyZWQgYmV0 d2VlbgorICAgICAgICBwb3J0cy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgYWxsb3dz IHVuc2tpcHBpbmcgaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc3BvbnNlMjA0Lmh0bWwgb24KKyAg ICAgICAgR1RLKy4KKworICAgICAgICAqIGxvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWFpblJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2Up OiBBZGQgc3VwcG9ydCBmb3IgMjA0IGFuZCAyMDUgc3RhdHVzIGNvZGVzLgorCiAyMDEyLTEyLTI3 ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFtU ZXhNYXBdIE1pbm9yIHJlZmFjdG9yaW5nIG9mIFRleHR1cmVNYXBwZXJMYXllci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5n ZUxvZwppbmRleCAzMTI1Y2M0YTM1MWQ4ZTk1MGJlNWI4NmU3MWY2MmU4MDBhMWRhODkzLi4xNjNl OTVjODhhYjQ3MGUxZjk3MGQ1MGM2YjE3NzM1MDEwNTRjNzY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTItMjcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBp Z2FsaWEuY29tPgorCisgICAgICAgIFByb3BlciBoYW5kbGluZyBvZiBIVFRQIDIwNCAoTm8gQ29u dGVudCkgc3RhdHVzIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYwMjA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTW92ZSB0aGUgaGFuZGxpbmcgb2YgMjA0IGFuZCAyMDUgc3RhdHVzIGNvZGVzIHRv IFdlYkNvcmUuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVm bC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hE ZWNpZGVQb2xpY3lGb3JSZXNwb25zZSk6CisKIDIwMTItMTItMjMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyODA4Mzc3PiBO ZXR3b3JrIHByb2Nlc3Mgc2hvdWxkIHJlc3BlY3QgY29va2llIGFjY2VwdCBwb2xpY3kKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFu Z2VMb2cKaW5kZXggMjg0ZjVkZDdjNDZkMGU4OWM5MjFiMDdlNzVkMmZiZGMyNjM1ZTM1NC4uN2Mz NmI4MDQ2MDc0MzU3NzUzZDI4MDdlMzZkNjVlMjY0NDU3Y2NjZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMi0xMi0yNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGln YWxpYS5jb20+CisKKyAgICAgICAgUHJvcGVyIGhhbmRsaW5nIG9mIEhUVFAgMjA0IChObyBDb250 ZW50KSBzdGF0dXMgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjAyMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNb3ZlIHRoZSBoYW5kbGluZyBvZiAyMDQgYW5kIDIwNSBzdGF0dXMgY29kZXMgdG8g V2ViQ29yZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hEZWNp ZGVQb2xpY3lGb3JSZXNwb25zZSk6CisKIDIwMTItMTItMjMgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyODA4Mzc3PiBOZXR3 b3JrIHByb2Nlc3Mgc2hvdWxkIHJlc3BlY3QgY29va2llIGFjY2VwdCBwb2xpY3kKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggMzUwZWIwZDVmMjhk NTg2NWI2MTQxYzk0NDY1ZDNiZDgzOTNmZDQ1MC4uYjc2YTQ4YmUxMDlhOThmOTMzYTBmZjhjYzYw Mjg4MWNkNjU0ZTVkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNv dXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxv YWRlci5jcHAKQEAgLTQ0LDYgKzQ0LDcgQEAKICNpbmNsdWRlICJGcmFtZUxvYWRlci5oIgogI2lu Y2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAiSFRNTEZvcm1FbGVtZW50Lmgi CisjaW5jbHVkZSAiSFRUUFN0YXR1c0NvZGVzLmgiCiAjaW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIK ICNpbmNsdWRlICJJbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaCIKICNpbmNsdWRlICJQYWdlLmgi CkBAIC00MjYsNiArNDI3LDE1IEBAIHZvaWQgTWFpblJlc291cmNlTG9hZGVyOjpyZXNwb25zZVJl Y2VpdmVkKENhY2hlZFJlc291cmNlKiByZXNvdXJjZSwgY29uc3QgUmVzb3VyCiAgICAgICAgIHJl dHVybjsKICAgICB9CiAKKyAgICBzd2l0Y2ggKG1fcmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSkg eworICAgIGNhc2UgSFRUUFJlc2V0Q29udGVudDoKKyAgICAgICAgLy8gRklYTUU6IGEgMjA1IHJl c3BvbnNlIHJlcXVpcmVzIHRoYXQgdGhlIHJlcXVlc3RlciByZXNldCB0aGUgZG9jdW1lbnQgdmll dy4KKyAgICAgICAgLy8gRmFsbHRocm91Z2gKKyAgICBjYXNlIEhUVFBOb0NvbnRlbnQ6CisgICAg ICAgIGNhbGxDb250aW51ZUFmdGVyQ29udGVudFBvbGljeSh0aGlzLCBQb2xpY3lJZ25vcmUpOwor ICAgICAgICByZXR1cm47CisgICAgfQorCiAjaWYgRU5BQkxFKEZUUERJUikKICAgICAvLyBSZXNw ZWN0IHRoZSBoaWRkZW4gRlRQIERpcmVjdG9yeSBMaXN0aW5nIHByZWYgc28gaXQgY2FuIGJlIHRl c3RlZCBldmVuIGlmIHRoZSBwb2xpY3kgZGVsZWdhdGUgbWlnaHQgb3RoZXJ3aXNlIGRpc2FsbG93 IGl0CiAgICAgU2V0dGluZ3MqIHNldHRpbmdzID0gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKS0+ c2V0dGluZ3MoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAppbmRleCA5YzJjOWRiMGE5YTM0ZjBlMjcyMDRk YjMyYmVkMjc4ZGJjNzg1ZTEwLi5mOTc0YzM5Mzg5YjRiNWU0ZjJlN2YwNTdjOWEzMTI5ZjVjNzg2 NjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQv RnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwCkBAIC0yOTgsMTIgKzI5OCw2IEBAIHZvaWQgRnJhbWVM b2FkZXJDbGllbnRFZmw6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UoRnJhbWVQb2xp Y3lGdW5jdGlvbiBmCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICAvLyBJZ25vcmUgcmVz cG9uc2VzIHdpdGggYW4gSFRUUCBzdGF0dXMgY29kZSBvZiAyMDQgKE5vIENvbnRlbnQpCi0gICAg aWYgKHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkgPT0gSFRUUE5vQ29udGVudCkgewotICAgICAg ICBjYWxsUG9saWN5RnVuY3Rpb24oZnVuY3Rpb24sIFBvbGljeUlnbm9yZSk7Ci0gICAgICAgIHJl dHVybjsKLSAgICB9Ci0KICAgICBpZiAoY2FuU2hvd01JTUVUeXBlKHJlc3BvbnNlLm1pbWVUeXBl KCkpKQogICAgICAgICBjYWxsUG9saWN5RnVuY3Rpb24oZnVuY3Rpb24sIFBvbGljeVVzZSk7CiAg ICAgZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFt ZUxvYWRlckNsaWVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRRdC5jcHAKaW5kZXggODI3MjBmYWIxYTZmMTAwMmFlYzVhMjIzNTA0MTQy ZThjNDkyM2RlYi4uYzllM2ZmNzU3OGNhMTVhZjcxNjFjNWE5NWI1MzU5Yjg1ZGQ4MGY1OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVy Q2xpZW50UXQuY3BwCkBAIC0xMTk5LDE2ICsxMTk5LDYgQEAgV2ViQ29yZTo6RnJhbWUqIEZyYW1l TG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNoQ3JlYXRlUGFnZShjb25zdCBXZWJDb3JlOjpOYXZpZ2F0 aW8KIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudFF0OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvclJl c3BvbnNlKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0IFdlYkNvcmU6OlJlc291 cmNlUmVzcG9uc2UmIHJlc3BvbnNlLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKQog ewotICAgIC8vIFdlIG5lZWQgdG8gY2FsbCBkaXJlY3RseSBoZXJlLgotICAgIHN3aXRjaCAocmVz cG9uc2UuaHR0cFN0YXR1c0NvZGUoKSkgewotICAgIGNhc2UgSFRUUFJlc2V0Q29udGVudDoKLSAg ICAgICAgLy8gRklYTUU6IGEgMjA1IHJlc3BvbnNlIHJlcXVpcmVzIHRoYXQgdGhlIHJlcXVlc3Rl ciByZXNldCB0aGUgZG9jdW1lbnQgdmlldy4KLSAgICAgICAgLy8gRmFsbHRocm91Z2gKLSAgICBj YXNlIEhUVFBOb0NvbnRlbnQ6Ci0gICAgICAgIGNhbGxQb2xpY3lGdW5jdGlvbihmdW5jdGlvbiwg UG9saWN5SWdub3JlKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIGlmIChXZWJDb3Jl Ojpjb250ZW50RGlzcG9zaXRpb25UeXBlKHJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZCgiQ29udGVu dC1EaXNwb3NpdGlvbiIpKSA9PSBXZWJDb3JlOjpDb250ZW50RGlzcG9zaXRpb25BdHRhY2htZW50 KQogICAgICAgICBjYWxsUG9saWN5RnVuY3Rpb24oZnVuY3Rpb24sIFBvbGljeURvd25sb2FkKTsK ICAgICBlbHNlIGlmIChjYW5TaG93TUlNRVR5cGUocmVzcG9uc2UubWltZVR5cGUoKSkpCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggYjI5NjIyMDU3NmIwMTAxOWNhMmVjMDM0Y2RiNWZiMGIwZGE1ZTA1NC4uOWEwOTc3YmI4YWVk MDVhNTQ4YjE5MGUwNmNkNjQ4N2UwMDQ4ODVmYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTEyLTI3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBQcm9wZXIgaGFuZGxpbmcgb2YgSFRUUCAyMDQgKE5vIENvbnRlbnQpIHN0YXR1cyBjb2RlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDIwNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCBhIHRlc3Qgd2hpY2ggaXMgbm93IHBhc3Npbmcu CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6IERpdHRvLgorICAgICAg ICAqIHBsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zOiBEaXR0by4KKyAgICAgICAgKiBwbGF0 Zm9ybS93aW5jYWlyby9UZXN0RXhwZWN0YXRpb25zOiBEaXR0by4KKwogMjAxMi0xMi0yNyAgVnNl dm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBbUmVncmVzc2lvbl0gQ2FuIG5vdCBzZXQgYnJlYWtwb2ludHMgaW4gc2NyaXB0cyBsb2Fk ZWQgd2l0aCBzb3VyY2UgbWFwLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCAzNjE1YjRlYTk4N2NjMDlkOWZjZmIxYjQ4ZTJhZTU3ODgwZjM3Yzg0Li5kYWUz MzgwNGYxODg5ZGRjOTMxNWY3ODAxZDE4Y2Q0NGU1MTViMWNhIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTEyMSw5ICsxMTIxLDYgQEAgd2Via2l0Lm9y Zy9iLzU4MzA5IGZhc3QvY2FudmFzL0RyYXdJbWFnZVNpbmdsZVBpeGVsU3RyZXRjaC5odG1sIFsg RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvNTg4NDUgZmFzdC9kb20vdGl0bGUtZGlyZWN0aW9uYWxp dHkuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzU4ODQ1IGZhc3QvZG9tL3RpdGxlLWRp cmVjdGlvbmFsaXR5LXJlbW92ZUNoaWxkLmh0bWwgWyBGYWlsdXJlIF0KIAotIyBIVFRQIDIwNCAo Tm8gQ29udGVudCkgc2hvdWxkIGJlIGlnbm9yZWQKLXdlYmtpdC5vcmcvYi82MDIwNiBodHRwL3Rl c3RzL25hdmlnYXRpb24vcmVzcG9uc2UyMDQuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3Jn L2IvNjE2MzAgZmFzdC9ldmVudHMvZHJvcHpvbmUtMDA1Lmh0bWwgWyBGYWlsdXJlIF0KIAogIyBO ZWVkIHRlc3RSdW5uZXIuc2V0U2hvdWxkU3RheU9uUGFnZUFmdGVySGFuZGxpbmdCZWZvcmVVbmxv YWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZjMwMTlm ODE5NzJkOGI1YmEzMWYyOTU1ZDczZmE4NGVmMTkxZjMxYi4uNDFiZTJjMTRiMWQyZjMyMDcwN2Y2 MzNmMzRiNzZkNjhkODMwZjM2YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTM5NiwxMCArMzk2LDYgQEAgZmFzdC9kb20vdGl0bGUtZGlyZWN0aW9uYWxp dHkuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5MjQK IHBsdWdpbnMvbW91c2UtY2xpY2staWZyYW1lLXRvLXBsdWdpbi5odG1sCiAKLSMgSFRUUCAyMDQg KE5vIENvbnRlbnQpIHNob3VsZCBiZSBpZ25vcmVkCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MDIwNgotaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc3BvbnNlMjA0 Lmh0bWwKLQogIyBUaGlzIHBsYXRmb3JtIGRvZXMgbm90IHN1cHBvcnQgdGhlIFBhZ2UgVmlzaWJp bGl0eSBBUEkuCiBmYXN0L2V2ZW50cy9wYWdlLXZpc2liaWxpdHktaWZyYW1lLWRlbGV0ZS10ZXN0 Lmh0bWwKIGZhc3QvZXZlbnRzL3BhZ2UtdmlzaWJpbGl0eS1pZnJhbWUtbW92ZS10ZXN0Lmh0bWwK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZTNlNzNiODM0 YjMxZmI3ZjM1NzAyYzQwZDUzNzdkNmI0MWY0ZTE1Mi4uZmJjZGQ3MmY4YThjNzJkODIyZjBkOTRm NzE4OTUxOThlZjU5ZjZjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3Rh dGlvbnMKQEAgLTE0NzUsMTAgKzE0NzUsNiBAQCBtZWRpYS9pbnZhbGlkLW1lZGlhLXVybC1jcmFz aC5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2Jhc2ljLWF1dGgtbm9wYXNzd29yZC5o dG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2Jhc2ljLWF1dGgtbm91c2VyLmh0bWwKIAot IyBIVFRQIDIwNCAoTm8gQ29udGVudCkgc2hvdWxkIGJlIGlnbm9yZWQKLSMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMjA2Ci1odHRwL3Rlc3RzL25hdmlnYXRpb24v cmVzcG9uc2UyMDQuaHRtbAotCiAjIFRoaXMgcGxhdGZvcm0gZG9lcyBub3Qgc3VwcG9ydCB0aGUg UGFnZSBWaXNpYmlsaXR5IEFQSS4KIGZhc3QvZXZlbnRzL3BhZ2UtdmlzaWJpbGl0eS1pZnJhbWUt ZGVsZXRlLXRlc3QuaHRtbAogZmFzdC9ldmVudHMvcGFnZS12aXNpYmlsaXR5LWlmcmFtZS1tb3Zl LXRlc3QuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luY2Fpcm8vVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggNWU3MGFjYzA2NjIyMDhiNzhjNTg0NzdlZGI5MDRlNjYxYmIxZTA3My4uYmU0 ZjJkYzJlYTExMTdhYzIwYmMxNDljZjNkM2MzOWFkMTc2ZmUxNyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2luY2Fpcm8vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS93aW5jYWlyby9UZXN0RXhwZWN0YXRpb25zCkBAIC0yMDA1LDEwICsyMDA1LDYg QEAgaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9iYXNpYy1hdXRoLW5vdXNlci5odG1sCiAjIEFu aW1hdGlvbiBBUEkgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdAogYW5pbWF0aW9ucy9hbmltYXRpb24t YXBpLTEuaHRtbAogCi0jIEhUVFAgMjA0IChObyBDb250ZW50KSBzaG91bGQgYmUgaWdub3JlZAot IyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAyMDYKLWh0dHAvdGVz dHMvbmF2aWdhdGlvbi9yZXNwb25zZTIwNC5odG1sCi0KICMgVGhpcyBwbGF0Zm9ybSBkb2VzIG5v dCBzdXBwb3J0IHRoZSBQYWdlIFZpc2liaWxpdHkgQVBJLgogZmFzdC9ldmVudHMvcGFnZS12aXNp YmlsaXR5LWlmcmFtZS1kZWxldGUtdGVzdC5odG1sCiBmYXN0L2V2ZW50cy9wYWdlLXZpc2liaWxp dHktaWZyYW1lLW1vdmUtdGVzdC5odG1sCg==