60192 2011-05-04 11:44:13 -0700 Web Inspector: add test for shadow DOM access in the console API 2011-05-05 05:16:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 398123 0 caseq 2011-05-04 11:44:13 -0700 We don't expose shadow DOM to JS normally, yet now that we show it in Elements panel, it may be accessed with $0. This test so far is the only place where we assure that a JS wrapper is properly created for shadow root and other shadow nodes. This is supposed to guard against things like bug 60026 398126 1 92292 caseq 2011-05-04 11:46:30 -0700 Created attachment 92292 patch 398646 2 92292 yurys 2011-05-05 03:33:25 -0700 Comment on attachment 92292 patch View in context: https://bugs.webkit.org/attachment.cgi?id=92292&action=review > LayoutTests/http/tests/inspector/elements-test.js:81 > +InspectorTest.selectNode = function(node, callback) Can you change InspectorTest.selectNodeWithId to call this method as well? > LayoutTests/inspector/console/console-shadow-dom-access.html:25 > + expressions.splice(0, 1); var expression = expressions.shift() 398668 3 caseq 2011-05-05 05:16:16 -0700 Manually committed a version with yurys' suggestions at r85849: http://trac.webkit.org/changeset/85849 92292 2011-05-04 11:46:30 -0700 2011-05-05 03:33:25 -0700 patch shadow-dom-console-test.diff text/plain 5060 caseq ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMDY2NjhmLi40NDhjOWFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDUt MDQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgdGVz dCBmb3Igc2hhZG93IERPTSBhY2Nlc3MgaW4gdGhlIGNvbnNvbGUgQVBJCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDE5MgorCisgICAgICAgICogaHR0 cC90ZXN0cy9pbnNwZWN0b3IvZWxlbWVudHMtdGVzdC5qczoKKyAgICAgICAgKGluaXRpYWxpemVf RWxlbWVudFRlc3QuSW5zcGVjdG9yVGVzdC5maW5kTm9kZS5wcm9jZXNzQ2hpbGRyZW4pOgorICAg ICAgICAoaW5pdGlhbGl6ZV9FbGVtZW50VGVzdC5JbnNwZWN0b3JUZXN0Lm5vZGVXaXRoSWQpOgor ICAgICAgICAoaW5pdGlhbGl6ZV9FbGVtZW50VGVzdC5JbnNwZWN0b3JUZXN0LnNlbGVjdE5vZGUp OgorICAgICAgICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtc2hhZG93LWRvbS1hY2Nlc3Mt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xl LXNoYWRvdy1kb20tYWNjZXNzLmh0bWw6IEFkZGVkLgorCisyMDExLTA1LTA0ICBBbmRyZXkgS29z eWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4gQW5vdGhl ciBzaG90IGF0IGZpeGluZyBmbGFraW5lc3MgdW5kZXIgd2luIChhbHNvIHJlbmFtZWQgYSBjb3Vw bGUgb2Ygb2Jzb2xldGUgdGhpbmdzKS4KIAogICAgICAgICAqIGluc3BlY3Rvci9lbGVtZW50cy9z aGFkb3ctZG9tLWV4cGVjdGVkLnR4dDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvaW5zcGVjdG9yL2VsZW1lbnRzLXRlc3QuanMgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2lu c3BlY3Rvci9lbGVtZW50cy10ZXN0LmpzCmluZGV4IDAyNzE0NTc2Li4xM2MyODYwIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9lbGVtZW50cy10ZXN0LmpzCisr KyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzLXRlc3QuanMKQEAg LTEsNyArMSw2IEBACiB2YXIgaW5pdGlhbGl6ZV9FbGVtZW50VGVzdCA9IGZ1bmN0aW9uKCkgewog Ci0KLUluc3BlY3RvclRlc3Qubm9kZVdpdGhJZCA9IGZ1bmN0aW9uKGlkVmFsdWUsIGNhbGxiYWNr KQorSW5zcGVjdG9yVGVzdC5maW5kTm9kZSA9IGZ1bmN0aW9uKG1hdGNoRnVuY3Rpb24sIGNhbGxi YWNrKQogewogICAgIGNhbGxiYWNrID0gSW5zcGVjdG9yVGVzdC5zYWZlV3JhcChjYWxsYmFjayk7 CiAgICAgdmFyIHJlc3VsdCA9IG51bGw7CkBAIC0xNSwxMSArMTQsMTYgQEAgSW5zcGVjdG9yVGVz dC5ub2RlV2l0aElkID0gZnVuY3Rpb24oaWRWYWx1ZSwgY2FsbGJhY2spCiAKICAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGNoaWxkcmVuICYmIGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgewogICAg ICAgICAgICAgdmFyIGNoaWxkTm9kZSA9IGNoaWxkcmVuW2ldOwotICAgICAgICAgICAgaWYgKGNo aWxkTm9kZS5nZXRBdHRyaWJ1dGUoImlkIikgPT09IGlkVmFsdWUpIHsKKyAgICAgICAgICAgIGlm IChtYXRjaEZ1bmN0aW9uKGNoaWxkTm9kZSkpIHsKICAgICAgICAgICAgICAgICByZXN1bHQgPSBj aGlsZE5vZGU7CiAgICAgICAgICAgICAgICAgY2FsbGJhY2socmVzdWx0KTsKICAgICAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAoY2hpbGROb2RlLnNo YWRvd1Jvb3QgJiYgbWF0Y2hGdW5jdGlvbihjaGlsZE5vZGUuc2hhZG93Um9vdCkpIHsKKyAgICAg ICAgICAgICAgICByZXN1bHQgPSBjaGlsZE5vZGUuc2hhZG93Um9vdDsKKyAgICAgICAgICAgICAg ICBjYWxsYmFjayhyZXN1bHQpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg IH0KICAgICAgICAgICAgIHBlbmRpbmdSZXF1ZXN0cysrOwogICAgICAgICAgICAgY2hpbGROb2Rl LmdldENoaWxkTm9kZXMocHJvY2Vzc0NoaWxkcmVuLmJpbmQobnVsbCwgZmFsc2UpKTsKICAgICAg ICAgICAgIGlmIChjaGlsZE5vZGUuc2hhZG93Um9vdCkgewpAQCAtNDIsNiArNDYsMTUgQEAgSW5z cGVjdG9yVGVzdC5ub2RlV2l0aElkID0gZnVuY3Rpb24oaWRWYWx1ZSwgY2FsbGJhY2spCiAgICAg fQogfTsKIAorSW5zcGVjdG9yVGVzdC5ub2RlV2l0aElkID0gZnVuY3Rpb24oaWRWYWx1ZSwgY2Fs bGJhY2spCit7CisgICAgZnVuY3Rpb24gbm9kZUlkTWF0Y2hlcyhub2RlKQorICAgIHsKKyAgICAg ICAgcmV0dXJuIG5vZGUuZ2V0QXR0cmlidXRlKCJpZCIpID09PSBpZFZhbHVlOworICAgIH0KKyAg ICBJbnNwZWN0b3JUZXN0LmZpbmROb2RlKG5vZGVJZE1hdGNoZXMsIGNhbGxiYWNrKTsKK30KKwog SW5zcGVjdG9yVGVzdC5leHBhbmRlZE5vZGVXaXRoSWQgPSBmdW5jdGlvbihpZFZhbHVlKQogewog ICAgIHZhciByZXN1bHQ7CkBAIC02NSw2ICs3OCwxMyBAQCBJbnNwZWN0b3JUZXN0LnNlbGVjdE5v ZGVXaXRoSWQgPSBmdW5jdGlvbihpZFZhbHVlLCBjYWxsYmFjaykKICAgICBJbnNwZWN0b3JUZXN0 Lm5vZGVXaXRoSWQoaWRWYWx1ZSwgbXljYWxsYmFjayk7CiB9OwogCitJbnNwZWN0b3JUZXN0LnNl bGVjdE5vZGUgPSBmdW5jdGlvbihub2RlLCBjYWxsYmFjaykKK3sKKyAgICBjYWxsYmFjayA9IElu c3BlY3RvclRlc3Quc2FmZVdyYXAoY2FsbGJhY2spOworICAgIFdlYkluc3BlY3Rvci51cGRhdGVG b2N1c2VkTm9kZShub2RlLmlkKTsKKyAgICBJbnNwZWN0b3JUZXN0LnJ1bkFmdGVyUGVuZGluZ0Rp c3BhdGNoZXMoY2FsbGJhY2spOworfQorCiBJbnNwZWN0b3JUZXN0LmR1bXBTZWxlY3RlZEVsZW1l bnRTdHlsZXMgPSBmdW5jdGlvbihleGNsdWRlQ29tcHV0ZWQsIGV4Y2x1ZGVNYXRjaGVkLCBvbWl0 TG9uZ2hhbmRzKQogewogICAgIHZhciBzdHlsZVNlY3Rpb25zID0gV2ViSW5zcGVjdG9yLnBhbmVs cy5lbGVtZW50cy5zaWRlYmFyUGFuZXMuc3R5bGVzLnNlY3Rpb25zOwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1zaGFkb3ctZG9tLWFjY2Vzcy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXNoYWRvdy1k b20tYWNjZXNzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li4wZGQ3YTk4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNv bGUvY29uc29sZS1zaGFkb3ctZG9tLWFjY2Vzcy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBA CitUZXN0cyB0aGF0ICQwIG1heSBzdWNjZXNzZnVsbHkgYmUgdXNlZCB0byByZWZlciB0byBzaGFk b3cgRE9NIGVsZW1lbnRzLgorCisKKyQwLnRvU3RyaW5nKCkgPSAiW29iamVjdCBOb2RlXSIKKyQw LmZpcnN0Q2hpbGQudG9TdHJpbmcoKSA9ICJbb2JqZWN0IEhUTUxEaXZFbGVtZW50XSIKKyQwLmZp cnN0Q2hpbGQuZmlyc3RDaGlsZC5zdHlsZS53aWR0aCA9ICI0MiUiCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtc2hhZG93LWRvbS1hY2Nlc3MuaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtc2hhZG93LWRvbS1hY2Nl c3MuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42ODM4ZjE3Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1zaGFk b3ctZG9tLWFjY2Vzcy5odG1sCkBAIC0wLDAgKzEsNDMgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdG9yLXRlc3QuanMiPjwv c2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRz LXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKwordmFyIHRlc3QgPSBmdW5jdGlvbigpCit7 CisgICAgdmFyIGV4cHJlc3Npb25zID0gWworICAgICAgICAiJDAudG9TdHJpbmcoKSIsCisgICAg ICAgICIkMC5maXJzdENoaWxkLnRvU3RyaW5nKCkiLAorICAgICAgICAiJDAuZmlyc3RDaGlsZC5m aXJzdENoaWxkLnN0eWxlLndpZHRoIgorICAgIF07CisgICAgZnVuY3Rpb24gaXNTaGFkb3dSb290 KG5vZGUpCisgICAgeworICAgICAgICByZXR1cm4gbm9kZS5ub2RlVHlwZSgpID09PSBOb2RlLlNI QURPV19ST09UX05PREU7CisgICAgfQorICAgIGZ1bmN0aW9uIHByb2Nlc3NFeHByZXNzaW9uKCkK KyAgICB7CisgICAgICAgIGlmICghZXhwcmVzc2lvbnMubGVuZ3RoKSB7CisgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CisgICAgICAgIHZhciBleHByZXNzaW9uID0gZXhwcmVzc2lvbnNbMF07CisgICAgICAgIGV4 cHJlc3Npb25zLnNwbGljZSgwLCAxKTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUlu Q29uc29sZUFuZER1bXAoZXhwcmVzc2lvbiwgcHJvY2Vzc0V4cHJlc3Npb24pOworICAgIH0KKyAg ICBJbnNwZWN0b3JUZXN0LmZpbmROb2RlKGlzU2hhZG93Um9vdCwgZnVuY3Rpb24obm9kZSkgewor ICAgICAgICBJbnNwZWN0b3JUZXN0LnNlbGVjdE5vZGUobm9kZSwgcHJvY2Vzc0V4cHJlc3Npb24p OworICAgIH0pOworfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJydW5U ZXN0KCkiPgorPHA+CitUZXN0cyB0aGF0ICQwIG1heSBzdWNjZXNzZnVsbHkgYmUgdXNlZCB0byBy ZWZlciB0byBzaGFkb3cgRE9NIGVsZW1lbnRzLgorPC9wPgorCis8bWV0ZXIgbWluPSIwIiBtYXg9 IjEwMCIgdmFsdWU9IjQyIj48L21ldGVyPgorPC9ib2R5PgorPC9odG1sPgo=