60191 2011-05-04 11:38:24 -0700 Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer 2011-05-04 13:17:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cmarrin cmarrin oldest_to_newest 398113 0 cmarrin 2011-05-04 11:38:24 -0700 PlatformCALayer ::replaceSublayer occasionally crashes because the current layer doesn't have a superlayer. I believe this is a benign case that happens when we are restructuring the tree. But currently it crashes. I will add protection against the null pointer and see if this avoids any other problems. 398115 1 cmarrin 2011-05-04 11:38:42 -0700 rdar://problem/8751147 398118 2 92290 cmarrin 2011-05-04 11:41:41 -0700 Created attachment 92290 Patch 398120 3 92290 simon.fraser 2011-05-04 11:43:38 -0700 Comment on attachment 92290 Patch You could leave the assertion in since it would be nice to know when this happens. 398200 4 cmarrin 2011-05-04 13:17:53 -0700 Committed r85781: <http://trac.webkit.org/changeset/85781> 92290 2011-05-04 11:41:41 -0700 2011-05-04 11:43:38 -0700 Patch bug-60191-20110504114140.patch text/plain 1837 cmarrin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NzY2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDQgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENyYXNoIGluIFBsYXRmb3JtQ0FMYXllciA6OnJlcGxhY2VTdWJs YXllciB3aGVuIGxheWVyIGhhcyBub3Qgc3VwZXJsYXllcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAxOTEKKworICAgICAgICBTa2lwIHJlcGxhY2VT dWJsYXllciB3aGVuIHRoZXJlIGlzIG5vIHN1cGVybGF5ZXIgcmF0aGVyIHRoYW4gYXNzZXJ0aW5n LgorICAgICAgICBUaGlzIGlzIHByb2JhYmx5IG5vdCBhIHByb2JsZW0gYW5kIGhhcHBlbnMgd2hl biByZXN0cnVjdHVyaW5nIHRoZSBsYXllcgorICAgICAgICB0cmVlLiBBdm9pZGluZyB0aGlzIGNy YXNoIHdpbGwgYWxsb3cgdXMgdG8gZ2V0IG1vcmUgdGVzdGluZy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0xheWVyQ0E6OnN3YXBGcm9tT3JUb1RpbGVkTGF5ZXIpOgorCiAyMDExLTA1LTA0ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvR3JhcGhpY3NMYXllckNBLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCShyZXZpc2lvbiA4NTUwMikKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIwNDAsMTAgKzIwNDAsMTAgQEAgdm9pZCBHcmFwaGljc0xheWVy Q0E6OnN3YXBGcm9tT3JUb1RpbGVkTAogCiAgICAgbV9sYXllci0+YWRvcHRTdWJsYXllcnMob2xk TGF5ZXIuZ2V0KCkpOwogICAgIAotICAgIC8vIElmIG1fbGF5ZXIgZG9lc24ndCBoYXZlIGEgcGFy ZW50LCBpdCBtZWFucyBpdCdzIHRoZSByb290IGxheWVyIGFuZAotICAgIC8vIGlzIGxpa2VseSBo b3N0ZWQgYnkgc29tZXRoaW5nIHRoYXQgaXMgbm90IGV4cGVjdGluZyB0byBiZSBjaGFuZ2VkCi0g ICAgQVNTRVJUKG9sZExheWVyLT5zdXBlcmxheWVyKCkpOwotICAgIG9sZExheWVyLT5zdXBlcmxh eWVyKCktPnJlcGxhY2VTdWJsYXllcihvbGRMYXllci5nZXQoKSwgbV9sYXllci5nZXQoKSk7Cisg ICAgLy8gRklYTUU6IFNraXAgdGhpcyBzdGVwIGlmIHdlIGRvbid0IGhhdmUgYSBzdXBlcmxheWVy LiBUaGlzIGlzIHByb2JsYWJseSBhIGJlbmlnbgorICAgIC8vIGNhc2UgdGhhdCBoYXBwZW5zIHdo aWxlIHJlc3RydWN0dXJpbmcgdGhlIGxheWVyIHRyZWUuCisgICAgaWYgKG9sZExheWVyLT5zdXBl cmxheWVyKCkpCisgICAgICAgIG9sZExheWVyLT5zdXBlcmxheWVyKCktPnJlcGxhY2VTdWJsYXll cihvbGRMYXllci5nZXQoKSwgbV9sYXllci5nZXQoKSk7CiAKICAgICB1cGRhdGVDb250ZW50c1Ry YW5zZm9ybSgpOwogCg==