60165 2011-05-04 06:28:18 -0700 [GTK] Unref the SoupSession used by WebKitGtk+ at exit 2011-06-03 03:05:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 svillar svillar eric mrobinson xan.lopez oldest_to_newest 397874 0 svillar 2011-05-04 06:28:18 -0700 [GTK] Unref the SoupSession used by WebKitGtk+ at exit 397877 1 92229 svillar 2011-05-04 06:31:23 -0700 Created attachment 92229 Patch 397937 2 92229 mrobinson 2011-05-04 08:29:42 -0700 Comment on attachment 92229 Patch Have you looked at using DEFINE_STATIC_LOCAL and a GRefPtr to do this? 398835 3 svillar 2011-05-05 10:57:11 -0700 (In reply to comment #2) > (From update of attachment 92229 [details]) > Have you looked at using DEFINE_STATIC_LOCAL and a GRefPtr to do this? I understood that DEFINE_STATIC_LOCAL was used to avoid destructor calling on exit which is totally the contrary to what I'm trying to achieve. Maybe I'm not understanding what you mean... 398932 4 mrobinson 2011-05-05 12:35:24 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 92229 [details] [details]) > > Have you looked at using DEFINE_STATIC_LOCAL and a GRefPtr to do this? > > I understood that DEFINE_STATIC_LOCAL was used to avoid destructor calling on exit which is totally the contrary to what I'm trying to achieve. Maybe I'm not understanding what you mean... It's used to avoid false leaks reporting on exit. 414170 5 xan.lopez 2011-06-02 09:00:58 -0700 (In reply to comment #4) > It's used to avoid false leaks reporting on exit. From the macro documentation: // Use these to declare and define a static local variable (static T;) so that // it is leaked so that its destructors are not called at exit. Using this // macro also allows workarounds a compiler bug present in Apple's version of GCC 4.0.1. So it seems to me it does the opposite of what we want? 414177 6 mrobinson 2011-06-02 09:09:41 -0700 (In reply to comment #5) > (In reply to comment #4) > > It's used to avoid false leaks reporting on exit. > > From the macro documentation: > > // Use these to declare and define a static local variable (static T;) so that > // it is leaked so that its destructors are not called at exit. Using this > // macro also allows workarounds a compiler bug present in Apple's version of GCC 4.0.1. > > So it seems to me it does the opposite of what we want? Oh right. It seems so! 414751 7 svillar 2011-06-03 03:05:37 -0700 Committed r87999: <http://trac.webkit.org/changeset/87999> 92229 2011-05-04 06:31:23 -0700 2011-06-02 09:10:00 -0700 Patch bug-60165-20110504153119.patch text/plain 1549 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogODU0MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAyZDI1NzY4ODg1 MjczMDRhOGEyNGJmMjM4MDg5YzA0ZTQ5ODEwMzhjLi5iNmU4NDVlMjJhY2RmMzJjODI2N2U3YjY3 YzY3YjQ5ZGEzMmUyMzc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEt MDUtMDQgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVW5yZWYgdGhl IFNvdXBTZXNzaW9uIHVzZWQgYnkgV2ViS2l0R3RrKyBhdCBleGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDE2NQorCisgICAgICAgIFdlYktpdEd0 aysgY3JlYXRlcyBhIFNvdXBTZXNzaW9uIGluc3RhbmNlIHRvIGhhbmRsZSBuZXR3b3JrIHN0dWZm CisgICAgICAgIHRoYXQgaXMgbmV2ZXIgZnJlZWQuIFdlIHNob3VsZCB1bnJlZiB0aGF0IG9iamVj dCBhdCBleGl0IHRpbWUuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0Z2xvYmFscy5jcHA6Cisg ICAgICAgICh3ZWJraXRFeGl0KToKKyAgICAgICAgKHdlYmtpdEluaXQpOgorCiAyMDExLTA0LTI5 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0Z2xvYmFscy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0Z2xvYmFscy5j cHAKaW5kZXggYjhkOGIxZjdkYmZlMWU0ZDljOTYyMGY5NDg2NmU2MTI5MDJkZDQxNi4uYjA2OWIx OGQ2ZGI0Y2QwMDk2NzI4ZTExMTc0ZWMxZGEyNjFhODE4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdGdsb2JhbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXRnbG9iYWxzLmNwcApAQCAtMjQ0LDYgKzI0NCwxMSBAQCBXZWJLaXRJY29u RGF0YWJhc2UqIHdlYmtpdF9nZXRfaWNvbl9kYXRhYmFzZSgpCiAgICAgcmV0dXJuIGRhdGFiYXNl OwogfQogCitzdGF0aWMgdm9pZCB3ZWJraXRFeGl0KCkKK3sKKyAgICBnX29iamVjdF91bnJlZiAo d2Via2l0X2dldF9kZWZhdWx0X3Nlc3Npb24oKSk7Cit9CisKIHZvaWQgd2Via2l0SW5pdCgpCiB7 CiAgICAgc3RhdGljIGJvb2wgaXNJbml0aWFsaXplZCA9IGZhbHNlOwpAQCAtMjg3LDYgKzI5Miw4 IEBAIHZvaWQgd2Via2l0SW5pdCgpCiAgICAgZ19vYmplY3RfdW5yZWYoc25pZmZlcik7CiAKICAg ICBzb3VwX3Nlc3Npb25fYWRkX2ZlYXR1cmVfYnlfdHlwZShzZXNzaW9uLCBTT1VQX1RZUEVfQ09O VEVOVF9ERUNPREVSKTsKKworICAgIGF0ZXhpdCh3ZWJraXRFeGl0KTsKIH0KIAogbmFtZXNwYWNl IFdlYktpdCB7Cg==