<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60164</bug_id>
          
          <creation_ts>2011-05-04 06:08:59 -0700</creation_ts>
          <short_desc>REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard</short_desc>
          <delta_ts>2011-05-04 07:55:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>PlatformOnly, Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Roben (:aroben)">aroben</reporter>
          <assigned_to name="Caio Marcelo de Oliveira Filho">cmarcelo</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>397864</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-05-04 06:08:59 -0700</bug_when>
    <thetext>webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings has been failing on Leopard since r85657.

http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31821 did not fail
http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31822 failed

It is not failing on other versions of Mac OS X, or on Windows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397871</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-05-04 06:19:38 -0700</bug_when>
    <thetext>From the bot:

$ ruby --version
ruby 1.8.6 (2009-06-08 patchlevel 369) [universal-darwin9.0]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397895</commentid>
    <comment_count>2</comment_count>
      <attachid>92233</attachid>
    <who name="Caio Marcelo de Oliveira Filho">cmarcelo</who>
    <bug_when>2011-05-04 06:56:04 -0700</bug_when>
    <thetext>Created attachment 92233
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397902</commentid>
    <comment_count>3</comment_count>
      <attachid>92233</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-05-04 07:03:46 -0700</bug_when>
    <thetext>Comment on attachment 92233
Patch

Rejecting attachment 92233 from commit-queue.

cmarcelo@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397916</commentid>
    <comment_count>4</comment_count>
      <attachid>92233</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-04 07:55:53 -0700</bug_when>
    <thetext>Comment on attachment 92233
Patch

Clearing flags on attachment: 92233

Committed r85750: &lt;http://trac.webkit.org/changeset/85750&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397917</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-05-04 07:55:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>92233</attachid>
            <date>2011-05-04 06:56:04 -0700</date>
            <delta_ts>2011-05-04 07:55:53 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60164-20110504105601.patch</filename>
            <type>text/plain</type>
            <size>1346</size>
            <attacher name="Caio Marcelo de Oliveira Filho">cmarcelo</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gODU3NDIpCisrKyBX
ZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMTEtMDUtMDQgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNh
aW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChyODU2NTcpOiB3ZWJraXRweS5jb21tb24u
cHJldHR5cGF0Y2hfdW5pdHRlc3QuUHJldHR5UGF0Y2hUZXN0LnRlc3RfcHJldHR5X2RpZmZfZW5j
b2RpbmdzIGZhaWxpbmcgb24gTGVvcGFyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NjAxNjQKKworICAgICAgICBVc2UgQXJyYXkjbGVuZ3RoIHRvIGdl
dCB0aGUgbnVtYmVyIG9mIGVsZW1lbnRzIGluIGFuIGFycmF5LiBBcnJheSNjb3VudAorICAgICAg
ICB3YXMgYWRkZWQgaW4gUnVieSAxLjguNywgYnV0IExlb3BhcmQgaGF2ZSBSdWJ5IDEuOC42Lgor
CisgICAgICAgICogUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmI6CisKIDIwMTEtMDUtMDMgIENh
aW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9y
Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2Vic2l0ZXMvYnVn
cy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl
YnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgkocmV2aXNp
b24gODU3NDIpCisrKyBXZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5
UGF0Y2gucmIJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDcgQEAgcHVibGljCiAgICAgICAg
ICAgICBicmVhawogICAgICAgICBlbmQKIAotICAgICAgICAkbGFzdF9wcmV0dGlmeV9maWxlX2Nv
dW50ID0gZmlsZURpZmZzLmNvdW50CisgICAgICAgICRsYXN0X3ByZXR0aWZ5X2ZpbGVfY291bnQg
PSBmaWxlRGlmZnMubGVuZ3RoCiAgICAgICAgIHN0ciArPSBmaWxlRGlmZnMuY29sbGVjdHsgfGRp
ZmZ8IGRpZmYudG9faHRtbCB9LmpvaW4KICAgICBlbmQKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>