60151 2011-05-04 02:55:08 -0700 [EFL] Remove ewk_tile_unused_cache_free function from public API 2011-05-07 19:50:34 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned abarth commit-queue dbates eric lucas.de.marchi webkit.review.bot oldest_to_newest 397766 0 t.morawski 2011-05-04 02:55:08 -0700 The ewk_tile_unused_cache_free function should be only called by ewk_tile_unused_cache_unref function. Calling this function without considering reference counting may lead to fatal results. 397768 1 92207 t.morawski 2011-05-04 02:57:26 -0700 Created attachment 92207 Patch 398273 2 92207 lucas.de.marchi 2011-05-04 14:51:57 -0700 Comment on attachment 92207 Patch LGTM 400105 3 92207 dbates 2011-05-07 14:55:47 -0700 Comment on attachment 92207 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92207&action=review > Source/WebKit/efl/ChangeLog:5 > + [EFL] Remove ewk_tile_unused_cache_free function form public api form => from 400106 4 92207 dbates 2011-05-07 14:57:07 -0700 Comment on attachment 92207 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92207&action=review >> Source/WebKit/efl/ChangeLog:5 >> + [EFL] Remove ewk_tile_unused_cache_free function form public api > > form => from api => API 400122 5 92207 commit-queue 2011-05-07 16:35:13 -0700 Comment on attachment 92207 Patch Clearing flags on attachment: 92207 Committed r86012: <http://trac.webkit.org/changeset/86012> 400124 6 commit-queue 2011-05-07 16:35:16 -0700 All reviewed patches have been landed. Closing bug. 400182 7 webkit.review.bot 2011-05-07 19:50:21 -0700 http://trac.webkit.org/changeset/86012 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg 400184 8 webkit.review.bot 2011-05-07 19:50:34 -0700 http://trac.webkit.org/changeset/86014 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg 92207 2011-05-04 02:57:26 -0700 2011-05-07 16:35:13 -0700 Patch ewk_tile_unused_cache_free.patch text/plain 2796 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzMTVlMjUyLi45NGY4ODAwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMDQgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW0VGTF0gUmVtb3ZlIGV3a190aWxlX3VudXNlZF9jYWNoZV9mcmVlIGZ1bmN0aW9uIGZv cm0gcHVibGljIGFwaQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjAxNTEKKworICAgICAgICBUaGUgZXdrX3RpbGVfdW51c2VkX2NhY2hlX2ZyZWUgZnVu Y3Rpb24gc2hvdWxkIGJlIG9ubHkgY2FsbGVkIGJ5CisgICAgICAgIGV3a190aWxlX3VudXNlZF9j YWNoZV91bnJlZiBmdW5jdGlvbi4gQ2FsbGluZyB0aGlzIGZ1bmN0aW9uIHdpdGhvdXQKKyAgICAg ICAgY29uc2lkZXJpbmcgcmVmZXJlbmNlIGNvdW50aW5nIG1heSBsZWFkIHRvIGZhdGFsIHJlc3Vs dHMuCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmM6CisgICAgICAgIChfZXdrX3Rp bGVfdW51c2VkX2NhY2hlX2ZyZWUpOgorICAgICAgICAoZXdrX3RpbGVfdW51c2VkX2NhY2hlX3Vu cmVmKToKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmg6CisKIDIwMTEtMDUtMDMgIExl YW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgW0VGTF0g VW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIE5FVFdPUktfQkFDS0VORD1jdXJsLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jCmluZGV4IDRiODFhMTUuLmExYWIyYzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuYworKysgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmMKQEAgLTU2MCwxMiArNTYwLDE2IEBA IHZvaWQgZXdrX3RpbGVfdW51c2VkX2NhY2hlX3VubG9ja19hcmVhKEV3a19UaWxlX1VudXNlZF9D YWNoZSAqdHVjKQogLyoqCiAgKiBGcmVlIGNhY2hlIG9mIHVudXNlZCB0aWxlcy4KICAqCisgKiBU aGlzIGZ1bmN0aW9uIHNob3VsZCBiZSBvbmx5IGNhbGxlZCBieSBld2tfdGlsZV91bnVzZWRfY2Fj aGVfdW5yZWYKKyAqIGZ1bmN0aW9uLiBDYWxsaW5nIHRoaXMgZnVuY3Rpb24gd2l0aG91dCBjb25z aWRlcmluZyByZWZlcmVuY2UgY291bnRpbmcKKyAqIG1heSBsZWFkIHRvIHVua25vd24gcmVzdWx0 cy4KKyAqCiAgKiBUaG9zZSB0aWxlcyB0aGF0IGFyZSBzdGlsbCB2aXNpYmxlIHdpbGwgcmVtYWlu IGxpdmUuIFRoZSB1bnVzZWQKICAqIHRpbGVzIHdpbGwgYmUgZnJlZWQuCiAgKgogICogQHNlZSBl d2tfdGlsZV91bnVzZWRfY2FjaGVfdW5yZWYoKQogICovCi12b2lkIGV3a190aWxlX3VudXNlZF9j YWNoZV9mcmVlKEV3a19UaWxlX1VudXNlZF9DYWNoZSAqdHVjKQorc3RhdGljIHZvaWQgX2V3a190 aWxlX3VudXNlZF9jYWNoZV9mcmVlKEV3a19UaWxlX1VudXNlZF9DYWNoZSAqdHVjKQogewogICAg IEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKHR1Yyk7CiAKQEAgLTYyOCw3ICs2MzIsNyBAQCB2 b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV91bnJlZihFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1 YykKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTih0dWMpOwogICAgIHR1Yy0+cmVmZXJl bmNlcy0tOwogICAgIGlmICghdHVjLT5yZWZlcmVuY2VzKQotICAgICAgICBld2tfdGlsZV91bnVz ZWRfY2FjaGVfZnJlZSh0dWMpOworICAgICAgICBfZXdrX3RpbGVfdW51c2VkX2NhY2hlX2ZyZWUo dHVjKTsKIH0KIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Rp bGVkX21vZGVsLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmgKaW5k ZXggNjUyNzcwZS4uNzk4ZjViYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9tb2RlbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9k ZWwuaApAQCAtNDEsNyArNDEsNiBAQCBFQVBJIHZvaWQgZXdrX3RpbGVfdXBkYXRlc19jbGVhcihF d2tfVGlsZSAqdCk7CiBFQVBJIEV3a19UaWxlX1VudXNlZF9DYWNoZSAqZXdrX3RpbGVfdW51c2Vk X2NhY2hlX25ldyhzaXplX3QgbWF4KTsKIEVBUEkgdm9pZCBld2tfdGlsZV91bnVzZWRfY2FjaGVf bG9ja19hcmVhKEV3a19UaWxlX1VudXNlZF9DYWNoZSAqdHVjLCBFdmFzX0Nvb3JkIHgsIEV2YXNf Q29vcmQgeSwgRXZhc19Db29yZCB3LCBFdmFzX0Nvb3JkIGgsIGZsb2F0IHpvb20pOwogRUFQSSB2 b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV91bmxvY2tfYXJlYShFd2tfVGlsZV9VbnVzZWRfQ2Fj aGUgKnR1Yyk7Ci1FQVBJIHZvaWQgZXdrX3RpbGVfdW51c2VkX2NhY2hlX2ZyZWUoRXdrX1RpbGVf VW51c2VkX0NhY2hlICp0dWMpOwogRUFQSSBFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKmV3a190aWxl X3VudXNlZF9jYWNoZV9yZWYoRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMpOwogRUFQSSB2b2lk IGV3a190aWxlX3VudXNlZF9jYWNoZV91bnJlZihFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1Yyk7 CiAK