60149 2011-05-04 02:37:44 -0700 [EFL] Added error check for _ewk_init_body result. 2011-05-04 16:34:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned commit-queue eric gyuyoung.kim kenneth lucas.de.marchi tonikitoo oldest_to_newest 397758 0 t.morawski 2011-05-04 02:37:44 -0700 The ewk_init function should be failed when _ewk_init_body function return false. 397760 1 92205 t.morawski 2011-05-04 02:38:26 -0700 Created attachment 92205 Patch 397762 2 t.morawski 2011-05-04 02:42:58 -0700 Change platform 397764 3 eric 2011-05-04 02:49:06 -0700 Attachment 92205 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 397770 4 92209 t.morawski 2011-05-04 03:04:15 -0700 Created attachment 92209 Fixed patch 397773 5 gyuyoung.kim 2011-05-04 03:09:53 -0700 LGTM. 397783 6 92209 kenneth 2011-05-04 03:46:12 -0700 Comment on attachment 92209 Fixed patch I guess that is ok 397802 7 gyuyoung.kim 2011-05-04 04:27:33 -0700 Lucas, How do you think about this patch ? 398270 8 92209 lucas.de.marchi 2011-05-04 14:48:17 -0700 Comment on attachment 92209 Fixed patch LGTM 398389 9 92209 commit-queue 2011-05-04 16:34:16 -0700 Comment on attachment 92209 Fixed patch Clearing flags on attachment: 92209 Committed r85804: <http://trac.webkit.org/changeset/85804> 398390 10 commit-queue 2011-05-04 16:34:22 -0700 All reviewed patches have been landed. Closing bug. 92205 2011-05-04 02:38:26 -0700 2011-05-04 03:04:15 -0700 Patch _ewk_init_body.patch text/plain 1052 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzMTVlMjUyLi42MTVjNzM3IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDQgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW0VGTF0gQWRkZWQgZXJyb3IgY2hlY2sgZm9yIF9ld2tfaW5pdF9ib2R5IHJlc3VsdC4K KworICAgICAgICBUaGUgZXdrX2luaXQgZnVuY3Rpb24gc2hvdWxkIGJlIGZhaWxlZCB3aGVuIF9l d2tfaW5pdF9ib2R5IGZ1bmN0aW9uCisgICAgICAgIHJldHVybiBmYWxzZS4KKworICAgICAgICAq IGV3ay9ld2tfbWFpbi5jcHA6CisgICAgICAgIChld2tfaW5pdCk6CisKIDIwMTEtMDUtMDMgIExl YW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgW0VGTF0g VW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIE5FVFdPUktfQkFDS0VORD1jdXJsLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfbWFpbi5jcHAKaW5kZXggOTY4N2YxMC4uOGNhODdkMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX21haW4uY3BwCkBAIC0xMDksNyArMTA5LDEwIEBAIGludCBld2tfaW5pdCh2b2lkKQog ICAgICAgICBnb3RvIGVycm9yX2VkamU7CiAgICAgfQogCi0gICAgX2V3a19pbml0X2JvZHkoKTsK KyAgICBpZiAoIV9ld2tfaW5pdF9ib2R5KCkpIHsKKyAgICAgICAgQ1JJVElDQUwoImNvdWxkIG5v dCBpbml0IGJvZHkiKTsKKyAgICAgICAgZ290byBlcnJvcl9lZGplOworICAgIH0KIAogICAgIHJl dHVybiArK19ld2tfaW5pdF9jb3VudDsKIAo= 92209 2011-05-04 03:04:15 -0700 2011-05-04 16:34:16 -0700 Fixed patch _ewk_init_body.patch text/plain 1107 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzMTVlMjUyLi43YTk0NDZkIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDQgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW0VGTF0gQWRkZWQgZXJyb3IgY2hlY2sgZm9yIF9ld2tfaW5pdF9ib2R5IHJlc3VsdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMTQ5CisK KyAgICAgICAgVGhlIGV3a19pbml0IGZ1bmN0aW9uIHNob3VsZCBiZSBmYWlsZWQgd2hlbiBfZXdr X2luaXRfYm9keSBmdW5jdGlvbgorICAgICAgICByZXR1cm4gZmFsc2UuCisKKyAgICAgICAgKiBl d2svZXdrX21haW4uY3BwOgorICAgICAgICAoZXdrX2luaXQpOgorCiAyMDExLTA1LTAzICBMZWFu ZHJvIFBlcmVpcmEgIDxsZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIFVu cmV2aWV3ZWQgYnVpbGQgZml4IGZvciBORVRXT1JLX0JBQ0tFTkQ9Y3VybC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX21haW4uY3BwCmluZGV4IDk2ODdmMTAuLjhjYTg3ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19tYWluLmNwcApAQCAtMTA5LDcgKzEwOSwxMCBAQCBpbnQgZXdrX2luaXQodm9pZCkKICAg ICAgICAgZ290byBlcnJvcl9lZGplOwogICAgIH0KIAotICAgIF9ld2tfaW5pdF9ib2R5KCk7Cisg ICAgaWYgKCFfZXdrX2luaXRfYm9keSgpKSB7CisgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3Qg aW5pdCBib2R5Iik7CisgICAgICAgIGdvdG8gZXJyb3JfZWRqZTsKKyAgICB9CiAKICAgICByZXR1 cm4gKytfZXdrX2luaXRfY291bnQ7CiAK