60147 2011-05-04 02:24:49 -0700 [EFL] Initialize viewport argument in ewk_view.cpp 2011-05-04 06:26:04 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 397753 0 gyuyoung.kim 2011-05-04 02:24:49 -0700 In _Ewk_View_Private_Data struct, viewport_arguments variable is defined. However, the viewport_arguments values are set to 0 because this structure is created by calloc(). So, if application invokes ewk_view_viewport_attributes_get() first without viewport meta tag, the ewk_view_viewport_attributes_get() returns wrong viewport values because viewport attributes values are set 0 instead of -1(ValueAuto). 397763 1 92206 gyuyoung.kim 2011-05-04 02:45:52 -0700 Created attachment 92206 Proposed Patch 397872 2 92206 commit-queue 2011-05-04 06:25:59 -0700 Comment on attachment 92206 Proposed Patch Clearing flags on attachment: 92206 Committed r85741: <http://trac.webkit.org/changeset/85741> 397873 3 commit-queue 2011-05-04 06:26:04 -0700 All reviewed patches have been landed. Closing bug. 92206 2011-05-04 02:45:52 -0700 2011-05-04 06:25:59 -0700 Proposed Patch patch-viewport.patch text/plain 1792 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzMTVlMjUyLi4yMmNkZTM3IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBJbml0aWFsaXplIHZpZXdwb3J0IGFyZ3VtZW50IGluIGV3a192aWV3LmNwcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAxNDcKKwor ICAgICAgICB2aWV3cG9ydCBjb21wdXRhdGlvbiBsb2dpYyBjYW4ndCBiZSB3b3JrZWQgY29ycmVj dGx5IGJlY2F1c2Ugdmlld3BvcnQgYXJndW1lbnQKKyAgICAgICAgaXNuJ3QgaW5pdGlhbGl6ZWQu IFNvLCB3ZSBuZWVkIHRvIGluaXRpYWxpemUgdmlld3BvcnQgYXJndW1lbnQuCisKKyAgICAgICAg KiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X3ByaXZfbmV3KToKKwogMjAx MS0wNS0wMyAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAg ICAgICBbRUZMXSBVbnJldmlld2VkIGJ1aWxkIGZpeCBmb3IgTkVUV09SS19CQUNLRU5EPWN1cmwu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBmYWYyZjZmLi43ZDFjMGMwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTU2Miw2ICs1NjIsMTQgQEAgc3RhdGljIEV3 a19WaWV3X1ByaXZhdGVfRGF0YSogX2V3a192aWV3X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0Rh dGEqIHNkKQogICAgICAgICBnb3RvIGVycm9yX3NldHRpbmdzOwogICAgIH0KIAorICAgIHByaXYt PnZpZXdwb3J0X2FyZ3VtZW50cy53aWR0aCA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpW YWx1ZUF1dG87CisgICAgcHJpdi0+dmlld3BvcnRfYXJndW1lbnRzLmhlaWdodCA9IFdlYkNvcmU6 OlZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG87CisgICAgcHJpdi0+dmlld3BvcnRfYXJndW1l bnRzLmluaXRpYWxTY2FsZSA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG87 CisgICAgcHJpdi0+dmlld3BvcnRfYXJndW1lbnRzLm1pbmltdW1TY2FsZSA9IFdlYkNvcmU6OlZp ZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG87CisgICAgcHJpdi0+dmlld3BvcnRfYXJndW1lbnRz Lm1heGltdW1TY2FsZSA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG87Cisg ICAgcHJpdi0+dmlld3BvcnRfYXJndW1lbnRzLnRhcmdldERlbnNpdHlEcGkgPSBXZWJDb3JlOjpW aWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvOworICAgIHByaXYtPnZpZXdwb3J0X2FyZ3VtZW50 cy51c2VyU2NhbGFibGUgPSBFSU5BX1RSVUU7CisKICAgICBwcml2LT5wYWdlX3NldHRpbmdzLT5z ZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkodHJ1ZSk7CiAgICAgcHJpdi0+cGFnZV9zZXR0aW5n cy0+c2V0RGVmYXVsdEZpeGVkRm9udFNpemUoMTIpOwogICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3Mt PnNldERlZmF1bHRGb250U2l6ZSgxNik7Cg==