60143 2011-05-04 00:02:57 -0700 Entering full screen fails >= second time on Vimeo.com. 2011-05-04 15:07:25 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://vimeo.com/21567634 InRadar P2 Normal --- 1 jer.noble jer.noble abarth eric gustavo.noronha gustavo webkit.review.bot xan.lopez oldest_to_newest 397722 0 jer.noble 2011-05-04 00:02:57 -0700 Entering full screen succeeds the first time when watching a video on Vimeo, but fails the second and subsequent times for a given page. The video is missing, and the full screen window shows the remaining, non-fullscreen portion of the page. 397723 1 jer.noble 2011-05-04 00:03:25 -0700 <rdar://problem/9380650> 397746 2 92200 jer.noble 2011-05-04 01:54:05 -0700 Created attachment 92200 Patch 397956 3 92200 darin 2011-05-04 09:12:51 -0700 Comment on attachment 92200 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92200&action=review > Source/WebCore/rendering/RenderFullScreen.cpp:42 > + // Force our layer to be updated by clearing its backing: Strange non-standard use of a colon here. I like that the comment says at least something the code does not. But It would be better to have a comment that said something a bit closer to what the change log note says. It’s not entirely clear how “clearing backing” is related to correctly reparenting, and that’s what the comment could help with. 397966 4 gustavo.noronha 2011-05-04 09:30:30 -0700 Attachment 92200 did not build on gtk: Build output: http://queues.webkit.org/results/8558538 397976 5 jer.noble 2011-05-04 09:37:30 -0700 gtk is failing because RenderLayerCompositor inherits from GraphicsLayerClient. The header is included from RenderLayerCompositor.h -> RenderLayerBacking.h -> GraphicsLayerClient.h. Unfortunately, the include in RenderLayerBacking.h is wrapped in a #if USE(ACCELERATED_COMPOSITING), so presumably gtk does not have that flag set. I'll wrap the #include "RenderLayerCompositor.h" statement in a #if USE(ACCELERATED_COMPOSITING) conditional before checking in. 397979 6 jer.noble 2011-05-04 09:38:16 -0700 In the long run, however, the entirety of RenderLayerCompositor.h should be wrapped in a #if USE(ACCELERATED_COMPOSITING) if it is truly dependent on that flag (as it seems it is). 397985 7 jer.noble 2011-05-04 09:42:16 -0700 Filed bug #60180 to cover the compile error. 397990 8 jer.noble 2011-05-04 09:44:52 -0700 (In reply to comment #3) > (From update of attachment 92200 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92200&action=review > > > Source/WebCore/rendering/RenderFullScreen.cpp:42 > > + // Force our layer to be updated by clearing its backing: > > Strange non-standard use of a colon here. > > I like that the comment says at least something the code does not. But It would be better to have a comment that said something a bit closer to what the change log note says. It’s not entirely clear how “clearing backing” is related to correctly reparenting, and that’s what the comment could help with. I've changed this comment to read: "Clearing the layer's backing will force the compositor to reparent the layer the next time layers are synchronized." 398116 9 jer.noble 2011-05-04 11:39:46 -0700 Committed r85767: <http://trac.webkit.org/changeset/85767> 398286 10 webkit.review.bot 2011-05-04 15:07:25 -0700 http://trac.webkit.org/changeset/85767 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/navigation/response204.html 92200 2011-05-04 01:54:05 -0700 2011-05-04 09:12:51 -0700 Patch bug-60143-20110504015407.patch text/plain 1834 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODU2MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjOTJmMWJhMmM2NDYwYjY2 MGJjNjM2MTIzZTM4ZTUxZDE3NjJmZmJlLi44YTE4MmQ0YmRhYzU4MzBlNDg2NTQxZTA5NzFmNjg4 OTMxMDAzYTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDQgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRW50ZXJpbmcgZnVsbCBzY3JlZW4gZmFpbHMgPj0gc2Vjb25k IHRpbWUgb24gVmltZW8uY29tLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjAxNDMKKworICAgICAgICBGb3JjZSB0aGUgUmVuZGVyRnVsbFNjcmVlbidz IGxheWVyIGJhY2tpbmcgdG8gYmUgcmVjcmVhdGVkIHdoZW4gc2V0QW5pbWF0aW5nKCkgaXMgY2Fs bGVkLgorICAgICAgICBQcmV2aW91c2x5LCB0aGUgUmVuZGVyTGF5ZXJDb21wb3NpdG9yIHdvdWxk IGZhaWwgdG8gcmVwYXJlbnQgdGhlIFJlbmRlckZ1bGxTY3JlZW4ncyBsYXllcgorICAgICAgICBh dCB0aGUgZW5kIG9mIGFuIGFuaW1hdGlvbiwgaWYgaXQgZGV0ZXJtaW5lZCB0aGF0IHRoZSBSZW5k ZXJGdWxsU2NyZWVuIHdvdWxkIHN0aWxsIHJlcXVpcmUKKyAgICAgICAgYSBsYXllciBldmVuIHdo ZW4gbm90IGFuaW1hdGluZy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVu LmNwcDoKKyAgICAgICAgKFJlbmRlckZ1bGxTY3JlZW46OnNldEFuaW1hdGluZyk6IENsZWFyIHRo ZSByZW5kZXJlcidzIGxheWVyLgorCiAyMDExLTA1LTAzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uY3BwCmluZGV4IDQ3NjcyN2Rj NjA1Nzg3MTYxYjE4OGQ0M2RjN2EzMmQyMzE1MWFmMzEuLjA4YmQxMjlmM2JhMDA4ZjIwMWZhMjFh NmY1ZTc2YWVlNmZmZDAxNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGdWxsU2NyZWVuLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RnVsbFNjcmVlbi5jcHAKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJSZW5kZXJGdWxsU2Ny ZWVuLmgiCiAKICNpbmNsdWRlICJSZW5kZXJMYXllci5oIgorI2luY2x1ZGUgIlJlbmRlckxheWVy Q29tcG9zaXRvci5oIgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApAQCAtMzYsOCArMzcs MTEgQEAgdm9pZCBSZW5kZXJGdWxsU2NyZWVuOjpzZXRBbmltYXRpbmcoYm9vbCBhbmltYXRpbmcp CiB7CiAgICAgbV9pc0FuaW1hdGluZyA9IGFuaW1hdGluZzsKICNpZiBVU0UoQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpCi0gICAgaWYgKGxheWVyKCkpCisgICAgaWYgKGxheWVyKCkpIHsKICAgICAg ICAgbGF5ZXIoKS0+Y29udGVudENoYW5nZWQoUmVuZGVyTGF5ZXI6OkZ1bGxTY3JlZW5DaGFuZ2Vk KTsKKyAgICAgICAgLy8gRm9yY2Ugb3VyIGxheWVyIHRvIGJlIHVwZGF0ZWQgYnkgY2xlYXJpbmcg aXRzIGJhY2tpbmc6CisgICAgICAgIGxheWVyKCktPmNsZWFyQmFja2luZygpOworICAgIH0KICNl bmRpZgogfQogCg==