60087 2011-05-03 17:07:49 -0700 WK2 Icon Database should provide access to all image representations in the icon. 2011-05-03 17:39:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson webkit.review.bot oldest_to_newest 397550 0 beidson 2011-05-03 17:07:49 -0700 WK2 Icon Database should provide access to all image representations in the icon. We need this for the CG platforms. In radar as <rdar://problem/9373182> 397555 1 92174 beidson 2011-05-03 17:13:18 -0700 Created attachment 92174 Patch v1 397558 2 webkit.review.bot 2011-05-03 17:14:30 -0700 Attachment 92174 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/cg/ImageCG.cpp:177: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 397571 3 92174 sam 2011-05-03 17:24:31 -0700 Comment on attachment 92174 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=92174&action=review > Source/WebCore/platform/graphics/BitmapImage.h:145 > + virtual RetainPtr<CFArrayRef> getCGImageArray(); I am not sure if get here is necessary, since you are returning a RetainPtr. 397583 4 beidson 2011-05-03 17:39:07 -0700 Landed in r85697 92174 2011-05-03 17:13:18 -0700 2011-05-03 17:24:31 -0700 Patch v1 patch.txt text/plain 5720 beidson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NjkxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDMgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MDA4NyBhbmQgPHJkYXI6Ly9wcm9ibGVtLzkzNzMxODI+CisgICAgICAgIFdLMiBJY29uIERh dGFiYXNlIHNob3VsZCBwcm92aWRlIGFjY2VzcyB0byBhbGwgaW1hZ2UgcmVwcmVzZW50YXRpb25z IGluIHRoZSBpY29uLgorCisgICAgICAgIEFkZCBhbiBhY2Nlc3NvciBmb3IgQ0cgcGxhdGZvcm1z IHRvIGdldCBhIENGQXJyYXlSZWYgb2YgYWxsIHRoZSBDR0ltYWdlUmVmcyByZXByZXNlbnRlZDoK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0ltYWdlLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZTo6Z2V0Q0dJ bWFnZUFycmF5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjpnZXRDR0ltYWdlQXJyYXkpOgorCiAyMDEx LTA1LTAzICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvQml0bWFwSW1hZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCShyZXZpc2lvbiA4NTY0MikKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0 Miw2ICsxNDIsNyBAQCBwdWJsaWM6CiAjaWYgVVNFKENHKQogICAgIHZpcnR1YWwgQ0dJbWFnZVJl ZiBnZXRDR0ltYWdlUmVmKCk7CiAgICAgdmlydHVhbCBDR0ltYWdlUmVmIGdldEZpcnN0Q0dJbWFn ZVJlZk9mU2l6ZShjb25zdCBJbnRTaXplJik7CisgICAgdmlydHVhbCBSZXRhaW5QdHI8Q0ZBcnJh eVJlZj4gZ2V0Q0dJbWFnZUFycmF5KCk7CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKFdJTikgfHwg KFBMQVRGT1JNKFFUKSAmJiBPUyhXSU5ET1dTKSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0ltYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvSW1hZ2UuaAkocmV2aXNpb24gODU2NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBA CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5o PgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAK ICNpZiBQTEFURk9STShNQUMpCiAjaWZkZWYgX19PQkpDX18KQEAgLTEzOSw2ICsxNDAsNyBAQCBw dWJsaWM6CiAjaWYgVVNFKENHKQogICAgIHZpcnR1YWwgQ0dJbWFnZVJlZiBnZXRDR0ltYWdlUmVm KCkgeyByZXR1cm4gMDsgfQogICAgIHZpcnR1YWwgQ0dJbWFnZVJlZiBnZXRGaXJzdENHSW1hZ2VS ZWZPZlNpemUoY29uc3QgSW50U2l6ZSYpIHsgcmV0dXJuIDA7IH0KKyAgICB2aXJ0dWFsIFJldGFp blB0cjxDRkFycmF5UmVmPiBnZXRDR0ltYWdlQXJyYXkoKSB7IHJldHVybiAwOyB9CiAjZW5kaWYK IAogI2lmIFBMQVRGT1JNKFdJTikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NnL0ltYWdlQ0cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCShyZXZpc2lvbiA4NTY0MikKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z Niw2ICszNiw3IEBACiAjaW5jbHVkZSAiUERGRG9jdW1lbnRJbWFnZS5oIgogI2luY2x1ZGUgIlBs YXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSA8QXBwbGljYXRpb25TZXJ2aWNlcy9BcHBsaWNhdGlv blNlcnZpY2VzLmg+CisjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ0ZBcnJheS5oPgogI2luY2x1 ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KIAogI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oQ0hS T01JVU0pCkBAIC0xNjcsNiArMTY4LDE5IEBAIENHSW1hZ2VSZWYgQml0bWFwSW1hZ2U6OmdldEZp cnN0Q0dJbWFnZVIKICAgICByZXR1cm4gZ2V0Q0dJbWFnZVJlZigpOwogfQogCitSZXRhaW5QdHI8 Q0ZBcnJheVJlZj4gQml0bWFwSW1hZ2U6OmdldENHSW1hZ2VBcnJheSgpCit7CisgICAgc2l6ZV90 IGNvdW50ID0gZnJhbWVDb3VudCgpOworICAgIGlmICghY291bnQpCisgICAgICAgIHJldHVybiAw OworICAgIAorICAgIENGTXV0YWJsZUFycmF5UmVmIGFycmF5ID0gQ0ZBcnJheUNyZWF0ZU11dGFi bGUoTlVMTCwgY291bnQsICZrQ0ZUeXBlQXJyYXlDYWxsQmFja3MpOworICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgY291bnQ7ICsraSkKKyAgICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVlKGFycmF5 LCBmcmFtZUF0SW5kZXgoaSkpOworICAgICAgICAKKyAgICByZXR1cm4gUmV0YWluUHRyPENGQXJy YXlSZWY+KEFkb3B0Q0YsIGFycmF5KTsKK30KKwogdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFw aGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJlY3QsIGNvbnN0IEZsb2F0 UmVjdCYgc3JjUmVjdCwgQ29sb3JTcGFjZSBzdHlsZUNvbG9yU3BhY2UsIENvbXBvc2l0ZU9wZXJh dG9yIGNvbXBvc2l0ZU9wKQogewogICAgIHN0YXJ0QW5pbWF0aW9uKCk7CkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA4NTY5MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTA1LTAzICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAwODcgYW5kIDxy ZGFyOi8vcHJvYmxlbS85MzczMTgyPgorICAgICAgICBXSzIgSWNvbiBEYXRhYmFzZSBzaG91bGQg cHJvdmlkZSBhY2Nlc3MgdG8gYWxsIGltYWdlIHJlcHJlc2VudGF0aW9ucyBpbiB0aGUgaWNvbi4K KworICAgICAgICBFeHBvc2UgYSBDRkFycmF5UmVmIG9mIENHSW1hZ2VSZWZzIGFzIEFQSSBmb3Ig Q0cgcGxhdGZvcm1zOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9jZy9XS0ljb25EYXRhYmFz ZUNHLmNwcDoKKyAgICAgICAgKFdLSWNvbkRhdGFiYXNlVHJ5Q29weUNHSW1hZ2VBcnJheUZvclVS TCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL2NnL1dLSWNvbkRhdGFiYXNlQ0cuaDoKKwog MjAxMS0wNS0wMyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0MvY2cvV0tJY29uRGF0YWJhc2VDRy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL2NnL1dLSWNvbkRhdGFiYXNlQ0cuY3BwCShyZXZpc2lvbiA4NTY0MikK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9jZy9XS0ljb25EYXRhYmFzZUNHLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzksMyArMzksMTAgQEAgQ0dJbWFnZVJlZiBXS0ljb25EYXRh YmFzZVRyeUdldENHSW1hZ2VGbwogICAgIEltYWdlKiBpbWFnZSA9IHRvSW1wbChpY29uRGF0YWJh c2VSZWYpLT5pbWFnZUZvclBhZ2VVUkwodG9XVEZTdHJpbmcodXJsUmVmKSk7CiAgICAgcmV0dXJu IGltYWdlID8gaW1hZ2UtPmdldEZpcnN0Q0dJbWFnZVJlZk9mU2l6ZShJbnRTaXplKHN0YXRpY19j YXN0PGludD4oc2l6ZS53aWR0aCksIHN0YXRpY19jYXN0PGludD4oc2l6ZS5oZWlnaHQpKSkgOiAw OwogfQorCitDRkFycmF5UmVmIFdLSWNvbkRhdGFiYXNlVHJ5Q29weUNHSW1hZ2VBcnJheUZvclVS TChXS0ljb25EYXRhYmFzZVJlZiBpY29uRGF0YWJhc2VSZWYsIFdLVVJMUmVmIHVybFJlZikKK3sK KyAgICBJbWFnZSogaW1hZ2UgPSB0b0ltcGwoaWNvbkRhdGFiYXNlUmVmKS0+aW1hZ2VGb3JQYWdl VVJMKHRvV1RGU3RyaW5nKHVybFJlZikpOworICAgIHJldHVybiBpbWFnZSA/IGltYWdlLT5nZXRD R0ltYWdlQXJyYXkoKS5sZWFrUmVmKCkgOiAwOworfQorCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvY2cvV0tJY29uRGF0YWJhc2VDRy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9jZy9XS0ljb25EYXRhYmFzZUNHLmgJKHJldmlzaW9u IDg1NjQyKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2NnL1dLSWNvbkRhdGFi YXNlQ0cuaAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQAogI2lmbmRlZiBXS0ljb25E YXRhYmFzZUNHX2gKICNkZWZpbmUgV0tJY29uRGF0YWJhc2VDR19oCiAKKyNpbmNsdWRlIDxDb3Jl Rm91bmRhdGlvbi9DRkFycmF5Lmg+CiAjaW5jbHVkZSA8Q29yZUdyYXBoaWNzL0NHSW1hZ2UuaD4K ICNpbmNsdWRlIDxXZWJLaXQyL1dLQmFzZS5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tHZW9tZXRy eS5oPgpAQCAtMzQsNyArMzUsOCBAQAogZXh0ZXJuICJDIiB7CiAjZW5kaWYKIAotV0tfRVhQT1JU IENHSW1hZ2VSZWYgV0tJY29uRGF0YWJhc2VUcnlHZXRDR0ltYWdlRm9yVVJMKFdLSWNvbkRhdGFi YXNlUmVmIGljb25EYXRhYmFzZSwgV0tVUkxSZWYgdXJsU3RyaW5nLCBXS1NpemUgc2l6ZSk7CitX S19FWFBPUlQgQ0dJbWFnZVJlZiBXS0ljb25EYXRhYmFzZVRyeUdldENHSW1hZ2VGb3JVUkwoV0tJ Y29uRGF0YWJhc2VSZWYgaWNvbkRhdGFiYXNlLCBXS1VSTFJlZiB1cmwsIFdLU2l6ZSBzaXplKTsK K1dLX0VYUE9SVCBDRkFycmF5UmVmIFdLSWNvbkRhdGFiYXNlVHJ5Q29weUNHSW1hZ2VBcnJheUZv clVSTChXS0ljb25EYXRhYmFzZVJlZiBpY29uRGF0YWJhc2UsIFdLVVJMUmVmIHVybCk7CiAKICNp ZmRlZiBfX2NwbHVzcGx1cwogfQo=