60049 2011-05-03 12:25:20 -0700 [Qt] Fix signals emitted in FakeReply used in autotests 2011-05-04 15:50:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo abarth commit-queue eric webkit.review.bot oldest_to_newest 397258 0 cmarcelo 2011-05-03 12:25:20 -0700 [Qt] Fix signals emitted in FakeReply used in autotests 397264 1 92105 cmarcelo 2011-05-03 12:36:03 -0700 Created attachment 92105 Patch 397297 2 92105 luiz 2011-05-03 13:06:04 -0700 Comment on attachment 92105 Patch LGTM 398106 3 92105 benjamin 2011-05-04 11:30:36 -0700 Comment on attachment 92105 Patch make sense 398143 4 92105 commit-queue 2011-05-04 12:00:55 -0700 Comment on attachment 92105 Patch Clearing flags on attachment: 92105 Committed r85772: <http://trac.webkit.org/changeset/85772> 398144 5 commit-queue 2011-05-04 12:01:00 -0700 All reviewed patches have been landed. Closing bug. 398288 6 webkit.review.bot 2011-05-04 15:07:37 -0700 http://trac.webkit.org/changeset/85772 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/navigation/response204.html 398337 7 cmarcelo 2011-05-04 15:50:01 -0700 (In reply to comment #6) > http://trac.webkit.org/changeset/85772 might have broken GTK Linux 64-bit Debug > The following tests are not passing: > http/tests/navigation/response204.html For the record: this patch only affects Qt autotests (small C++ programs that we use to test Qt API). So it's a "false alarm". PS: I'm not sure if it's helpful to add this kind of follow up. 92105 2011-05-03 12:36:03 -0700 2011-05-04 12:00:54 -0700 Patch bug-60049-20110503163601.patch text/plain 3432 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogODU2MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNmNjNWY2ODcyMjRh NTAzY2E0YzNhNWFmNDQ1NGFkZDlhN2UyZDNhMS4uNWRkYjRlZjgwMjUzYzBmODM5OTFmNzkxOWVi YjQ5ZjNmMThmMWQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMS0wNS0w MyAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9z c2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gRml4IHNpZ25hbHMgZW1pdHRlZCBpbiBGYWtlUmVwbHkgdXNlZCBpbiBhdXRvdGVzdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMDQ5CisK KyAgICAgICAgVGhlIHNpZ25hbHMgZW1pdHRlZCBmb3IgZWFjaCBjYXNlIG9mIEZha2VSZXBseSB3 ZXJlIHN3YXBwZWQgKGVycm9yIGNhc2UKKyAgICAgICAgZW1pdHRpbmcgbWV0YURhdGFDaGFuZ2Vk KCkgYW5kIHJlZGlyZWN0IGNhc2UgZW1pdHRpbmcgZXJyb3IoKSkuIEVtaXR0aW5nCisgICAgICAg IHJlYWR5UmVhZCgpIGlzIG5vdCBuZWNlc3NhcnkuCisKKyAgICAgICAgKiB0ZXN0cy9xd2ViZnJh bWUvdHN0X3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChGYWtlUmVwbHk6OkZha2VSZXBseSk6Cisg ICAgICAgIENob29zZSB0aGUgZGlmZmVyZW50IGNvbnRpbnVlIGZ1bmN0aW9uIGZvciBlYWNoIGNh c2Ugb2YgRmFrZVJlcGx5LiBUaGlzIHJlbW92ZXMKKyAgICAgICAgdGhlIG5lZWQgb2YgdGhlIGlm LXN0YXRlbWVudCBpbiB0aW1lb3V0KCkgYW5kIGxldCB1cyByZXBsYWNlIHRpbWVvdXQoKSB3aXRo IHR3bworICAgICAgICBzaW1wbGVyIGZ1bmN0aW9ucy4KKworICAgICAgICAoRmFrZVJlcGx5Ojpj b250aW51ZVJlZGlyZWN0KToKKyAgICAgICAgKEZha2VSZXBseTo6Y29udGludWVFcnJvcik6Cisg ICAgICAgIENvbnRpbnVhdGlvbiBjYXNlcywgZW1pdHRpbmcgdGhlIG1pbmltYWwgc2V0IG9mIHNp Z25hbHMgbmVlZGVkIGZvciBlYWNoIGNhc2UuCisKIDIwMTEtMDUtMDEgIFNhbSBXZWluaWcgIDxz YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1l LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3Bw CmluZGV4IDNiOTMyNGQ1YjExNzM3MzdiZDViYjJjMGNhYjRiNjE3OWQ1N2JiYzguLjZiZmI1MGZl YjFiMTBkM2Y4Y2ExYWY3YjA3Y2JhYWM1ODk0M2RkNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCkBAIC0yMzA5LDE2ICsyMzA5 LDIwIEBAIHB1YmxpYzoKICAgICAgICAgaWYgKHJlcXVlc3QudXJsKCkgPT0gUVVybCgicXJjOi90 ZXN0MS5odG1sIikpIHsKICAgICAgICAgICAgIHNldEhlYWRlcihRTmV0d29ya1JlcXVlc3Q6Okxv Y2F0aW9uSGVhZGVyLCBRU3RyaW5nKCJxcmM6L3Rlc3QyLmh0bWwiKSk7CiAgICAgICAgICAgICBz ZXRBdHRyaWJ1dGUoUU5ldHdvcmtSZXF1ZXN0OjpSZWRpcmVjdGlvblRhcmdldEF0dHJpYnV0ZSwg UVVybCgicXJjOi90ZXN0Mi5odG1sIikpOworICAgICAgICAgICAgUVRpbWVyOjpzaW5nbGVTaG90 KDAsIHRoaXMsIFNMT1QoY29udGludWVSZWRpcmVjdCgpKSk7CiAgICAgICAgIH0KICNpZm5kZWYg UVRfTk9fT1BFTlNTTAotICAgICAgICBlbHNlIGlmIChyZXF1ZXN0LnVybCgpID09IFFVcmwoInFy YzovZmFrZS1zc2wtZXJyb3IuaHRtbCIpKQotICAgICAgICAgICAgc2V0RXJyb3IoUU5ldHdvcmtS ZXBseTo6U3NsSGFuZHNoYWtlRmFpbGVkRXJyb3IsIHRyKCJGYWtlIGVycm9yICEiKSk7IC8vIGZv cmNlIGEgc3NsIGVycm9yCisgICAgICAgIGVsc2UgaWYgKHJlcXVlc3QudXJsKCkgPT0gUVVybCgi cXJjOi9mYWtlLXNzbC1lcnJvci5odG1sIikpIHsKKyAgICAgICAgICAgIHNldEVycm9yKFFOZXR3 b3JrUmVwbHk6OlNzbEhhbmRzaGFrZUZhaWxlZEVycm9yLCB0cigiRmFrZSBlcnJvciEiKSk7Cisg ICAgICAgICAgICBRVGltZXI6OnNpbmdsZVNob3QoMCwgdGhpcywgU0xPVChjb250aW51ZUVycm9y KCkpKTsKKyAgICAgICAgfQogI2VuZGlmCi0gICAgICAgIGVsc2UgaWYgKHJlcXVlc3QudXJsKCku aG9zdCgpID09IFFMYXRpbjFTdHJpbmcoImFiY2RlZi5hYmNkZWYiKSkKKyAgICAgICAgZWxzZSBp ZiAocmVxdWVzdC51cmwoKS5ob3N0KCkgPT0gUUxhdGluMVN0cmluZygiYWJjZGVmLmFiY2RlZiIp KSB7CiAgICAgICAgICAgICBzZXRFcnJvcihRTmV0d29ya1JlcGx5OjpIb3N0Tm90Rm91bmRFcnJv ciwgdHIoIkludmFsaWQgVVJMIikpOworICAgICAgICAgICAgUVRpbWVyOjpzaW5nbGVTaG90KDAs IHRoaXMsIFNMT1QoY29udGludWVFcnJvcigpKSk7CisgICAgICAgIH0KIAogICAgICAgICBvcGVu KFFJT0RldmljZTo6UmVhZE9ubHkpOwotICAgICAgICBRVGltZXI6OnNpbmdsZVNob3QoMCwgdGhp cywgU0xPVCh0aW1lb3V0KCkpKTsKICAgICB9CiAgICAgfkZha2VSZXBseSgpCiAgICAgewpAQCAt MjMzNCwxOCArMjMzOCwxNSBAQCBwcm90ZWN0ZWQ6CiAgICAgfQogCiBwcml2YXRlIHNsb3RzOgot ICAgIHZvaWQgdGltZW91dCgpCisgICAgdm9pZCBjb250aW51ZVJlZGlyZWN0KCkKICAgICB7Ci0g ICAgICAgIGlmIChyZXF1ZXN0KCkudXJsKCkgPT0gUVVybCgicXJjOi8vdGVzdDEuaHRtbCIpKQot ICAgICAgICAgICAgZW1pdCBlcnJvcih0aGlzLT5lcnJvcigpKTsKLSAgICAgICAgZWxzZSBpZiAo cmVxdWVzdCgpLnVybCgpID09IFFVcmwoImh0dHA6Ly9hYmNkZWYuYWJjZGVmLyIpKQotICAgICAg ICAgICAgZW1pdCBtZXRhRGF0YUNoYW5nZWQoKTsKLSNpZm5kZWYgUVRfTk9fT1BFTlNTTAotICAg ICAgICBlbHNlIGlmIChyZXF1ZXN0KCkudXJsKCkgPT0gUVVybCgicXJjOi9mYWtlLXNzbC1lcnJv ci5odG1sIikpCi0gICAgICAgICAgICByZXR1cm47Ci0jZW5kaWYKKyAgICAgICAgZW1pdCBtZXRh RGF0YUNoYW5nZWQoKTsKKyAgICAgICAgZW1pdCBmaW5pc2hlZCgpOworICAgIH0KIAotICAgICAg ICBlbWl0IHJlYWR5UmVhZCgpOworICAgIHZvaWQgY29udGludWVFcnJvcigpCisgICAgeworICAg ICAgICBlbWl0IGVycm9yKHRoaXMtPmVycm9yKCkpOwogICAgICAgICBlbWl0IGZpbmlzaGVkKCk7 CiAgICAgfQogfTsK