60048 2011-05-03 11:49:56 -0700 store results.html options in localstorage 2011-05-03 13:51:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan eric mihaip tony oldest_to_newest 397234 0 ojan 2011-05-03 11:49:56 -0700 store results.html options in localstorage 397235 1 92098 ojan 2011-05-03 11:51:33 -0700 Created attachment 92098 Patch 397243 2 92098 eric 2011-05-03 12:03:17 -0700 Comment on attachment 92098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review > LayoutTests/fast/harness/resources/results-test.js:65 > +function runTest(results, assertions, opt_localStorageValue) opt_? Funny prefix. 397251 3 ojan 2011-05-03 12:15:09 -0700 (In reply to comment #2) > (From update of attachment 92098 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review > > > LayoutTests/fast/harness/resources/results-test.js:65 > > +function runTest(results, assertions, opt_localStorageValue) > > opt_? Funny prefix. It's a convention I picked up from Google's JS code. I'm happy to remove the prefix or do something different. It's useful to be able to specify that an argument is optional though. 397323 4 92098 tony 2011-05-03 13:37:32 -0700 Comment on attachment 92098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review >>> LayoutTests/fast/harness/resources/results-test.js:65 >> >> opt_? Funny prefix. > > It's a convention I picked up from Google's JS code. I'm happy to remove the prefix or do something different. It's useful to be able to specify that an argument is optional though. The opt_ prefix seems fine considering we already checked in some code for it. We can discuss/change if we decide to have a JS style guide. 397352 5 ojan 2011-05-03 13:51:59 -0700 Committed r85654: <http://trac.webkit.org/changeset/85654> 92098 2011-05-03 11:51:33 -0700 2011-05-03 13:37:32 -0700 Patch bug-60048-20110503115132.patch text/plain 6273 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODU2MjYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NTk2NTQ4MDVhNWQxZGE4ZmEyYjE4 MjdkYTMyNWUwY2Y5OGNlZGRiLi5kMDBmZDAzNWQ0Y2M0OTFkYjJkZWMwZGViMTZhZTEyZGUxNTI3 NjIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDUtMDMgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBzdG9yZSByZXN1bHRzLmh0bWwgb3B0aW9ucyBpbiBsb2NhbHN0b3JhZ2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMDQ4CisKKyAgICAg ICAgVGhpcyBtYWtlcyBvcHRpb25zIHBlcnNpc3RlbnQgcGVyLWRvbWFpbi4gSXQncyBub3QgcGVy ZmVjdCwKKyAgICAgICAgYnV0IGl0IHNob3VsZCBtYWtlIGl0IHBvc3NpYmxlIHRvIGhhdmUgcHJl ZmVyZW5jZXMgZm9yIGhvdworICAgICAgICBwZW9wbGUgd291bGQgbGlrZSB0aGUgcmVzdWx0cy5o dG1sIHBhZ2UgdG8gcmVuZGVyLgorCisgICAgICAgICogZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9y ZXN1bHRzLXRlc3QuanM6CisgICAgICAgICogZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbDoKKwor MjAxMS0wNS0wMyAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IFRvbnkgQ2hhbmcuCiAKICAgICAgICAgbWFrZSBwaXhlbCB6b29taW5nIGluIHJl c3VsdHMuaHRtbCBmaWxlIGxlc3MgamFycmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRlc3QuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2hh cm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qcwppbmRleCBjMmI0ZjliMjMzZWM2NzA3M2Jl N2MyMmU3Y2Y1NTE3YmRmNWNmMWIwLi41NzAyMTJhNTI1N2Y4YzZiYzczODViYjQ5MzFlMzE1N2Mw NzI5Njk1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jl c3VsdHMtdGVzdC5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jl c3VsdHMtdGVzdC5qcwpAQCAtNjIsMTEgKzYyLDEyIEBAIGZ1bmN0aW9uIGFzc2VydFRydWUoYm9v bCkKICAgICAgICAgbG9nRmFpbCgnRkFJTCcpOwogfQogCi1mdW5jdGlvbiBydW5UZXN0KHJlc3Vs dHMsIGFzc2VydGlvbnMpCitmdW5jdGlvbiBydW5UZXN0KHJlc3VsdHMsIGFzc2VydGlvbnMsIG9w dF9sb2NhbFN0b3JhZ2VWYWx1ZSkKIHsKICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICcn OwogICAgIGdfdGVzdEluZGV4Kys7CiAgICAgZ19zdGF0ZSA9IHVuZGVmaW5lZDsKKyAgICBsb2Nh bFN0b3JhZ2Uuc2V0SXRlbShPcHRpb25Xcml0ZXIuX2tleSwgb3B0X2xvY2FsU3RvcmFnZVZhbHVl IHx8ICcnKTsKIAogICAgIHRyeSB7CiAgICAgICAgIEFERF9SRVNVTFRTKHJlc3VsdHMpOwpAQCAt MTE5LDcgKzEyMCw3IEBAIGZ1bmN0aW9uIHJ1blRlc3RzKCkKICAgICAgICAgYXNzZXJ0VHJ1ZShk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaW1hZ2UtcmVzdWx0cy1oZWFkZXInKS50ZXh0Q29udGVu dCA9PSAnJyk7CiAgICAgICAgIGFzc2VydFRydWUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rl eHQtcmVzdWx0cy1oZWFkZXInKS50ZXh0Q29udGVudCAhPSAnJyk7CiAgICAgfSk7Ci0gICAgCisK ICAgICByZXN1bHRzID0gbW9ja1Jlc3VsdHMoKTsKICAgICB2YXIgc3VidHJlZSA9IHJlc3VsdHMu dGVzdHNbJ2ZvbyddID0ge30KICAgICBzdWJ0cmVlWydiYXIuaHRtbCddID0gbW9ja0V4cGVjdGF0 aW9uKCdURVhUJywgJ01JU1NJTkcnKTsKQEAgLTM4Miw2ICszODMsMTMgQEAgZnVuY3Rpb24gcnVu VGVzdHMoKQogICAgICAgICB1cGRhdGVUb2dnbGluZ0ltYWdlcygpOwogICAgICAgICBhc3NlcnRU cnVlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3Rib2R5IHRkOm50aC1jaGlsZCgzKScpLnRleHRD b250ZW50ID09ICcgaW1hZ2VzICAgZGlmZiAnKTsKICAgICB9KTsKKyAgICAKKyAgICByZXN1bHRz ID0gbW9ja1Jlc3VsdHMoKTsKKyAgICByZXN1bHRzLnRlc3RzWydyZWFkaW5nLW9wdGlvbnMtZnJv bS1sb2NhbHN0b3JhZ2UuaHRtbCddID0gbW9ja0V4cGVjdGF0aW9uKCdJTUFHRStURVhUJywgJ0lN QUdFK1RFWFQnKTsKKyAgICBydW5UZXN0KHJlc3VsdHMsIGZ1bmN0aW9uKCkgeworICAgICAgICBh c3NlcnRUcnVlKHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3Io J3Rib2R5JyksIG51bGwpWydkaXNwbGF5J10gIT0gJ25vbmUnKTsKKyAgICAgICAgYXNzZXJ0VHJ1 ZShkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCd0Ym9keSB0ZDpudGgtY2hpbGQoMyknKS50ZXh0Q29u dGVudCA9PSAnZXhwZWN0ZWQgYWN0dWFsICBkaWZmICcpOworICAgIH0sICd7InRvZ2dsZS1pbWFn ZXMiOmZhbHNlLCJ1bmV4cGVjdGVkLXJlc3VsdHMiOmZhbHNlfScpOwogCiAgICAgZG9jdW1lbnQu Ym9keS5pbm5lckhUTUwgPSAnPHByZT4nICsgZ19sb2cuam9pbignXG4nKSArICc8L3ByZT4nOwog fQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWwKaW5kZXggOGY5ZThhM2VlZmYxNTIw YTNjNGNjNDZhZmM5M2FjNWQ5MGU2NTExZC4uZWRlNzMzOWEyNDE4N2EwNzczNDE1YWI2ZWZjYjky MDM1OGE2OGM0NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sCkBAIC03NDIs OCArNzQyLDEzIEBAIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoJ21vdXNlb3V0JywgUGl4ZWxa b29tZXIuaGFuZGxlTW91c2VPdXQsIGZhbHNlKTsKIAogZnVuY3Rpb24gb25seVNob3dVbmV4cGVj dGVkRmFpbHVyZXMoKQogewotICAgIHZhciBjaGVja0JveCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd1bmV4cGVjdGVkLXJlc3VsdHMnKTsKLSAgICByZXR1cm4gIWNoZWNrQm94IHx8IGNoZWNr Qm94LmNoZWNrZWQ7CisgICAgcmV0dXJuIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd1bmV4cGVj dGVkLXJlc3VsdHMnKS5jaGVja2VkOworfQorCitmdW5jdGlvbiBoYW5kbGVVbmV4cGVjdGVkUmVz dWx0c0NoYW5nZSgpCit7CisgICAgT3B0aW9uV3JpdGVyLnNhdmUoKTsKKyAgICB1cGRhdGVFeHBl Y3RlZEZhaWx1cmVzKCk7CiB9CiAKIGZ1bmN0aW9uIHVwZGF0ZUV4cGVjdGVkRmFpbHVyZXMoKQpA QCAtNzUyLDYgKzc1Nyw0MyBAQCBmdW5jdGlvbiB1cGRhdGVFeHBlY3RlZEZhaWx1cmVzKCkKICAg ICAgICAgJy5leHBlY3RlZCB7IGRpc3BsYXk6IG5vbmU7IH0nIDogJyc7CiB9CiAKK3ZhciBPcHRp b25Xcml0ZXIgPSB7fTsKKworT3B0aW9uV3JpdGVyLl9rZXkgPSAncnVuLXdlYmtpdC10ZXN0cy1v cHRpb25zJzsKKworT3B0aW9uV3JpdGVyLnNhdmUgPSBmdW5jdGlvbigpCit7CisgICAgdmFyIG9w dGlvbnMgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCdsYWJlbCBpbnB1dCcpOworICAgIHZh ciBkYXRhID0ge307CisgICAgZm9yICh2YXIgaSA9IDAsIGxlbiA9IG9wdGlvbnMubGVuZ3RoOyBp IDwgbGVuOyBpKyspIHsKKyAgICAgICAgdmFyIG9wdGlvbiA9IG9wdGlvbnNbaV07CisgICAgICAg IGRhdGFbb3B0aW9uLmlkXSA9IG9wdGlvbi5jaGVja2VkOworICAgIH0KKyAgICBsb2NhbFN0b3Jh Z2Uuc2V0SXRlbShPcHRpb25Xcml0ZXIuX2tleSwgSlNPTi5zdHJpbmdpZnkoZGF0YSkpOworfQor CitPcHRpb25Xcml0ZXIuYXBwbHkgPSBmdW5jdGlvbigpCit7CisgICAgdmFyIGpzb24gPSBsb2Nh bFN0b3JhZ2UuZ2V0SXRlbShPcHRpb25Xcml0ZXIuX2tleSk7CisgICAgaWYgKCFqc29uKQorICAg ICAgICByZXR1cm47CisKKyAgICB2YXIgZGF0YSA9IEpTT04ucGFyc2UoanNvbik7CisgICAgZm9y ICh2YXIgaWQgaW4gZGF0YSkgeworICAgICAgICB2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZChpZCk7CisgICAgICAgIGlmIChpbnB1dCkgeworICAgICAgICAgICAgaW5wdXQuY2hl Y2tlZCA9IGRhdGFbaWRdOworICAgICAgICAgICAgaW5wdXQub25jaGFuZ2UoKTsKKyAgICAgICAg fQorICAgIH0KK30KKworZnVuY3Rpb24gaGFuZGxlVG9nZ2xlSW1hZ2VzQ2hhbmdlKCkKK3sKKyAg ICBPcHRpb25Xcml0ZXIuc2F2ZSgpOworICAgIHVwZGF0ZVRvZ2dsaW5nSW1hZ2VzKCk7Cit9CisK IGZ1bmN0aW9uIHVwZGF0ZVRvZ2dsaW5nSW1hZ2VzKCkKIHsKICAgICB2YXIgc2hvdWxkVG9nZ2xl ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RvZ2dsZS1pbWFnZXMnKS5jaGVja2VkOwpAQCAt NzcyLDcgKzgxNCw2IEBAIGZ1bmN0aW9uIHVwZGF0ZVRvZ2dsaW5nSW1hZ2VzKCkKICAgICB1cGRh dGVJbWFnZVRvZ2dsaW5nVGltZXIoKTsKIH0KIAotCiBmdW5jdGlvbiBnZXRSZXN1bHRDb250YWlu ZXIobm9kZSkKIHsKICAgICByZXR1cm4gKG5vZGUudGFnTmFtZSA9PSAnSU1HJykgPyBwYXJlbnRP ZlR5cGUobm9kZSwgJy5yZXN1bHQtY29udGFpbmVyJykgOiBub2RlOwpAQCAtODA2LDExICs4NDcs OSBAQCBmdW5jdGlvbiBnZW5lcmF0ZVBhZ2UoKQogICAgICAgICAnPGEgaHJlZj0iamF2YXNjcmlw dDp2b2lkKCkiIGNsYXNzPSJjb2xsYXBzZS1hbGwiIG9uY2xpY2s9ImNvbGxhcHNlQWxsRXhwZWN0 YXRpb25zKCkiPmNvbGxhcHNlIGFsbDwvYT4nOwogCiAgICAgLy8gRklYTUU6IHB1dCB0aGVzZSBv cHRpb25zIGluIGEgbWVudQotICAgIC8vIEZJWE1FOiBzdG9yZSB0aGVzZSBhcyBwcmVmcyBpbiBs b2NhbHN0b3JhZ2U/Ci0gICAgaWYgKGdsb2JhbFN0YXRlKCkucmVzdWx0cy51c2VzX2V4cGVjdGF0 aW9uc19maWxlKQotICAgICAgICBodG1sICs9ICc8bGFiZWw+PGlucHV0IGlkPSJ1bmV4cGVjdGVk LXJlc3VsdHMiIHR5cGU9Y2hlY2tib3ggY2hlY2tlZCBvbmNoYW5nZT0idXBkYXRlRXhwZWN0ZWRG YWlsdXJlcygpIj5Pbmx5IHNob3cgdW5leHBlY3RlZCByZXN1bHRzPC9sYWJlbD4nOworICAgIGh0 bWwgKz0gJzxsYWJlbD48aW5wdXQgaWQ9InVuZXhwZWN0ZWQtcmVzdWx0cyIgdHlwZT1jaGVja2Jv eCBjaGVja2VkIG9uY2hhbmdlPSJoYW5kbGVVbmV4cGVjdGVkUmVzdWx0c0NoYW5nZSgpIj5Pbmx5 IHNob3cgdW5leHBlY3RlZCByZXN1bHRzPC9sYWJlbD4nOwogCi0gICAgaHRtbCArPSAnPGxhYmVs PjxpbnB1dCBpZD0idG9nZ2xlLWltYWdlcyIgdHlwZT1jaGVja2JveCBjaGVja2VkIG9uY2hhbmdl PSJ1cGRhdGVUb2dnbGluZ0ltYWdlcygpIj5Ub2dnbGUgaW1hZ2VzPC9sYWJlbD4nOworICAgIGh0 bWwgKz0gJzxsYWJlbD48aW5wdXQgaWQ9InRvZ2dsZS1pbWFnZXMiIHR5cGU9Y2hlY2tib3ggY2hl Y2tlZCBvbmNoYW5nZT0iaGFuZGxlVG9nZ2xlSW1hZ2VzQ2hhbmdlKCkiPlRvZ2dsZSBpbWFnZXM8 L2xhYmVsPic7CiAKICAgICBodG1sICs9ICc8L2Rpdj4nOwogCkBAIC04NDYsOSArODg1LDEzIEBA IGZ1bmN0aW9uIGdlbmVyYXRlUGFnZSgpCiAKICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9 IGh0bWw7CiAKKyAgICBPcHRpb25Xcml0ZXIuYXBwbHkoKTsKKwogICAgIGlmIChkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncmVzdWx0cy10YWJsZScpKSB7CiAgICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdyZXN1bHRzLXRhYmxlJykuYWRkRXZlbnRMaXN0ZW5lcignY2xpY2snLCBUYWJs ZVNvcnRlci5oYW5kbGVDbGljaywgZmFsc2UpOwogICAgICAgICBUYWJsZVNvcnRlci5zb3J0Q29s dW1uKDApOworICAgICAgICBpZiAoIWdsb2JhbFN0YXRlKCkucmVzdWx0cy51c2VzX2V4cGVjdGF0 aW9uc19maWxlKQorICAgICAgICAgICAgcGFyZW50T2ZUeXBlKGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd1bmV4cGVjdGVkLXJlc3VsdHMnKSwgJ2xhYmVsJykuc3R5bGUuZGlzcGxheSA9ICdub25l JzsKICAgICAgICAgaWYgKCFnbG9iYWxTdGF0ZSgpLmhhc1RleHRGYWlsdXJlcykKICAgICAgICAg ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXh0LXJlc3VsdHMtaGVhZGVyJykudGV4dENv bnRlbnQgPSAnJzsKICAgICAgICAgaWYgKCFnbG9iYWxTdGF0ZSgpLmhhc0ltYWdlRmFpbHVyZXMp IHsK