60045 2011-05-03 11:33:01 -0700 Scrollbar thumb sometimes leaves artifacts in the track after scrolling 2011-05-03 11:45:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 397219 0 bdakin 2011-05-03 11:33:01 -0700 Sometimes the scrollbar thumb leaves artifacts of itself at the top and/or bottom of the track after scrolling. <rdar://problem/9015376> Patch forthcoming. 397221 1 92094 bdakin 2011-05-03 11:35:37 -0700 Created attachment 92094 Patch 397226 2 92094 mitz 2011-05-03 11:38:00 -0700 Comment on attachment 92094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92094&action=review > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:143 > +#if USE(WK_SCROLLBAR_PAINTER) > + gButtonPlacement = ScrollbarButtonsNone; > +#else You can return here and not read the default. Or you can return without even setting the value because it’s already initialized to ScrollbarButtonsNone in the static initializer. 397231 3 bdakin 2011-05-03 11:44:03 -0700 (In reply to comment #2) > You can return here and not read the default. Or you can return without even setting the value because it’s already initialized to ScrollbarButtonsNone in the static initializer. Sounds good! Will change. 397232 4 bdakin 2011-05-03 11:45:41 -0700 Committed change with revision 85629. 92094 2011-05-03 11:35:37 -0700 2011-05-03 11:38:00 -0700 Patch for-review.txt text/plain 1875 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NjI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDMgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDA0NQorICAgICAgICBTY3JvbGxiYXIgdGh1bWIgc29tZXRpbWVzIGxlYXZlcyBhcnRpZmFjdHMg aW4gdGhlIHRyYWNrIGFmdGVyIHNjcm9sbGluZworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmct CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MDE1Mzc2PgorCisgICAgICAgIFdoZW4gd2UncmUg dXNpbmcgV0tfU0NST0xMQkFSX1BBSU5URVIsIHRoZSBBcHBsZVNjcm9sbEJhclZhcmlhbnQgZGVm YXVsdCBzaG91bGQgCisgICAgICAgIGFsd2F5cyBiZSBpZ25vcmVkLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnVwZGF0ZUFy cm93UGxhY2VtZW50KToKKwogMjAxMS0wNS0wMyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0JKHJldmlzaW9u IDg1NTgyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsNiArMTM4LDkgQEAgc3RhdGljIFNjcm9sbGJhckJ1 dHRvbnNQbGFjZW1lbnQgZ0J1dHRvbgogCiBzdGF0aWMgdm9pZCB1cGRhdGVBcnJvd1BsYWNlbWVu dCgpCiB7CisjaWYgVVNFKFdLX1NDUk9MTEJBUl9QQUlOVEVSKQorICAgIGdCdXR0b25QbGFjZW1l bnQgPSBTY3JvbGxiYXJCdXR0b25zTm9uZTsKKyNlbHNlCiAgICAgTlNTdHJpbmcgKmJ1dHRvblBs YWNlbWVudCA9IFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIG9iamVjdEZv cktleTpAIkFwcGxlU2Nyb2xsQmFyVmFyaWFudCJdOwogICAgIGlmIChbYnV0dG9uUGxhY2VtZW50 IGlzRXF1YWxUb1N0cmluZzpAIlNpbmdsZSJdKQogICAgICAgICBnQnV0dG9uUGxhY2VtZW50ID0g U2Nyb2xsYmFyQnV0dG9uc1NpbmdsZTsKQEAgLTE0NiwxMiArMTQ5LDEwIEBAIHN0YXRpYyB2b2lk IHVwZGF0ZUFycm93UGxhY2VtZW50KCkKICAgICBlbHNlIGlmIChbYnV0dG9uUGxhY2VtZW50IGlz RXF1YWxUb1N0cmluZzpAIkRvdWJsZUJvdGgiXSkKICAgICAgICAgZ0J1dHRvblBsYWNlbWVudCA9 IFNjcm9sbGJhckJ1dHRvbnNEb3VibGVCb3RoOwogICAgIGVsc2UgewotI2lmIFVTRShXS19TQ1JP TExCQVJfUEFJTlRFUikKLSAgICAgICAgZ0J1dHRvblBsYWNlbWVudCA9IFNjcm9sbGJhckJ1dHRv bnNOb25lOwotI2Vsc2UKKwogICAgICAgICBnQnV0dG9uUGxhY2VtZW50ID0gU2Nyb2xsYmFyQnV0 dG9uc0RvdWJsZUVuZDsKLSNlbmRpZgogICAgIH0KKyNlbmRpZgogfQogCiB2b2lkIFNjcm9sbGJh clRoZW1lTWFjOjpyZWdpc3RlclNjcm9sbGJhcihTY3JvbGxiYXIqIHNjcm9sbGJhcikK