60041 2011-05-03 11:01:25 -0700 [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0 2011-07-14 02:16:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi commit-queue kenneth lucas.de.marchi mrobinson tonikitoo xan.lopez yang.jie oldest_to_newest 397195 0 lucas.de.marchi 2011-05-03 11:01:25 -0700 [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0 397198 1 92091 lucas.de.marchi 2011-05-03 11:03:48 -0700 Created attachment 92091 Patch 397204 2 92091 xan.lopez 2011-05-03 11:14:18 -0700 Comment on attachment 92091 Patch Looks good to me! 397663 3 92091 lucas.de.marchi 2011-05-03 20:16:01 -0700 Comment on attachment 92091 Patch Clearing flags on attachment: 92091 Committed r85710: <http://trac.webkit.org/changeset/85710> 397664 4 lucas.de.marchi 2011-05-03 20:16:23 -0700 All reviewed patches have been landed. Closing bug. 437012 5 yang.jie 2011-07-14 02:16:04 -0700 why the patch is only added to Source/cmake/WebKitHelpers.cmake? I found the compling still failed on the 14.0.812.0 chromium, log as below:   CXX(target) out/Release/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources01.o In file included from third_party/WebKit/Source/JavaScriptCore/wtf/PassRefPtr.h:25:0,                  from third_party/WebKit/Source/JavaScriptCore/wtf/CrossThreadRefCounted.h:35,                  from third_party/WebKit/Source/JavaScriptCore/wtf/text/StringImpl.h:28,                  from third_party/WebKit/Source/JavaScriptCore/wtf/text/WTFString.h:28,                  from third_party/WebKit/Source/WebCore/platform/text/PlatformString.h:28,                  from third_party/WebKit/Source/WebCore/loader/cache/CachedResource.h:28,                  from third_party/WebKit/Source/WebCore/loader/cache/CachedResourceHandle.h:29,                  from third_party/WebKit/Source/WebCore/dom/Clipboard.h:27,                  from third_party/WebKit/Source/WebCore/dom/Event.h:27,                  from third_party/WebKit/Source/WebCore/dom/BeforeProcessEvent.h:30,                  from out/Release/obj/gen/webkit/bindings/V8BeforeProcessEvent.h:24,                  from out/Release/obj/gen/webcore/bindings/V8BeforeProcessEvent.cpp:22,                  from out/Release/obj/gen/webkit/bindings/V8DerivedSources01.cpp:31: third_party/WebKit/Source/JavaScriptCore/wtf/NullPtr.h:48:1: error:  identifier 'nullptr' will become a keyword in C++0x  [-Werror=c++0x-compat] this patch is already there. 92091 2011-05-03 11:03:48 -0700 2011-05-03 20:16:01 -0700 Patch bug-60041-20110503150417.patch text/plain 1716 lucas.de.marchi U3VidmVyc2lvbiBSZXZpc2lvbjogODU2MjIKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBhOTRjY2M1ZTQxYWFiNzllYTZiMjE2ZGFkN2NlZWQ3ZWUwYzRkMDE3Li41ZWI0 M2NjNzk3OThjZjQ2MDNiOWNkNGQ2OTk4NjQ5N2IwYmU4NTU1IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDMgIEx1Y2FzIERl IE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gUmVtb3ZlIEMrKzB4IGNv bXBhdCBtb2RlIHdhcm5pbmdzIGZvciBHQ0MgPj0gNC42LjAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMDQxCisKKyAgICAgICAgSGFyZGNvZGUgLVdu by1jKysweC1jb21wYXQgZm9yIHRoZSBkZWZhdWx0IGNvbXBpbGVyIChpZiB2ZXJzaW9uID49Cisg ICAgICAgIDQuNi4wKSB1bnRpbCBvdXIgY29kZWJhc2UgaXMgcmVhZHkuIFRoaXMgaXMgdGhlIHNh bWUgYXMgZG9uZSBmb3IKKyAgICAgICAgYXV0b3Rvb2xzLgorCisgICAgICAgICogU291cmNlL2Nt YWtlL1dlYktpdEhlbHBlcnMuY21ha2U6IGRpdHRvLgorCiAyMDExLTA1LTAyICBBZGFtIEtsZWlu ICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9j bWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4IDViZjY1YTM3NDYxYjBjNmMxNmJjNjc5Nzhj ZDM4MDE5MTRlZGYwMWYuLmVhNDc4MjgxMzUzZjAyNzg5ZWIzOTcxODAxN2FkNWQxMTkxOTQyZGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBAIC0yMyw2ICsyMywxMiBAQCBNQUNSTyhXRUJL SVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90YXJnZXQpCiAgICAgIyBFbmFibGUgd2Fybmlu Z3MgYnkgZGVmYXVsdAogICAgIFNFVChPTERfQ09NUElMRV9GTEFHUyAiLVcgLURBTk9USEVSX0JS SUNLX0lOX1RIRSAtV2FsbCAtV2V4dHJhIC1XY2FzdC1hbGlnbiAtV2NoYXItc3Vic2NyaXB0cyAt V2Zvcm1hdCAtV2Zvcm1hdC1zZWN1cml0eSAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV25v LWZvcm1hdC15MmsgLVduby1wYXJlbnRoZXNlcyAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVdwb2lu dGVyLWFyaXRoICAtV3JldHVybi10eXBlIC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdzICR7T0xEX0NP TVBJTEVfRkxBR1N9IikKIAorICAgICMgRGlzYWJsZSBDKysweCBjb21wYXQgd2FybmluZ3MgZm9y IEdDQyA+PSA0LjYuMCB1bnRpbCB3ZSBidWlsZAorICAgICMgY2xlYW5seSB3aXRoIHRoYXQuCisg ICAgSUYgKE5PVCAke0NPTVBJTEVSX1ZFUlNJT059IFZFUlNJT05fTEVTUyAiNC42LjAiKQorICAg ICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1Xbm8tYysr MHgtY29tcGF0IikKKyAgICBFTkRJRiAoKQorCiAgICAgU0VUX1RBUkdFVF9QUk9QRVJUSUVTICgk e190YXJnZXR9IFBST1BFUlRJRVMKIAlDT01QSUxFX0ZMQUdTICIke09MRF9DT01QSUxFX0ZMQUdT fSIpCiAK