60040 2011-05-03 10:53:39 -0700 Links broken at iplanwebsites.com 2011-05-03 11:18:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hyatt hyatt webkit.review.bot oldest_to_newest 397186 0 hyatt 2011-05-03 10:53:39 -0700 The links don't work because line box culling gives the wrong answer for a bounding client rect for empty links that get skipped as part of leading whitespace. 397188 1 hyatt 2011-05-03 10:55:17 -0700 <rdar://problem/9261591> 397189 2 92090 hyatt 2011-05-03 10:55:35 -0700 Created attachment 92090 Patch 397190 3 92090 mitz 2011-05-03 10:57:21 -0700 Comment on attachment 92090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92090&action=review > Source/WebCore/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + > + Need a short description and bug URL (OOPS!) > + > + No new tests. (OOPS!) Please fill out the info here > LayoutTests/ChangeLog:5 > + https://bugs.webkit.org/show_bug.cgi?id=60040 Would be nice to also have the Radar link here. 397192 4 hyatt 2011-05-03 11:00:35 -0700 Fixed in r85623. 397207 5 webkit.review.bot 2011-05-03 11:18:33 -0700 Attachment 92090 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'Source/WebCore/C..." exit_code: 1 Source/WebCore/ChangeLog:5: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 92090 2011-05-03 10:55:35 -0700 2011-05-03 10:57:21 -0700 Patch patch.txt text/plain 3277 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NjIyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMDMgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09Q UyEpCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVySW5saW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcklubGluZTo6Y3Vs bGVkSW5saW5lQWJzb2x1dGVRdWFkcyk6CisKIDIwMTEtMDUtMDMgIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggY2hyb21pdW0gYnVpbGQuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAkocmV2aXNpb24gODU2MTIpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTY3LDYgKzU2NywxMSBAQCB2b2lkIFJlbmRlcklubGluZTo6YWJzb2x1dGVRdWFkcyhWZWN0 b3I8CiAKIHZvaWQgUmVuZGVySW5saW5lOjpjdWxsZWRJbmxpbmVBYnNvbHV0ZVF1YWRzKGNvbnN0 IFJlbmRlcklubGluZSogY29udGFpbmVyLCBWZWN0b3I8RmxvYXRRdWFkPiYgcXVhZHMpCiB7Cisg ICAgaWYgKCFjdWxsZWRJbmxpbmVGaXJzdExpbmVCb3goKSkgeworICAgICAgICBxdWFkcy5hcHBl bmQobG9jYWxUb0Fic29sdXRlUXVhZChGbG9hdFJlY3QoKSkpOworICAgICAgICByZXR1cm47Cisg ICAgfQorCiAgICAgYm9vbCBpc0hvcml6b250YWwgPSBzdHlsZSgpLT5pc0hvcml6b250YWxXcml0 aW5nTW9kZSgpOwogICAgIGZvciAoUmVuZGVyT2JqZWN0KiBjdXJyID0gZmlyc3RDaGlsZCgpOyBj dXJyOyBjdXJyID0gY3Vyci0+bmV4dFNpYmxpbmcoKSkgewogICAgICAgICBpZiAoY3Vyci0+aXNG bG9hdGluZ09yUG9zaXRpb25lZCgpKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODU2MjIpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0w NS0wMyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYwMDQwCisgICAgICAgIAorICAgICAgICBMaW5rcyBicm9rZW4gYXQgaXBs YW53ZWJzaXRlcy5jb20uIE1ha2Ugc3VyZSB0aGF0IGN1bGxlZElubGluZUFic29sdXRlUXVhZHMg c3RpbGwgZG9lcworICAgICAgICBhIHRyYW5zbGF0aW9uIG9mIGEgMCwwIHBvaW50IHRvIGFic29s dXRlIGNvb3JkaW5hdGVzIHNvIHRoYXQgdGhlIHRvcCBsZWZ0IHBvc2l0aW9uIGlzCisgICAgICAg IGFjY3VyYXRlLgorCisgICAgICAgIEFkZGVkIGZhc3QvaW5saW5lL3NraXBwZWQtd2hpdGVzcGFj ZS1jbGllbnQtcmVjdC5odG1sCisKKyAgICAgICAgKiBmYXN0L2lubGluZS9za2lwcGVkLXdoaXRl c3BhY2UtY2xpZW50LXJlY3QtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2lu bGluZS9za2lwcGVkLXdoaXRlc3BhY2UtY2xpZW50LXJlY3QuaHRtbDogQWRkZWQuCisKIDIwMTEt MDUtMDMgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggdGVz dCBhY2NpZGVudGFsbHkgbW9kaWZpZWQgaW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2Vz ZXQvODU2MTAuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2lubGluZS9za2lwcGVkLXdoaXRlc3Bh Y2UtY2xpZW50LXJlY3QtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvaW5saW5lL3NraXBwZWQtd2hpdGVzcGFjZS1jbGllbnQtcmVjdC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2lubGluZS9za2lwcGVkLXdoaXRlc3BhY2Ut Y2xpZW50LXJlY3QtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitQQVNT CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2lubGluZS9za2lwcGVkLXdoaXRlc3BhY2UtY2xpZW50 LXJlY3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2lubGluZS9za2lwcGVk LXdoaXRlc3BhY2UtY2xpZW50LXJlY3QuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvaW5saW5lL3NraXBwZWQtd2hpdGVzcGFjZS1jbGllbnQtcmVjdC5odG1sCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDIxIEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICB3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpCisKK2Z1bmN0aW9uIHJ1blRlc3QoKQorewor ICAgIHZhciByZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKS5nZXRCb3VuZGlu Z0NsaWVudFJlY3QoKTsKKyAgICBpZiAocmVjdC50b3AgPiAwIHx8IHJlY3QubGVmdCA+IDApCisg ICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJykuaW5uZXJIVE1MID0gJ1BB U1MnOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8 ZGl2PiAgIDxhIGlkPSJ0ZXN0Ij48L2E+ICAgIDwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+RkFJ TDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgorCg==