60029 2011-05-03 08:33:42 -0700 Web Inspector: [Chromium] Clicking on non-object entry in detailed heap snapshots should clear retaining paths shown 2011-05-03 12:55:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 397099 0 mnaganov 2011-05-03 08:33:42 -0700 It's confusing when clicking on a constructor entry doesn't change anything in retaining paths list. The retaining paths list should hint user that it needs to click on object entries to see paths. 397100 1 92081 mnaganov 2011-05-03 08:36:28 -0700 Created attachment 92081 patch 397280 2 mnaganov 2011-05-03 12:55:21 -0700 Manually committed http://trac.webkit.org/changeset/85641 2011-05-03 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked. https://bugs.webkit.org/show_bug.cgi?id=60029 * English.lproj/localizedStrings.js: * inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset): (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid): 92081 2011-05-03 08:36:28 -0700 2011-05-03 12:18:04 -0700 patch patch-60029 text/plain 3536 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOWUxYjBiLi4wZmQ2MWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDUtMDMgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJJbnNw ZWN0b3I6IFtDaHJvbWl1bV0gSGludCB1c2VyIHRoYXQgdG8gZGlzcGxheSByZXRhaW5pbmcgcGF0 aHMsIGFuIG9iamVjdCBlbnRyeSBtdXN0IGJlIGNsaWNrZWQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDAyOQorCisgICAgICAgICogRW5nbGlzaC5s cHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv RGV0YWlsZWRIZWFwc2hvdFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90UmV0YWluaW5nUGF0aHNMaXN0LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRGV0YWlsZWRIZWFwc2hvdFZpZXcucHJvdG90eXBlLl9tb3VzZUNsaWNrSW5Db250YWlu bWVudEdyaWQpOgorCiAyMDExLTA1LTAzICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggMzE0YmVj ODNkMWViYjg3ZDU3NzRiZmUwOWZiNzEyY2UzYTNhMzgyMS4uNGYyNTdiZGI4ZGQxM2M4YmM3OTk4 M2ZkNjIxZjdjYTA3M2M0MzY2YiAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSAxMzUKemNt Y2F+bjBkb2Q8Xyh0flBYNT1YWVZPUkMhO3MwNCUjaDhYej52PzcyUDZ+MFdJalVATGwjM1NQXkpW WlJzeGgkCmtVP150RDBNZ3xeUj8lZGl0SX58Y2xrK3Fzd01vPilVZCo3eFY5bWU8MEc+Sl4wMDAw MAoKZGVsdGEgOQpSY21kbVJsPTskTzxfKHR+MHN0QSgxI3whYQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RWaWV3Lmpz CmluZGV4IGI4ZWVkMTQuLmY3ZjFiY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcwpAQCAtNDAwLDYg KzQwMCwxNSBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90UmV0YWluaW5nUGF0aHNMaXN0LnBy b3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fcmVzZXRQYXRocygpOwogICAgIH0sCiAKKyAgICBy ZXNldDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgZGVsZXRlIHRoaXMuX2NhbmNlbDsKKyAg ICAgICAgdGhpcy5yZW1vdmVDaGlsZHJlbigpOworICAgICAgICB0aGlzLnJlc2V0U29ydGluZ0Nh Y2hlKCk7CisgICAgICAgIHRoaXMuX2NvdW50ZXIgPSAwOworICAgICAgICB0aGlzLmFwcGVuZENo aWxkKG5ldyBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlKHtwYXRoOldlYkluc3BlY3Rvci5VSVN0 cmluZygiQ2xpY2sgb24gYW4gb2JqZWN0IHRvIHNob3cgcmV0YWluaW5nIHBhdGhzIiksIGxlbjoi In0sIGZhbHNlKSk7CisgICAgfSwKKwogICAgIHNob3dOZXh0OiBmdW5jdGlvbihwYXRoc0NvdW50 KQogICAgIHsKICAgICAgICAgV2ViSW5zcGVjdG9yLlBsZWFzZVdhaXRNZXNzYWdlLnByb3RvdHlw ZS5zaG93KHRoaXMuZWxlbWVudCwgdGhpcy5zZWFyY2hDYW5jZWxsZWQuYmluZCh0aGlzLCBwYXRo c0NvdW50KSk7CkBAIC01MzcsNiArNTQ2LDcgQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNo b3RWaWV3ID0gZnVuY3Rpb24ocGFyZW50LCBwcm9maWxlKQogICAgIHJldGFpbm1lbnRWaWV3LmVs ZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5yZXRhaW5tZW50RGF0YUdyaWQuZWxlbWVudCk7CiAgICAg cmV0YWlubWVudFZpZXcudmlzaWJsZSA9IHRydWU7CiAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENo aWxkKHJldGFpbm1lbnRWaWV3LmVsZW1lbnQpOworICAgIHRoaXMucmV0YWlubWVudERhdGFHcmlk LnJlc2V0KCk7CiAKICAgICB0aGlzLmRhdGFHcmlkID0gdGhpcy5jb25zdHJ1Y3RvcnNEYXRhR3Jp ZDsKICAgICB0aGlzLmN1cnJlbnRWaWV3ID0gdGhpcy5jb25zdHJ1Y3RvcnNWaWV3OwpAQCAtODY3 LDEwICs4NzcsMTIgQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3LnByb3RvdHlw ZSA9IHsKICAgICAgICAgaWYgKCFyb3cpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIHZh ciBub2RlSXRlbSA9IHJvdy5fZGF0YUdyaWROb2RlOwotICAgICAgICBpZiAoIW5vZGVJdGVtIHx8 IG5vZGVJdGVtLmlzRXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUoZXZlbnQpIHx8ICFub2Rl SXRlbS5zbmFwc2hvdE5vZGVJbmRleCkKKyAgICAgICAgaWYgKCFub2RlSXRlbSB8fCBub2RlSXRl bS5pc0V2ZW50V2l0aGluRGlzY2xvc3VyZVRyaWFuZ2xlKGV2ZW50KSkKICAgICAgICAgICAgIHJl dHVybjsKLQotICAgICAgICB0aGlzLnJldGFpbm1lbnREYXRhR3JpZC5zZXREYXRhU291cmNlKHRo aXMsIG5vZGVJdGVtLmlzRGVsZXRlZE5vZGUgPyBub2RlSXRlbS5kYXRhR3JpZC5iYXNlU25hcHNo b3QgOiBub2RlSXRlbS5kYXRhR3JpZC5zbmFwc2hvdCwgbm9kZUl0ZW0uc25hcHNob3ROb2RlSW5k ZXgsIG5vZGVJdGVtLmlzRGVsZXRlZE5vZGUgPyB0aGlzLmJhc2VTZWxlY3RFbGVtZW50LmNoaWxk Tm9kZXNbdGhpcy5iYXNlU2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4XS5sYWJlbCArICIgfCAi IDogIiIpOworICAgICAgICBpZiAobm9kZUl0ZW0uc25hcHNob3ROb2RlSW5kZXgpCisgICAgICAg ICAgICB0aGlzLnJldGFpbm1lbnREYXRhR3JpZC5zZXREYXRhU291cmNlKHRoaXMsIG5vZGVJdGVt LmlzRGVsZXRlZE5vZGUgPyBub2RlSXRlbS5kYXRhR3JpZC5iYXNlU25hcHNob3QgOiBub2RlSXRl bS5kYXRhR3JpZC5zbmFwc2hvdCwgbm9kZUl0ZW0uc25hcHNob3ROb2RlSW5kZXgsIG5vZGVJdGVt LmlzRGVsZXRlZE5vZGUgPyB0aGlzLmJhc2VTZWxlY3RFbGVtZW50LmNoaWxkTm9kZXNbdGhpcy5i YXNlU2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4XS5sYWJlbCArICIgfCAiIDogIiIpOworICAg ICAgICBlbHNlCisgICAgICAgICAgICB0aGlzLnJldGFpbm1lbnREYXRhR3JpZC5yZXNldCgpOwog ICAgIH0sCiAKICAgICBfbW91c2VDbGlja0luUmV0YWlubWVudEdyaWQ6IGZ1bmN0aW9uKGV2ZW50 KQo=