60026 2011-05-03 08:09:15 -0700 [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE 2011-05-03 09:20:19 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 caseq caseq antonm dglazkov rolandsteiner oldest_to_newest 397085 0 caseq 2011-05-03 08:09:15 -0700 There's no IDL class for ShadowRoot, hence there's no toV8(ShadowRoot*) overload, and the following lines in toV8Slow(Node*): http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp?rev=84520#L168 case Node::SHADOW_ROOT_NODE: return toV8(static_cast<ShadowRoot*>(impl), forceNewObject); will resolve toV8() to toV8(Node*), which will invoke toV8Slow(Node*) etc. This isn't normally exposed, as we do not expose ShadowRoot nodes in bindings -- yet this popped up when I started adding shadow DOM support to inspector, as one can access last inspected node in console via $0. 397095 1 92079 caseq 2011-05-03 08:19:35 -0700 Created attachment 92079 patch 397098 2 antonm 2011-05-03 08:23:42 -0700 LGTM, maybe rearrange cases to have a fall-through to default case. 397101 3 92079 dglazkov 2011-05-03 08:39:44 -0700 Comment on attachment 92079 patch with antonm's suggestion. 397117 4 caseq 2011-05-03 09:20:19 -0700 (In reply to comment #3) > (From update of attachment 92079 [details]) > with antonm's suggestion. Manually committed r85606 (changed as per Anton's comment): http://trac.webkit.org/changeset/85606 92079 2011-05-03 08:19:35 -0700 2011-05-03 08:39:44 -0700 patch shadow-root-wrapper.diff text/plain 1573 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNGI1MjIxLi5lMWMyZGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDQgKzEsMTUg QEAKLTIwMTEtMDUtMDMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgorMjAx MS0wNS0wMyAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gdG9WOChO b2RlKikgd2lsbCBlbnRlciBpbmZpbml0ZSByZWN1cnNpb24gd2hlbiBjYWxsZWQgd2l0aCBhIG5v ZGUgb2YgdHlwZSBTSEFET1dfUk9PVF9OT0RFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MDAyNgorCisgICAgICAgIFJldHVybiBhIHdyYXBwZXIgZm9y IE5vZGUgaW4gdG9WOChOb2RlKikgd2hlbiBjYWxsZWQgd2l0aCBhIG5vZGUgb2YgdHlwZQorICAg ICAgICBTSEFET1dfUk9PVF9OT0RFIGluc3RlYWQgb2YgZW50ZXJpbmcgaW5maW5pdGUgcmVjdXJz aW9uLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm9kZUN1c3RvbS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjp0b1Y4U2xvdyk6CiAKICAgICAgICAgTm90IHJldmlld2VkOiBmaXhl ZCB0eXBvIGluIGluc3BlY3RvciBzdHlsZS4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm9kZUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhOb2RlQ3VzdG9tLmNwcAppbmRleCA3NTA3MjcyLi5jZGY2NGI1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhOb2RlQ3VzdG9t LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhOb2RlQ3VzdG9t LmNwcApAQCAtMTY1LDcgKzE2NSw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0b1Y4U2xvdyhO b2RlKiBpbXBsLCBib29sIGZvcmNlTmV3T2JqZWN0KQogICAgIGNhc2UgTm9kZTo6RE9DVU1FTlRf RlJBR01FTlRfTk9ERToKICAgICAgICAgcmV0dXJuIHRvVjgoc3RhdGljX2Nhc3Q8RG9jdW1lbnRG cmFnbWVudCo+KGltcGwpLCBmb3JjZU5ld09iamVjdCk7CiAgICAgY2FzZSBOb2RlOjpTSEFET1df Uk9PVF9OT0RFOgotICAgICAgICByZXR1cm4gdG9WOChzdGF0aWNfY2FzdDxTaGFkb3dSb290Kj4o aW1wbCksIGZvcmNlTmV3T2JqZWN0KTsKKyAgICAgICAgYnJlYWs7IC8vIFRoZXJlJ3Mgbm8gSURM IGNsYXNzIGZvciBTaGFkb3dSb290LCB1c2UgTm9kZSBpbiB0aGUgZGVmYXVsdCBwYXRoIGluc3Rl YWQuCiAgICAgY2FzZSBOb2RlOjpOT1RBVElPTl9OT0RFOgogICAgICAgICByZXR1cm4gdG9WOChz dGF0aWNfY2FzdDxOb3RhdGlvbio+KGltcGwpLCBmb3JjZU5ld09iamVjdCk7CiAgICAgZGVmYXVs dDogYnJlYWs7IC8vIFhQQVRIX05BTUVTUEFDRV9OT0RFCg==