60024 2011-05-03 07:31:23 -0700 [v8] remove an ASSERT from grouping logic 2011-05-03 15:23:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 antonm antonm commit-queue pfeldman yurys oldest_to_newest 397071 0 antonm 2011-05-03 07:31:23 -0700 [v8] remove an ASSERT from grouping logic 397072 1 antonm 2011-05-03 07:32:36 -0700 Unfortunately there is no easy way to repro it. Good news it's not mandatory and there are no release mode crashes to be best of my knowledge. 397075 2 92074 antonm 2011-05-03 07:40:03 -0700 Created attachment 92074 Patch 397076 3 antonm 2011-05-03 07:40:28 -0700 crbug.com/80745 397451 4 commit-queue 2011-05-03 15:21:02 -0700 The commit-queue encountered the following flaky tests while processing attachment 92074: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 397452 5 92074 commit-queue 2011-05-03 15:23:00 -0700 Comment on attachment 92074 Patch Clearing flags on attachment: 92074 Committed r85673: <http://trac.webkit.org/changeset/85673> 397453 6 commit-queue 2011-05-03 15:23:05 -0700 All reviewed patches have been landed. Closing bug. 92074 2011-05-03 07:40:03 -0700 2011-05-03 15:23:00 -0700 Patch bug-60024-20110503184001.patch text/plain 1860 antonm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NjAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDMgIEFudG9uIE11 aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbdjhdIHJlbW92ZSBhbiBBU1NFUlQgZnJvbSBncm91cGluZyBs b2dpYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjAw MjQKKworICAgICAgICBUaGlzIEFTU0VSVCB3YXMgZXhwbG9yYXRvcnkuICBBbGFzLCByaWdodCBu b3cgSSBhbSBhd2FyZSBvZiBubyBlYXN5IHdheSB0bworICAgICAgICByZXBybyBpdC4gIFJlbW92 aW5nIGZvciBub3cgZm9yIGdyZWVuZXIgYm90cy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG9u bHkgYW4gQVNTRVJUIHJlbW92YWwuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJv bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYWxjdWxhdGVHcm91cElkKToKKwogMjAxMS0w NS0wMiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGFrZSBhZHZh bnRhZ2Ugb2YgaW1wbGljaXQgY29udmVyc2lvbiBmcm9tIG51bGxwdHJfdCB0byBQYXNzT3duUHRy CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3Bw CShyZXZpc2lvbiA4NTYwMykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250 cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk2LDEwICsyOTYsOCBAQCBzdGF0aWMgR3Jv dXBJZCBjYWxjdWxhdGVHcm91cElkKFN0eWxlQmFzCiAgICAgICAgIC8vIHdlIG5lZWQgdG8gZ3Jv dXAgdGhlbSB3aXRoIHRoZWlyIG5vZGUgb3IgcmVndWxhciBvbmVzLgogICAgICAgICBpZiAoY3Vy cmVudC0+aXNNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbigpKSB7CiAgICAgICAgICAgICBDU1NNdXRh YmxlU3R5bGVEZWNsYXJhdGlvbiogY3NzTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24gPSBzdGF0aWNf Y2FzdDxDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbio+KGN1cnJlbnQpOwotICAgICAgICAgICAg aWYgKGNzc011dGFibGVTdHlsZURlY2xhcmF0aW9uLT5pc0lubGluZVN0eWxlRGVjbGFyYXRpb24o KSkgewotICAgICAgICAgICAgICAgIEFTU0VSVChjc3NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi0+ cGFyZW50KCktPmlzU3R5bGVTaGVldCgpKTsKKyAgICAgICAgICAgIGlmIChjc3NNdXRhYmxlU3R5 bGVEZWNsYXJhdGlvbi0+aXNJbmxpbmVTdHlsZURlY2xhcmF0aW9uKCkpCiAgICAgICAgICAgICAg ICAgcmV0dXJuIGNhbGN1bGF0ZUdyb3VwSWQoY3NzTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24tPm5v ZGUoKSk7Ci0gICAgICAgICAgICB9CiAgICAgICAgICAgICAvLyBFaXRoZXIgd2UgaGF2ZSBubyBw YXJlbnQsIG9yIHRoaXMgcGFyZW50IGlzIGEgQ1NTUnVsZS4KICAgICAgICAgICAgIEFTU0VSVChj c3NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi0+cGFyZW50KCkgPT0gY3NzTXV0YWJsZVN0eWxlRGVj bGFyYXRpb24tPnBhcmVudFJ1bGUoKSk7CiAgICAgICAgIH0K