60016 2011-05-03 02:34:35 -0700 [GTK] WidgetGtk setFocus can not access directly the widget in WK2 2011-05-09 08:39:38 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned oldest_to_newest 397018 0 alex 2011-05-03 02:34:35 -0700 We are grabbing directly the focus using the widget and this only works for Webkit1. 397019 1 92056 alex 2011-05-03 02:42:26 -0700 Created attachment 92056 Proposed patch 397170 2 92056 mrobinson 2011-05-03 10:29:09 -0700 Comment on attachment 92056 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=92056&action=review Great stuff. > Source/WebCore/platform/gtk/WidgetGtk.cpp:69 > + Frame* frame = Frame::frameForWidget(this); > + if (frame) { This can just be: if (Frame* frame = Frame::frameForWidget(this)) { or an early return. > Source/WebCore/platform/gtk/WidgetGtk.cpp:71 > + Page* page = frame->page(); > + page->chrome()->focus(); Also should just be frame->page()->chrome()->focus(); 400519 3 alex 2011-05-09 08:39:38 -0700 Thanks for the comments, landed: http://trac.webkit.org/changeset/86058 92056 2011-05-03 02:42:26 -0700 2011-05-03 10:29:08 -0700 Proposed patch widgetgtk.patch text/plain 1828 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5Yzk1ZDk1Li4wN2IwNjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDUtMDMgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gV2lk Z2V0R3RrIHNldEZvY3VzIGNhbiBub3QgYWNjZXNzIGRpcmVjdGx5IHRoZSB3aWRnZXQgaW4gV0sy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDAxNgor CisgICAgICAgIEFkZGVkIGNvZGUgdG8gY2hlY2sgdGhlIHNpdHVhdGlvbiB3aGVyZSB3ZSBkbyBu b3QgaGF2ZSBkaXJlY3QKKyAgICAgICAgYWNjZXNzIHRvIHRoZSB3aWRnZXQuIFdlIHVzZSB0aGUg cGFnZSB0byBncmFiIHRoZSBmb2N1cyB3aGljaAorICAgICAgICB3b3VsZCBzZW5kIGEgcmVxdWVz dCB0byB0aGUgVUlQcm9jZXNzIGluIFdLMi4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9XaWRn ZXRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpzZXRGb2N1cyk6CisKIDIwMTEt MDUtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9XaWRnZXRHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dp ZGdldEd0ay5jcHAKaW5kZXggOWJjYTUwNi4uZDFiNDkyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1dpZGdldEd0ay5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJjb25m aWcuaCIKICNpbmNsdWRlICJXaWRnZXQuaCIKIAorI2luY2x1ZGUgIkNocm9tZS5oIgogI2luY2x1 ZGUgIkN1cnNvci5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUgIkdyYXBoaWNz Q29udGV4dC5oIgpAQCAtNTQsOCArNTUsMjEgQEAgV2lkZ2V0Ojp+V2lkZ2V0KCkKIAogdm9pZCBX aWRnZXQ6OnNldEZvY3VzKGJvb2wgZm9jdXNlZCkKIHsKLSAgICBpZiAoZm9jdXNlZCkKLSAgICAg ICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzKHBsYXRmb3JtV2lkZ2V0KCkgPyBwbGF0Zm9ybVdpZGdl dCgpIDogR1RLX1dJREdFVChyb290KCktPmhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50 KCkpKTsKKyAgICBpZiAoIWZvY3VzZWQpCisgICAgICAgIHJldHVybjsKKworICAgIEd0a1dpZGdl dCogd2lkZ2V0ID0gcGxhdGZvcm1XaWRnZXQoKSA/IHBsYXRmb3JtV2lkZ2V0KCkgOiByb290KCkt Pmhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7CisgICAgaWYgKHdpZGdldCkgewor ICAgICAgICBndGtfd2lkZ2V0X2dyYWJfZm9jdXMod2lkZ2V0KTsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KKworICAgIC8vIFdlIGFyZSBydW5uaW5nIFdLMi4KKyAgICBGcmFtZSogZnJhbWUgPSBG cmFtZTo6ZnJhbWVGb3JXaWRnZXQodGhpcyk7CisgICAgaWYgKGZyYW1lKSB7CisgICAgICAgIFBh Z2UqIHBhZ2UgPSBmcmFtZS0+cGFnZSgpOworICAgICAgICBwYWdlLT5jaHJvbWUoKS0+Zm9jdXMo KTsKKyAgICB9CiB9CiAKIHZvaWQgV2lkZ2V0OjpzZXRDdXJzb3IoY29uc3QgQ3Vyc29yJiBjdXJz b3IpCg==