60011 2011-05-03 00:00:34 -0700 Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty() 2011-05-04 04:36:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 macpherson webkit-unassigned commit-queue darin eric macpherson oldest_to_newest 396987 0 macpherson 2011-05-03 00:00:34 -0700 Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty() 396988 1 92051 macpherson 2011-05-03 00:01:59 -0700 Created attachment 92051 Patch 396989 2 macpherson 2011-05-03 00:03:18 -0700 Removed code is analogous to if (x==y) x = y; 397196 3 92051 darin 2011-05-03 11:02:05 -0700 Comment on attachment 92051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92051&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Can’t land this as is. You need to replace this line with an explanation of why this change doesn’t require new tests. 397539 4 92169 macpherson 2011-05-03 16:55:02 -0700 Created attachment 92169 Patch 397540 5 macpherson 2011-05-03 16:56:39 -0700 Fixed ChangeLog entry. 397732 6 92169 eric 2011-05-04 01:11:39 -0700 Comment on attachment 92169 Patch This code is obviously very old. :) 397805 7 92169 commit-queue 2011-05-04 04:35:55 -0700 Comment on attachment 92169 Patch Clearing flags on attachment: 92169 Committed r85730: <http://trac.webkit.org/changeset/85730> 397806 8 commit-queue 2011-05-04 04:36:00 -0700 All reviewed patches have been landed. Closing bug. 92051 2011-05-03 00:01:59 -0700 2011-05-03 16:54:52 -0700 Patch bug-60011-20110503170157.patch text/plain 1697 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NTg2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDMgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcmVkdW5kYW50IGNvbnZlcnNpb24g ZnJvbSBhdXRvIHRhYmxlIGxheW91dCB0byBhdXRvIHRhYmxlIGxheW91dCBpbiBDU1NTdHlsZVNl bGVjdG9yOjphcHBseVByb3BlcnR5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYwMDExCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisK KyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD U1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KToKKyAgICAgICAgUmVtb3ZlIHJldW5kYW50 IGNoZWNrIGZvciBhdXRvIHRhYmxlIGxheW91dC4KKwogMjAxMS0wNS0wMiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVy bnN0ZWluLgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkocmV2 aXNpb24gODU1ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM3NDMsMTcgKzM3NDMsOSBAQCB2b2lkIENTU1N0eWxlU2VsZWN0 b3I6OmFwcGx5UHJvcGVydHkoaW50CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVBvc2l0aW9uOgogICAg ICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFKHBvc2l0aW9uLCBQ b3NpdGlvbikKICAgICAgICAgcmV0dXJuOwotICAgIGNhc2UgQ1NTUHJvcGVydHlUYWJsZUxheW91 dDogewotICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTCh0YWJsZUxheW91dCwgVGFi bGVMYXlvdXQpCi0KLSAgICAgICAgRVRhYmxlTGF5b3V0IGwgPSAqcHJpbWl0aXZlVmFsdWU7Ci0g ICAgICAgIGlmIChsID09IFRBVVRPKQotICAgICAgICAgICAgbCA9IFJlbmRlclN0eWxlOjppbml0 aWFsVGFibGVMYXlvdXQoKTsKLQotICAgICAgICBtX3N0eWxlLT5zZXRUYWJsZUxheW91dChsKTsK KyAgICBjYXNlIENTU1Byb3BlcnR5VGFibGVMYXlvdXQ6CisgICAgICAgIEhBTkRMRV9JTkhFUklU X0FORF9JTklUSUFMX0FORF9QUklNSVRJVkUodGFibGVMYXlvdXQsIFRhYmxlTGF5b3V0KQogICAg ICAgICByZXR1cm47Ci0gICAgfQotICAgICAgICAKICAgICBjYXNlIENTU1Byb3BlcnR5VW5pY29k ZUJpZGk6IAogICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZF KHVuaWNvZGVCaWRpLCBVbmljb2RlQmlkaSkKICAgICAgICAgcmV0dXJuOwo= 92169 2011-05-03 16:55:02 -0700 2011-05-04 04:35:55 -0700 Patch bug-60011-20110504095459.patch text/plain 1715 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Njg5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMDMgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KKworICAgICAgICBSZW1vdmUgcmVkdW5kYW50IGNvbnZlcnNpb24gZnJv bSBhdXRvIHRhYmxlIGxheW91dCB0byBhdXRvIHRhYmxlIGxheW91dCBpbiBDU1NTdHlsZVNlbGVj dG9yOjphcHBseVByb3BlcnR5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYwMDExCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFkZGVkIGFzIG5vIGZ1 bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOgor ICAgICAgICBSZW1vdmUgcmV1bmRhbnQgY2hlY2sgZm9yIGF1dG8gdGFibGUgbGF5b3V0LgorCiAy MDExLTA1LTAzICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0 eWxlU2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHls ZVNlbGVjdG9yLmNwcAkocmV2aXNpb24gODU2ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NT U3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3NDMsMTcgKzM3NDMsOSBAQCB2 b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAgICAgY2FzZSBDU1NQcm9w ZXJ0eVBvc2l0aW9uOgogICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJ TUlUSVZFKHBvc2l0aW9uLCBQb3NpdGlvbikKICAgICAgICAgcmV0dXJuOwotICAgIGNhc2UgQ1NT UHJvcGVydHlUYWJsZUxheW91dDogewotICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElB TCh0YWJsZUxheW91dCwgVGFibGVMYXlvdXQpCi0KLSAgICAgICAgRVRhYmxlTGF5b3V0IGwgPSAq cHJpbWl0aXZlVmFsdWU7Ci0gICAgICAgIGlmIChsID09IFRBVVRPKQotICAgICAgICAgICAgbCA9 IFJlbmRlclN0eWxlOjppbml0aWFsVGFibGVMYXlvdXQoKTsKLQotICAgICAgICBtX3N0eWxlLT5z ZXRUYWJsZUxheW91dChsKTsKKyAgICBjYXNlIENTU1Byb3BlcnR5VGFibGVMYXlvdXQ6CisgICAg ICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMX0FORF9QUklNSVRJVkUodGFibGVMYXlvdXQs IFRhYmxlTGF5b3V0KQogICAgICAgICByZXR1cm47Ci0gICAgfQotICAgICAgICAKICAgICBjYXNl IENTU1Byb3BlcnR5VW5pY29kZUJpZGk6IAogICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5J VElBTF9BTkRfUFJJTUlUSVZFKHVuaWNvZGVCaWRpLCBVbmljb2RlQmlkaSkKICAgICAgICAgcmV0 dXJuOwo=