<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>6001</bug_id>
          
          <creation_ts>2005-12-08 01:48:13 -0800</creation_ts>
          <short_desc>CSS2: WebKit does not handle fallback custom cursors</short_desc>
          <delta_ts>2006-09-26 05:39:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.w3.org/TR/REC-CSS2/ui.html#cursor-props</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P4</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>9013</dependson>
          <blocked>6002</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>ian</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>25699</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-12-08 01:48:13 -0800</bug_when>
    <thetext>WebKit does not handle fallback custom cursors

I should have caught the fallback cursor issue when reviewing darin&apos;s orginal patch:
http://bugzilla.opendarwin.org/show_bug.cgi?id=5689</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>25700</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-12-08 01:50:19 -0800</bug_when>
    <thetext>From the spec:
http://www.w3.org/TR/REC-CSS2/ui.html#cursor-props
&quot;If the user agent cannot handle the first cursor of a list of cursors, it should attempt to handle the 
second, etc. If the user agent cannot handle any user-defined cursor, it must use the generic cursor at the 
end of the list.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>25703</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-12-08 01:58:37 -0800</bug_when>
    <thetext>http://www.w3.org/Graphics/SVG/Test/20030813/svggen/interact-cursor-01-f.svg
Demonstrates cursor fallback behavior.

http://www.w3.org/TR/css3-ui/
also has some example code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>25770</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-12-10 10:16:53 -0800</bug_when>
    <thetext>Even though I did the original custom cursor work, I suggest that someone else do the &quot;list of cursors&quot; and 
fallback machinery work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42952</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2006-05-19 14:36:04 -0700</bug_when>
    <thetext>Unless I&apos;m missing something, this means that WebKit cannot handle any custom cursor specified in accordance with the spec, and also any custom cursor that WebKit handles is specified incorrectly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54871</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-09-06 00:57:05 -0700</bug_when>
    <thetext>I spoke with hyatt and darin this evening.  We&apos;ve come up with a pretty simple fix for this.

1. We will need a new class, perhaps called CursorDescription. (like FontDescription).  This will contain CurorType enum (just like RenderStyle::cursor() does today), as well as a CachedImage* (just like cursorImage() does today), as well as a CursorDescription next pointer (CursorDescription* m_next; CursorDescription* next() const;)
2. RenderStyle::cursor() will stay (to optimize for the common single-specified cursor case).  RenderStyle::cursorImage() will change to CursorDescription* RenderStyle::cursorList().
3. Either cursor() will return a special CURSOR_LIST enum value, or simply cursorList() returning non-null will trigger the cursor list fallback behavior instead of the normal single-cursor case.

That&apos;s pretty much it.  This should be a pretty small patch and shouldn&apos;t take more than a couple hours to code up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54879</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2006-09-06 02:13:52 -0700</bug_when>
    <thetext>There&apos;s a lot work already done in an unfinished patch for bug 6002.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54889</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-09-06 03:27:03 -0700</bug_when>
    <thetext>One other thing I forgot.  The CursorDescription class can&apos;t just point to a CacheImage, as the cursor might not just be an image.  It will need to point to either an SVGCursorElement (bug 6002) or a CachedImage, FloatPoint (hotspot -- as part of CSS3) pair.  Perhaps we&apos;ll want an abstract class to codify this CursorProvider interface.  Not sure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>56525</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-09-26 05:39:51 -0700</bug_when>
    <thetext>Fixed as part of bug 6002</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>