59999 2011-05-02 18:26:45 -0700 The web process locks up when the plug-in process crashes 2011-05-02 18:48:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 396871 0 andersca 2011-05-02 18:26:45 -0700 The web process locks up when the plug-in process crashes 396880 1 92030 andersca 2011-05-02 18:41:44 -0700 Created attachment 92030 Patch 396882 2 webkit.review.bot 2011-05-02 18:45:16 -0700 Attachment 92030 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 396887 3 andersca 2011-05-02 18:48:36 -0700 Committed r85573: <http://trac.webkit.org/changeset/85573> 92030 2011-05-02 18:41:44 -0700 2011-05-02 18:43:39 -0700 Patch bug-59999-20110502184143.patch text/plain 6178 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NTcxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMDIgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgd2ViIHByb2Nlc3MgbG9ja3MgdXAgd2hlbiB0aGUg cGx1Zy1pbiBwcm9jZXNzIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU5OTk5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODg5MzAzPgor CisgICAgICAgIEFkZCBhIGhhc2ggbWFwIGZyb20gcGx1Zy1pbiBwYXRocyB0byBDb3JlSVBDIGNv bm5lY3Rpb25zIHRvIFBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci4KKyAgICAgICAgQWRk IFBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlcjo6cGx1Z2luUHJvY2Vzc0NyYXNoZWQgYW5k IG1ha2UgaXQgbG9vayB1cCB0aGUgY29ycmVzcG9uZGluZworICAgICAgICBDb3JlSVBDIGNvbm5l Y3Rpb24gYW5kIGNhbGwgcG9zdENvbm5lY3Rpb25EaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1 ZSBvbiBpdC4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHA6Cisg ICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpwb3N0Q29ubmVjdGlvbkRpZENsb3NlT25Db25u ZWN0aW9uV29ya1F1ZXVlKToKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24u aDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25N YW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5h Z2VyOjpnZXRQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbik6CisgICAgICAgIChXZWJLaXQ6OlBsdWdp blByb2Nlc3NDb25uZWN0aW9uTWFuYWdlcjo6cmVtb3ZlUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb24p OgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXI6OnBsdWdp blByb2Nlc3NDcmFzaGVkKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJv Y2Vzc0Nvbm5lY3Rpb25NYW5hZ2VyLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNz LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGx1Z2luUHJvY2Vzc0NyYXNoZWQp OgorCiAyMDExLTA1LTAyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgVHJ5IHRvIGZpeCBXaW5kb3dzIGJ1aWxkLgpJbmRleDogU291cmNlL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCShyZXZpc2lvbiA4NTUwOSkKKysr IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTU1MCw2ICs1NTAsMTEgQEAgdm9pZCBDb25uZWN0aW9uOjpwcm9jZXNzSW5jb21p bmdNZXNzYWdlKAogICAgIGVucXVldWVJbmNvbWluZ01lc3NhZ2UoaW5jb21pbmdNZXNzYWdlKTsK IH0KIAordm9pZCBDb25uZWN0aW9uOjpwb3N0Q29ubmVjdGlvbkRpZENsb3NlT25Db25uZWN0aW9u V29ya1F1ZXVlKCkKK3sKKyAgICBtX2Nvbm5lY3Rpb25RdWV1ZS5zY2hlZHVsZVdvcmsoV29ya0l0 ZW06OmNyZWF0ZSh0aGlzLCAmQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKSk7Cit9CisK IHZvaWQgQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKCkKIHsKICAgICAvLyBUaGUgY29u bmVjdGlvbiBpcyBub3cgaW52YWxpZC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0Nv cmVJUEMvQ29ubmVjdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L0NvcmVJUEMvQ29ubmVjdGlvbi5oCShyZXZpc2lvbiA4NTUwOSkKKysrIFNvdXJjZS9XZWJLaXQy L1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcsNiAr MTQ3LDggQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXREZWZhdWx0U3luY01lc3NhZ2VUaW1lb3V0 KGRvdWJsZSk7CiAKKyAgICB2b2lkIHBvc3RDb25uZWN0aW9uRGlkQ2xvc2VPbkNvbm5lY3Rpb25X b3JrUXVldWUoKTsKKwogICAgIHN0YXRpYyBjb25zdCBpbnQgRGVmYXVsdFRpbWVvdXQgPSAwOwog ICAgIHN0YXRpYyBjb25zdCBpbnQgTm9UaW1lb3V0ID0gLTE7CiAKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAkocmV2aXNpb24gODU1NzApCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OTYs NyArNzk2LDcgQEAgdm9pZCBXZWJQcm9jZXNzOjpjbGVhclBsdWdpblNpdGVEYXRhKGNvbgogI2lm IEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKIHZvaWQgV2ViUHJvY2Vzczo6cGx1Z2luUHJvY2Vzc0Ny YXNoZWQoY29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1l bnQuCisgICAgbV9wbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIucGx1Z2luUHJvY2Vzc0Ny YXNoZWQocGx1Z2luUGF0aCk7CiB9CiAjZW5kaWYKIApJbmRleDogU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3ND b25uZWN0aW9uTWFuYWdlci5jcHAJKHJldmlzaW9uIDg1NTY2KQorKysgU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTc1LDYgKzc1LDEzIEBAIFBsdWdpblByb2Nlc3NDb25uZWN0aW9uKiBQ bHVnaW5Qcm9jZXNzQ28KICAgICBSZWZQdHI8UGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb24+IHBsdWdp blByb2Nlc3NDb25uZWN0aW9uID0gUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb246OmNyZWF0ZSh0aGlz LCBwbHVnaW5QYXRoLCBjb25uZWN0aW9uSWRlbnRpZmllcik7CiAgICAgbV9wbHVnaW5Qcm9jZXNz Q29ubmVjdGlvbnMuYXBwZW5kKHBsdWdpblByb2Nlc3NDb25uZWN0aW9uKTsKIAorICAgIHsKKyAg ICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fcGF0aHNBbmRDb25uZWN0aW9uc011dGV4KTsKKyAg ICAgICAgQVNTRVJUKCFtX3BhdGhzQW5kQ29ubmVjdGlvbnMuY29udGFpbnMocGx1Z2luUHJvY2Vz c0Nvbm5lY3Rpb24tPnBsdWdpblBhdGgoKSkpOworCisgICAgICAgIG1fcGF0aHNBbmRDb25uZWN0 aW9ucy5zZXQocGx1Z2luUGF0aCwgcGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb24tPmNvbm5lY3Rpb24o KSk7CisgICAgfQorCiAgICAgcmV0dXJuIHBsdWdpblByb2Nlc3NDb25uZWN0aW9uLmdldCgpOwog fQogCkBAIC04Myw5ICs5MCwyOSBAQCB2b2lkIFBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdl cjo6cmVtCiAgICAgc2l6ZV90IHZlY3RvckluZGV4ID0gbV9wbHVnaW5Qcm9jZXNzQ29ubmVjdGlv bnMuZmluZChwbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbik7CiAgICAgQVNTRVJUKHZlY3RvckluZGV4 ICE9IG5vdEZvdW5kKTsKIAorICAgIHsKKyAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fcGF0 aHNBbmRDb25uZWN0aW9uc011dGV4KTsKKyAgICAgICAgQVNTRVJUKG1fcGF0aHNBbmRDb25uZWN0 aW9ucy5jb250YWlucyhwbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbi0+cGx1Z2luUGF0aCgpKSk7Cisg ICAgICAgIAorICAgICAgICBtX3BhdGhzQW5kQ29ubmVjdGlvbnMucmVtb3ZlKHBsdWdpblByb2Nl c3NDb25uZWN0aW9uLT5wbHVnaW5QYXRoKCkpOworICAgIH0KKwogICAgIG1fcGx1Z2luUHJvY2Vz c0Nvbm5lY3Rpb25zLnJlbW92ZSh2ZWN0b3JJbmRleCk7CiB9CiAKK3ZvaWQgUGx1Z2luUHJvY2Vz c0Nvbm5lY3Rpb25NYW5hZ2VyOjpwbHVnaW5Qcm9jZXNzQ3Jhc2hlZChjb25zdCBTdHJpbmcmIHBs dWdpblBhdGgpCit7CisgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fcGF0aHNBbmRDb25uZWN0aW9u c011dGV4KTsKKyAgICBDb3JlSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uID0gbV9wYXRoc0Fu ZENvbm5lY3Rpb25zLmdldChwbHVnaW5QYXRoKS5nZXQoKTsKKworICAgIC8vIEl0J3MgT0sgZm9y IGNvbm5lY3Rpb24gdG8gYmUgbnVsbCBoZXJlOyBpdCB3aWxsIGhhcHBlbiBpZiB0aGlzIHdlYiBw cm9jZXNzIGRvZXNuJ3Qga25vdworICAgIC8vIGFueXRoaW5nIGFib3V0IHRoZSBwbHVnLWluIHBy b2Nlc3MuCisgICAgaWYgKCFjb25uZWN0aW9uKQorICAgICAgICByZXR1cm47CisKKyAgICBjb25u ZWN0aW9uLT5wb3N0Q29ubmVjdGlvbkRpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlKCk7Cit9 CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCiAjZW5kaWYgLy8gRU5BQkxFKFBMVUdJTl9QUk9D RVNTKQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nl c3NDb25uZWN0aW9uTWFuYWdlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIuaAkocmV2aXNpb24g ODU1NjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vz c0Nvbm5lY3Rpb25NYW5hZ2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI5LDExICsyOSwxOCBAQAog I2lmIEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKIAogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+Cisj aW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KKyNp bmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgorI2luY2x1 ZGUgPHd0Zi90ZXh0L1N0cmluZ0hhc2guaD4KIAogLy8gTWFuYWdlcyBwbHVnLWluIHByb2Nlc3Mg Y29ubmVjdGlvbnMgZm9yIHRoZSBnaXZlbiB3ZWIgcHJvY2Vzcy4KIAorbmFtZXNwYWNlIENvcmVJ UEMgeworICAgIGNsYXNzIENvbm5lY3Rpb247Cit9CisKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBj bGFzcyBQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbjsKQEAgLTQ3LDggKzU0LDE0IEBAIHB1YmxpYzoK ICAgICBQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbiogZ2V0UGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb24o Y29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoKTsKICAgICB2b2lkIHJlbW92ZVBsdWdpblByb2Nlc3ND b25uZWN0aW9uKFBsdWdpblByb2Nlc3NDb25uZWN0aW9uKik7CiAKKyAgICAvLyBDYWxsZWQgb24g dGhlIHdlYiBwcm9jZXNzIGNvbm5lY3Rpb24gd29yayBxdWV1ZS4KKyAgICB2b2lkIHBsdWdpblBy b2Nlc3NDcmFzaGVkKGNvbnN0IFN0cmluZyYgcGx1Z2luUGF0aCk7CisKIHByaXZhdGU6CiAgICAg VmVjdG9yPFJlZlB0cjxQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbj4gPiBtX3BsdWdpblByb2Nlc3ND b25uZWN0aW9uczsKKworICAgIE11dGV4IG1fcGF0aHNBbmRDb25uZWN0aW9uc011dGV4OworICAg IEhhc2hNYXA8U3RyaW5nLCBSZWZQdHI8Q29yZUlQQzo6Q29ubmVjdGlvbj4gPiBtX3BhdGhzQW5k Q29ubmVjdGlvbnM7CiB9OwogCiB9Cg==