59990 2011-05-02 17:57:14 -0700 [GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480 2011-05-10 12:40:01 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson mrobinson alex cgarcia pnormand webkit.review.bot xan.lopez oldest_to_newest 396836 0 mrobinson 2011-05-02 17:57:14 -0700 It seems the issue here is that there are two situations that are no longer handled by the code grabbing the drawable size: 1. When the drawable is null. 2. When the drawable is in fact a GdkPixmap. For the time being this diables the sanity check for WebKit2, but we can wait to add support for that when we decide whether or not to drop GTK+ 2.x support for WebKit2. 396839 1 92019 mrobinson 2011-05-02 17:59:23 -0700 Created attachment 92019 Patch 396840 2 mrobinson 2011-05-02 17:59:51 -0700 Style bot: We have to keep the parameter name because this header is used in C code. 396843 3 webkit.review.bot 2011-05-02 18:02:10 -0700 Attachment 92019 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/gtk/GtkVersioning.h:38: The parameter name "drawable" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 400661 4 92019 xan.lopez 2011-05-09 12:34:06 -0700 Comment on attachment 92019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92019&action=review > Source/WebCore/platform/gtk/GtkVersioning.c:267 > + g_assert(GDK_IS_PIXMAP(drawable) || GDK_IS_WINDOW(drawable)); This will crash in release builds, so better change it for g_return_if_fail. 401423 5 mrobinson 2011-05-10 12:37:37 -0700 Committed r86178: <http://trac.webkit.org/changeset/86178> 92019 2011-05-02 17:59:23 -0700 2011-05-10 12:40:01 -0700 Patch bug-59990-20110502175922.patch text/plain 4255 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODU1MTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NTA3ODcxOWFjOWY5OTk4 MjhmMzBjMjQ3MTcwZDU0ZmMxYjZiYzFlLi42MTIyOTExOTU0YzkwYTcwNDZkNzI4ZDBiYzMwOGZl MzRhOThhOTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMDIgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdW1dlYktpdDJdIEdUSysgMi54IHdpZGdl dCByZW5kZXJpbmcgZmFpbHMgYWZ0ZXIgcjg1NDgwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTk5MAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhp cyBpcyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHBpeGVsIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL0d0a1ZlcnNpb25pbmcuYzoKKyAgICAgICAgKGdldEdka0RyYXdhYmxlU2l6ZSk6IEFk ZGVkIHRoaXMgaGVscGVyIG1ldGhvZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvR3RrVmVyc2lv bmluZy5oOiBBZGRlZCBoZWxwZXIgbWV0aG9kIGRlY2xhcmF0aW9uLgorICAgICAgICAqIHBsYXRm b3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldp ZGdldFJlbmRlcmluZ0NvbnRleHQ6OldpZGdldFJlbmRlcmluZ0NvbnRleHQpOiBDYWxsIGludG8g dGhlIGhlbHBlciBpZgorICAgICAgICB0aGVyZSBpcyBhY3R1YWxseSBhIEdka0RyYXdhYmxlLiBJ ZiBub3QsIGRpc2FibGUgdGhlIHNhbml0eSBjaGVjay4KKwogMjAxMS0wNS0wMiAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmlu LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcu YyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmMKaW5kZXggMTEz OGQ1NjIwNWIwMWE1ZWYyM2MxZDEzYjQ4YzAyMTM2ZTAwNmM0OS4uNWQyMjRjZGFjODA0NWVmNjNm MGEyYWE4ZDZmNzdmNDQwZmU5ZjE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL0d0a1ZlcnNpb25pbmcuYworKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv R3RrVmVyc2lvbmluZy5jCkBAIC0yNjEsNiArMjYxLDI3IEBAIGdka19waXhidWZfZ2V0X2Zyb21f c3VyZmFjZShjYWlyb19zdXJmYWNlX3QgKiBzdXJmYWNlLAogICAgIHJldHVybiBkZXN0OwogfQog CisjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwgMjQsIDApCit2b2lkIGdldEdka0RyYXdhYmxlU2l6 ZShHZGtEcmF3YWJsZSAqZHJhd2FibGUsIGludCAqd2lkdGgsIGludCAqaGVpZ2h0KQoreworICAg IGdfYXNzZXJ0KEdES19JU19QSVhNQVAoZHJhd2FibGUpIHx8IEdES19JU19XSU5ET1coZHJhd2Fi bGUpKTsKKworICAgIGlmIChHREtfSVNfUElYTUFQKGRyYXdhYmxlKSkgeworICAgICAgICBnZGtf cGl4bWFwX2dldF9zaXplKEdES19QSVhNQVAoZHJhd2FibGUpLCB3aWR0aCwgaGVpZ2h0KTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KKworICAgIEdka1dpbmRvdyAqd2luZG93ID0gR0RLX1dJTkRP VyhkcmF3YWJsZSk7CisgICAgKndpZHRoID0gZ2RrX3dpbmRvd19nZXRfd2lkdGgod2luZG93KTsK KyAgICAqaGVpZ2h0ID0gZ2RrX3dpbmRvd19nZXRfaGVpZ2h0KHdpbmRvdyk7Cit9CisjZWxzZQor dm9pZCBnZXRHZGtEcmF3YWJsZVNpemUoR2RrRHJhd2FibGUgKmRyYXdhYmxlLCBpbnQgKndpZHRo LCBpbnQgKmhlaWdodCkKK3sKKyAgICBnZGtfZHJhd2FibGVfZ2V0X3NpemUoZHJhd2FibGUsICZ3 aWR0aCwgJmhlaWdodCk7Cit9CisjZW5kaWYgLy8gR1RLX0NIRUNLX1ZFUlNJT04oMiwgMjQsIDAp CisKICNlbmRpZiAvLyBHVEtfQVBJX1ZFUlNJT05fMgogCiAjaWYgIUdMSUJfQ0hFQ0tfVkVSU0lP TigyLCAyNywgMSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtW ZXJzaW9uaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVmVyc2lvbmluZy5o CmluZGV4IGI0NGZjMzgzOTI2MjY1NmMzMDAzMTRhZjg5NTZiZGZjMjEzMWE1NzIuLjkyZDAzYzQw N2U3MmYyMDM0ZWQyNjQwZWViYWQyZTJmN2JiMmY4ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuaApAQCAtMzUsNiArMzUsNyBAQCBHX0JFR0lOX0RFQ0xT CiAjZWxzZQogR2RrUGl4YnVmKiBnZGtfcGl4YnVmX2dldF9mcm9tX3N1cmZhY2UoY2Fpcm9fc3Vy ZmFjZV90KiBzdXJmYWNlLCBpbnQgc3JjWCwgaW50IHNyY1ksCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbnQgd2lkdGgsIGludCBoZWlnaHQpOwordm9pZCBnZXRHZGtE cmF3YWJsZVNpemUoR2RrRHJhd2FibGUqIGRyYXdhYmxlLCBpbnQqIHdpZHRoLCBpbnQqIGhlaWdo dCk7CiAjZW5kaWYKIAogI2lmICFHVEtfQ0hFQ0tfVkVSU0lPTigyLCAyMywgNCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNw cAppbmRleCBkNzU5MTYzMDBiOWM4ZmM0YjBiN2QxMTM3NTVlYzFmZTcwM2Q3OWVmLi5mNDNkYzVm NDU2NGMxNTVlYzVkNDAyOWQzMzFhZjU1MTExNWU3YzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvV2lkZ2V0UmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dpZGdldFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC04Mywx NCArODMsMTIgQEAgV2lkZ2V0UmVuZGVyaW5nQ29udGV4dDo6V2lkZ2V0UmVuZGVyaW5nQ29udGV4 dChHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwKIAogICAgIC8vIFdlIG5ldmVyIHdh bnQgdG8gY3JlYXRlIGEgc2NyYXRjaCBidWZmZXIgbGFyZ2VyIHRoYW4gdGhlIHNpemUgb2Ygb3Vy IHRhcmdldCBHZGtEcmF3YWJsZS4KICAgICAvLyBUaGlzIHByZXZlbnRzIGdpYW50IHBpeG1hcCBh bGxvY2F0aW9ucyBmb3IgdmVyeSBsYXJnZSB3aWRnZXRzIGluIHNtYWxsZXIgdmlld3MuCi0gICAg aW50IG1heFdpZHRoID0gMCwgbWF4SGVpZ2h0ID0gMDsKLSNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigy LCAyNCwgMCkKLSAgICBtYXhXaWR0aCA9IGdka193aW5kb3dfZ2V0X3dpZHRoKGdyYXBoaWNzQ29u dGV4dC0+Z2RrV2luZG93KCkpOwotICAgIG1heEhlaWdodCA9IGdka193aW5kb3dfZ2V0X2hlaWdo dChncmFwaGljc0NvbnRleHQtPmdka1dpbmRvdygpKTsKLSNlbHNlCi0gICAgZ2RrX2RyYXdhYmxl X2dldF9zaXplKGdyYXBoaWNzQ29udGV4dC0+Z2RrV2luZG93KCksICZtYXhXaWR0aCwgJm1heEhl aWdodCk7Ci0jZW5kaWYKLSAgICBtX3RhcmdldFJlY3Quc2V0U2l6ZShtX3RhcmdldFJlY3Quc2l6 ZSgpLnNocnVua1RvKEludFNpemUobWF4V2lkdGgsIG1heEhlaWdodCkpKTsKKyAgICAvLyBGSVhN RTogV2UgbmVlZCB0byBpbXBsZW1lbnQgdGhpcyBjaGVjayBmb3IgV2ViS2l0MiBhcyB3ZWxsLgor ICAgIGlmIChncmFwaGljc0NvbnRleHQtPmdka1dpbmRvdygpKSB7CisgICAgICAgIGludCBtYXhX aWR0aCA9IDAsIG1heEhlaWdodCA9IDA7CisgICAgICAgIGdldEdka0RyYXdhYmxlU2l6ZShncmFw aGljc0NvbnRleHQtPmdka1dpbmRvdygpLCAmbWF4V2lkdGgsICZtYXhIZWlnaHQpOworICAgICAg ICBtX3RhcmdldFJlY3Quc2V0U2l6ZShtX3RhcmdldFJlY3Quc2l6ZSgpLnNocnVua1RvKEludFNp emUobWF4V2lkdGgsIG1heEhlaWdodCkpKTsKKyAgICB9CiAKICAgICAvLyBXaWRnZXRzIHNvbWV0 aW1lcyBuZWVkIHRvIGRyYXcgb3V0c2lkZSB0aGVpciBib3VuZGFyaWVzIGZvciB0aGluZ3Mgc3Vj aCBhcwogICAgIC8vIGV4dGVyaW9yIGZvY3VzLiBXZSB3YW50IHRvIGFsbG9jYXRlIGEgc29tZSBl eHRyYSBwaXhlbHMgaW4gb3VyIHN1cmZhY2UgZm9yIHRoaXMuCg==