59981 2011-05-02 17:01:44 -0700 remove no longer used method 2011-05-03 09:39:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan dpranke tony oldest_to_newest 396799 0 ojan 2011-05-02 17:01:44 -0700 remove no longer used method 396801 1 92007 ojan 2011-05-02 17:02:03 -0700 Created attachment 92007 Patch 396828 2 92007 dpranke 2011-05-02 17:38:18 -0700 Comment on attachment 92007 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92007&action=review LGTM. > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:234 > # changing the calls to this on the chromium build slaves. I think you can delete this FIXME, right? Also, I probably would have not included the _ms_ in the name, since it's not really that relevant. 397129 3 ojan 2011-05-03 09:39:54 -0700 Committed r85612: <http://trac.webkit.org/changeset/85612> 92007 2011-05-02 17:02:03 -0700 2011-05-03 09:23:08 -0700 Patch bug-59981-20110502170202.patch text/plain 2599 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODU0ODEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNjAzZjBkZmJkMTc1MGY4NWVlMDJmZGIzMGQxMGNiN2Q1 Y2MyMDVjLi4zZDhmYjU5ZmM5NmJiZWE3OTkwOGZmMmJmMmUyNDI1MDc5YTQ0OTRlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDUtMDIgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByZW1vdmUgbm8gbG9uZ2Vy IHVzZWQgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01OTk4MQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzX2dlbmVyYXRvci5weToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfZ2VuZXJh dG9yX3VuaXR0ZXN0LnB5OgorCiAyMDExLTA1LTAyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5z b25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdl L2pzb25fcmVzdWx0c19nZW5lcmF0b3IucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfZ2VuZXJhdG9yLnB5CmluZGV4IDIz NDYxM2E1NWJkNDZkZGQ4MjU4YTQxMzBlN2UzODllODRhNDQ1MDIuLjgyZDIxZTYyZjY0Y2Y3YzE0 OWU2YzAxMzk4NzgwNTM5ZjEzZjMwMmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0c19nZW5lcmF0b3IucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uv anNvbl9yZXN1bHRzX2dlbmVyYXRvci5weQpAQCAtMjI5LDEwICsyMjksNiBAQCBjbGFzcyBKU09O UmVzdWx0c0dlbmVyYXRvckJhc2Uob2JqZWN0KToKICAgICAgICAgICAgIGZpbGVfcGF0aCA9IHNl bGYuX2ZzLmpvaW4oc2VsZi5fcmVzdWx0c19kaXJlY3RvcnksIHNlbGYuSU5DUkVNRU5UQUxfUkVT VUxUU19GSUxFTkFNRSkKICAgICAgICAgICAgIHdyaXRlX2pzb24oc2VsZi5fZnMsIGpzb24sIGZp bGVfcGF0aCkKIAotICAgICMgRklYTUU6IFJlbW92ZSB0aGlzIGZ1bmN0aW9uIG9uY2UgdGhlIGNo cm9taXVtIGJ1aWxkYm90cyBzdG9wIGNhbGxpbmcgaXQuCi0gICAgZGVmIGdlbmVyYXRlX2Z1bGxf cmVzdWx0c19maWxlKHNlbGYpOgotICAgICAgICBzZWxmLmdlbmVyYXRlX3RpbWVzX21zX2ZpbGUo KQotCiAgICAgZGVmIGdlbmVyYXRlX3RpbWVzX21zX2ZpbGUoc2VsZik6CiAgICAgICAgICMgRklY TUU6IHJlbmFtZSB0byBnZW5lcmF0ZV90aW1lc19tc19maWxlLiBUaGlzIG5lZWRzIHRvIGJlIGNv b3JkaW5hdGVkIHdpdGgKICAgICAgICAgIyBjaGFuZ2luZyB0aGUgY2FsbHMgdG8gdGhpcyBvbiB0 aGUgY2hyb21pdW0gYnVpbGQgc2xhdmVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzX2dlbmVyYXRvcl91 bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9w YWNrYWdlL2pzb25fcmVzdWx0c19nZW5lcmF0b3JfdW5pdHRlc3QucHkKaW5kZXggMjFhNzIxYTIz OWNmMWQxNTY4NTQ0YTllZDA2YzIyNjc0NTZhMjMwOC4uMjQ4OTExYTk2MmNhMGY5MDc1YmYzYmY5 NzA0Yjk2ZWUwNThhYWYwYyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzX2dlbmVyYXRvcl91bml0dGVzdC5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2Fn ZS9qc29uX3Jlc3VsdHNfZ2VuZXJhdG9yX3VuaXR0ZXN0LnB5CkBAIC0xMTAsNyArMTEwLDcgQEAg Y2xhc3MgSlNPTkdlbmVyYXRvclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgICAgICMg V2UgZG9uJ3QgdmVyaWZ5IHRoZSByZXN1bHRzIGhlcmUsIGJ1dCBhdCBsZWFzdCB3ZSBtYWtlIHN1 cmUgdGhlIGNvZGUgcnVucyB3aXRob3V0IGVycm9ycy4KICAgICAgICAgZ2VuZXJhdG9yLmdlbmVy YXRlX2pzb25fb3V0cHV0KCkKLSAgICAgICAgZ2VuZXJhdG9yLmdlbmVyYXRlX2Z1bGxfcmVzdWx0 c19maWxlKCkKKyAgICAgICAgZ2VuZXJhdG9yLmdlbmVyYXRlX3RpbWVzX21zX2ZpbGUoKQogCiAg ICAgZGVmIF92ZXJpZnlfanNvbl9yZXN1bHRzKHNlbGYsIHRlc3RzX3NldCwgdGVzdF90aW1pbmdz LCBmYWlsZWRfY291bnRfbWFwLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQQVNTX2Nv dW50LCBESVNBQkxFRF9jb3VudCwgRkxBS1lfY291bnQsCg==