59979 2011-05-02 17:00:10 -0700 Allow access keys to be used in shadow DOM 2011-05-03 16:08:30 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 59805 59832 1 rolandsteiner rolandsteiner ap dglazkov dominicc morrita oldest_to_newest 396797 0 rolandsteiner 2011-05-02 17:00:10 -0700 It should be possible to assign an access key to elements in a shadow DOM. Currently, only elements in the light tree are considered. 396980 1 ap 2011-05-02 23:10:34 -0700 Could you please clarify why this is necessary? 397169 2 rolandsteiner 2011-05-03 10:29:01 -0700 User-defined components could have, e.g., a link to a help page, or an [O]K and [C]ancel button embedded that have an access key assigned. 397447 3 92147 rolandsteiner 2011-05-03 15:20:45 -0700 Created attachment 92147 Patch Moving access key members and methods back into Document from TreeScope, traverse into shadow DOM when building access key map. 397492 4 rolandsteiner 2011-05-03 16:08:30 -0700 Committed r85680: <http://trac.webkit.org/changeset/85680> 92147 2011-05-03 15:20:45 -0700 2011-05-03 15:24:09 -0700 Patch bug-59979-20110503152044.patch text/plain 6608 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogODU2MTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMjJkYzk0MzA4NjVmYTY2 Y2Y0MjZhMjJhMDYxMjg0MzhlYmY1ZTVkLi42YTI2N2RkY2ZkMjUyYjUzZWEwZmQzZjFiMmI1ZDg2 M2MxZGMyMTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMDMgIFJvbGFu ZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgYWNjZXNzIGtleXMgdG8gYmUg dXNlZCBpbiBzaGFkb3cgRE9NCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01OTk3OQorCisgICAgICAgIE1vdmUgYWNjZXNzIGtleSBtZXRob2RzIGFuZCBt ZW1iZXJzIGJhY2sgdG8gRG9jdW1lbnQgZnJvbSBUcmVlU2NvcGUuCisgICAgICAgIEFsc28gdHJh dmVyc2UgaW50byBzaGFkb3cgdHJlZXMgd2hlbiBidWlsZGluZyB0aGUgYWNjZXNzIGtleSBtYXAu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAocmVmYWN0b3JpbmcpCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OkRvY3VtZW50KToKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpnZXRFbGVtZW50QnlBY2Nlc3NLZXkpOgorICAgICAg ICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmJ1aWxkQWNjZXNzS2V5TWFwKToKKyAgICAgICAgKFdlYkNv cmU6OkRvY3VtZW50OjppbnZhbGlkYXRlQWNjZXNzS2V5TWFwKToKKyAgICAgICAgKiBkb20vRG9j dW1lbnQuaDoKKyAgICAgICAgKiBkb20vVHJlZVNjb3BlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlRyZWVTY29wZTo6VHJlZVNjb3BlKToKKyAgICAgICAgKFdlYkNvcmU6OlRyZWVTY29wZTo6ZGVz dHJveVRyZWVTY29wZURhdGEpOgorICAgICAgICAqIGRvbS9UcmVlU2NvcGUuaDoKKwogMjAxMS0w NS0wMyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGY3MGQ2MzBmOTkx NGExNDA0NGE0NjNhNTZhZmRlYWU3YTc3ODJjZDkuLjlkMzcyZTA4ZWNjNzIzZDI2OGJlYTVlYjgx Y2E2NDE3ZGNkMWE5ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNDAwLDYgKzQwMCw3 IEBAIERvY3VtZW50OjpEb2N1bWVudChGcmFtZSogZnJhbWUsIGNvbnN0IEtVUkwmIHVybCwgYm9v bCBpc1hIVE1MLCBib29sIGlzSFRNTCkKICNlbmRpZgogICAgICwgbV9jcmVhdGVSZW5kZXJlcnMo dHJ1ZSkKICAgICAsIG1faW5QYWdlQ2FjaGUoZmFsc2UpCisgICAgLCBtX2FjY2Vzc0tleU1hcFZh bGlkKGZhbHNlKQogICAgICwgbV91c2VTZWN1cmVLZXlib2FyZEVudHJ5V2hlbkFjdGl2ZShmYWxz ZSkKICAgICAsIG1faXNYSFRNTChpc1hIVE1MKQogICAgICwgbV9pc0hUTUwoaXNIVE1MKQpAQCAt NjA5LDYgKzYxMCwzNiBAQCBFbGVtZW50KiBEb2N1bWVudDo6Z2V0RWxlbWVudEJ5SWQoY29uc3Qg QXRvbWljU3RyaW5nJiBpZCkgY29uc3QKICAgICByZXR1cm4gVHJlZVNjb3BlOjpnZXRFbGVtZW50 QnlJZChpZCk7CiB9CiAKK0VsZW1lbnQqIERvY3VtZW50OjpnZXRFbGVtZW50QnlBY2Nlc3NLZXko Y29uc3QgU3RyaW5nJiBrZXkpCit7CisgICAgaWYgKGtleS5pc0VtcHR5KCkpCisgICAgICAgIHJl dHVybiAwOworICAgIGlmICghbV9hY2Nlc3NLZXlNYXBWYWxpZCkgeworICAgICAgICBidWlsZEFj Y2Vzc0tleU1hcCh0aGlzKTsKKyAgICAgICAgbV9hY2Nlc3NLZXlNYXBWYWxpZCA9IHRydWU7Cisg ICAgfQorICAgIHJldHVybiBtX2VsZW1lbnRzQnlBY2Nlc3NLZXkuZ2V0KGtleS5pbXBsKCkpOwor fQorCit2b2lkIERvY3VtZW50OjpidWlsZEFjY2Vzc0tleU1hcChDb250YWluZXJOb2RlKiByb290 KQoreworICAgICBmb3IgKE5vZGUqIG4gPSByb290OyBuOyBuID0gbi0+dHJhdmVyc2VOZXh0Tm9k ZShyb290KSkgeworICAgICAgICBpZiAoIW4tPmlzRWxlbWVudE5vZGUoKSkKKyAgICAgICAgICAg IGNvbnRpbnVlOworICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8RWxlbWVu dCo+KG4pOworICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIGFjY2Vzc0tleSA9IGVsZW1lbnQt PmdldEF0dHJpYnV0ZShhY2Nlc3NrZXlBdHRyKTsKKyAgICAgICAgaWYgKCFhY2Nlc3NLZXkuaXNF bXB0eSgpKQorICAgICAgICAgICAgbV9lbGVtZW50c0J5QWNjZXNzS2V5LnNldChhY2Nlc3NLZXku aW1wbCgpLCBlbGVtZW50KTsKKyAgICAgICAgYnVpbGRBY2Nlc3NLZXlNYXAoZWxlbWVudC0+c2hh ZG93Um9vdCgpKTsKKyAgICB9Cit9CisKK3ZvaWQgRG9jdW1lbnQ6OmludmFsaWRhdGVBY2Nlc3NL ZXlNYXAoKQoreworICAgIG1fYWNjZXNzS2V5TWFwVmFsaWQgPSBmYWxzZTsKKyAgICBtX2VsZW1l bnRzQnlBY2Nlc3NLZXkuY2xlYXIoKTsKK30KKwogTWVkaWFRdWVyeU1hdGNoZXIqIERvY3VtZW50 OjptZWRpYVF1ZXJ5TWF0Y2hlcigpCiB7CiAgICAgaWYgKCFtX21lZGlhUXVlcnlNYXRjaGVyKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuaAppbmRleCA3N2ZmMjM2OTViN2RmMTg1OTc2YmQzMTI1NjA3MzBmN2Rj MTFjZTA1Li5jYWEzNTk4NDdlYjBlOTUxZWM5ZTFjZDM2MzMyYzNjNjFkMDIzY2NhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuaApAQCAtMjQ1LDYgKzI0NSw5IEBAIHB1YmxpYzoKIAogICAgIEVsZW1lbnQq IGdldEVsZW1lbnRCeUlkKGNvbnN0IEF0b21pY1N0cmluZyYgaWQpIGNvbnN0OwogCisgICAgRWxl bWVudCogZ2V0RWxlbWVudEJ5QWNjZXNzS2V5KGNvbnN0IFN0cmluZyYga2V5KTsKKyAgICB2b2lk IGludmFsaWRhdGVBY2Nlc3NLZXlNYXAoKTsKKwogICAgIC8vIERPTSBtZXRob2RzICYgYXR0cmli dXRlcyBmb3IgRG9jdW1lbnQKIAogICAgIERFRklORV9BVFRSSUJVVEVfRVZFTlRfTElTVEVORVIo YWJvcnQpOwpAQCAtMTExOSw2ICsxMTIyLDggQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgY2FjaGVE b2N1bWVudEVsZW1lbnQoKSBjb25zdDsKIAorICAgIHZvaWQgYnVpbGRBY2Nlc3NLZXlNYXAoQ29u dGFpbmVyTm9kZSogcm9vdCk7CisKICAgICB2b2lkIGNyZWF0ZVN0eWxlU2VsZWN0b3IoKTsKIAog ICAgIFBhc3NSZWZQdHI8Tm9kZUxpc3Q+IGhhbmRsZVplcm9QYWRkaW5nKGNvbnN0IEhpdFRlc3RS ZXF1ZXN0JiwgSGl0VGVzdFJlc3VsdCYpIGNvbnN0OwpAQCAtMTMzMCw2ICsxMzM1LDkgQEAgcHJp dmF0ZToKICAgICBIYXNoU2V0PEVsZW1lbnQqPiBtX21lZGlhVm9sdW1lQ2FsbGJhY2tFbGVtZW50 czsKICAgICBIYXNoU2V0PEVsZW1lbnQqPiBtX3ByaXZhdGVCcm93c2luZ1N0YXRlQ2hhbmdlZEVs ZW1lbnRzOwogCisgICAgSGFzaE1hcDxTdHJpbmdJbXBsKiwgRWxlbWVudCosIENhc2VGb2xkaW5n SGFzaD4gbV9lbGVtZW50c0J5QWNjZXNzS2V5OyAgICAKKyAgICBib29sIG1fYWNjZXNzS2V5TWFw VmFsaWQ7CisKICAgICBib29sIG1fdXNlU2VjdXJlS2V5Ym9hcmRFbnRyeVdoZW5BY3RpdmU7CiAK ICAgICBib29sIG1faXNYSFRNTDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9UcmVl U2NvcGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZS5jcHAKaW5kZXggMGU5OWQ2 ZmYwMTg5MTJlMWYwZGRkY2M3ODljMjkyNWE1NTUwZGU1YS4uMTliNjRkNTQ4ZjU2NzhjYzFlMzIz ZjgxYmFmNThjMTIzZmJhMzI1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVT Y29wZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZS5jcHAKQEAgLTM5LDcg KzM5LDYgQEAgdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIFRyZWVTY29wZTo6VHJlZVNjb3Bl KERvY3VtZW50KiBkb2N1bWVudCkKICAgICA6IENvbnRhaW5lck5vZGUoZG9jdW1lbnQpCiAgICAg LCBtX3BhcmVudFRyZWVTY29wZSgwKQotICAgICwgbV9hY2Nlc3NLZXlNYXBWYWxpZChmYWxzZSkK ICAgICAsIG1fbnVtTm9kZUxpc3RDYWNoZXMoMCkKIHsKIH0KQEAgLTU0LDcgKzUzLDYgQEAgdm9p ZCBUcmVlU2NvcGU6OmRlc3Ryb3lUcmVlU2NvcGVEYXRhKCkKIHsKICAgICBtX2VsZW1lbnRzQnlJ ZC5jbGVhcigpOwogICAgIG1faW1hZ2VNYXBzQnlOYW1lLmNsZWFyKCk7Ci0gICAgbV9lbGVtZW50 c0J5QWNjZXNzS2V5LmNsZWFyKCk7CiB9CiAKIHZvaWQgVHJlZVNjb3BlOjpzZXRQYXJlbnRUcmVl U2NvcGUoVHJlZVNjb3BlKiBuZXdQYXJlbnRTY29wZSkKQEAgLTg0LDMwICs4Miw2IEBAIHZvaWQg VHJlZVNjb3BlOjpyZW1vdmVFbGVtZW50QnlJZChjb25zdCBBdG9taWNTdHJpbmcmIGVsZW1lbnRJ ZCwgRWxlbWVudCogZWxlbWVuCiAgICAgbV9lbGVtZW50c0J5SWQucmVtb3ZlKGVsZW1lbnRJZC5p bXBsKCksIGVsZW1lbnQpOwogfQogCi1FbGVtZW50KiBUcmVlU2NvcGU6OmdldEVsZW1lbnRCeUFj Y2Vzc0tleShjb25zdCBTdHJpbmcmIGtleSkgY29uc3QKLXsKLSAgICBpZiAoa2V5LmlzRW1wdHko KSkKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgaWYgKCFtX2FjY2Vzc0tleU1hcFZhbGlkKSB7Ci0g ICAgICAgIGZvciAoTm9kZSogbiA9IGZpcnN0Q2hpbGQoKTsgbjsgbiA9IG4tPnRyYXZlcnNlTmV4 dE5vZGUoKSkgewotICAgICAgICAgICAgaWYgKCFuLT5pc0VsZW1lbnROb2RlKCkpCi0gICAgICAg ICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGlj X2Nhc3Q8RWxlbWVudCo+KG4pOwotICAgICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBhY2Nl c3NLZXkgPSBlbGVtZW50LT5nZXRBdHRyaWJ1dGUoYWNjZXNza2V5QXR0cik7Ci0gICAgICAgICAg ICBpZiAoIWFjY2Vzc0tleS5pc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgbV9lbGVtZW50c0J5 QWNjZXNzS2V5LnNldChhY2Nlc3NLZXkuaW1wbCgpLCBlbGVtZW50KTsKLSAgICAgICAgfQotICAg ICAgICBtX2FjY2Vzc0tleU1hcFZhbGlkID0gdHJ1ZTsKLSAgICB9Ci0gICAgcmV0dXJuIG1fZWxl bWVudHNCeUFjY2Vzc0tleS5nZXQoa2V5LmltcGwoKSk7Ci19Ci0KLXZvaWQgVHJlZVNjb3BlOjpp bnZhbGlkYXRlQWNjZXNzS2V5TWFwKCkKLXsKLSAgICBtX2FjY2Vzc0tleU1hcFZhbGlkID0gZmFs c2U7Ci0gICAgbV9lbGVtZW50c0J5QWNjZXNzS2V5LmNsZWFyKCk7Ci19Ci0KIHZvaWQgVHJlZVNj b3BlOjphZGRJbWFnZU1hcChIVE1MTWFwRWxlbWVudCogaW1hZ2VNYXApCiB7CiAgICAgQXRvbWlj U3RyaW5nSW1wbCogbmFtZSA9IGltYWdlTWFwLT5nZXROYW1lKCkuaW1wbCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1Ry ZWVTY29wZS5oCmluZGV4IDRiYmRlMTA5Yzc5ZDIwYzdlMzNkZDI0ZGMyMTNjMGQxYjFlM2MwYmMu LmU5MjNmYzRiMzY4NmNkMDc2ZmY5MDc1NzM2MzlkMzkwMzQwM2QzMjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9UcmVlU2NvcGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vVHJl ZVNjb3BlLmgKQEAgLTUxLDkgKzUxLDYgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlSW1hZ2VN YXAoSFRNTE1hcEVsZW1lbnQqKTsKICAgICBIVE1MTWFwRWxlbWVudCogZ2V0SW1hZ2VNYXAoY29u c3QgU3RyaW5nJiB1cmwpIGNvbnN0OwogCi0gICAgRWxlbWVudCogZ2V0RWxlbWVudEJ5QWNjZXNz S2V5KGNvbnN0IFN0cmluZyYga2V5KSBjb25zdDsKLSAgICB2b2lkIGludmFsaWRhdGVBY2Nlc3NL ZXlNYXAoKTsKLQogICAgIHZvaWQgYWRkTm9kZUxpc3RDYWNoZSgpIHsgKyttX251bU5vZGVMaXN0 Q2FjaGVzOyB9CiAgICAgdm9pZCByZW1vdmVOb2RlTGlzdENhY2hlKCkgeyBBU1NFUlQobV9udW1O b2RlTGlzdENhY2hlcyA+IDApOyAtLW1fbnVtTm9kZUxpc3RDYWNoZXM7IH0KICAgICBib29sIGhh c05vZGVMaXN0Q2FjaGVzKCkgY29uc3QgeyByZXR1cm4gbV9udW1Ob2RlTGlzdENhY2hlczsgfQpA QCAtNzksOSArNzYsNiBAQCBwcml2YXRlOgogICAgIERvY3VtZW50T3JkZXJlZE1hcCBtX2VsZW1l bnRzQnlJZDsKICAgICBEb2N1bWVudE9yZGVyZWRNYXAgbV9pbWFnZU1hcHNCeU5hbWU7CiAKLSAg ICBtdXRhYmxlIEhhc2hNYXA8U3RyaW5nSW1wbCosIEVsZW1lbnQqLCBDYXNlRm9sZGluZ0hhc2g+ IG1fZWxlbWVudHNCeUFjY2Vzc0tleTsgICAgCi0gICAgbXV0YWJsZSBib29sIG1fYWNjZXNzS2V5 TWFwVmFsaWQ7Ci0KICAgICB1bnNpZ25lZCBtX251bU5vZGVMaXN0Q2FjaGVzOwogfTsKIAo=