59967 2011-05-02 15:24:13 -0700 Avoid wasted cycles updating paths when popping the context stack 2011-05-02 16:19:04 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser mdelaney7 simon.fraser oldest_to_newest 396720 0 simon.fraser 2011-05-02 15:24:13 -0700 CanvasRenderingContext2D::restore() does m_path.transform(state().m_transform); which is a waste of cycles if the path is empty, or the transform is identity. 396739 1 91995 simon.fraser 2011-05-02 15:49:42 -0700 Created attachment 91995 Patch 396753 2 mdelaney7 2011-05-02 16:06:54 -0700 I wonder if putting isEmpty first in the check might make these paths even a little faster. isIdentity() looks at a handful of values on the matrix whereas isEmpty should be checking just a single count variable (platform dependent of course though). 396763 3 simon.fraser 2011-05-02 16:19:04 -0700 http://trac.webkit.org/changeset/85540 91995 2011-05-02 15:49:42 -0700 2011-05-02 16:05:22 -0700 Patch bug-59967-20110502154940.patch text/plain 1600 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogODUzNzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMDM3YTczM2I5ZDcyMTdm MmE3NTBlZWY5ZDc0YTVmYzA1NjYzYjgwLi40ZjM0OGRiM2I4NTU0Njc0OTE0MDhiZGM1ODY2NmFj OTk0YWU1NTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDIgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgd2FzdGVkIGN5Y2xlcyB1cGRhdGluZyBw YXRocyB3aGVuIHBvcHBpbmcgdGhlIGNvbnRleHQgc3RhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5OTY3CisKKyAgICAgICAgQ2FudmFzUmVuZGVy aW5nQ29udGV4dDJEIGhhcyB0byBtYXAgdGhlIGN1cnJlbnQgcGF0aCB0aHJvdWdoCisgICAgICAg IHRyYW5zZm9ybXMgd2hlbmV2ZXIgdGhlIGNvbnRleHQgc3RhY2sgaXMgcG9wcGVkLCB3aGljaCBj cmVhdGVzCisgICAgICAgIGEgbG90IG9mIHBsYXRmb3JtIHBhdGggb2JqZWN0cy4gQXZvaWQgZXh0 cmEgd29yayBoZXJlIHdoZW4gdGhlCisgICAgICAgIHBhdGggaXMgZW1wdHksIG9yIHdoZW4gdGhl IHRyYW5zZm9ybSBpcyBpZGVudGl0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nn L1BhdGhDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjp0cmFuc2Zvcm0pOgorCiAyMDEx LTA0LTI5ICBFbWlsIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgVG9ueSBDaGFuZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NnL1BhdGhDRy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j Zy9QYXRoQ0cuY3BwCmluZGV4IDNiOTcyNWE1ZDRjYmQ5YTQ2ZDZiZDc2Y2NlOTdiMmVhNzg3NWQ0 OWIuLjUxNDQ0NGI4NTVkMzg4NTQ0YTY1N2RhMzU1NGJiMTM2Y2I2YmRlMDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENHLmNwcApAQCAtMzAwLDYgKzMw MCw5IEBAIHZvaWQgUGF0aDo6YXBwbHkodm9pZCogaW5mbywgUGF0aEFwcGxpZXJGdW5jdGlvbiBm dW5jdGlvbikgY29uc3QKIAogdm9pZCBQYXRoOjp0cmFuc2Zvcm0oY29uc3QgQWZmaW5lVHJhbnNm b3JtJiB0cmFuc2Zvcm0pCiB7CisgICAgaWYgKHRyYW5zZm9ybS5pc0lkZW50aXR5KCkgfHwgaXNF bXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBDR011dGFibGVQYXRoUmVmIHBhdGggPSBD R1BhdGhDcmVhdGVNdXRhYmxlKCk7CiAgICAgQ0dBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtQ0cg PSB0cmFuc2Zvcm07CiAgICAgQ0dQYXRoQWRkUGF0aChwYXRoLCAmdHJhbnNmb3JtQ0csIG1fcGF0 aCk7Cg==