59965 2011-05-02 15:13:13 -0700 [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled 2011-05-03 14:21:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr alokp enne junov kbr senorblanco twiz vangelis oldest_to_newest 396704 0 jamesr 2011-05-02 15:13:13 -0700 [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled 396711 1 91991 jamesr 2011-05-02 15:18:14 -0700 Created attachment 91991 Patch 396715 2 jamesr 2011-05-02 15:19:28 -0700 This crash is showing up with moderate frequency in recent Chrome releases. It only shows up with the --enable-accelerated-2d-canvas flag on but can be triggered by doing something as simple as resizing the window with a fullscreen canvas demo opened. 396919 3 91991 kbr 2011-05-02 19:37:54 -0700 Comment on attachment 91991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91991&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:207 > +#endif senorblanco should review this. He just added a short-circuit to DrawingBuffer::reset() to do no work if the size hasn't changed, and I have a feeling that making this contentChanged call in all cases may impact performance. 397281 4 91991 senorblanco 2011-05-03 12:56:53 -0700 Comment on attachment 91991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91991&action=review Looks good (unofficially). >> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:207 >> +#endif > > senorblanco should review this. He just added a short-circuit to DrawingBuffer::reset() to do no work if the size hasn't changed, and I have a feeling that making this contentChanged call in all cases may impact performance. I think this is correct. Valid size changes are unaffected; this only changes the case when we're going from valid -> invalid size, in which case we won't be rendering Canvas2D on the GPU anyway and we should definitely tell the compositor. 397307 5 junov 2011-05-03 13:20:35 -0700 *** Bug 60056 has been marked as a duplicate of this bug. *** 397365 6 91991 kbr 2011-05-03 14:03:06 -0700 Comment on attachment 91991 Patch OK, sounds good. 397389 7 91991 jamesr 2011-05-03 14:21:39 -0700 Comment on attachment 91991 Patch Clearing flags on attachment: 91991 Committed r85661: <http://trac.webkit.org/changeset/85661> 397390 8 jamesr 2011-05-03 14:21:42 -0700 All reviewed patches have been landed. Closing bug. 91991 2011-05-02 15:18:14 -0700 2011-05-03 14:21:39 -0700 Patch bug-59965-20110502151813.patch text/plain 6690 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogODU0ODUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5M2Y3YTQzOTRhNDZiYWZlMWEyZjRm YzE2NWY0Y2I3MGQyMDMxMTJiLi42NmQ0ZDMwMDU1ZThlOGYxNDdiMWYzOGIzNWI5YTk4OTI3Nzhh ODk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMDIgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIFJlc2l6aW5nIGEgMmQgY2FudmFzIHRvIGh1Z2UgZGlt ZW5zaW9ucyBhZnRlciBjb21wb3NpdGluZyBjcmFzaGVzIHdpdGggYWNjZWxlcmF0ZWQgMmQgY2Fu dmFzIG9wdGlvbiBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01OTk2NQorCisgICAgICAgIEFkZHMgYSB0ZXN0IHdpdGggYSBjYW52YXMgcmVu ZGVyZWQgb25jZSB3aXRoIG5vcm1hbCB3aWR0aC9oZWlnaHQgZGltZW5zaW9ucyB0aGVuIHJlc2l6 ZWQgdG8gdmVyeSBsYXJnZSBkaW1lbnNpb25zLgorCisgICAgICAgICogZmFzdC9jYW52YXMvY2Fu dmFzLXJlc2l6ZS1hZnRlci1wYWludC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvY2FudmFzL2NhbnZhcy1yZXNpemUtYWZ0ZXItcGFpbnQuaHRtbDogQWRkZWQuCisKIDIwMTEt MDUtMDIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvY2FudmFzLXJlc2l6ZS1hZnRlci1wYWludC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy9jYW52YXMtcmVzaXplLWFmdGVyLXBhaW50LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi43ZWYyMmU5YTQzMWFkMDI3MjcxM2I3MWZkYzg3OTQwMTZjOGVmMTJmCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXJlc2l6ZS1hZnRlci1w YWludC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXJlc2l6ZS1hZnRlci1wYWludC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXJlc2l6ZS1hZnRlci1wYWludC5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjk1NzNjYmY1OTMxYTljMDM0ZWYyNWZhMTg0ZTc5NWRiMWQ4OTBlZjUKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtcmVzaXplLWFmdGVyLXBhaW50 Lmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8Y2FudmFzIGlkPSJjIiB3 aWR0aD0xMDAgaGVpZ2h0PTEwMD48L2NhbnZhcz4KKzwhLS0gVGVzdHMgdGhhdCByZXNpemluZyBh IGNhbnZhcyB0byB2ZXJ5IGxhcmdlIGRpbWVuc2lvbnMgYWZ0ZXIgYSBjb21wb3NpdGUgZG9lcyBu b3QgY3Jhc2ggLS0+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit2YXIgYyA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjIik7CisKK2Z1bmN0aW9uIHJlc2l6ZSgpIHsKKyAgICBjLndpZHRo ICA9ICAiNTAwMCI7CisgICAgYy5oZWlnaHQgPSAiMTAwMDAiOworfQorCitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZGlzcGxheSgp OyAvLyBGb3JjZSBhIGNvbXBvc2l0ZSBhdCBub3JtYWwgd2lkdGgvaGVpZ2h0IHRvIGVuc3VyZSB3 ZSBoYXZlIGEgY29tcG9zaXRpbmcgbGF5ZXIgZm9yIHRoZSBjYW52YXMuCisgICAgcmVzaXplKCk7 Cit9IGVsc2UKKyAgICB3aW5kb3cuc2V0VGltZW91dChyZXNpemUsIDApOworCitkb2N1bWVudC53 cml0ZSgiUEFTUyIpOworPC9zY3JpcHQ+CisKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MzFiMmExN2E0ZmEwOGZj M2FhNjRlZjNiOGUwOWNiYmYzMmZjNTAzLi4xMjNmMzkwMmM0MTg4ZGY1MTkxMDJhMTA4ZTlmMTEw OTdmNDlmNzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMDIgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFJlc2l6aW5nIGEgMmQgY2FudmFz IHRvIGh1Z2UgZGltZW5zaW9ucyBhZnRlciBjb21wb3NpdGluZyBjcmFzaGVzIHdpdGggYWNjZWxl cmF0ZWQgMmQgY2FudmFzIG9wdGlvbiBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTk2NQorCisgICAgICAgIEZpeGVzIGEgZmV3IGJ1Z3Mg bGVhZGluZyB0byBhIGNyYXNoIGlmIGEgY2FudmFzIGFscmVhZHkgYmVpbmcgY29tcG9zaXRlZCB3 YXMgcmVzaXplZCB0byBodWdlIGRpbWVuc2lvbnMuCisKKyAgICAgICAgVGVzdDogZmFzdC9jYW52 YXMvY2FudmFzLXJlc2l6ZS1hZnRlci1wYWludC5odG1sCisKKyAgICAgICAgKiBodG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFz UmVuZGVyaW5nQ29udGV4dDJEOjpyZXNldCk6CisgICAgICAgICAgICBNYXJrIHRoZSBjYW52YXMn cyBsYXllciBhcyBuZWVkaW5nIGEgc3ludGhldGljIHN0eWxlIHJlY2FsY3VsYXRpb24gd2hlbiBj cmVhdGluZyBvciBkZXN0cm95aW5nIHRoZSBiYWNraW5nCisgICAgICAgICAgICBEcmF3aW5nQnVm ZmVyIHNvIHRoYXQgd2UgZXhpdCBjb21wb3NpdGluZyBtb2RlIHByb3Blcmx5IGlmIHdlIGNhbid0 IGhhbmRsZSB0aGUgY2FudmFzIGRpbWVuc2lvbnMuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vQ2FudmFzMkRMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNhbnZhczJETGF5ZXJDaHJvbWl1bTo6c2V0TGF5ZXJSZW5kZXJlcik6CisgICAgICAgICAgICBB ZGQgYSBudWxsIGNoZWNrIGZvciBtX2RyYXdpbmdCdWZmZXIKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmF3aW5n QnVmZmVyOjpjbGVhcik6CisgICAgICAgICAgICBBdm9pZCBjbGVhcmluZyB0aGUgbV9jb250ZXh0 IHBvaW50ZXIgaW4gcmVzZXQoKSAtIHdlIGRlc3Ryb3kgdGhlIERyYXdpbmdCdWZmZXIgd2hlbmV2 ZXIgcmVzZXQoKSBmYWlscywgc28KKyAgICAgICAgICAgIHRoaXMgaXMgdW5uZWNlc3NhcnkuCisK IDIwMTEtMDUtMDIgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCmluZGV4IGZmMTIxNjhiZTFi NGNiZmFlMjI0OWI2MGEzZTQyNDg2ZmQxZWQwZDYuLmUyZjc1MzQ5NmUxMDBkNmQ1ZmZlNTUxMjQw ZjE4MmM0N2RmNDM3ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtMTk1LDE2ICsxOTUsMTYgQEAgdm9p ZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnJlc2V0KCkKICAgICAgICAgaWYgKG1fY29udGV4 dDNEICYmIG1fZHJhd2luZ0J1ZmZlcikgewogICAgICAgICAgICAgaWYgKG1fZHJhd2luZ0J1ZmZl ci0+cmVzZXQoSW50U2l6ZShjYW52YXMoKS0+d2lkdGgoKSwgY2FudmFzKCktPmhlaWdodCgpKSkp IHsKICAgICAgICAgICAgICAgICBjLT5zZXRTaGFyZWRHcmFwaGljc0NvbnRleHQzRChtX2NvbnRl eHQzRC5nZXQoKSwgbV9kcmF3aW5nQnVmZmVyLmdldCgpLCBJbnRTaXplKGNhbnZhcygpLT53aWR0 aCgpLCBjYW52YXMoKS0+aGVpZ2h0KCkpKTsKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJ TkcpCi0gICAgICAgICAgICAgICAgUmVuZGVyQm94KiByZW5kZXJCb3ggPSBjYW52YXMoKS0+cmVu ZGVyQm94KCk7Ci0gICAgICAgICAgICAgICAgaWYgKHJlbmRlckJveCAmJiByZW5kZXJCb3gtPmhh c0xheWVyKCkgJiYgcmVuZGVyQm94LT5sYXllcigpLT5oYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5n KCkpCi0gICAgICAgICAgICAgICAgICAgIHJlbmRlckJveC0+bGF5ZXIoKS0+Y29udGVudENoYW5n ZWQoUmVuZGVyTGF5ZXI6OkNhbnZhc0NoYW5nZWQpOwotI2VuZGlmCiAgICAgICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgICAgIGMtPnNldFNoYXJlZEdyYXBoaWNzQ29udGV4dDNEKDAsIDAs IEludFNpemUoKSk7CiAgICAgICAgICAgICAgICAgbV9kcmF3aW5nQnVmZmVyLmNsZWFyKCk7CiAg ICAgICAgICAgICAgICAgbV9jb250ZXh0M0QuY2xlYXIoKTsKICAgICAgICAgICAgIH0KKyNpZiBV U0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgICAgICAgICBSZW5kZXJCb3gqIHJlbmRl ckJveCA9IGNhbnZhcygpLT5yZW5kZXJCb3goKTsKKyAgICAgICAgICAgIGlmIChyZW5kZXJCb3gg JiYgcmVuZGVyQm94LT5oYXNMYXllcigpICYmIHJlbmRlckJveC0+bGF5ZXIoKS0+aGFzQWNjZWxl cmF0ZWRDb21wb3NpdGluZygpKQorICAgICAgICAgICAgICAgIHJlbmRlckJveC0+bGF5ZXIoKS0+ Y29udGVudENoYW5nZWQoUmVuZGVyTGF5ZXI6OkNhbnZhc0NoYW5nZWQpOworI2VuZGlmCiAgICAg ICAgIH0KICAgICB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3Bw CmluZGV4IDI2YWQzN2EwMzIxMGRkM2YyNTRlNTZiYTI5ZGFkMzM2OTYwNzQ4NmYuLjkyNzU5NTA0 ODFmNzE2MTMxYmE4MmUxYTRlNjA0NWJjNDFhODgxNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ2FudmFzMkRM YXllckNocm9taXVtLmNwcApAQCAtMTE5LDcgKzExOSw3IEBAIHZvaWQgQ2FudmFzMkRMYXllckNo cm9taXVtOjpzZXREcmF3aW5nQnVmZmVyKERyYXdpbmdCdWZmZXIqIGRyYXdpbmdCdWZmZXIpCiAK IHZvaWQgQ2FudmFzMkRMYXllckNocm9taXVtOjpzZXRMYXllclJlbmRlcmVyKExheWVyUmVuZGVy ZXJDaHJvbWl1bSogbmV3TGF5ZXJSZW5kZXJlcikKIHsKLSAgICBpZiAobGF5ZXJSZW5kZXJlcigp ICE9IG5ld0xheWVyUmVuZGVyZXIpIHsKKyAgICBpZiAobGF5ZXJSZW5kZXJlcigpICE9IG5ld0xh eWVyUmVuZGVyZXIgJiYgbV9kcmF3aW5nQnVmZmVyKSB7CiAgICAgICAgIGlmIChtX2RyYXdpbmdC dWZmZXItPmdyYXBoaWNzQ29udGV4dDNEKCkpIHsKICAgICAgICAgICAgIGlmIChsYXllclJlbmRl cmVyKCkpCiAgICAgICAgICAgICAgICAgbGF5ZXJSZW5kZXJlcigpLT5yZW1vdmVDaGlsZENvbnRl eHQobV9kcmF3aW5nQnVmZmVyLT5ncmFwaGljc0NvbnRleHQzRCgpLmdldCgpKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNw cAppbmRleCA4ZTI5M2Y3NzhhOTA1MmZlYWM5NmI5Mzk2NjJlZGRlYjM5ODQwNmJkLi5mZDZlOTUy MzU0ZjdjMjEwNGM1NWUxMjQwMmVkMmEyNTMyYmU2MWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwCkBAIC05Miw4 ICs5Miw2IEBAIHZvaWQgRHJhd2luZ0J1ZmZlcjo6Y2xlYXIoKQogICAgIG1fY29udGV4dC0+Ymlu ZEZyYW1lYnVmZmVyKEdyYXBoaWNzQ29udGV4dDNEOjpGUkFNRUJVRkZFUiwgbV9mYm8pOwogICAg IG1fY29udGV4dC0+ZGVsZXRlRnJhbWVidWZmZXIobV9mYm8pOwogICAgIG1fZmJvID0gMDsKLSAg ICAKLSAgICBtX2NvbnRleHQuY2xlYXIoKTsKIH0KIAogdm9pZCBEcmF3aW5nQnVmZmVyOjpjcmVh dGVTZWNvbmRhcnlCdWZmZXJzKCkK