59963 2011-05-02 14:34:15 -0700 fix failing printing_unittest on win32 2011-05-03 14:14:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth aroben eric ojan tony oldest_to_newest 396671 0 dpranke 2011-05-02 14:34:15 -0700 fix failing printing_unittest on win32 396672 1 91982 dpranke 2011-05-02 14:34:57 -0700 Created attachment 91982 Patch 396852 2 91982 abarth 2011-05-02 18:11:40 -0700 Comment on attachment 91982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91982&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:588 > - # FIXME: scm.py outputs debug logging to stderr. It should probably go to stdout. > - self.assertFalse(err.empty()) > + # FIXME: debug output from the port and scm objects may or may not go > + # to stderr, so there's no point in testing its contents here. > + # self.assertTrue(err.empty()) Generally we don't want commented out code. Maybe just remove it? 396863 3 dpranke 2011-05-02 18:17:04 -0700 Sure, I can do that. 397381 4 dpranke 2011-05-03 14:14:57 -0700 Committed r85658: <http://trac.webkit.org/changeset/85658> 91982 2011-05-02 14:34:57 -0700 2011-05-02 18:11:39 -0700 Patch bug-59963-20110502143456.patch text/plain 1730 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODU1MjAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0MmU4ZTA0NmU2Yzc0Y2EyNTM0ZDM1YTMzZjY2MzYwZjYx Yjk1ZDg1Li4yYTZhMGFjYmQ5OGJhZjRlNzNlNTA1MjIzZGYwZDJlNDliOTEwZjE0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDUtMDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZml4IGZhaWxpbmcg cHJpbnRpbmdfdW5pdHRlc3Qgb24gd2luMzIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU5OTYzCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZ191bml0dGVzdC5weToKKwogMjAxMS0w NS0wMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAg SW5jb3Jwb3JhdGUgYSByZXZpZXcgY29tbWVudCB0aGF0IEkgbWlzdGFrZW5seSBvbWl0dGVkIGZy b20gbXkgbGFzdCBjb21taXQuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZ191bml0dGVzdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3ByaW50aW5nX3VuaXR0 ZXN0LnB5CmluZGV4IDhmMWNiMjYxODNiZWE0ZGU5MTI4ODc1YjE2MDRkNWZhNWYwODU4ZjcuLmM5 MDA4NGViMGFlMGMyYjM3NzljMDU4ODk1MDU1YzcyOWU2NDZlNjUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3ByaW50aW5nX3Vu aXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91 dF9wYWNrYWdlL3ByaW50aW5nX3VuaXR0ZXN0LnB5CkBAIC01ODMsOCArNTgzLDkgQEAgQlVHWCA6 IGZhaWx1cmVzL2V4cGVjdGVkL3RpbWVvdXQuaHRtbCA9IFRJTUVPVVQKICAgICAgICAgcHJpbnRl ciwgZXJyLCBvdXQgPSBzZWxmLmdldF9wcmludGVyKFsnLS12ZXJib3NlJ10pCiAgICAgICAgIHVy ID0gZ2V0X3VuZXhwZWN0ZWRfcmVzdWx0cyhleHBlY3RlZD1GYWxzZSwgcGFzc2luZz1GYWxzZSwg Zmxha3k9RmFsc2UpCiAgICAgICAgIHByaW50ZXIucHJpbnRfdW5leHBlY3RlZF9yZXN1bHRzKHVy KQotICAgICAgICAjIEZJWE1FOiBzY20ucHkgb3V0cHV0cyBkZWJ1ZyBsb2dnaW5nIHRvIHN0ZGVy ci4gSXQgc2hvdWxkIHByb2JhYmx5IGdvIHRvIHN0ZG91dC4KLSAgICAgICAgc2VsZi5hc3NlcnRG YWxzZShlcnIuZW1wdHkoKSkKKyAgICAgICAgIyBGSVhNRTogZGVidWcgb3V0cHV0IGZyb20gdGhl IHBvcnQgYW5kIHNjbSBvYmplY3RzIG1heSBvciBtYXkgbm90IGdvCisgICAgICAgICMgdG8gc3Rk ZXJyLCBzbyB0aGVyZSdzIG5vIHBvaW50IGluIHRlc3RpbmcgaXRzIGNvbnRlbnRzIGhlcmUuCisg ICAgICAgICMgc2VsZi5hc3NlcnRUcnVlKGVyci5lbXB0eSgpKQogICAgICAgICBzZWxmLmFzc2Vy dEZhbHNlKG91dC5lbXB0eSgpKQogCiAgICAgZGVmIHRlc3RfcHJpbnRfdW5leHBlY3RlZF9yZXN1 bHRzX2J1aWxkYm90KHNlbGYpOgo=