59954 2011-05-02 12:27:15 -0700 Need a way to handle CoreIPC messages on the connection work queue 2011-05-02 12:41:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 396550 0 andersca 2011-05-02 12:27:15 -0700 Need a way to handle CoreIPC messages on the connection work queue 396552 1 91957 andersca 2011-05-02 12:29:41 -0700 Created attachment 91957 Patch 396555 2 91957 aroben 2011-05-02 12:34:27 -0700 Comment on attachment 91957 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91957&action=review > Source/WebKit2/ChangeLog:10 > + member function, willProcessMessageOnClientRunLoop which should return true if the message > + was processed and false otherwise. Users of Connection can use addQueueClient to add clients I'd say "should return true if the message should be forwarded to the Connection::Client's run loop for processing and false otherwise". (Note that this reverses the meaning of the return value.) That seems slightly closer in spirit to Cocoa delegate methods that start with "will". > Source/WebKit2/Platform/CoreIPC/Connection.cpp:242 > +void Connection::addQueueClient(QueueClient* queueClient) > +{ > + MutexLocker locker(m_connectionQueueClientsMutex); > + m_connectionQueueClients.append(queueClient); > +} Should we assert that the client isn't already in m_connectionQueueClients? > Source/WebKit2/Platform/CoreIPC/Connection.h:108 > + protected: > + virtual ~QueueClient() { } > + > + public: > + virtual bool willProcessMessageOnClientRunLoop(Connection*, MessageID, ArgumentDecoder*) = 0; Maybe reverse these sections? 396557 3 andersca 2011-05-02 12:41:32 -0700 Committed r85503: <http://trac.webkit.org/changeset/85503> 91957 2011-05-02 12:29:41 -0700 2011-05-02 12:34:27 -0700 Patch bug-59954-20110502122940.patch text/plain 4282 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NTAyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDUtMDIgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIGEgd2F5IHRvIGhhbmRsZSBDb3JlSVBDIG1lc3Nh Z2VzIG9uIHRoZSBjb25uZWN0aW9uIHdvcmsgcXVldWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5OTU0CisKKyAgICAgICAgQWRkIGEgQ29ubmVjdGlv bjo6UXVldWVDbGllbnQgYWJzdHJhY3QgY2xhc3MuIFRoaXMgY2xhc3MgaGFzIGEgc2luZ2xlIHB1 cmUgdmlydHVhbAorICAgICAgICBtZW1iZXIgZnVuY3Rpb24sIHdpbGxQcm9jZXNzTWVzc2FnZU9u Q2xpZW50UnVuTG9vcCB3aGljaCBzaG91bGQgcmV0dXJuIHRydWUgaWYgdGhlIG1lc3NhZ2UKKyAg ICAgICAgd2FzIHByb2Nlc3NlZCBhbmQgZmFsc2Ugb3RoZXJ3aXNlLiBVc2VycyBvZiBDb25uZWN0 aW9uIGNhbiB1c2UgYWRkUXVldWVDbGllbnQgdG8gYWRkIGNsaWVudHMKKyAgICAgICAgYW5kIGFs bCBtZXNzYWdlcyB3aWxsIGJlIGRpc3BhdGNoZWQgdG8gdGhlIHF1ZXVlIGNsaWVudHMgZmlyc3Qu CisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAo Q29yZUlQQzo6Q29ubmVjdGlvbjo6YWRkUXVldWVDbGllbnQpOgorICAgICAgICAoQ29yZUlQQzo6 Q29ubmVjdGlvbjo6cmVtb3ZlUXVldWVDbGllbnQpOgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVj dGlvbjo6cHJvY2Vzc0luY29taW5nTWVzc2FnZSk6CisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQ Qy9Db25uZWN0aW9uLmg6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpRdWV1ZUNsaWVu dDo6flF1ZXVlQ2xpZW50KToKKwogMjAxMS0wNS0wMiAgSmVmZiBNaWxsZXIgIDxqZWZmbUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAkocmV2aXNpb24gODU0 OTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMzUsNiArMjM1LDIxIEBAIHZvaWQgQ29ubmVjdGlvbjo6c2V0U2hv dWxkRXhpdE9uU3luY01lc3MKICAgICBtX3Nob3VsZEV4aXRPblN5bmNNZXNzYWdlU2VuZEZhaWx1 cmUgPSBzaG91bGRFeGl0T25TeW5jTWVzc2FnZVNlbmRGYWlsdXJlOwogfQogCit2b2lkIENvbm5l Y3Rpb246OmFkZFF1ZXVlQ2xpZW50KFF1ZXVlQ2xpZW50KiBxdWV1ZUNsaWVudCkKK3sKKyAgICBN dXRleExvY2tlciBsb2NrZXIobV9jb25uZWN0aW9uUXVldWVDbGllbnRzTXV0ZXgpOworICAgIG1f Y29ubmVjdGlvblF1ZXVlQ2xpZW50cy5hcHBlbmQocXVldWVDbGllbnQpOworfQorCit2b2lkIENv bm5lY3Rpb246OnJlbW92ZVF1ZXVlQ2xpZW50KFF1ZXVlQ2xpZW50KiBxdWV1ZUNsaWVudCkKK3sK KyAgICBNdXRleExvY2tlciBsb2NrZXIobV9jb25uZWN0aW9uUXVldWVDbGllbnRzTXV0ZXgpOwor ICAgIHNpemVfdCBpbmRleCA9IG1fY29ubmVjdGlvblF1ZXVlQ2xpZW50cy5maW5kKHF1ZXVlQ2xp ZW50KTsKKworICAgIEFTU0VSVChpbmRleCAhPSBub3RGb3VuZCk7CisgICAgbV9jb25uZWN0aW9u UXVldWVDbGllbnRzLnJlbW92ZShpbmRleCk7Cit9CisKIHZvaWQgQ29ubmVjdGlvbjo6c2V0RGlk Q2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVDYWxsYmFjayhEaWRDbG9zZU9uQ29ubmVjdGlvbldv cmtRdWV1ZUNhbGxiYWNrIGNhbGxiYWNrKQogewogICAgIEFTU0VSVCghbV9pc0Nvbm5lY3RlZCk7 CkBAIC01MTcsNiArNTMyLDE5IEBAIHZvaWQgQ29ubmVjdGlvbjo6cHJvY2Vzc0luY29taW5nTWVz c2FnZSgKICAgICAgICAgfQogICAgIH0KIAorICAgIC8vIEhhbmQgb2ZmIHRoZSBtZXNzYWdlIHRv IHRoZSBjb25uZWN0aW9uIHF1ZXVlIGNsaWVudHMuCisgICAgeworICAgICAgICBNdXRleExvY2tl ciBsb2NrZXIobV9jb25uZWN0aW9uUXVldWVDbGllbnRzTXV0ZXgpOworCisgICAgICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgbV9jb25uZWN0aW9uUXVldWVDbGllbnRzLnNpemUoKTsgKytpKSB7 CisgICAgICAgICAgICBpZiAobV9jb25uZWN0aW9uUXVldWVDbGllbnRzW2ldLT53aWxsUHJvY2Vz c01lc3NhZ2VPbkNsaWVudFJ1bkxvb3AodGhpcywgaW5jb21pbmdNZXNzYWdlLm1lc3NhZ2VJRCgp LCBpbmNvbWluZ01lc3NhZ2UuYXJndW1lbnRzKCkpKSB7CisgICAgICAgICAgICAgICAgLy8gQSBj b25uZWN0aW9uIHF1ZXVlIGNsaWVudCBoYW5kbGVkIHRoZSBtZXNzYWdlLCBvdXIgd29yayBoZXJl IGlzIGRvbmUuCisgICAgICAgICAgICAgICAgaW5jb21pbmdNZXNzYWdlLnJlbGVhc2VBcmd1bWVu dHMoKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAgIH0K KyAgICB9CisKICAgICBlbnF1ZXVlSW5jb21pbmdNZXNzYWdlKGluY29taW5nTWVzc2FnZSk7CiB9 CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5o CShyZXZpc2lvbiA4NTQ5MykKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29u bmVjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNiArMTAwLDE0IEBAIHB1YmxpYzoKICNl bmRpZgogICAgIH07CiAKKyAgICBjbGFzcyBRdWV1ZUNsaWVudCB7CisgICAgcHJvdGVjdGVkOgor ICAgICAgICB2aXJ0dWFsIH5RdWV1ZUNsaWVudCgpIHsgfQorCisgICAgcHVibGljOgorICAgICAg ICB2aXJ0dWFsIGJvb2wgd2lsbFByb2Nlc3NNZXNzYWdlT25DbGllbnRSdW5Mb29wKENvbm5lY3Rp b24qLCBNZXNzYWdlSUQsIEFyZ3VtZW50RGVjb2RlciopID0gMDsKKyAgICB9OworCiAjaWYgUExB VEZPUk0oTUFDKQogICAgIHR5cGVkZWYgbWFjaF9wb3J0X3QgSWRlbnRpZmllcjsKICNlbGlmIFBM QVRGT1JNKFdJTikKQEAgLTEyOSw3ICsxMzcsMTAgQEAgcHVibGljOgogICAgIC8vIGhhbmRsaW5n IHRoZSBtZXNzYWdlIG9uIHRoZSBjbGllbnQgdGhyZWFkIGZpcnN0LgogICAgIHR5cGVkZWYgdm9p ZCAoKkRpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlQ2FsbGJhY2spKFdvcmtRdWV1ZSYsIENv bm5lY3Rpb24qKTsKICAgICB2b2lkIHNldERpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlQ2Fs bGJhY2soRGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVDYWxsYmFjayBjYWxsYmFjayk7Ci0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKKworICAgIHZv aWQgYWRkUXVldWVDbGllbnQoUXVldWVDbGllbnQqKTsKKyAgICB2b2lkIHJlbW92ZVF1ZXVlQ2xp ZW50KFF1ZXVlQ2xpZW50Kik7CisKICAgICBib29sIG9wZW4oKTsKICAgICB2b2lkIGludmFsaWRh dGUoKTsKICAgICB2b2lkIG1hcmtDdXJyZW50bHlEaXNwYXRjaGVkTWVzc2FnZUFzSW52YWxpZCgp OwpAQCAtMjM0LDYgKzI0NSw5IEBAIHByaXZhdGU6CiAgICAgV29ya1F1ZXVlIG1fY29ubmVjdGlv blF1ZXVlOwogICAgIFJ1bkxvb3AqIG1fY2xpZW50UnVuTG9vcDsKIAorICAgIE11dGV4IG1fY29u bmVjdGlvblF1ZXVlQ2xpZW50c011dGV4OworICAgIFZlY3RvcjxRdWV1ZUNsaWVudCo+IG1fY29u bmVjdGlvblF1ZXVlQ2xpZW50czsKKwogICAgIHVuc2lnbmVkIG1faW5EaXNwYXRjaE1lc3NhZ2VD b3VudDsKICAgICB1bnNpZ25lZCBtX2luRGlzcGF0Y2hNZXNzYWdlTWFya2VkRGlzcGF0Y2hXaGVu V2FpdGluZ0ZvclN5bmNSZXBseUNvdW50OwogICAgIGJvb2wgbV9kaWRSZWNlaXZlSW52YWxpZE1l c3NhZ2U7Cg==