59934 2011-05-02 07:10:07 -0700 [GTK] Media tests relying on video-paint-test.js are still flaky 2011-05-02 07:31:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric.carlson oldest_to_newest 396366 0 pnormand 2011-05-02 07:10:07 -0700 I think it's because we dump the DRT before the media paused and seeked to 0. Example of diff, this shows the slider is not at 0 (I think): --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/video-controls-rendering-expected.txt 2011-05-02 05:29:28.000000000 -0700 +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/video-controls-rendering-actual.txt 2011-05-02 05:29:28.000000000 -0700 @@ -27,7 +27,7 @@ RenderText {#text} at (0,0) size 55x12 text run at (0,0) width 55: "00:00 / 00:06" RenderSlider {INPUT} at (66,0) size 153x20 - RenderBlock {DIV} at (2,4) size 12x12 + RenderBlock {DIV} at (11,4) size 12x12 RenderButton {INPUT} at (240,220) size 20x20 RenderButton {INPUT} at (260,220) size 20x20 RenderButton {INPUT} at (280,220) size 20x20 396370 1 91922 pnormand 2011-05-02 07:16:26 -0700 Created attachment 91922 proposed patch 396380 2 pnormand 2011-05-02 07:31:33 -0700 Committed r85475: <http://trac.webkit.org/changeset/85475> 91922 2011-05-02 07:16:26 -0700 2011-05-02 07:25:19 -0700 proposed patch proposed-patch.patch text/plain 1986 pnormand RnJvbSA2ZThhOWY5YTUxMzRkYjgyMmFiMWUzNTBhZTE4MGNmOTc1ZGJmZmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDIgTWF5IDIwMTEgMTY6MTc6NTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKysrKysrKysKIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBhaW50LXRl c3QuanMgfCAgICA2ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwZmY3OTAwLi5hOWJmNzRjIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MjAgQEAKIDIwMTEtMDUtMDIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IE1lZGlhIHRlc3RzIHJlbHlpbmcgb24gdmlkZW8tcGFpbnQtdGVzdC5qcyBhcmUgc3RpbGwgZmxh a3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5OTM0 CisKKyAgICAgICAgRHVtcCB0aGUgcmVuZGVyIHRyZWUgYWZ0ZXIgdGhlIHZpZGVvIGNvbXBsZXRl ZCB0aGUgc2Vlay4gVGhpcyBpcworICAgICAgICB0byBhdm9pZCBmbGFrZSBoYXBwZW5pbmcgaW4g dGhlIGNvbnRyb2wgc2xpZGVyIG5vdCBhbHdheXMgYmVpbmcgYXQKKyAgICAgICAgYmVnaW5uaW5n IG9mIHRoZSB0aW1lbGluZS4KKworICAgICAgICAqIG1lZGlhL3ZpZGVvLXBhaW50LXRlc3QuanM6 CisgICAgICAgIChpbml0LmRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIuKToKKyAgICAgICAgKGlu aXQpOgorCisyMDExLTA1LTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KKwogICAgICAgICBVbnJldmlld2VkLCByZS1lbmFibGUgd2Vic29ja2V0IHRlc3RzIG9uIEdU Sy4gdGhleSBtb3ZlZCBvdmVyIHRvIGEKICAgICAgICAgcmVhbCBodHRwIHNlcnZlciBhbmQgbW9z dCBvZiB0aGUgZmxha2luZXNzIHdlbnQgYXdheS4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tcGFpbnQtdGVzdC5qcyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBhaW50 LXRlc3QuanMKaW5kZXggMGIzZjAwNGQuLmY0ZjA2OTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL3ZpZGVvLXBhaW50LXRlc3QuanMKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t cGFpbnQtdGVzdC5qcwpAQCAtOSw4ICs5LDEwIEBAIGZ1bmN0aW9uIGluaXQoKQogICAgICAgICAg ICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5lcigicGxheWluZyIsIGZ1bmN0aW9uKCkgewogICAgICAg ICAgICAgICAgIHZpZGVvLnBhdXNlKCk7CiAgICAgICAgICAgICAgICAgdmlkZW8uY3VycmVudFRp bWUgPSAwOwotICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp Ci0gICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsK KyAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCJzZWVrZWQiLCBmdW5jdGlv bigpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKKyAgICAgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAg ZG9jdW1lbnQuYm9keS5vZmZzZXRMZWZ0OwogICAgICAgICB9Ci0tIAoxLjcuNC40