59932 2011-05-02 05:41:44 -0700 [GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24 2011-05-02 09:14:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned mrobinson oldest_to_newest 396346 0 pnormand 2011-05-02 05:41:44 -0700 gdk_drawable_get_size has been deprecated since version 2.24 and should not be used in newly-written code. Use gdk_window_get_width() and gdk_window_get_height() for GdkWindows. Use gdk_pixmap_get_size() for GdkPixmaps. 396349 1 91916 pnormand 2011-05-02 05:51:28 -0700 Created attachment 91916 proposed patch 396403 2 pnormand 2011-05-02 09:14:46 -0700 Committed r85480: <http://trac.webkit.org/changeset/85480> 91916 2011-05-02 05:51:28 -0700 2011-05-02 08:51:19 -0700 proposed patch proposed-patch.patch text/plain 2223 pnormand RnJvbSBjYzk5ODQzYTUwNzJmMGRmMDM1NTk5ZWIwZGQ0ZWJmM2FkZDNjZGQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDIgTWF5IDIwMTEgMTQ6NTI6NDggKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vZ3RrL1dp ZGdldFJlbmRlcmluZ0NvbnRleHQuY3BwICAgICAgICB8ICAgIDUgKysrKysKIDIgZmlsZXMgY2hh bmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTA1 Njc3MC4uZGM3Zjc3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTA1LTAyICBQ aGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBnZGtfZHJhd2FibGVfZ2V0X3Np emUoKSBzaG91bGRuJ3QgYmUgdXNlZCB3aXRoIEdUSysgPj0gMi4yNAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk5MzIKKworICAgICAgICBVc2UgZ2Rr X3dpbmRvd19nZXRfd2lkdGgoKSBhbmQgZ2RrX3dpbmRvd19nZXRfaGVpZ2h0KCkgaWYKKyAgICAg ICAgYXZhaWxhYmxlLCBpbnN0ZWFkIG9mIHRoZSBkZXByZWNhdGVkIGdka19kcmF3YWJsZV9nZXRf c2l6ZSgpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4IG9ubHkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvV2lkZ2V0UmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpXaWRnZXRSZW5kZXJpbmdDb250ZXh0OjpXaWRnZXRSZW5kZXJpbmdDb250ZXh0KToK KwogMjAxMS0wNS0wMSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA2NWJjYWQ2 Li5kNzU5MTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvV2lkZ2V0 UmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dp ZGdldFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC04NCw3ICs4NCwxMiBAQCBXaWRnZXRSZW5kZXJp bmdDb250ZXh0OjpXaWRnZXRSZW5kZXJpbmdDb250ZXh0KEdyYXBoaWNzQ29udGV4dCogZ3JhcGhp Y3NDb250ZXh0LAogICAgIC8vIFdlIG5ldmVyIHdhbnQgdG8gY3JlYXRlIGEgc2NyYXRjaCBidWZm ZXIgbGFyZ2VyIHRoYW4gdGhlIHNpemUgb2Ygb3VyIHRhcmdldCBHZGtEcmF3YWJsZS4KICAgICAv LyBUaGlzIHByZXZlbnRzIGdpYW50IHBpeG1hcCBhbGxvY2F0aW9ucyBmb3IgdmVyeSBsYXJnZSB3 aWRnZXRzIGluIHNtYWxsZXIgdmlld3MuCiAgICAgaW50IG1heFdpZHRoID0gMCwgbWF4SGVpZ2h0 ID0gMDsKKyNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLCAyNCwgMCkKKyAgICBtYXhXaWR0aCA9IGdk a193aW5kb3dfZ2V0X3dpZHRoKGdyYXBoaWNzQ29udGV4dC0+Z2RrV2luZG93KCkpOworICAgIG1h eEhlaWdodCA9IGdka193aW5kb3dfZ2V0X2hlaWdodChncmFwaGljc0NvbnRleHQtPmdka1dpbmRv dygpKTsKKyNlbHNlCiAgICAgZ2RrX2RyYXdhYmxlX2dldF9zaXplKGdyYXBoaWNzQ29udGV4dC0+ Z2RrV2luZG93KCksICZtYXhXaWR0aCwgJm1heEhlaWdodCk7CisjZW5kaWYKICAgICBtX3Rhcmdl dFJlY3Quc2V0U2l6ZShtX3RhcmdldFJlY3Quc2l6ZSgpLnNocnVua1RvKEludFNpemUobWF4V2lk dGgsIG1heEhlaWdodCkpKTsKIAogICAgIC8vIFdpZGdldHMgc29tZXRpbWVzIG5lZWQgdG8gZHJh dyBvdXRzaWRlIHRoZWlyIGJvdW5kYXJpZXMgZm9yIHRoaW5ncyBzdWNoIGFzCi0tIAoxLjcuNC40