59927 2011-05-02 04:52:43 -0700 [SH4] AssemblerLabel does not name a type 2011-05-26 14:59:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 thouraya.andolsi webkit-unassigned ademar barraclough commit-queue darin eric ggaren oliver webkit.review.bot oldest_to_newest 396330 0 thouraya.andolsi 2011-05-02 04:52:43 -0700 Hello, Updating webkit, I have got the following error : error: AssemblerLabel does not name a type. The issue is caused by the work done to Use AssemblerLabel throughout Assembler classes. To fix the problem, I have to change the define order inf MacroAssemblerSH4.h as follow #include "SH4Assembler.h" #include "AbstractMacroAssembler.h" But I'll get a webkit style problem :Alphabetical sorting problem. [build/include_order] [4] I have another solution which is to add: # inculde AbstractMacroAssembler.h in AbstractMacroAssembler.h What do you suggest as a solution? I'm preparing a patch. I think there is the same issue in MIPS platforms. Regards, Thouraya 396338 1 91912 thouraya.andolsi 2011-05-02 05:16:24 -0700 Created attachment 91912 fix issue 396339 2 webkit.review.bot 2011-05-02 05:17:30 -0700 Attachment 91912 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 397105 3 thouraya.andolsi 2011-05-03 09:04:04 -0700 Hello, Any update ? Regards. 402600 4 eric 2011-05-11 20:32:50 -0700 There is a similar fix to this posted for MIPS somewher ein bugzilla. Why do these headers have an ordering dependency? That seems like the real bug! 402734 5 thouraya.andolsi 2011-05-12 00:47:46 -0700 (In reply to comment #4) > There is a similar fix to this posted for MIPS somewher ein bugzilla. Why do these headers have an ordering dependency? That seems like the real bug! Hello, because AbstractMacroAssembler class needs AssemblerLabel struct which is defined in AssemblerBuffer.h file. Or AssemblerBuffer.h is included in "SH4Assembler.h" and not in AbstractMacroAssembler.h. Regards, Thouraya. 404946 6 91912 barraclough 2011-05-16 23:10:08 -0700 Comment on attachment 91912 fix issue sorry! - tried to keep everything working :-) 407933 7 thouraya.andolsi 2011-05-23 06:40:50 -0700 Hello The patch was reviewed more than one week ago but it's not yet added to commit queue? Rgards, Thouraya. 407963 8 91912 eric 2011-05-23 07:31:31 -0700 Comment on attachment 91912 fix issue You may want to set cq? To convey your desire. Why do we need to missort the headers like this? Can't We include the needed header in the other header? 407975 9 94428 thouraya.andolsi 2011-05-23 08:05:13 -0700 Created attachment 94428 fix issue 408004 10 94428 oliver 2011-05-23 09:09:53 -0700 Comment on attachment 94428 fix issue Why do you need this change? no other platforms require AssemblerBuffer to be included in this way. 408005 11 oliver 2011-05-23 09:11:53 -0700 (In reply to comment #10) > (From update of attachment 94428 [details]) > Why do you need this change? no other platforms require AssemblerBuffer to be included in this way. Oh i see, eric is making a bad suggestion for the world of jsc. 408007 12 thouraya.andolsi 2011-05-23 09:13:40 -0700 Hello, (In reply to comment #10) > (From update of attachment 94428 [details]) > Why do you need this change? no other platforms require AssemblerBuffer to be included in this way. MIPS requires changes: they suggested the same solution which is to swap the 2 include files and it was accepted in Bug 60283 Regards, Thouraya. 408008 13 91912 oliver 2011-05-23 09:14:09 -0700 Comment on attachment 91912 fix issue Just set cq? on patches f you are unable to commit yourself. Otherwise reviewers have no indication as to whether they should be using the commit bot or not. 408009 14 91912 commit-queue 2011-05-23 09:40:20 -0700 Comment on attachment 91912 fix issue Clearing flags on attachment: 91912 Committed r87076: <http://trac.webkit.org/changeset/87076> 408010 15 commit-queue 2011-05-23 09:40:26 -0700 All reviewed patches have been landed. Closing bug. 408011 16 darin 2011-05-23 09:41:30 -0700 This is not good. In our project we strive to not create includes that have to be included in a certain order. Each header file is supposed to include everything it depends on. Check-ins like this one go against that basic WebKit design principle. 410413 17 ademar 2011-05-26 07:21:46 -0700 (In reply to comment #16) > This is not good. In our project we strive to not create includes that have to be included in a certain order. Each header file is supposed to include everything it depends on. Check-ins like this one go against that basic WebKit design principle. Any plans on fixing it any other way? (I don't have access to a SH4 environment to test) 410756 18 darin 2011-05-26 12:54:46 -0700 This patch was already landed, so it should be fixed. I do think someone should fix it another way. 410882 19 eric 2011-05-26 14:59:49 -0700 There were a flurry of these patches for all the various ports. This was a recent regression caused by some other Assembler refactor. I never tracked down the change, but I would suspect that Gavin or Oliver or Geoff would know what change it might be. 91912 2011-05-02 05:16:24 -0700 2011-05-23 09:40:20 -0700 fix issue 0090-AssemblerLabel-does-not-name-a-type-issue.patch text/plain 1516 thouraya.andolsi RnJvbSBkMTAxMzQwMDZlOTA5M2QwZTM3OWZhYWZmYjY2ZTMwOTU1NjQ0ODZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG91cmF5YSBBTkRPTFNJIDx0aG91cmF5YS5hbmRvbHNpQHN0 LmNvbT4KRGF0ZTogTW9uLCAyIE1heSAyMDExIDEzOjE3OjMwICswMjAwClN1YmplY3Q6IFtQQVRD SCA5MC85MF0gQXNzZW1ibGVyTGFiZWwgZG9lcyBub3QgbmFtZSBhIHR5cGUgaXNzdWUuCgotLS0K IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgIHwgICAx MSArKysrKysrKysrKwogLi4uL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl clNINC5oICAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZGQwOGZiYi4uOWI1NWY3 OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMDIg IFRob3VyYXlhIEFORE9MU0kgIDx0aG91cmF5YS5hbmRvbHNpQHN0LmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbU0g0XSBBc3NlbWJsZXJMYWJl bCBkb2VzIG5vdCBuYW1lIGEgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTk5MjcKKworICAgICAgICBTSDRBc3NlbWJsZXIuaCBmaWxlIHNob29s ZCBiZSBpbmNsdWRlZCBiZWZvcmUgQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oLgorCisgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0Lmg6CisKIDIwMTEtMDUtMDIgIEdhYm9yIExv a2kgIDxsb2tpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGRmaXggZm9yIEFSTSBhZnRlciBy ODU0NDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJTSDQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJTSDQuaAppbmRleCA1ZWY3YjIwLi45MDM2ZjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCkBAIC0yOSw4ICsyOSw4 IEBACiAKICNpZiBFTkFCTEUoQVNTRU1CTEVSKSAmJiBDUFUoU0g0KQogCi0jaW5jbHVkZSAiQWJz dHJhY3RNYWNyb0Fzc2VtYmxlci5oIgogI2luY2x1ZGUgIlNINEFzc2VtYmxlci5oIgorI2luY2x1 ZGUgIkFic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaCIKICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5o PgogCiBuYW1lc3BhY2UgSlNDIHsKLS0gCjEuNy4yLjMKCg== 94428 2011-05-23 08:05:13 -0700 2011-05-23 09:09:53 -0700 fix issue AssemblerLabel-does-not-name-a-type.patch text/plain 1429 thouraya.andolsi RnJvbSAxNGM0MTgwNzJiMGZhN2E3NmFlNTU5Njc0M2I3NDUxMzVhZjNhOTIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG91cmF5YSBBTkRPTFNJIDx0aG91cmF5YS5hbmRvbHNpQHN0 LmNvbT4KRGF0ZTogTW9uLCAyMyBNYXkgMjAxMSAxNjoxMDoyNSArMDIwMApTdWJqZWN0OiBbUEFU Q0ggMTExLzExMV0gQXNzZW1ibGVyTGFiZWwgZG9lcyBub3QgbmFtZSBhIHR5cGUuCgotLS0KIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgIHwgICAgOSAr KysrKysrKysKIC4uLi9hc3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oICAgICAgICAg ICAgIHwgICAgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDAgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZDhjYWY1NS4uMjExNjVjOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjMgIFRob3Vy YXlhIEFORE9MU0kgIDx0aG91cmF5YS5hbmRvbHNpQHN0LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbU0g0XSBBc3NlbWJsZXJMYWJlbCBkb2Vz IG5vdCBuYW1lIGEgdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTk5MjcKKworICAgICAgICAqIGFzc2VtYmxlci9BYnN0cmFjdE1hY3JvQXNzZW1i bGVyLmg6CisKIDIwMTEtMDUtMjMgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BYnN0cmFjdE1hY3JvQXNzZW1ibGVyLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIu aAppbmRleCA1ZDdjNmU5Li40OWJlNzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaApAQCAtMjgsNiArMjgs NyBAQAogCiAjaW5jbHVkZSAiQ29kZUxvY2F0aW9uLmgiCiAjaW5jbHVkZSAiTWFjcm9Bc3NlbWJs ZXJDb2RlUmVmLmgiCisjaW5jbHVkZSA8QXNzZW1ibGVyQnVmZmVyLmg+CiAjaW5jbHVkZSA8d3Rm L05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL1VudXNlZFBhcmFtLmg+CiAKLS0gCjEuNy4y LjMKCg==