59926 2011-05-02 03:56:03 -0700 Debugger call frame line numbers are inaccurate if your file contains getter or setter declarations 2012-03-11 12:33:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED DUPLICATE 77675 P1 Critical --- 0 rackley webkit-unassigned barraclough BugZilla domenic oldest_to_newest 396322 0 91907 rackley 2011-05-02 03:56:03 -0700 Created attachment 91907 test file to reproduce the problem If you have a file that uses getter/setter syntax similar to TestObject.prototype={ get prop(){ return 0; } } The line numbers become skewed in the parser/debugger call frame. For each one of these in your file, the parser seems to add 2 or 3 extra lines to the current line count. I first noticed this problem when trying to debug the Web Inspector. It is currently impossible to accurately step through the Web Inspector using the debugger since this syntax is used quite frequently by it. I've attached a simple test case that reproduces the problem on the nightly build. There is an html file and script. If you set a breakpoint on line 6 of test.html and step into the function call, you will notice that you step into the function a few lines forward from the proper place. I've verified that this line number is being received from the backend and it isn't a bug in the inspector. This seems to have been happening for a while. This is probably the cause of Bug 42252. 396323 1 91908 rackley 2011-05-02 03:57:03 -0700 Created attachment 91908 test script used by test.html 396691 2 91985 rackley 2011-05-02 14:54:13 -0700 Created attachment 91985 patch to fix the bug 443983 3 BugZilla 2011-07-29 10:27:24 -0700 I encountered this problem too, while trying to debug the LeaksParser. The attached patch fixed it for me, but I don't know enough about the area of code to review it. It is fairly straightforward though. 444068 4 rackley 2011-07-29 13:31:00 -0700 Strange because I think this was fixed by a change made against another bug. When is the last time you did a full update? 444128 5 BugZilla 2011-07-29 15:04:39 -0700 I'm on r91704. 444148 6 rackley 2011-07-29 15:40:57 -0700 I thought this change might have fixed it http://trac.webkit.org/changeset/85456/trunk/Source/JavaScriptCore/parser/JSParser.cpp Sounds like it's not the same fix. 575815 7 barraclough 2012-03-11 12:33:16 -0700 This should be fixed in r106589. If it's not, please reopen bug#77675, that is now tracking this problem. cheers, G. *** This bug has been marked as a duplicate of bug 77675 *** 91907 2011-05-02 03:56:03 -0700 2011-05-02 03:56:03 -0700 test file to reproduce the problem test.html text/html 161 rackley PGh0bWw+CjxoZWFkPgo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJ0ZXN0Lmpz Ij48L3NjcmlwdD4KPHNjcmlwdD4KCXZhciB0byA9IG5ldyBUZXN0T2JqZWN0KCk7Cgl0by5ydW5U ZXN0KCk7Cjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5Pgo8L2JvZHk+CjwvaHRtbD4= 91908 2011-05-02 03:57:03 -0700 2011-05-02 03:57:03 -0700 test script used by test.html test.js application/x-javascript 256 rackley VGVzdE9iamVjdCA9IGZ1bmN0aW9uKCl7Cgp9CgpUZXN0T2JqZWN0LnByb3RvdHlwZT17CiAgICBn ZXQgcHJvcCgpewogICAgICAgIHJldHVybiAwOwogICAgfSwKICAgIGdldCBteVByb3AoKXsKICAg ICAgICByZXR1cm4gMTsKICAgIH0sCiAgICAKICAgIHJ1blRlc3Q6IGZ1bmN0aW9uKCl7CiAgICAg ICAgdmFyIGMgPSAwOwogICAgICAgIAogICAgICAgIHZhciB5ID0gOCArIGM7CiAgICAgICAgcmV0 dXJuIHRoaXMubXlQcm9wICsgeTsKICAgIH0KfQ== 91985 2011-05-02 14:54:13 -0700 2011-05-02 14:54:13 -0700 patch to fix the bug mypatch.txt text/plain 1555 rackley SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCShyZXZpc2lv biA4NTQ1NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAxMCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgUnlh biBBY2tsZXkgKHJ5YW5hY2tsZXlAZ21haWwuY29tKQogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC0xNzQzLDYgKzE3NDQsNyBAQCB0ZW1wbGF0ZSA8Ym9vbCBjb21wbGV0ZSwgY2xh c3MgVHJlZUJ1aWxkCiB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxkZXI+IFRyZWVFeHByZXNzaW9u IEpTUGFyc2VyOjpwYXJzZU9iamVjdExpdGVyYWwoVHJlZUJ1aWxkZXImIGNvbnRleHQpCiB7CiAg ICAgaW50IHN0YXJ0T2Zmc2V0ID0gbV90b2tlbi5tX2RhdGEuaW50VmFsdWU7CisgICAgaW50IHN0 YXJ0TGluZSA9IG1fbGV4ZXItPmxpbmVOdW1iZXIoKTsKICAgICBjb25zdW1lT3JGYWlsKE9QRU5C UkFDRSk7CiAKICAgICBpZiAobWF0Y2goQ0xPU0VCUkFDRSkpIHsKQEAgLTE3NTQsNiArMTc1Niw3 IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3MKICAgICBmYWlsSWZG YWxzZShwcm9wZXJ0eSk7CiAgICAgaWYgKCFtX3N5bnRheEFscmVhZHlWYWxpZGF0ZWQgJiYgY29u dGV4dC5nZXRUeXBlKHByb3BlcnR5KSAhPSBQcm9wZXJ0eU5vZGU6OkNvbnN0YW50KSB7CiAgICAg ICAgIG1fbGV4ZXItPnNldE9mZnNldChzdGFydE9mZnNldCk7CisgICAgICAgIG1fbGV4ZXItPnNl dExpbmVOdW1iZXIoc3RhcnRMaW5lKTsKICAgICAgICAgbmV4dCgpOwogICAgICAgICByZXR1cm4g cGFyc2VTdHJpY3RPYmplY3RMaXRlcmFsKGNvbnRleHQpOwogICAgIH0KQEAgLTE3NjgsNiArMTc3 MSw3IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3MKICAgICAgICAg ZmFpbElmRmFsc2UocHJvcGVydHkpOwogICAgICAgICBpZiAoIW1fc3ludGF4QWxyZWFkeVZhbGlk YXRlZCAmJiBjb250ZXh0LmdldFR5cGUocHJvcGVydHkpICE9IFByb3BlcnR5Tm9kZTo6Q29uc3Rh bnQpIHsKICAgICAgICAgICAgIG1fbGV4ZXItPnNldE9mZnNldChzdGFydE9mZnNldCk7CisgICAg ICAgICAgICBtX2xleGVyLT5zZXRMaW5lTnVtYmVyKHN0YXJ0TGluZSk7CiAgICAgICAgICAgICBu ZXh0KCk7CiAgICAgICAgICAgICByZXR1cm4gcGFyc2VTdHJpY3RPYmplY3RMaXRlcmFsKGNvbnRl eHQpOwogICAgICAgICB9Cg==