59914 2011-05-01 22:01:25 -0700 WebKit2: Crash closing tab with docked Web Inspector 2011-05-02 07:10:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 bweinstein bweinstein aroben timothy oldest_to_newest 396219 0 bweinstein 2011-05-01 22:01:25 -0700 There is a crash closing a tab with a docked web inspector. State isn't being torn down correctly, and the WindowMessageBroadcaster listener isn't being removed. <rdar://problem/9359672> 396221 1 91881 bweinstein 2011-05-01 22:09:25 -0700 Created attachment 91881 [PATCH] fix 396225 2 91881 mitz 2011-05-01 22:14:13 -0700 Comment on attachment 91881 [PATCH] fix View in context: https://bugs.webkit.org/attachment.cgi?id=91881&action=review > Source/WebKit2/ChangeLog:10 > + didn't do the tear that is needed, but is called when we close the web inspector explcitly. typo: “tear that” 396235 3 bweinstein 2011-05-01 22:44:45 -0700 Landed in r85457. 396365 4 aroben 2011-05-02 07:10:04 -0700 Can you make a test for this using TestWebKitAPI? 91881 2011-05-01 22:09:25 -0700 2011-05-01 22:14:13 -0700 [PATCH] fix close_tab_docked_inspector.patch text/plain 4970 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MzU4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzIgQEAKKzIwMTEtMDQtMjkgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IENyYXNoIGNsb3NpbmcgdGFiIHdpdGgg ZG9ja2VkIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU5OTE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MzU5NjcyPgorICAg ICAgICAKKyAgICAgICAgV2hlbiBhIHRhYiBpcyBjbG9zZWQgd2l0aCBhIGRvY2tlZCBpbnNwZWN0 b3IsIGludmFsaWRhdGUgY2FsbGVkIHBsYXRmb3JtQ2xvc2UsIHdoaWNoCisgICAgICAgIGRpZG4n dCBkbyB0aGUgdGVhciB0aGF0IGlzIG5lZWRlZCwgYnV0IGlzIGNhbGxlZCB3aGVuIHdlIGNsb3Nl IHRoZSB3ZWIgaW5zcGVjdG9yIGV4cGxjaXRseS4KKyAgICAgICAgT25lIHBhcnQgb2YgdGVhciBk b3duIHdlIHdlcmVuJ3QgZG9pbmcgaXMgcmVtb3Zpbmcgb3Vyc2VsdmVzIGFzIGEgV2luZG93TWVz c2FnZUJyb2RjYXN0ZXIgbGlzdGVuZXIKKyAgICAgICAgb24gdGhlIGluc3BlY3RlZCB3ZWIgdmll dywgYW5kIHRoaXMgY2FuIGNhdXNlIGNyYXNoZXMuCisgICAgICAgIAorICAgICAgICBUaGlzIHBh dGNoIGFsc28gcmVuYW1lcyBwbGF0Zm9ybUNsb3NlIHRvIHBsYXRmb3JtRGlkQ2xvc2UsIHRvIGJl IGNsZWFyZXIgYWJvdXQgd2hlbiB0aGUgZnVuY3Rpb24KKyAgICAgICAgaXMgY2FsbGVkLgorCisg ICAgICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViSW5zcGVjdG9yUHJveHk6OmludmFsaWRhdGUpOiBDYWxsIGRpZENsb3NlIGluc3RlYWQg b2YgcGxhdGZvcm1DbG9zZS4KKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OmRp ZENsb3NlKTogQ2FsbCBwbGF0Zm9ybURpZENsb3NlIGluc3RlYWQgb2YgcGxhdGZvcm1DbG9zZS4K KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJJ bnNwZWN0b3JQcm94eTo6cGxhdGZvcm1EaWRDbG9zZSk6IFJlbmFtZWQgZnJvbSBwbGF0Zm9ybUNs b3NlLgorICAgICAgICAqIFVJUHJvY2Vzcy93aW4vV2ViSW5zcGVjdG9yUHJveHlXaW4uY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1EaWRDbG9zZSk6IERp dHRvLgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yR3RrLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGlkQ2xvc2UpOiBEaXR0by4K KyAgICAgICAgKiBVSVByb2Nlc3MvcXQvV2ViSW5zcGVjdG9yUHJveHlRdC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybURpZENsb3NlKTogRGl0dG8uCisK IDIwMTEtMDQtMjkgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IG1pdHpwZXR0ZWwuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5z cGVjdG9yUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJJbnNwZWN0b3JQcm94eS5jcHAJKHJldmlzaW9uIDg1MzQyKQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODMsNyAr ODMsNyBAQCBXZWJJbnNwZWN0b3JQcm94eTo6fldlYkluc3BlY3RvclByb3h5KCkKIHZvaWQgV2Vi SW5zcGVjdG9yUHJveHk6OmludmFsaWRhdGUoKQogewogICAgIG1fcGFnZS0+Y2xvc2UoKTsKLSAg ICBwbGF0Zm9ybUNsb3NlKCk7CisgICAgZGlkQ2xvc2UoKTsKIAogICAgIG1fcGFnZSA9IDA7CiAK QEAgLTIyMCw3ICsyMjAsNyBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpkaWRDbG9zZSgpCiAg ICAgICAgIGRldGFjaCgpOwogICAgIH0KIAotICAgIHBsYXRmb3JtQ2xvc2UoKTsKKyAgICBwbGF0 Zm9ybURpZENsb3NlKCk7CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OmJyaW5nVG9Gcm9u dCgpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHku aAkocmV2aXNpb24gODUzNDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVj dG9yUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtMTE1LDcgKzExNSw3IEBAIHByaXZhdGU6CiAK ICAgICBXZWJQYWdlUHJveHkqIHBsYXRmb3JtQ3JlYXRlSW5zcGVjdG9yUGFnZSgpOwogICAgIHZv aWQgcGxhdGZvcm1PcGVuKCk7Ci0gICAgdm9pZCBwbGF0Zm9ybUNsb3NlKCk7CisgICAgdm9pZCBw bGF0Zm9ybURpZENsb3NlKCk7CiAgICAgdm9pZCBwbGF0Zm9ybUJyaW5nVG9Gcm9udCgpOwogICAg IHZvaWQgcGxhdGZvcm1JbnNwZWN0ZWRVUkxDaGFuZ2VkKGNvbnN0IFN0cmluZyYpOwogICAgIHZv aWQgcGxhdGZvcm1BdHRhY2goKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv V2ViSW5zcGVjdG9yR3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvZ3RrL1dlYkluc3BlY3Rvckd0ay5jcHAJKHJldmlzaW9uIDg1MzQyKQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00NSw3ICs0NSw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtT3BlbigpCiAg ICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAotdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZv cm1DbG9zZSgpCit2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybURpZENsb3NlKCkKIHsK ICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCShyZXZpc2lvbiA4NTM0MikK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTE0MSw3ICsxNDEsNyBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5 OjpwbGF0Zm9ybU9wZW4oKQogICAgIG1faW5zcGVjdG9yV2luZG93LmFkb3B0TlMod2luZG93KTsK IH0KIAotdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DbG9zZSgpCit2b2lkIFdlYklu c3BlY3RvclByb3h5OjpwbGF0Zm9ybURpZENsb3NlKCkKIHsKICAgICBbbV9pbnNwZWN0b3JXaW5k b3cuZ2V0KCkgc2V0RGVsZWdhdGU6bmlsXTsKICAgICBbbV9pbnNwZWN0b3JXaW5kb3cuZ2V0KCkg b3JkZXJPdXQ6bmlsXTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9XZWJJbnNw ZWN0b3JQcm94eVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvV2ViSW5zcGVjdG9yUHJveHlRdC5jcHAJKHJldmlzaW9uIDg1MzQyKQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1dlYkluc3BlY3RvclByb3h5UXQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NCw3ICs0NCw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtT3Blbigp CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAotdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxh dGZvcm1DbG9zZSgpCit2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybURpZENsb3NlKCkK IHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdpbi5jcHAJKHJldmlzaW9uIDg1 MzQyKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNwZWN0b3JQcm94eVdp bi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwNSw3ICsyMDUsNyBAQCB2b2lkIFdlYkluc3BlY3Rv clByb3h5OjpwbGF0Zm9ybU9wZW4oKQogICAgIDo6U2hvd1dpbmRvdyhtX2luc3BlY3RvcldpbmRv dywgU1dfU0hPVyk7CiB9CiAKLXZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ2xvc2Uo KQordm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1EaWRDbG9zZSgpCiB7CiAgICAgQVNT RVJUKCFtX2lzQXR0YWNoZWQpOwogICAgIEFTU0VSVCghbV9pc1Zpc2libGUgfHwgbV9pbnNwZWN0 b3JXaW5kb3cpOwo=