59912 2011-05-01 19:42:09 -0700 Automated Bug 5768 test from manual test. 2011-05-06 13:05:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 NEW P2 Normal --- 1 honten webkit-unassigned abarth darin dbates honten rniwa oldest_to_newest 396193 0 honten 2011-05-01 19:42:09 -0700 Automated Bug 5768 test from manual test. 396196 1 91875 honten 2011-05-01 19:45:15 -0700 Created attachment 91875 Patch 396199 2 91875 honten 2011-05-01 19:48:57 -0700 Comment on attachment 91875 Patch The test is originally written by Darin at Bug 5768, but, at the time, it was not automatically run test. So I change the test, please review my change. Thanks, 396200 3 honten 2011-05-01 19:49:34 -0700 BTW, this is originally requested in webkit-meeting Hack-a-thon. (In reply to comment #2) > (From update of attachment 91875 [details]) > The test is originally written by Darin at Bug 5768, but, at the time, it was not automatically run test. > > So I change the test, please review my change. > > Thanks, 396204 4 91875 abarth 2011-05-01 19:58:40 -0700 Comment on attachment 91875 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91875&action=review > LayoutTests/fast/frames/frame-with-noresize-refresh.html:12 > +if (window.layoutTestController) > + layoutTestController.dumpAsText(); > + > +if (window.layoutTestController) > + layoutTestController.dumpChildFramesAsText(); > + > +if (window.layoutTestController) > + layoutTestController.waitUntilDone(); This can all be combined into one if-block. > LayoutTests/fast/frames/frame-with-noresize-refresh.html:14 > +alert("This test checks if multiple frame loading correctly refreshes layout with noresize attribute in frame."); I'd just make this a comment instead of an alert. An alert can be annoying when running the test manually. > LayoutTests/fast/frames/frame-with-noresize-refresh.html:23 > + window.setTimeout(test, 100); Why these set timeouts? They look like race conditions to me. 396260 5 91887 honten 2011-05-01 23:48:48 -0700 Created attachment 91887 Patch 396261 6 91887 honten 2011-05-01 23:50:42 -0700 Comment on attachment 91887 Patch Adam, Could you please review again? I removed settimeout functions and used call back from frame source files. Actually settimeout functions are used from original version, but I suppose my version would be better;-) Thanks, 396514 7 91887 rniwa 2011-05-02 11:46:56 -0700 Comment on attachment 91887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91887&action=review r- due to various nits. > LayoutTests/fast/frames/frame-with-noresize-refresh.html:3 > + It's more helpful to put this in body so that readers can see what the test is testing in the expected result. > LayoutTests/fast/frames/frame-with-noresize-refresh.html:31 > + switch(i) { > + case 1: > + f.src = "resources/frame2.html"; > + break; > + case 2: > + f.src = "resources/frame1.html"; > + break; > + case 3: > + if (window.layoutTestController) > + layoutTestController.notifyDone(); > + break; > + } Do we really need this switch statement? Can't we just do something along the line of: if (!is_frame2 && !called_from_frame2) f.src = "resources/frame2.html"; else if (is_frame2) f.src = "resources/frame1.html"; else { if (window.layoutTestController) layoutTestController.notifyDone(); } > LayoutTests/fast/frames/resources/frame1.html:1 > +<html> No DOCTYPE > LayoutTests/fast/frames/resources/frame1.html:4 > +<head> > +<title>frame1</title> > +</head> Do we need title? > LayoutTests/fast/frames/resources/frame1.html:7 > +Frame 1. > +<div id="msg">First loading. FAIL if you see this message as the final message.</div> Frame 1 and first loading are redundant. You should put either but not both. > LayoutTests/fast/frames/resources/frame1.html:9 > + if(parent.parent.parent.test(false)) Why 3 parents?? > LayoutTests/fast/frames/resources/frame1.html:10 > + document.getElementById('msg').innerText = "SUCCESS to load twice."; I don't think you need to say " to load twice". PASS or SUCCESS suffice. 396515 8 91887 rniwa 2011-05-02 11:47:16 -0700 Comment on attachment 91887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91887&action=review r- due to various nits. > LayoutTests/fast/frames/frame-with-noresize-refresh.html:3 > + It's more helpful to put this in body so that readers can see what the test is testing in the expected result. > LayoutTests/fast/frames/frame-with-noresize-refresh.html:31 > + switch(i) { > + case 1: > + f.src = "resources/frame2.html"; > + break; > + case 2: > + f.src = "resources/frame1.html"; > + break; > + case 3: > + if (window.layoutTestController) > + layoutTestController.notifyDone(); > + break; > + } Do we really need this switch statement? Can't we just do something along the line of: if (!is_frame2 && !called_from_frame2) f.src = "resources/frame2.html"; else if (is_frame2) f.src = "resources/frame1.html"; else { if (window.layoutTestController) layoutTestController.notifyDone(); } > LayoutTests/fast/frames/resources/frame1.html:1 > +<html> No DOCTYPE > LayoutTests/fast/frames/resources/frame1.html:4 > +<head> > +<title>frame1</title> > +</head> Do we need title? > LayoutTests/fast/frames/resources/frame1.html:7 > +Frame 1. > +<div id="msg">First loading. FAIL if you see this message as the final message.</div> Frame 1 and first loading are redundant. You should put either but not both. > LayoutTests/fast/frames/resources/frame1.html:9 > + if(parent.parent.parent.test(false)) Why 3 parents?? > LayoutTests/fast/frames/resources/frame1.html:10 > + document.getElementById('msg').innerText = "SUCCESS to load twice."; I don't think you need to say " to load twice". PASS or SUCCESS suffice. 396534 9 honten 2011-05-02 12:05:57 -0700 Thank you for your review every time. (In reply to comment #8) > > LayoutTests/fast/frames/frame-with-noresize-refresh.html:3 > > + > > It's more helpful to put this in body so that readers can see what the test is testing in the expected result. Actually, we cannot use <body> tag with <frameset> at the same time. Or should I move the message into frame1.html in <body>? > Do we really need this switch statement? Can't we just do something along the line of: > if (!is_frame2 && !called_from_frame2) > f.src = "resources/frame2.html"; > else if (is_frame2) > f.src = "resources/frame1.html"; > else { > if (window.layoutTestController) > layoutTestController.notifyDone(); > } Yes, you are right. This is much clearer than switch version. > > LayoutTests/fast/frames/resources/frame1.html:4 > > +<head> > > +<title>frame1</title> > > +</head> > > Do we need title? No, I can remove them. > > LayoutTests/fast/frames/resources/frame1.html:7 > > +Frame 1. > > +<div id="msg">First loading. FAIL if you see this message as the final message.</div> > > Frame 1 and first loading are redundant. You should put either but not both. I will remain "Frame 1." > > LayoutTests/fast/frames/resources/frame1.html:9 > > + if(parent.parent.parent.test(false)) > > Why 3 parents?? We want to access to the test() function in frame-with-noresize-refresh.html. The first parent is <frame> in frame-with-noresize-refresh.html and the second is <frameset> and the third is <body>. So we need 3 parents. > > LayoutTests/fast/frames/resources/frame1.html:10 > > + document.getElementById('msg').innerText = "SUCCESS to load twice."; > > I don't think you need to say " to load twice". PASS or SUCCESS suffice. Sure. 396547 10 rniwa 2011-05-02 12:24:30 -0700 (In reply to comment #9) > Thank you for your review every time. > > (In reply to comment #8) > > > LayoutTests/fast/frames/frame-with-noresize-refresh.html:3 > > > + > > > > It's more helpful to put this in body so that readers can see what the test is testing in the expected result. > > > Actually, we cannot use <body> tag with <frameset> at the same time. > Or should I move the message into frame1.html in <body>? Oops, I didn't see frameset. You could use console.log() then. 396883 11 92032 honten 2011-05-02 18:45:24 -0700 Created attachment 92032 Patch 396884 12 92032 honten 2011-05-02 18:45:46 -0700 Comment on attachment 92032 Patch Please review again. 397115 13 rniwa 2011-05-03 09:16:45 -0700 (In reply to comment #2) > (From update of attachment 91875 [details]) > The test is originally written by Darin at Bug 5768, but, at the time, it was not automatically run test. > > So I change the test, please review my change. I don't see any test attached on the bug 5768. Where did you get the test? If we're converting a manual test, we should be removing the original manual test. Also, did you make sure the bug 5768 reproduces with this test when the patch is reverted? 397136 14 honten 2011-05-03 09:50:08 -0700 Please click in bug 5768 "unsuccesful attempt at automatic testing" link and you can download zip file which include the test files. I'll remove the manual test. It is really old patch...5 years ago. So the code part which should be applied with the patch. So it is really hard to revert and make the test fail intentionally... (In reply to comment #13) > (In reply to comment #2) > > (From update of attachment 91875 [details] [details]) > > The test is originally written by Darin at Bug 5768, but, at the time, it was not automatically run test. > > > > So I change the test, please review my change. > > I don't see any test attached on the bug 5768. Where did you get the test? If we're converting a manual test, we should be removing the original manual test. Also, did you make sure the bug 5768 reproduces with this test when the patch is reverted? 397138 15 honten 2011-05-03 09:51:18 -0700 > I'll remove the manual test. Oops, so the test is not landed into the current repo. It looks like Darin didn't land it because he couldn't run the test with DumpRenderTree at the time. (In reply to comment #14) > Please click in bug 5768 > "unsuccesful attempt at automatic testing" > link and you can download zip file which include the test files. > > I'll remove the manual test. > > It is really old patch...5 years ago. > > So the code part which should be applied with the patch. So it is really hard to revert and make the test fail intentionally... > > (In reply to comment #13) > > (In reply to comment #2) > > > (From update of attachment 91875 [details] [details] [details]) > > > The test is originally written by Darin at Bug 5768, but, at the time, it was not automatically run test. > > > > > > So I change the test, please review my change. > > > > I don't see any test attached on the bug 5768. Where did you get the test? If we're converting a manual test, we should be removing the original manual test. Also, did you make sure the bug 5768 reproduces with this test when the patch is reverted? 397140 16 rniwa 2011-05-03 09:52:16 -0700 (In reply to comment #14) > Please click in bug 5768 > "unsuccesful attempt at automatic testing" > link and you can download zip file which include the test files. That's written by mitz, not darin. > So the code part which should be applied with the patch. So it is really hard to revert and make the test fail intentionally... Then how do we know that your test is testing what it claims to test? 397144 17 honten 2011-05-03 09:59:27 -0700 According to Bug 5768, the problem is twice frame loading with noresize attribute. Of course, we don't have to include the bug, we shouldn't land it. But I think the test pattern itself is reasonable to check if multiple time frame loading is working or not. And, as I wrote here, this is originally pointed out to convert by dbates@ at last week webkit meeting. What do you think? (In reply to comment #16) > (In reply to comment #14) > > Please click in bug 5768 > > "unsuccesful attempt at automatic testing" > > link and you can download zip file which include the test files. > > That's written by mitz, not darin. > > > So the code part which should be applied with the patch. So it is really hard to revert and make the test fail intentionally... > > Then how do we know that your test is testing what it claims to test? 397152 18 rniwa 2011-05-03 10:14:17 -0700 (In reply to comment #17) > According to Bug 5768, the problem is twice frame loading with noresize attribute. > > Of course, we don't have to include the bug, we shouldn't land it. I don't really understand what you mean but I don't think we should be speculatively adding a new test. 397163 19 honten 2011-05-03 10:20:36 -0700 I mean, if the test is not needed, we don't have to land it. I don't have final judgement;-) Ok, I just leave it. But we might need to make sure dbates@ who originally ask us to make the test run automatically. (In reply to comment #18) > (In reply to comment #17) > > According to Bug 5768, the problem is twice frame loading with noresize attribute. > > > > Of course, we don't have to include the bug, we shouldn't land it. > > I don't really understand what you mean but I don't think we should be speculatively adding a new test. 399722 20 92032 dbates 2011-05-06 12:23:37 -0700 Comment on attachment 92032 Patch This test seems better suited as a pixel-test/repainting-test instead of a text-only test because the description for bug #5768 (https://bugs.webkit.org/show_bug.cgi?id=5768#c0), in particular the last two sentences, describes a painting/repainting issue. This also coincides with the changes described in the patch for the bug (and additional bug comments) and the omission of dumpAsText() from the manual test case that were landed in changeset 11648, <http://trac.webkit.org/changeset/11648>. I am hesitant to land a test that differs much from the original test case since we are working with limited information due to the amount of time that has elapsed since bug #5768 was fixed. 399750 21 honten 2011-05-06 13:05:05 -0700 David, Thank you for your comment. I'm not an expert for DumpRenderTree(), so I leave the problem. If I have time, I'll investigate more. (In reply to comment #20) > (From update of attachment 92032 [details]) > This test seems better suited as a pixel-test/repainting-test instead of a text-only test because the description for bug #5768 (https://bugs.webkit.org/show_bug.cgi?id=5768#c0), in particular the last two sentences, describes a painting/repainting issue. This also coincides with the changes described in the patch for the bug (and additional bug comments) and the omission of dumpAsText() from the manual test case that were landed in changeset 11648, <http://trac.webkit.org/changeset/11648>. > > I am hesitant to land a test that differs much from the original test case since we are working with limited information due to the amount of time that has elapsed since bug #5768 was fixed. 91875 2011-05-01 19:45:15 -0700 2011-05-01 23:48:41 -0700 Patch bug-59912-20110501194514.patch text/plain 3751 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODUzNjkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YTU4ZGZiYzJlMTkyNDI2NmE4ZmJj MWFkOTRhNDk2NDEzZGMzNDZiLi45Y2IyNjBjZjQxYThkN2NjOWFkOWIyZTBmNTE2NWYxMTBkODM0 ZjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDEgIE5hb2tpIFRha2FubyAgPHRh a2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXV0b21hdGVkIEJ1ZyA1NzY4IHRlc3QgZnJvbSBtYW51YWwgdGVzdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5OTEyCisK KyAgICAgICAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY4 LgorICAgICAgICBJIG1hZGUgdGhlIHRlc3Qgb3JpZ2luYWxseSB3cml0dGVuIGJ5IERhcmluIHRv IHJ1biBhdXRvbWF0aWNhbGx5LgorCisgICAgICAgICogZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1u b3Jlc2l6ZS1yZWZyZXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFt ZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTEuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9m cmFtZXMvcmVzb3VyY2VzL2ZyYW1lMi5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0yOSAgS2VubmV0 aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gTWVyZ2Vk IGluIGFsbCBkb3duc3RyZWFtIENocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUt cmVmcmVzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzkzOTFiYTQ0ZjFlNGQyNjc0ZTlhMzJh OGRmNjZmZmJiYTY0YWFmYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJh bWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUtcmVmcmVzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3 IEBACitBTEVSVDogVGhpcyB0ZXN0IGNoZWNrcyBpZiBtdWx0aXBsZSBmcmFtZSBsb2FkaW5nIGNv cnJlY3RseSByZWZyZXNoZXMgbGF5b3V0IHdpdGggbm9yZXNpemUgYXR0cmlidXRlIGluIGZyYW1l LgorCisKKy0tLS0tLS0tCitGcmFtZTogJ2YnCistLS0tLS0tLQorRnJhbWUgMQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS13aXRoLW5vcmVzaXplLXJlZnJlc2gu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5mM2JlZDAzYmJiYjAzY2Y0MDhmNTE0YTg4MmZkMDQ1NTllY2IzZDAw Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1u b3Jlc2l6ZS1yZWZyZXNoLmh0bWwKQEAgLTAsMCArMSw0OCBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBDaGlsZEZy YW1lc0FzVGV4dCgpOworCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxh eW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKworYWxlcnQoIlRoaXMgdGVzdCBj aGVja3MgaWYgbXVsdGlwbGUgZnJhbWUgbG9hZGluZyBjb3JyZWN0bHkgcmVmcmVzaGVzIGxheW91 dCB3aXRoIG5vcmVzaXplIGF0dHJpYnV0ZSBpbiBmcmFtZS4iKTsKKwordmFyIGkgPSAwOworZnVu Y3Rpb24gdGVzdCgpCit7CisgICAgaSsrOworICAgIHZhciBmID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2YnKTsKKyAgICBzd2l0Y2goaSkgeworICAgICAgICBjYXNlIDE6CisgICAgICAgICAg ICB3aW5kb3cuc2V0VGltZW91dCh0ZXN0LCAxMDApOworICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIGNhc2UgMjoKKyAgICAgICAgICAgIGYuc3JjID0gInJlc291cmNlcy9mcmFtZTIuaHRtbCI7 CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSAzOgorICAgICAgICAgICAgd2luZG93 LnNldFRpbWVvdXQodGVzdCwgMTAwKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNl IDQ6CisgICAgICAgICAgICBmLnNyYyA9ICJyZXNvdXJjZXMvZnJhbWUxLmh0bWwiOworICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgNToKKyAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1l b3V0KHRlc3QsIDEwMCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSA2OgorICAg ICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICBicmVhazsK KyAgICB9Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxmcmFtZXNldD4KKyAgICA8ZnJhbWUgb25s b2FkPSJ0ZXN0KCkiIGlkPSJmIiBzcmM9InJlc291cmNlcy9mcmFtZTEuaHRtbCIgbm9yZXNpemU+ Cis8L2ZyYW1lc2V0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFt ZXMvcmVzb3VyY2VzL2ZyYW1lMS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvcmVzb3Vy Y2VzL2ZyYW1lMS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM3ZDNhYTc0NmM3ZGRlOTgwYzExNDg3N2EyZGYz Mzg5ZDQzZTdhMGEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9y ZXNvdXJjZXMvZnJhbWUxLmh0bWwKQEAgLTAsMCArMSw4IEBACis8aHRtbD4KKzxoZWFkPgorPHRp dGxlPmZyYW1lMTwvdGl0bGU+Cis8L2hlYWQ+Cis8Ym9keT4KK0ZyYW1lIDEKKzwvYm9keT4KKzwv aHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFt ZTIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTIuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4wZDI4YjU4MzI1NGE2NzI1YzljMGI3OWNiNWMyZTJiOGQ1MmJlYjExCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvcmVzb3VyY2VzL2ZyYW1lMi5o dG1sCkBAIC0wLDAgKzEsOCBAQAorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5mcmFtZTI8L3RpdGxl PgorPC9oZWFkPgorPGJvZHk+CitGcmFtZSAyCis8L2JvZHk+Cis8L2h0bWw+Cg== 91887 2011-05-01 23:48:48 -0700 2011-05-02 18:45:18 -0700 Patch bug-59912-20110501234847.patch text/plain 3732 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODUzNjkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YTU4ZGZiYzJlMTkyNDI2NmE4ZmJj MWFkOTRhNDk2NDEzZGMzNDZiLi45Y2IyNjBjZjQxYThkN2NjOWFkOWIyZTBmNTE2NWYxMTBkODM0 ZjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDEgIE5hb2tpIFRha2FubyAgPHRh a2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXV0b21hdGVkIEJ1ZyA1NzY4IHRlc3QgZnJvbSBtYW51YWwgdGVzdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5OTEyCisK KyAgICAgICAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY4 LgorICAgICAgICBJIG1hZGUgdGhlIHRlc3Qgb3JpZ2luYWxseSB3cml0dGVuIGJ5IERhcmluIHRv IHJ1biBhdXRvbWF0aWNhbGx5LgorCisgICAgICAgICogZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1u b3Jlc2l6ZS1yZWZyZXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFt ZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTEuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9m cmFtZXMvcmVzb3VyY2VzL2ZyYW1lMi5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0yOSAgS2VubmV0 aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gTWVyZ2Vk IGluIGFsbCBkb3duc3RyZWFtIENocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUt cmVmcmVzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjg3ZmY4YzgzZjYzMmZiMGM5ZDBkOWI2 YzJiYTc2YTBjOTk5ZGI4YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJh bWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUtcmVmcmVzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3 IEBACisKKworLS0tLS0tLS0KK0ZyYW1lOiAnZicKKy0tLS0tLS0tCitGcmFtZSAxLgorU1VDQ0VT UyB0byBsb2FkIHR3aWNlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJh bWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9m cmFtZS13aXRoLW5vcmVzaXplLXJlZnJlc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45NDEyZDA3YWU4NDc5 NmNjYzNmY2Q5ZWI5ZWRjMTc5Y2NiZjg5NWEwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWwKQEAgLTAsMCAr MSwzOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzwhLS1UaGlzIHRlc3QgY2hlY2tzIGlm IG11bHRpcGxlIGZyYW1lIGxvYWRpbmcgY29ycmVjdGx5IHJlZnJlc2hlcyBsYXlvdXQgd2l0aCBu b3Jlc2l6ZSBhdHRyaWJ1dGUgaW4gZnJhbWUuLS0+Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBDaGlsZEZyYW1lc0FzVGV4 dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKwordmFy IGNhbGxlZF9mcm9tX2ZyYW1lMiA9IGZhbHNlOworCit2YXIgaSA9IDA7CitmdW5jdGlvbiB0ZXN0 KGlzX2ZyYW1lMikKK3sKKyAgICBjYWxsZWRfZnJvbV9mcmFtZTIgfD0gaXNfZnJhbWUyOworICAg IGkrKzsKKyAgICB2YXIgZiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmJyk7CisgICAgc3dp dGNoKGkpIHsKKyAgICAgICAgY2FzZSAxOgorICAgICAgICAgICAgZi5zcmMgPSAicmVzb3VyY2Vz L2ZyYW1lMi5odG1sIjsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIDI6CisgICAg ICAgICAgICBmLnNyYyA9ICJyZXNvdXJjZXMvZnJhbWUxLmh0bWwiOworICAgICAgICAgICAgYnJl YWs7CisgICAgICAgIGNhc2UgMzoKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u ZSgpOworICAgICAgICAgICAgYnJlYWs7CisgICAgfQorICAgIHJldHVybiBjYWxsZWRfZnJvbV9m cmFtZTI7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxmcmFtZXNldD4KKyAgICA8ZnJhbWUgaWQ9 ImYiIHNyYz0icmVzb3VyY2VzL2ZyYW1lMS5odG1sIiBub3Jlc2l6ZT4KKzwvZnJhbWVzZXQ+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvZnJh bWUxLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvZnJhbWUxLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uMTNlZDFlZDBhODVmNmQ5ZmJhOWQyODAwYzkwNTUyOTA3M2FiMDZkYgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTEu aHRtbApAQCAtMCwwICsxLDEzIEBACis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPmZyYW1lMTwvdGl0 bGU+Cis8L2hlYWQ+Cis8Ym9keT4KK0ZyYW1lIDEuCis8ZGl2IGlkPSJtc2ciPkZpcnN0IGxvYWRp bmcuIEZBSUwgaWYgeW91IHNlZSB0aGlzIG1lc3NhZ2UgYXMgdGhlIGZpbmFsIG1lc3NhZ2UuPC9k aXY+Cis8c2NyaXB0PgorICBpZihwYXJlbnQucGFyZW50LnBhcmVudC50ZXN0KGZhbHNlKSkKKyAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbXNnJykuaW5uZXJUZXh0ID0gIlNVQ0NFU1MgdG8g bG9hZCB0d2ljZS4iOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvZnJhbWUyLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvZnJhbWUyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTNjZjhiMTE4 MzM2MjUwYjBhNzdjNjdiYjVkNDIxZWI4Zjg2OWMzNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTIuaHRtbApAQCAtMCwwICsxLDExIEBA Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPmZyYW1lMjwvdGl0bGU+Cis8L2hlYWQ+Cis8Ym9keT4K K0ZyYW1lIDIKKzxzY3JpcHQ+CisgIHBhcmVudC5wYXJlbnQucGFyZW50LnRlc3QodHJ1ZSk7Cis8 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 92032 2011-05-02 18:45:24 -0700 2011-05-06 12:23:37 -0700 Patch bug-59912-20110502184522.patch text/plain 3698 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODUzNjkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YTU4ZGZiYzJlMTkyNDI2NmE4ZmJj MWFkOTRhNDk2NDEzZGMzNDZiLi45Y2IyNjBjZjQxYThkN2NjOWFkOWIyZTBmNTE2NWYxMTBkODM0 ZjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMDEgIE5hb2tpIFRha2FubyAgPHRh a2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXV0b21hdGVkIEJ1ZyA1NzY4IHRlc3QgZnJvbSBtYW51YWwgdGVzdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5OTEyCisK KyAgICAgICAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY4 LgorICAgICAgICBJIG1hZGUgdGhlIHRlc3Qgb3JpZ2luYWxseSB3cml0dGVuIGJ5IERhcmluIHRv IHJ1biBhdXRvbWF0aWNhbGx5LgorCisgICAgICAgICogZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1u b3Jlc2l6ZS1yZWZyZXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFt ZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTEuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9m cmFtZXMvcmVzb3VyY2VzL2ZyYW1lMi5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0yOSAgS2VubmV0 aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gTWVyZ2Vk IGluIGFsbCBkb3duc3RyZWFtIENocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUt cmVmcmVzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjExZWRlNmEyNDEzOTU3MDkwMTU0YmMz YmRlZGFmNzk3MGY0NDgzZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJh bWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUtcmVmcmVzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4 IEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgNTogVGhpcyB0ZXN0IGNoZWNrcyBpZiBtdWx0aXBs ZSBmcmFtZSBsb2FkaW5nIGNvcnJlY3RseSByZWZyZXNoZXMgbGF5b3V0IHdpdGggbm9yZXNpemUg YXR0cmlidXRlIGluIGZyYW1lLgorCisKKy0tLS0tLS0tCitGcmFtZTogJ2YnCistLS0tLS0tLQor RnJhbWUgMQorU1VDQ0VTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJh bWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9m cmFtZS13aXRoLW5vcmVzaXplLXJlZnJlc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mZTFjNzQzOWQzNmJl YWY0ZjUxZTIzZTA0ZjRhNTcxNDY4OWU4MzkxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1yZWZyZXNoLmh0bWwKQEAgLTAsMCAr MSwzNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2NvbnNv bGUubG9nKCJUaGlzIHRlc3QgY2hlY2tzIGlmIG11bHRpcGxlIGZyYW1lIGxvYWRpbmcgY29ycmVj dGx5IHJlZnJlc2hlcyBsYXlvdXQgd2l0aCBub3Jlc2l6ZSBhdHRyaWJ1dGUgaW4gZnJhbWUuIik7 CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENoaWxk RnJhbWVzQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgp OworfQorCit2YXIgY2FsbGVkX2Zyb21fZnJhbWUyID0gZmFsc2U7CisKK2Z1bmN0aW9uIHRlc3Qo aXNfZnJhbWUyKQoreworICAgIGNhbGxlZF9mcm9tX2ZyYW1lMiB8PSBpc19mcmFtZTI7CisKKyAg ICB2YXIgZiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmJyk7CisgICAgaWYgKCFpc19mcmFt ZTIgJiYgIWNhbGxlZF9mcm9tX2ZyYW1lMikKKyAgICAgICAgZi5zcmMgPSAicmVzb3VyY2VzL2Zy YW1lMi5odG1sIjsKKyAgICBlbHNlIGlmIChpc19mcmFtZTIpCisgICAgICAgIGYuc3JjID0gInJl c291cmNlcy9mcmFtZTEuaHRtbCI7CisgICAgZWxzZSB7CisgICAgICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7CisgICAgfQorCisgICAgcmV0dXJuIGNhbGxlZF9mcm9tX2ZyYW1lMjsKK30KKzwv c2NyaXB0PgorPC9oZWFkPgorPGZyYW1lc2V0PgorICAgIDxmcmFtZSBpZD0iZiIgc3JjPSJyZXNv dXJjZXMvZnJhbWUxLmh0bWwiIG5vcmVzaXplPgorPC9mcmFtZXNldD4KKzwvaHRtbD4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTEuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTEuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42 ZDE4NTY0YmY2NmIxZmMxMmIwNjI2OGZlMTJiNWZkNTk5NDMzNDM1Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvcmVzb3VyY2VzL2ZyYW1lMS5odG1sCkBAIC0wLDAg KzEsMTEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KK0ZyYW1lIDEKKzxkaXYg aWQ9Im1zZyI+RkFJTCBpZiB5b3Ugc2VlIHRoaXMgbWVzc2FnZSBhcyB0aGUgZmluYWwgbWVzc2Fn ZS48L2Rpdj4KKzxzY3JpcHQ+CisgIGlmKHBhcmVudC5wYXJlbnQucGFyZW50LnRlc3QoZmFsc2Up KQorICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdtc2cnKS5pbm5lclRleHQgPSAiU1VDQ0VT UyI7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9mcmFtZTIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJh bWVzL3Jlc291cmNlcy9mcmFtZTIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hNjA3ODg2MmU4YzBmMDgxMmZl ODM5MjU5MDRmZTdiZTA4MDRlZTE5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9mcmFtZXMvcmVzb3VyY2VzL2ZyYW1lMi5odG1sCkBAIC0wLDAgKzEsOSBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxib2R5PgorRnJhbWUgMgorPHNjcmlwdD4KKyAgcGFyZW50LnBhcmVu dC5wYXJlbnQudGVzdCh0cnVlKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=