59886 2011-05-01 13:28:50 -0700 REGRESSIONS (r71934, r74787): In standalone media documents, (double-)clicking the media element doesn’t play/pause, clicking outside it does 2011-05-02 16:27:21 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov InRadar, Regression P1 Major --- 59976 1 mitz inferno dglazkov eric.carlson inferno oldest_to_newest 396021 0 mitz 2011-05-01 13:28:50 -0700 <rdar://problem/9319469> In a standalone media document, such as the URL, clicking the video element should pause it and double-clicking it should resume playback. Clicking and double-clicking in the background should have no effect. r71934 broke the clicking/double-clicking the video behavior. r74787 made it so clicking/double-clicking the background pauses/plays the video. Both are wrong. 396025 1 mitz 2011-05-01 13:33:21 -0700 The mistake in r74787 is obvious (not checking the target element). 396081 2 inferno 2011-05-01 15:59:40 -0700 Sorry about the regression. I accidently assumed the descendant node check on mouse click, double click events(code cleanup) while fixing a sec bug on key down event which does do the descendants check on target node. uploading a fix soon. 396097 3 91859 inferno 2011-05-01 16:36:28 -0700 Created attachment 91859 Patch 396243 4 inferno 2011-05-01 22:59:56 -0700 Committed r85458: <http://trac.webkit.org/changeset/85458> 396245 5 inferno 2011-05-01 23:01:05 -0700 Thank you Eric. Filed https://bugs.webkit.org/show_bug.cgi?id=59917 to cover regression from r71934. 91859 2011-05-01 16:36:28 -0700 2011-05-01 21:25:18 -0700 Patch bug-59886-20110501163627.patch text/plain 2553 inferno SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NDM0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMDEgIEFiaGlzaGVr IEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZWdyZXNzaW9uKHI3NDc4Nyk6IE1lZGlhIGRvY3VtZW50 IG1vdXNlIGNsaWNrIGFuZCBkb3VibGUtY2xpY2sKKyAgICAgICAgZXZlbnRzIHNob3VsZCBiZSBj aGVja2VkIG9uIHRhcmdldCBub2RlIG9ubHkgYW5kIG5vdCBpdHMgZGVzY2VuZGFudHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTg4NgorCisgICAg ICAgICogaHRtbC9NZWRpYURvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRG9j dW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorCiAyMDExLTA1LTAxICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRG9jdW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFEb2N1bWVudC5jcHAJKHJldmlzaW9uIDg1 MzI5KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYURvY3VtZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTU0LDIxICsxNTQsMjYgQEAgdm9pZCBNZWRpYURvY3VtZW50OjpkZWZhdWx0RXZl bnRIYW5kbGVyKAogICAgIGlmICghdGFyZ2V0Tm9kZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg SFRNTFZpZGVvRWxlbWVudCogdmlkZW8gPSBkZXNjZW5kZW50VmlkZW9FbGVtZW50KHRhcmdldE5v ZGUpOwotICAgIGlmICghdmlkZW8pCi0gICAgICAgIHJldHVybjsKLQotICAgIGlmIChldmVudC0+ dHlwZSgpID09IGV2ZW50TmFtZXMoKS5jbGlja0V2ZW50KSB7Ci0gICAgICAgIGlmICghdmlkZW8t PmNhblBsYXkoKSkgewotICAgICAgICAgICAgdmlkZW8tPnBhdXNlKGV2ZW50LT5mcm9tVXNlckdl c3R1cmUoKSk7Ci0gICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKLSAgICAg ICAgfQotICAgIH0gZWxzZSBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkuZGJsY2xp Y2tFdmVudCkgewotICAgICAgICBpZiAodmlkZW8tPmNhblBsYXkoKSkgewotICAgICAgICAgICAg dmlkZW8tPnBsYXkoZXZlbnQtPmZyb21Vc2VyR2VzdHVyZSgpKTsKLSAgICAgICAgICAgIGV2ZW50 LT5zZXREZWZhdWx0SGFuZGxlZCgpOworICAgIGlmICh0YXJnZXROb2RlLT5oYXNUYWdOYW1lKHZp ZGVvVGFnKSkgeworICAgICAgICBIVE1MVmlkZW9FbGVtZW50KiB2aWRlbyA9IHN0YXRpY19jYXN0 PEhUTUxWaWRlb0VsZW1lbnQqPih0YXJnZXROb2RlKTsKKyAgICAgICAgaWYgKGV2ZW50LT50eXBl KCkgPT0gZXZlbnROYW1lcygpLmNsaWNrRXZlbnQpIHsKKyAgICAgICAgICAgIGlmICghdmlkZW8t PmNhblBsYXkoKSkgeworICAgICAgICAgICAgICAgIHZpZGVvLT5wYXVzZShldmVudC0+ZnJvbVVz ZXJHZXN0dXJlKCkpOworICAgICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgp OworICAgICAgICAgICAgfQorICAgICAgICB9IGVsc2UgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZl bnROYW1lcygpLmRibGNsaWNrRXZlbnQpIHsKKyAgICAgICAgICAgIGlmICh2aWRlby0+Y2FuUGxh eSgpKSB7CisgICAgICAgICAgICAgICAgdmlkZW8tPnBsYXkoZXZlbnQtPmZyb21Vc2VyR2VzdHVy ZSgpKTsKKyAgICAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKKyAgICAg ICAgICAgIH0KICAgICAgICAgfQotICAgIH0gZWxzZSBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVu dE5hbWVzKCkua2V5ZG93bkV2ZW50ICYmIGV2ZW50LT5pc0tleWJvYXJkRXZlbnQoKSkgeworICAg IH0KKyAgICAKKyAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkua2V5ZG93bkV2 ZW50ICYmIGV2ZW50LT5pc0tleWJvYXJkRXZlbnQoKSkgeworICAgICAgICBIVE1MVmlkZW9FbGVt ZW50KiB2aWRlbyA9IGRlc2NlbmRlbnRWaWRlb0VsZW1lbnQodGFyZ2V0Tm9kZSk7CisgICAgICAg IGlmICghdmlkZW8pCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgS2V5Ym9hcmRFdmVu dCoga2V5Ym9hcmRFdmVudCA9IHN0YXRpY19jYXN0PEtleWJvYXJkRXZlbnQqPihldmVudCk7CiAg ICAgICAgIGlmIChrZXlib2FyZEV2ZW50LT5rZXlJZGVudGlmaWVyKCkgPT0gIlUrMDAyMCIpIHsg Ly8gc3BhY2UKICAgICAgICAgICAgIGlmICh2aWRlby0+cGF1c2VkKCkpIHsK