59884 2011-05-01 12:14:02 -0700 Move scm.py into its own module in preparation for splitting it up 2011-05-01 12:20:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth webkit.review.bot oldest_to_newest 395987 0 eric 2011-05-01 12:14:02 -0700 Move scm.py into its own module in preparation for splitting it up 395992 1 91833 eric 2011-05-01 12:18:04 -0700 Created attachment 91833 Patch 395993 2 webkit.review.bot 2011-05-01 12:19:21 -0700 Attachment 91833 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 51, in <module> from webkitpy.style_references import detect_checkout File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style_references.py", line 47, in <module> from webkitpy.common.checkout.scm import detect_scm_system File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py", line 4, in <module> from .scm import SCM, SVN, Git, CommitMessage, detect_scm_system, find_checkout_root, default_scm, AuthenticationError, AmbiguousCommitError, CheckoutNeedsUpdate ImportError: No module named scm If any of these errors are false positives, please file a bug against check-webkit-style. 395994 3 91833 abarth 2011-05-01 12:19:36 -0700 Comment on attachment 91833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91833&action=review > Tools/Scripts/webkitpy/test/main.py:153 > + # unittest.main has horrible error reporting when module imports are bad > + # so we test import here to make debugging bad imports much easier. > + for module in modules: > + __import__(module) Is this related? 395995 4 eric 2011-05-01 12:20:24 -0700 (In reply to comment #3) > (From update of attachment 91833 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91833&action=review > > > Tools/Scripts/webkitpy/test/main.py:153 > > + # unittest.main has horrible error reporting when module imports are bad > > + # so we test import here to make debugging bad imports much easier. > > + for module in modules: > > + __import__(module) > > Is this related? It made it posible to track down the import problems with making changes like this. It would have made tracking down your PIL problem super-easy. 395996 5 eric 2011-05-01 12:20:57 -0700 Committed r85427: <http://trac.webkit.org/changeset/85427> 91833 2011-05-01 12:18:04 -0700 2011-05-01 12:19:35 -0700 Patch bug-59884-20110501121803.patch text/plain 2917 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODU0MjUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOGIxNWZiZTI4ZjM1YWU4YTFlNDQ3OTFlYWEzMThjMGE4 ODlkMDU0Li43NmQwMTY3NzgxYjRjNjgwMzkwZjczMDhlNGRiZWY3NGE2MTVmYzkyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDUtMDEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgc2NtLnB5IGludG8g aXRzIG93biBtb2R1bGUgaW4gcHJlcGFyYXRpb24gZm9yIHNwbGl0dGluZyBpdCB1cAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk4ODQKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9fX2luaXRfXy5weTogQWRk ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbS5w eTogTW92ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2Nt L3NjbV91bml0dGVzdC5weTogTW92ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90ZXN0 L21haW4ucHk6CisKIDIwMTEtMDUtMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9fX2luaXRfXy5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9fX2luaXRfXy5weQpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4yNmRkNmNjNjQ5ODgzN2FmMDYyOGQ3ZWNlOTlmMDhiZTY0N2RjZjBlCi0tLSAvZGV2L251bGwK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL19faW5pdF9f LnB5CkBAIC0wLDAgKzEsNCBAQAorIyBSZXF1aXJlZCBmb3IgUHl0aG9uIHRvIHNlYXJjaCB0aGlz IGRpcmVjdG9yeSBmb3IgbW9kdWxlIGZpbGVzCisKKyMgV2Ugb25seSBleHBvcnQgcHVibGljIEFQ SSBoZXJlLgorZnJvbSAuc2NtIGltcG9ydCBTQ00sIFNWTiwgR2l0LCBDb21taXRNZXNzYWdlLCBk ZXRlY3Rfc2NtX3N5c3RlbSwgZmluZF9jaGVja291dF9yb290LCBkZWZhdWx0X3NjbSwgQXV0aGVu dGljYXRpb25FcnJvciwgQW1iaWd1b3VzQ29tbWl0RXJyb3IsIENoZWNrb3V0TmVlZHNVcGRhdGUK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKaW5kZXggMDgwZTBlNWVkMWUxNWI5NTIxY2Nk NjA0YmFhN2Q1YTVjZTU0NWEwMC4uN2RjMzM5OTMyMjBhZTJjODBjODJhNmRiNTcyZjI0MWU1Y2Zk Mjc0ZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKQEAgLTk2LDcgKzk2LDcgQEAg Y2xhc3MgVGVzdGVyKG9iamVjdCk6CiAgICAgZGVmIHJ1bl90ZXN0cyhzZWxmLCBzeXNfYXJndiwg ZXh0ZXJuYWxfcGFja2FnZV9wYXRocz1Ob25lKToKICAgICAgICAgIiIiUnVuIHRoZSB1bml0IHRl c3RzIGluIGFsbCAqX3VuaXR0ZXN0LnB5IG1vZHVsZXMgaW4gd2Via2l0cHkuCiAKLSAgICAgICAg VGhpcyBtZXRob2QgZXhjbHVkZXMgIndlYmtpdHB5LmNvbW1vbi5jaGVja291dC5zY21fdW5pdHRl c3QiIHVubGVzcworICAgICAgICBUaGlzIG1ldGhvZCBleGNsdWRlcyAid2Via2l0cHkuY29tbW9u LmNoZWNrb3V0LnNjbS5zY21fdW5pdHRlc3QiIHVubGVzcwogICAgICAgICB0aGUgLS1hbGwgb3B0 aW9uIGlzIHRoZSBzZWNvbmQgZWxlbWVudCBvZiBzeXNfYXJndi4KIAogICAgICAgICBBcmdzOgpA QCAtMTQwLDEzICsxNDAsMTggQEAgY2xhc3MgVGVzdGVyKG9iamVjdCk6CiAgICAgICAgIGlmIGxl bihzeXNfYXJndikgPiAxIGFuZCBzeXMuYXJndlsxXSA9PSAiLS1hbGwiOgogICAgICAgICAgICAg c3lzLmFyZ3YucmVtb3ZlKCItLWFsbCIpCiAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICBleGNs dWRlZF9tb2R1bGUgPSAid2Via2l0cHkuY29tbW9uLmNoZWNrb3V0LnNjbV91bml0dGVzdCIKKyAg ICAgICAgICAgIGV4Y2x1ZGVkX21vZHVsZSA9ICJ3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuc2Nt LnNjbV91bml0dGVzdCIKICAgICAgICAgICAgIF9sb2cuaW5mbygiRXhjbHVkaW5nOiAlcyAodXNl IC0tYWxsIHRvIGluY2x1ZGUpIiAlIGV4Y2x1ZGVkX21vZHVsZSkKICAgICAgICAgICAgIG1vZHVs ZXMucmVtb3ZlKGV4Y2x1ZGVkX21vZHVsZSkKIAogICAgICAgICBpZiBzeXMucGxhdGZvcm0gPT0g J3dpbjMyJzoKICAgICAgICAgICAgIG1vZHVsZXMgPSBmaWx0ZXIoc2VsZi5fd2luMzJfYmxhY2ts aXN0LCBtb2R1bGVzKQogCisgICAgICAgICMgdW5pdHRlc3QubWFpbiBoYXMgaG9ycmlibGUgZXJy b3IgcmVwb3J0aW5nIHdoZW4gbW9kdWxlIGltcG9ydHMgYXJlIGJhZAorICAgICAgICAjIHNvIHdl IHRlc3QgaW1wb3J0IGhlcmUgdG8gbWFrZSBkZWJ1Z2dpbmcgYmFkIGltcG9ydHMgbXVjaCBlYXNp ZXIuCisgICAgICAgIGZvciBtb2R1bGUgaW4gbW9kdWxlczoKKyAgICAgICAgICAgIF9faW1wb3J0 X18obW9kdWxlKQorCiAgICAgICAgIHN5c19hcmd2LmV4dGVuZChtb2R1bGVzKQogCiAgICAgICAg ICMgV2UgcGFzcyBOb25lIGZvciB0aGUgbW9kdWxlIGJlY2F1c2Ugd2UgZG8gbm90IHdhbnQgdGhl IHVuaXR0ZXN0Cg==