59856 2011-04-29 18:06:31 -0700 Plug-in failed to initialize message should be called when Java fails to initialize 2011-05-02 11:05:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken sam oldest_to_newest 395675 0 sfalken 2011-04-29 18:06:31 -0700 Plug-in failed to initialize message should be called when Java fails to initialize 395692 1 91784 sfalken 2011-04-29 18:16:50 -0700 Created attachment 91784 Patch 395789 2 91784 mjs 2011-04-30 03:05:42 -0700 Comment on attachment 91784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91784&action=review r=me > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1257 > + const String mimeType = "application/x-java-applet"; I suggest naming this javaMimeType or appletMimeType or something like that. 395842 3 sam 2011-04-30 17:19:33 -0700 I don't understand this patch. This is not checking initialization, but rather whether a java plugin exists or not. 395848 4 sfalken 2011-04-30 19:15:23 -0700 Inside WebPage::createPlugin for the failure case, GetPluginPath succeeds, returning the proper path to the Java plug-in. The failure occurs when NetscapePluginModule::getOrCreate calls pluginModule->load() to initialize the plug-in. When this fails, getOrCreate returns 0, and then createPlugin returns 0. The Java applet path doesn't appear to use PluginView, so the call you added to DidFailToInitializePlugin in PluginView::initializePlugin doesn't get called in this case. I'd be open to fixing this another way - let me know. 396481 5 sfalken 2011-05-02 11:05:34 -0700 Committed r85493: <http://trac.webkit.org/changeset/85493> 91784 2011-04-29 18:16:50 -0700 2011-04-30 03:05:42 -0700 Patch bug-59856-20110429181640.patch text/plain 2012 sfalken SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Mzc2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjkgIFN0ZXZlIEZh bGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBQbHVnLWluIGZhaWxlZCB0byBpbml0aWFsaXplIG1lc3Nh Z2Ugc2hvdWxkIGJlIGNhbGxlZCB3aGVuIEphdmEgZmFpbHMgdG8gaW5pdGlhbGl6ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk4NTYKKyAgICAgICAg CisgICAgICAgIFRvIG1hdGNoIHRoZSBXZWJLaXQxIGJlaGF2aW9yLCBXZWJLaXQyIHNob3VsZCBk aXNwYXRjaCB0aGUgcGx1Zy1pbiBmYWlsZWQKKyAgICAgICAgdG8gaW5pdGlhbGl6ZSBtZXNzYWdl IHdoZW4gd2UgY2FuJ3QgaW5zdGFudGlhdGUgdGhlIEphdmEgcGx1Zy1pbi4KKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlSmF2YUFwcGxldFdpZGdl dCk6CisKIDIwMTEtMDQtMjkgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2Fk ZXJDbGllbnQuY3BwCShyZXZpc2lvbiA4NTMzNykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMjU0LDcgKzEyNTQsMTMgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6cmVkaXJl Y3REYXRhVAogCiBQYXNzUmVmUHRyPFdpZGdldD4gV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0 ZUphdmFBcHBsZXRXaWRnZXQoY29uc3QgSW50U2l6ZSYgcGx1Z2luU2l6ZSwgSFRNTEFwcGxldEVs ZW1lbnQqIGFwcGxldEVsZW1lbnQsIGNvbnN0IEtVUkwmIGJhc2VVUkwsIGNvbnN0IFZlY3RvcjxT dHJpbmc+JiBwYXJhbU5hbWVzLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFyYW1WYWx1ZXMpCiB7 Ci0gICAgcmV0dXJuIGNyZWF0ZVBsdWdpbihwbHVnaW5TaXplLCBhcHBsZXRFbGVtZW50LCBLVVJM KCksIHBhcmFtTmFtZXMsIHBhcmFtVmFsdWVzLCAiYXBwbGljYXRpb24veC1qYXZhLWFwcGxldCIs IGZhbHNlKTsKKyAgICBjb25zdCBTdHJpbmcgbWltZVR5cGUgPSAiYXBwbGljYXRpb24veC1qYXZh LWFwcGxldCI7CisgICAgUmVmUHRyPFdpZGdldD4gcGx1Z2luID0gY3JlYXRlUGx1Z2luKHBsdWdp blNpemUsIGFwcGxldEVsZW1lbnQsIEtVUkwoKSwgcGFyYW1OYW1lcywgcGFyYW1WYWx1ZXMsIG1p bWVUeXBlLCBmYWxzZSk7CisgICAgaWYgKCFwbHVnaW4pIHsKKyAgICAgICAgaWYgKFdlYlBhZ2Uq IHdlYlBhZ2UgPSBtX2ZyYW1lLT5wYWdlKCkpCisgICAgICAgICAgICB3ZWJQYWdlLT5zZW5kKE1l c3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRpZEZhaWxUb0luaXRpYWxpemVQbHVnaW4obWltZVR5cGUp KTsKKyAgICB9CisgICAgcmV0dXJuIHBsdWdpbi5yZWxlYXNlKCk7CiB9CiAKIHN0YXRpYyBib29s IHBsdWdpblN1cHBvcnRzRXh0ZW5zaW9uKFBsdWdpbkRhdGEqIHBsdWdpbkRhdGEsIGNvbnN0IFN0 cmluZyYgZXh0ZW5zaW9uKQo=