59852 2011-04-29 17:53:15 -0700 WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins 2011-04-29 20:52:37 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P1 Normal --- 1 ap ap andersca eric.carlson mitz simon.fraser oldest_to_newest 395661 0 ap 2011-04-29 17:53:15 -0700 On some machines, this makes WebKit think that QuickTime supports Flash - it's present in the QT plug-ins plist, but is disabled. <rdar://problem/9314011> 395667 1 91778 ap 2011-04-29 17:58:03 -0700 Created attachment 91778 proposed fix 395671 2 91778 mitz 2011-04-29 18:02:24 -0700 Comment on attachment 91778 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=91778&action=review > Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:150 > + const void *isEnabled = CFDictionaryGetValue(mimeTypeInfo, CFSTR("WebPluginTypeEnabled")); Star goes next to void, but this should be CFTypeRef, not void*. 395680 3 ap 2011-04-29 18:09:13 -0700 > Star goes next to void, but this should be CFTypeRef, not void*. Why does CFDictionaryGetValue return const void *, and not CFTypeRef? 395682 4 ap 2011-04-29 18:11:42 -0700 On a second thought, I agree. 395748 5 ap 2011-04-29 20:52:37 -0700 Committed <http://trac.webkit.org/changeset/85386> 91778 2011-04-29 17:58:03 -0700 2011-04-29 18:02:24 -0700 proposed fix DisabledPlugin.txt text/plain 2212 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Mzc0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MjogV2ViUGx1Z2luVHlwZUVuYWJsZWQga2V5IGlz IGlnbm9yZWQgd2hlbiBlbnVtZXJhdGluZyBwbHVnLWlucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk4NTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzkzMTQwMTE+CisKKyAgICAgICAgKiBTaGFyZWQvUGx1Z2lucy9OZXRzY2FwZS9tYWMvTmV0c2Nh cGVQbHVnaW5Nb2R1bGVNYWMubW06CisgICAgICAgIChXZWJLaXQ6OmdldFBsdWdpbkluZm9Gcm9t UHJvcGVydHlMaXN0cyk6IERvIHdoYXQgV2ViS2l0MSBkb2VzIChidXQgaW4gQ0YgZGlhbGVjdCku IEFuZCB5ZXMsCisgICAgICAgIEkndmUgc2VlbiBwbGlzdHMgd2l0aCBib3RoIG51bWJlcnMgYW5k IGJvb2xlYW5zIHVzZWQgLgorCiAyMDExLTA0LTI5ICBKaWEgUHUgIDxqcHVAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvUGx1Z2lucy9OZXRzY2FwZS9tYWMvTmV0c2NhcGVQbHVnaW5Nb2R1bGVNYWMubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05l dHNjYXBlUGx1Z2luTW9kdWxlTWFjLm1tCShyZXZpc2lvbiA4NTM3NCkKKysrIFNvdXJjZS9XZWJL aXQyL1NoYXJlZC9QbHVnaW5zL05ldHNjYXBlL21hYy9OZXRzY2FwZVBsdWdpbk1vZHVsZU1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMTQ2LDYgKzE0NiwyMCBAQCBzdGF0aWMgYm9vbCBnZXRQbHVn aW5JbmZvRnJvbVByb3BlcnR5TGlzCiAgICAgICAgIGlmICghbWltZVR5cGVJbmZvIHx8IENGR2V0 VHlwZUlEKG1pbWVUeXBlSW5mbykgIT0gQ0ZEaWN0aW9uYXJ5R2V0VHlwZUlEKCkpCiAgICAgICAg ICAgICBjb250aW51ZTsKIAorICAgICAgICAvLyBGSVhNRTogQ29uc2lkZXIgc3RvcmluZyBkaXNh YmxlZCBNSU1FIHR5cGVzLgorICAgICAgICBjb25zdCB2b2lkICppc0VuYWJsZWQgPSBDRkRpY3Rp b25hcnlHZXRWYWx1ZShtaW1lVHlwZUluZm8sIENGU1RSKCJXZWJQbHVnaW5UeXBlRW5hYmxlZCIp KTsKKyAgICAgICAgaWYgKGlzRW5hYmxlZCkgeworICAgICAgICAgICAgaWYgKENGR2V0VHlwZUlE KGlzRW5hYmxlZCkgPT0gQ0ZOdW1iZXJHZXRUeXBlSUQoKSkgeworICAgICAgICAgICAgICAgIGlu dCB2YWx1ZTsKKyAgICAgICAgICAgICAgICBpZiAoIUNGTnVtYmVyR2V0VmFsdWUoc3RhdGljX2Nh c3Q8Q0ZOdW1iZXJSZWY+KGlzRW5hYmxlZCksIGtDRk51bWJlckludFR5cGUsICZ2YWx1ZSkgfHwg IXZhbHVlKQorICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0gZWxz ZSBpZiAoQ0ZHZXRUeXBlSUQoaXNFbmFibGVkKSA9PSBDRkJvb2xlYW5HZXRUeXBlSUQoKSkgewor ICAgICAgICAgICAgICAgIGlmICghQ0ZCb29sZWFuR2V0VmFsdWUoc3RhdGljX2Nhc3Q8Q0ZCb29s ZWFuUmVmPihpc0VuYWJsZWQpKSkKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAg ICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQorCiAg ICAgICAgIC8vIEdldCB0aGUgTUlNRSB0eXBlIGRlc2NyaXB0aW9uLgogICAgICAgICBDRlN0cmlu Z1JlZiBtaW1lVHlwZURlc2NyaXB0aW9uID0gc3RhdGljX2Nhc3Q8Q0ZTdHJpbmdSZWY+KENGRGlj dGlvbmFyeUdldFZhbHVlKG1pbWVUeXBlSW5mbywgQ0ZTVFIoIldlYlBsdWdpblR5cGVEZXNjcmlw dGlvbiIpKSk7CiAgICAgICAgIGlmIChtaW1lVHlwZURlc2NyaXB0aW9uICYmIENGR2V0VHlwZUlE KG1pbWVUeXBlRGVzY3JpcHRpb24pICE9IENGU3RyaW5nR2V0VHlwZUlEKCkpCg==