59851 2011-04-29 17:42:51 -0700 Pages with accelerated compositing do not redraw unless scrolled 2011-05-02 12:56:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar P1 Normal --- 1 cmarrin cmarrin simon.fraser oldest_to_newest 395651 0 cmarrin 2011-04-29 17:42:51 -0700 * STEPS TO REPRODUCE 1. go to http://demos.legendthemes.com/3d/ 2. Press F11 for Full Screen 3. Press F11 to leave Full screen * RESULTS Page will not repaint correctly unless scrolled. <rdar://problem/9242845> 395660 1 91777 cmarrin 2011-04-29 17:52:22 -0700 Created attachment 91777 Patch 395669 2 91777 simon.fraser 2011-04-29 17:59:18 -0700 Comment on attachment 91777 Patch Why does Windows need this change but not Mac? 395732 3 cmarrin 2011-04-29 19:43:38 -0700 (In reply to comment #2) > (From update of attachment 91777 [details]) > Why does Windows need this change but not Mac? I thought about that. I haven't tried debugging this sequence of calls on Mac. But I'm assuming that there is some Mac specific code that does a setNeedsDIsplay() later in time. Or it could be that CA automatically dirties the layer when changing size and CACF doesn't. I don't think doing a setNeedsDisplay here will hurt Mac. But I could always rejigger the code a bit so this is only done on Windows. 395736 4 91777 simon.fraser 2011-04-29 19:55:33 -0700 Comment on attachment 91777 Patch I actually think we need it (see Radar comments). 396242 5 91777 simon.fraser 2011-05-01 22:57:15 -0700 Comment on attachment 91777 Patch Actually, I think you should only repaint if it got larger, and then only the rects that were revealed. 396549 6 91956 cmarrin 2011-05-02 12:27:14 -0700 Created attachment 91956 Patch 396564 7 cmarrin 2011-05-02 12:56:25 -0700 Landed in http://trac.webkit.org/changeset/85508 91777 2011-04-29 17:52:22 -0700 2011-05-02 12:27:14 -0700 Patch 59851.patch text/plain 1279 cmarrin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Mzc0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjkgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBhZ2VzIHdpdGggYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgZG8g bm90IHJlZHJhdyB1bmxlc3Mgc2Nyb2xsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU5ODUxCisKKyAgICAgICAgQWRkZWQgYSBzZXROZWVkRGlzcGxh eSBvbiB0aGUgbm9uLWNvbXBvc2l0ZWQgY29udGVudCBsYXllciBhZnRlcgorICAgICAgICB0aGUg c2l6ZSBpcyBjaGFuZ2VkIHNvIGl0IHBhaW50cyB0aGUgZnVsbCBzaXplIG9mIHRoZSBsYXllci4K KworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9jYS9MYXllclRyZWVIb3N0Q0EuY3BwOgor ICAgICAgICAoV2ViS2l0OjpMYXllclRyZWVIb3N0Q0E6OnNpemVEaWRDaGFuZ2UpOgorCiAyMDEx LTA0LTI5ICBKaWEgUHUgIDxqcHVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNh bSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvY2EvTGF5 ZXJUcmVlSG9zdENBLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvY2EvTGF5ZXJUcmVlSG9zdENBLmNwcAkocmV2aXNpb24gODUzNzQpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvY2EvTGF5ZXJUcmVlSG9zdENBLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTI5LDYgKzEyOSw3IEBACiB7CiAgICAgbV9yb290TGF5ZXItPnNldFNp emUobmV3U2l6ZSk7CiAgICAgbV9ub25Db21wb3NpdGVkQ29udGVudExheWVyLT5zZXRTaXplKG5l d1NpemUpOworICAgIG1fbm9uQ29tcG9zaXRlZENvbnRlbnRMYXllci0+c2V0TmVlZHNEaXNwbGF5 KCk7CiAKICAgICBpZiAobV9wYWdlT3ZlcmxheUxheWVyKQogICAgICAgICBtX3BhZ2VPdmVybGF5 TGF5ZXItPnNldFNpemUobmV3U2l6ZSk7Cg== 91956 2011-05-02 12:27:14 -0700 2011-05-02 12:50:39 -0700 Patch 59851.patch text/plain 2025 cmarrin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1Mzc0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMjkgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBhZ2VzIHdpdGggYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgZG8g bm90IHJlZHJhdyB1bmxlc3Mgc2Nyb2xsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU5ODUxCisKKyAgICAgICAgQWRkZWQgYSBzZXROZWVkRGlzcGxh eSBvbiB0aGUgbm9uLWNvbXBvc2l0ZWQgY29udGVudCBsYXllciBhZnRlcgorICAgICAgICB0aGUg c2l6ZSBpcyBjaGFuZ2VkIHNvIGl0IHBhaW50cyB0aGUgZnVsbCBzaXplIG9mIHRoZSBsYXllci4g Q2FsbGVkCisgICAgICAgIG9ubHkgZm9yIHRoZSBhcmVhcyBuZXdseSBleHBvc2VkLCBpZiBhbnku CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvY2EvTGF5ZXJUcmVlSG9zdENBLmNwcDoK KyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlSG9zdENBOjpzaXplRGlkQ2hhbmdlKToKKwogMjAx MS0wNC0yOSAgSmlhIFB1ICA8anB1QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2NhL0xh eWVyVHJlZUhvc3RDQS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL2NhL0xheWVyVHJlZUhvc3RDQS5jcHAJKHJldmlzaW9uIDg1Mzc0KQorKysgU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2NhL0xheWVyVHJlZUhvc3RDQS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEyOCw4ICsxMjgsMjAgQEAKIHZvaWQgTGF5ZXJUcmVlSG9zdENBOjpz aXplRGlkQ2hhbmdlKGNvbnN0IEludFNpemUmIG5ld1NpemUpCiB7CiAgICAgbV9yb290TGF5ZXIt PnNldFNpemUobmV3U2l6ZSk7CisKKyAgICAvLyBJZiB0aGUgbmV3U2l6ZSBleHBvc2VzIG5ldyBh cmVhcyBvZiB0aGUgbm9uLWNvbXBvc2l0ZWQgY29udGVudCBhIHNldE5lZWRzRGlzcGxheSBpcyBu ZWVkZWQKKyAgICAvLyBmb3IgdGhvc2UgbmV3bHkgZXhwb3NlZCBhcmVhcy4KKyAgICBGbG9hdFNp emUgb2xkU2l6ZSA9IG1fbm9uQ29tcG9zaXRlZENvbnRlbnRMYXllci0+c2l6ZSgpOwogICAgIG1f bm9uQ29tcG9zaXRlZENvbnRlbnRMYXllci0+c2V0U2l6ZShuZXdTaXplKTsKIAorICAgIGlmIChu ZXdTaXplLndpZHRoKCkgPiBvbGRTaXplLndpZHRoKCkpIHsKKyAgICAgICAgZmxvYXQgaGVpZ2h0 ID0gc3RkOjptaW4oc3RhdGljX2Nhc3Q8ZmxvYXQ+KG5ld1NpemUuaGVpZ2h0KCkpLCBvbGRTaXpl LmhlaWdodCgpKTsKKyAgICAgICAgbV9ub25Db21wb3NpdGVkQ29udGVudExheWVyLT5zZXROZWVk c0Rpc3BsYXlJblJlY3QoRmxvYXRSZWN0KG9sZFNpemUud2lkdGgoKSwgMCwgbmV3U2l6ZS53aWR0 aCgpIC0gb2xkU2l6ZS53aWR0aCgpLCBoZWlnaHQpKTsKKyAgICB9CisKKyAgICBpZiAobmV3U2l6 ZS5oZWlnaHQoKSA+IG9sZFNpemUuaGVpZ2h0KCkpCisgICAgICAgIG1fbm9uQ29tcG9zaXRlZENv bnRlbnRMYXllci0+c2V0TmVlZHNEaXNwbGF5SW5SZWN0KEZsb2F0UmVjdCgwLCBvbGRTaXplLmhl aWdodCgpLCBuZXdTaXplLndpZHRoKCksIG5ld1NpemUuaGVpZ2h0KCkgLSBvbGRTaXplLmhlaWdo dCgpKSk7CisKICAgICBpZiAobV9wYWdlT3ZlcmxheUxheWVyKQogICAgICAgICBtX3BhZ2VPdmVy bGF5TGF5ZXItPnNldFNpemUobmV3U2l6ZSk7CiAK