59848 2011-04-29 17:23:52 -0700 [ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint 2011-05-10 17:34:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 ctguil webkit-unassigned brettw commit-queue darin jamesr oldest_to_newest 395640 0 ctguil 2011-04-29 17:23:52 -0700 This issue was discovered while investigating http://crbug.com/80616. Looks like the call to endPlatformPaint should have been removed in this changeset 41978. http://trac.webkit.org/changeset/41978/trunk/WebCore/platform/graphics/chromium/FontChromiumWin.cpp. 395641 1 91771 ctguil 2011-04-29 17:26:18 -0700 Created attachment 91771 Patch 395928 2 91771 eric 2011-05-01 09:52:04 -0700 Comment on attachment 91771 Patch You might try webkit-patch upload for your next patch. It will automatically check the patch checkbox, etc. when uploading. 395929 3 91771 eric 2011-05-01 09:52:57 -0700 Comment on attachment 91771 Patch OK. How do we test this? Recently there was a RIAA added for GraphicsContext::save/restore which helped get rid of a bunch of bugs like this in the cross-platofrm code. 395930 4 91771 eric 2011-05-01 09:54:37 -0700 Comment on attachment 91771 Patch Seems we either need a test or an explanation of why testing is impossible in your ChangeLog. I don't think we can test printing with DumpRenderTree. So if printing is required to test this, automated testing may be impossible. 399996 5 ctguil 2011-05-06 18:31:10 -0700 One way to "test" would be to have the non-printing case fail (in debug mode) when this bug occurs. I have a Chromium change out for review for that. http://codereview.chromium.org/6949012/ 399999 6 92675 ctguil 2011-05-06 18:45:54 -0700 Created attachment 92675 Proposed Patch Adding testing information. 401531 7 92675 ctguil 2011-05-10 14:57:48 -0700 Comment on attachment 92675 Proposed Patch Patch needs to be updated to address errors uncovered by chromium change. 401570 8 93030 ctguil 2011-05-10 15:34:23 -0700 Created attachment 93030 Address issue uncovered by proposed Chromium test patch. Adding testing information. 401581 9 93030 jamesr 2011-05-10 15:41:54 -0700 Comment on attachment 93030 Address issue uncovered by proposed Chromium test patch. Hurray for testing! 401669 10 93030 commit-queue 2011-05-10 17:33:57 -0700 Comment on attachment 93030 Address issue uncovered by proposed Chromium test patch. Clearing flags on attachment: 93030 Committed r86199: <http://trac.webkit.org/changeset/86199> 401670 11 commit-queue 2011-05-10 17:34:02 -0700 All reviewed patches have been landed. Closing bug. 91771 2011-04-29 17:26:18 -0700 2011-05-06 18:45:49 -0700 Patch MyPatch.txt text/plain 1515 ctguil SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MzczKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMjkgIENocmlzIEd1 aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb250OjpkcmF3Q29tcGxleFRleHQgY2FsbHMg RW5kUGxhdGZvcm1QYWludCB3aXRob3V0IGNhbGxpbmcgQmVnaW5QbGF0Zm9ybVBhaW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTg0OAorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRyYXdDb21wbGV4VGV4dCk6CisKIDIwMTEtMDQtMjkgIEVt aWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERp bWl0cmkgR2xhemtvdi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcAkocmV2aXNpb24g ODUzNjkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250 Q2hyb21pdW1XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjQsOCArNTI0LDYgQEAgdm9pZCBG b250OjpkcmF3Q29tcGxleFRleHQoR3JhcGhpY3NDb250ZQogICAgIC8vIFVuaXNjcmliZSBjb3Vu dHMgdGhlIGNvb3JkaW5hdGVzIGZyb20gdGhlIHVwcGVyIGxlZnQsIHdoaWxlIFdlYktpdCB1c2Vz CiAgICAgLy8gdGhlIGJhc2VsaW5lLCBzbyB3ZSBoYXZlIHRvIHN1YnRyYWN0IG9mZiB0aGUgYXNj ZW50LgogICAgIHN0YXRlLmRyYXcoZ3JhcGhpY3NDb250ZXh0LCBoZGMsIGxyb3VuZGYocG9pbnQu eCgpKSwgbHJvdW5kZihwb2ludC55KCkgLSBmb250TWV0cmljcygpLmFzY2VudCgpKSwgZnJvbSwg dG8pOwotCi0gICAgc2tpYTo6RW5kUGxhdGZvcm1QYWludChjb250ZXh0LT5jYW52YXMoKSk7CiB9 CiAKIHZvaWQgRm9udDo6ZHJhd0VtcGhhc2lzTWFya3NGb3JDb21wbGV4VGV4dChHcmFwaGljc0Nv bnRleHQqIC8qIGNvbnRleHQgKi8sIGNvbnN0IFRleHRSdW4mIC8qIHJ1biAqLywgY29uc3QgQXRv bWljU3RyaW5nJiAvKiBtYXJrICovLCBjb25zdCBGbG9hdFBvaW50JiAvKiBwb2ludCAqLywgaW50 IC8qIGZyb20gKi8sIGludCAvKiB0byAqLykgY29uc3QK 92675 2011-05-06 18:45:54 -0700 2011-05-10 15:34:18 -0700 Proposed Patch bug-59848-20110506184554.patch text/plain 1722 ctguil SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1OTkyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDYgIENocmlzIEd1 aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb250OjpkcmF3Q29tcGxleFRleHQgY2FsbHMg RW5kUGxhdGZvcm1QYWludCB3aXRob3V0IGNhbGxpbmcgQmVnaW5QbGF0Zm9ybVBhaW50LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk4NDgKKworICAg ICAgICBUbyB0ZXN0IHRoaXMgSSBwbGFuIHRvIG1ha2UgdGhlIG5vbi1wcmludGluZyBkZXZpY2Ug KEJpdG1hcFBsYXRmb3JtRGV2aWNlKSBmYWlsCisgICAgICAgIHdoZW4gRW5kUGxhdGZvcm1QYWlu dCBkb2Vzbid0IG1hdGNodXAgd2l0aCBCZWdpblBsYXRmb3JtUGFpbnQuCisgICAgICAgIGh0dHA6 Ly9jb2RlcmV2aWV3LmNocm9taXVtLm9yZy82OTQ5MDEyLyAKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGb250OjpkcmF3Q29tcGxleFRleHQpOgorCiAyMDExLTA1LTA2ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdp bi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vRm9udENocm9taXVtV2luLmNwcAkocmV2aXNpb24gODU4NjcpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01MjQsOCArNTI0LDYgQEAgdm9pZCBGb250OjpkcmF3Q29tcGxleFRleHQo R3JhcGhpY3NDb250ZQogICAgIC8vIFVuaXNjcmliZSBjb3VudHMgdGhlIGNvb3JkaW5hdGVzIGZy b20gdGhlIHVwcGVyIGxlZnQsIHdoaWxlIFdlYktpdCB1c2VzCiAgICAgLy8gdGhlIGJhc2VsaW5l LCBzbyB3ZSBoYXZlIHRvIHN1YnRyYWN0IG9mZiB0aGUgYXNjZW50LgogICAgIHN0YXRlLmRyYXco Z3JhcGhpY3NDb250ZXh0LCBoZGMsIGxyb3VuZGYocG9pbnQueCgpKSwgbHJvdW5kZihwb2ludC55 KCkgLSBmb250TWV0cmljcygpLmFzY2VudCgpKSwgZnJvbSwgdG8pOwotCi0gICAgc2tpYTo6RW5k UGxhdGZvcm1QYWludChjb250ZXh0LT5jYW52YXMoKSk7CiB9CiAKIHZvaWQgRm9udDo6ZHJhd0Vt cGhhc2lzTWFya3NGb3JDb21wbGV4VGV4dChHcmFwaGljc0NvbnRleHQqIC8qIGNvbnRleHQgKi8s IGNvbnN0IFRleHRSdW4mIC8qIHJ1biAqLywgY29uc3QgQXRvbWljU3RyaW5nJiAvKiBtYXJrICov LCBjb25zdCBGbG9hdFBvaW50JiAvKiBwb2ludCAqLywgaW50IC8qIGZyb20gKi8sIGludCAvKiB0 byAqLykgY29uc3QK 93030 2011-05-10 15:34:23 -0700 2011-05-10 17:33:57 -0700 Address issue uncovered by proposed Chromium test patch. bug-59848-20110510153421.patch text/plain 2156 ctguil SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1OTkyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMDYgIENocmlzIEd1 aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1XaW5dIEZvbnQ6OmRyYXdDb21w bGV4VGV4dCBjYWxscyBFbmRQbGF0Zm9ybVBhaW50IHdpdGhvdXQgY2FsbGluZyBCZWdpblBsYXRm b3JtUGFpbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01OTg0OAorCisgICAgICAgIFRvIHRlc3QgdGhpcyBJIHBsYW4gdG8gbWFrZSB0aGUgbm9uLXBy aW50aW5nIGRldmljZSAoQml0bWFwUGxhdGZvcm1EZXZpY2UpIGZhaWwKKyAgICAgICAgd2hlbiBF bmRQbGF0Zm9ybVBhaW50IGRvZXNuJ3QgbWF0Y2h1cCB3aXRoIEJlZ2luUGxhdGZvcm1QYWludC4K KyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzY5NDkwMTIvIAorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRyYXdDb21wbGV4VGV4dCk6CisKIDIwMTEtMDUtMDYgIEJl dGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Rm9udENocm9taXVtV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4uY3BwCShyZXZpc2lvbiA4NTg2NykK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1 bVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OSw3ICsxNzksOCBAQCBUcmFuc3BhcmVuY3lB d2FyZUZvbnRQYWludGVyOjp+VHJhbnNwYXJlCiAgICAgaWYgKG1fY3JlYXRlZFRyYW5zcGFyZW5j eUxheWVyKQogICAgICAgICBtX2dyYXBoaWNzQ29udGV4dC0+ZW5kVHJhbnNwYXJlbmN5TGF5ZXIo KTsKICAgICBtX2dyYXBoaWNzQ29udGV4dC0+cmVzdG9yZSgpOwotICAgIHNraWE6OkVuZFBsYXRm b3JtUGFpbnQobV9wbGF0Zm9ybUNvbnRleHQtPmNhbnZhcygpKTsKKyAgICBpZiAobV90cmFuc3Bh cmVuY3kucGxhdGZvcm1Db250ZXh0KCkpCisgICAgICAgIHNraWE6OkVuZFBsYXRmb3JtUGFpbnQo bV90cmFuc3BhcmVuY3kucGxhdGZvcm1Db250ZXh0KCktPmNhbnZhcygpKTsKIH0KIAogLy8gU3Bl Y2lhbGl6YXRpb24gZm9yIHNpbXBsZSBHbHlwaEJ1ZmZlciBwYWludGluZy4KQEAgLTUyNCw4ICs1 MjUsNiBAQCB2b2lkIEZvbnQ6OmRyYXdDb21wbGV4VGV4dChHcmFwaGljc0NvbnRlCiAgICAgLy8g VW5pc2NyaWJlIGNvdW50cyB0aGUgY29vcmRpbmF0ZXMgZnJvbSB0aGUgdXBwZXIgbGVmdCwgd2hp bGUgV2ViS2l0IHVzZXMKICAgICAvLyB0aGUgYmFzZWxpbmUsIHNvIHdlIGhhdmUgdG8gc3VidHJh Y3Qgb2ZmIHRoZSBhc2NlbnQuCiAgICAgc3RhdGUuZHJhdyhncmFwaGljc0NvbnRleHQsIGhkYywg bHJvdW5kZihwb2ludC54KCkpLCBscm91bmRmKHBvaW50LnkoKSAtIGZvbnRNZXRyaWNzKCkuYXNj ZW50KCkpLCBmcm9tLCB0byk7Ci0KLSAgICBza2lhOjpFbmRQbGF0Zm9ybVBhaW50KGNvbnRleHQt PmNhbnZhcygpKTsKIH0KIAogdm9pZCBGb250OjpkcmF3RW1waGFzaXNNYXJrc0ZvckNvbXBsZXhU ZXh0KEdyYXBoaWNzQ29udGV4dCogLyogY29udGV4dCAqLywgY29uc3QgVGV4dFJ1biYgLyogcnVu ICovLCBjb25zdCBBdG9taWNTdHJpbmcmIC8qIG1hcmsgKi8sIGNvbnN0IEZsb2F0UG9pbnQmIC8q IHBvaW50ICovLCBpbnQgLyogZnJvbSAqLywgaW50IC8qIHRvICovKSBjb25zdAo=