59839 2011-04-29 15:30:14 -0700 [chromium] Layout test animations/3d/replace-filling-transform.html failing 2011-05-03 14:48:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 59149 1 kbr jamesr dino dpranke enne jamesr simon.fraser vangelis oldest_to_newest 395558 0 kbr 2011-04-29 15:30:14 -0700 http://trac.webkit.org/changeset/85338 added layout test animations/3d/replace-filling-transform.html which appears to be failing on all Chromium platforms. See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=animations%2F3d%2Freplace-filling-transform.html Suppressing this failure for the moment. 395783 1 dino 2011-04-30 01:23:15 -0700 I tried to make this a platform independent pixel test. The strange thing about the bad actual results linked is that you're only seeing the red square. A failure should display both some red and green. It's as if the green square is being composited below the red square. Is this with your hardware compositor enabled? 395784 2 dino 2011-04-30 01:26:08 -0700 To be more clear about the test: the green square should animate and end up in the same location as the red square. The green should cover the red. A failure in the test should still show the entire green rectangle, just with some red visible. The fact that you see only red suggests the red is being drawn over the green. 396900 3 kbr 2011-05-02 19:08:26 -0700 Presumably this test is running with the hardware compositor enabled on Chromium. 396924 4 jamesr 2011-05-02 19:51:44 -0700 (In reply to comment #3) > Presumably this test is running with the hardware compositor enabled on Chromium. Aha, that's the issue - it is not running with the compositor enabled in chromium! We only run the tests enumerated here in the chromium gpu configuration: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py#L75 and we only skip the tests enumerated here in the chromium non-gpu configuration: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expectations.txt#L285 We should update both to be aware of the fact that animations/3d/... is only useful when run with the compositor enabled. 396926 5 92041 jamesr 2011-05-02 19:54:45 -0700 Created attachment 92041 Patch 396927 6 jamesr 2011-05-02 19:55:16 -0700 This should do the trick. 396974 7 dpranke 2011-05-02 22:45:08 -0700 the python patch looks correct to me. 397212 8 92041 kbr 2011-05-03 11:26:10 -0700 Comment on attachment 92041 Patch Looks good to me. 397229 9 92041 jamesr 2011-05-03 11:43:50 -0700 Comment on attachment 92041 Patch Clearing flags on attachment: 92041 Committed r85628: <http://trac.webkit.org/changeset/85628> 397230 10 jamesr 2011-05-03 11:43:54 -0700 All reviewed patches have been landed. Closing bug. 397284 11 dino 2011-05-03 12:58:39 -0700 Out of interest, do you ignore 3d transforms when you don't have HW compositing? Technically, the test should have worked with or without compositing - there wasn't anything really 3d about it. I just used a translate3d(something, something, 0) in order to trigger HW on the Apple engine. 397405 12 jamesr 2011-05-03 14:48:00 -0700 (In reply to comment #11) > Out of interest, do you ignore 3d transforms when you don't have HW compositing? Technically, the test should have worked with or without compositing - there wasn't anything really 3d about it. I just used a translate3d(something, something, 0) in order to trigger HW on the Apple engine. It should just be ignored. Technically, this test was passing before - it was showing up as a failure just because the shade of green that chromium renders is slightly different from the baseline. However, it seems more reasonable to run the animations/3d/ tests with our compositor enabled since that's what our users will experience. 92041 2011-05-02 19:54:45 -0700 2011-05-03 11:43:50 -0700 Patch bug-59839-20110502195452.patch text/plain 2955 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogODU1MDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZjU2MTM4YzBiYzlmYWNjYjE4MTU5 ZDRmYmQ1ZDc0OGMwOTA1ODg5Li4xNDE3YWRlODk0ZGQ3NmIxNjBmOTI2ZGEyZDI4YmMxMzVmOTAx ZThmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMDIgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIExheW91dCB0ZXN0IGFuaW1hdGlvbnMvM2QvcmVwbGFj ZS1maWxsaW5nLXRyYW5zZm9ybS5odG1sIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5ODM5CisKKyAgICAgICAgSWdub3JlIGFuaW1hdGlv bnMvM2Qgd2hlbiBydW4gaW4gQ1BVIG1vZGUgYXMgdGhlc2UgYXJlIGNvbXBvc2l0b3IgdGVzdHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisK IDIwMTEtMDUtMDIgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBO b3QgcmV2aWV3ZWQuIEJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCAxMWQyODQ0YzMzM2QxOGVmZmYxM2U2 M2I5YzRhODM5YmJkZjA3MmJiLi4zOWEwNjZmN2Q1ZTFmMWQ1ZjViOTAwYjFhMmQ0NTM2NWU1ODY0 MDZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVj dGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0CkBAIC0yODYsNiArMjg2LDcgQEAgQlVHQ1IxMDM5NSBXT05URklYIFNLSVAg OiBodHRwL3Rlc3RzL3dlYmFyY2hpdmUgPSBGQUlMIFBBU1MKIC8vIHBhdGhzLgogQlVHQ1IxNTcz MyBXT05URklYIENQVSBTS0lQIDogY29tcG9zaXRpbmcgPSBGQUlMIFBBU1MgVElNRU9VVAogQlVH Q1IxNTczMyBXT05URklYIENQVSBTS0lQIDogcGxhdGZvcm0vY2hyb21pdW0vY29tcG9zaXRpbmcg PSBGQUlMIFBBU1MgVElNRU9VVAorQlVHQ1IxNTczMyBXT05URklYIENQVSBTS0lQIDogYW5pbWF0 aW9ucy8zZCA9IEZBSUwgUEFTUyBUSU1FT1VUCiAKIC8vIFJ1biB0aGUgTWFjLXNwZWNpZmljIHBs YXRmb3JtIHRlc3RzLCBidXQgb25seSB0byBjaGVjayBmb3IgY3Jhc2hlcy4KIFdPTlRGSVggOiBw bGF0Zm9ybS9ndGsgPSBGQUlMIFBBU1MKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCA4NjZhMzRiMjE4NDE4ZjlmZGQ4N2JmMWRiNWFmYjJmNGRkOWYx ODM3Li5lMjkwMzFhNzQxOGQzZWRkMWUxMzFmNzA3MTRjODM2NWYzNDhhNTYyIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDUtMDIgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIExh eW91dCB0ZXN0IGFuaW1hdGlvbnMvM2QvcmVwbGFjZS1maWxsaW5nLXRyYW5zZm9ybS5odG1sIGZh aWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5 ODM5CisKKyAgICAgICAgQWRkIGFuaW1hdGlvbnMvM2QgdG8gdGhlIGxpc3Qgb2YgdGVzdHMgcnVu IGluIHRoZSBjaHJvbWl1bS1ncHUgY29uZmlndXJhdGlvbiBzaW5jZSB0aGVzZSB0ZXN0cyBleGVy Y2lzZSB0aGUgY29tcG9zaXRvci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5OgorCiAyMDExLTA1LTAyICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX2dwdS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW1fZ3B1LnB5CmluZGV4IGZmYzJjZjc0Y2M3NTQ2NzNmNzE3NzRiYzg0ZTI5YjY0MzJjNjVm ZGYuLjMzOGY1YzUwMTU1Yjg2Y2E0MGI5ZjVkZGVkMWU5ZTZhNzM2MjA5MjkgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1f Z3B1LnB5CkBAIC03NCw3ICs3NCw3IEBAIGRlZiBfc2V0X2dwdV9vcHRpb25zKHBvcnQpOgogCiBk ZWYgX3Rlc3RzKHBvcnQsIHBhdGhzKToKICAgICBpZiBub3QgcGF0aHM6Ci0gICAgICAgIHBhdGhz ID0gWydjb21wb3NpdGluZycsICdwbGF0Zm9ybS9jaHJvbWl1bS9jb21wb3NpdGluZycsICdtZWRp YSddCisgICAgICAgIHBhdGhzID0gWydjb21wb3NpdGluZycsICdwbGF0Zm9ybS9jaHJvbWl1bS9j b21wb3NpdGluZycsICdtZWRpYScsICdhbmltYXRpb25zLzNkJ10KICAgICAgICAgaWYgbm90IHBv cnQubmFtZSgpLnN0YXJ0c3dpdGgoJ2Nocm9taXVtLWdwdS1tYWMnKToKICAgICAgICAgICAgICMg Q2FudmFzIGlzIG5vdCB5ZXQgYWNjZWxlcmF0ZWQgb24gdGhlIE1hYywgc28gdGhlcmUncyBubyBw b2ludAogICAgICAgICAgICAgIyBpbiBydW5uaW5nIHRoZSB0ZXN0cyB0aGVyZS4K