59835 2011-04-29 14:54:14 -0700 Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm 2011-05-01 12:10:50 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 56410 1 rniwa rniwa ap commit-queue darin sam simon.fraser oldest_to_newest 395536 0 rniwa 2011-04-29 14:54:14 -0700 currentKeyboardEvent in EventHandlerMac.mm is called exactly one place in WebKit/WebHTMLView.mm, and I think think there's any reason this function should be in WebCore. 395538 1 91744 rniwa 2011-04-29 14:58:53 -0700 Created attachment 91744 cleanup 395933 2 91744 eric 2011-05-01 09:59:02 -0700 Comment on attachment 91744 cleanup Yay! 395984 3 91744 commit-queue 2011-05-01 12:10:45 -0700 Comment on attachment 91744 cleanup Clearing flags on attachment: 91744 Committed r85425: <http://trac.webkit.org/changeset/85425> 395985 4 commit-queue 2011-05-01 12:10:50 -0700 All reviewed patches have been landed. Closing bug. 91744 2011-04-29 14:58:53 -0700 2011-05-01 12:10:45 -0700 cleanup bug-59835-20110429145852.patch text/plain 5506 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MzYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjkgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTW92ZSBjdXJyZW50S2V5Ym9hcmRFdmVudCBmcm9tIEV2ZW50SGFu ZGxlck1hYy5tbSB0byBXZWJIVE1MVmlldy5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk4MzUKKworICAgICAgICBNb3ZlZCBjdXJyZW50S2V5Ym9h cmRFdmVudC4KKworICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorICAgICAgICAqIHBhZ2UvRXZl bnRIYW5kbGVyLmg6CisgICAgICAgICogcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tOgorCiAy MDExLTA0LTI5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgW1F0XSBVbnJldmlld2VkIGJ1aWxkZml4IGFmdGVyIHI4NTM0My4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL1dlYkNvcmUuZXhwLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNv cmUuZXhwLmluCShyZXZpc2lvbiA4NTM1MCkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluCSh3b3JraW5nIGNvcHkpCkBAIC0zMjIsNiArMzIyLDcgQEAgX19aTjdXZWJDb3JlMTNJZGVu dGlmaWVyUmVwM2dldEVQS2MKIF9fWk43V2ViQ29yZTEzSWRlbnRpZmllclJlcDNnZXRFaQogX19a TjdXZWJDb3JlMTNKU0hUTUxFbGVtZW50NnNfaW5mb0UKIF9fWk43V2ViQ29yZTEzS2V5Ym9hcmRF dmVudEMxRVJLTjNXVEYxMkF0b21pY1N0cmluZ0ViYlBOU185RE9NV2luZG93RVJLTlMxXzZTdHJp bmdFamJiYmJiCitfX1pON1dlYkNvcmUxM0tleWJvYXJkRXZlbnRDMUVSS05TXzIxUGxhdGZvcm1L ZXlib2FyZEV2ZW50RVBOU185RE9NV2luZG93RQogX19aTjdXZWJDb3JlMTNSZXNvdXJjZUVycm9y QzFFUDdOU0Vycm9yCiBfX1pON1dlYkNvcmUxM1Jlc291cmNlRXJyb3JDMUVQOV9fQ0ZFcnJvcgog X19aTjdXZWJDb3JlMTNUeXBpbmdDb21tYW5kMzlpbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JJblF1 b3RlZENvbnRlbnRFUE5TXzhEb2N1bWVudEUKQEAgLTEwNjYsNyArMTA2Nyw2IEBAIF9fWk5LN1dl YkNvcmUxMUhpc3RvcnlJdGVtOXZpZXdTdGF0ZUV2CiBfX1pOSzdXZWJDb3JlMTFSZW5kZXJMYXll cjE5YWJzb2x1dGVCb3VuZGluZ0JveEV2CiBfX1pOSzdXZWJDb3JlMTFSZW5kZXJTdHlsZTIxdmlz aXRlZERlcGVuZGVudENvbG9yRWkKIF9fWk5LN1dlYkNvcmUxMVNjcmlwdFZhbHVlOWdldFN0cmlu Z0VQTjNKU0M5RXhlY1N0YXRlRVJOM1dURjZTdHJpbmdFCi1fX1pOSzdXZWJDb3JlMTJFdmVudEhh bmRsZXIyMGN1cnJlbnRLZXlib2FyZEV2ZW50RXYKIF9fWk5LN1dlYkNvcmUxMkljb25EYXRhYmFz ZTEyZGF0YWJhc2VQYXRoRXYKIF9fWk5LN1dlYkNvcmUxMkljb25EYXRhYmFzZTI0c2hvdWxkU3Rv cFRocmVhZEFjdGl2aXR5RXYKIF9fWk5LN1dlYkNvcmUxMkljb25EYXRhYmFzZTlpc0VuYWJsZWRF dgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCShyZXZpc2lvbiA4NTM1MCkKKysr IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTIw Nyw4ICsyMDcsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZW5kU2Nyb2xsRXZlbnQoKTsKICAgICAK ICNpZiBQTEFURk9STShNQUMpICYmIGRlZmluZWQoX19PQkpDX18pCi0gICAgUGFzc1JlZlB0cjxL ZXlib2FyZEV2ZW50PiBjdXJyZW50S2V5Ym9hcmRFdmVudCgpIGNvbnN0OwotCiAgICAgdm9pZCBt b3VzZURvd24oTlNFdmVudCAqKTsKICAgICB2b2lkIG1vdXNlRHJhZ2dlZChOU0V2ZW50ICopOwog ICAgIHZvaWQgbW91c2VVcChOU0V2ZW50ICopOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9t YWMvRXZlbnRIYW5kbGVyTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv bWFjL0V2ZW50SGFuZGxlck1hYy5tbQkocmV2aXNpb24gODUzNTApCisrKyBTb3VyY2UvV2ViQ29y ZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTExOSwyNCAr MTE5LDYgQEAgYm9vbCBFdmVudEhhbmRsZXI6OndoZWVsRXZlbnQoTlNFdmVudCAqZQogICAgIHJl dHVybiB3aGVlbEV2ZW50LmlzQWNjZXB0ZWQoKTsKIH0KIAotUGFzc1JlZlB0cjxLZXlib2FyZEV2 ZW50PiBFdmVudEhhbmRsZXI6OmN1cnJlbnRLZXlib2FyZEV2ZW50KCkgY29uc3QKLXsKLSAgICBO U0V2ZW50ICpldmVudCA9IFtOU0FwcCBjdXJyZW50RXZlbnRdOwotICAgIGlmICghZXZlbnQpCi0g ICAgICAgIHJldHVybiAwOwotICAgIHN3aXRjaCAoW2V2ZW50IHR5cGVdKSB7Ci0gICAgICAgIGNh c2UgTlNLZXlEb3duOiB7Ci0gICAgICAgICAgICBQbGF0Zm9ybUtleWJvYXJkRXZlbnQgcGxhdGZv cm1FdmVudChldmVudCk7Ci0gICAgICAgICAgICBwbGF0Zm9ybUV2ZW50LmRpc2FtYmlndWF0ZUtl eURvd25FdmVudChQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlJhd0tleURvd24pOwotICAgICAgICAg ICAgcmV0dXJuIEtleWJvYXJkRXZlbnQ6OmNyZWF0ZShwbGF0Zm9ybUV2ZW50LCBtX2ZyYW1lLT5k b2N1bWVudCgpLT5kZWZhdWx0VmlldygpKTsKLSAgICAgICAgfQotICAgICAgICBjYXNlIE5TS2V5 VXA6Ci0gICAgICAgICAgICByZXR1cm4gS2V5Ym9hcmRFdmVudDo6Y3JlYXRlKGV2ZW50LCBtX2Zy YW1lLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpKTsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAg ICAgICAgIHJldHVybiAwOwotICAgIH0KLX0KLQogYm9vbCBFdmVudEhhbmRsZXI6OmtleUV2ZW50 KE5TRXZlbnQgKmV2ZW50KQogewogICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MzYxKQorKysgU291cmNlL1dlYktpdC9tYWMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjkgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBjdXJyZW50S2V5Ym9hcmRFdmVudCBmcm9tIEV2 ZW50SGFuZGxlck1hYy5tbSB0byBXZWJIVE1MVmlldy5tbQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk4MzUKKworICAgICAgICBNb3ZlZCBjdXJyZW50 S2V5Ym9hcmRFdmVudC4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06CisgICAg ICAgIChjdXJyZW50S2V5Ym9hcmRFdmVudCk6CisgICAgICAgICgtW1dlYkhUTUxWaWV3IGJlY29t ZUZpcnN0UmVzcG9uZGVyXSk6CisKIDIwMTEtMDQtMjkgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQkocmV2aXNpb24gODUzNTApCisrKyBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0zNjgyLDYgKzM2ODIsMjUgQEAgc3RhdGljIEJPT0wgaXNJblBhc3N3b3JkRmllbGQoRnJhbWUq IGNvcgogICAgIHJldHVybiBjb3JlRnJhbWUgJiYgY29yZUZyYW1lLT5zZWxlY3Rpb24oKS0+aXNJ blBhc3N3b3JkRmllbGQoKTsKIH0KIAorc3RhdGljIFBhc3NSZWZQdHI8S2V5Ym9hcmRFdmVudD4g Y3VycmVudEtleWJvYXJkRXZlbnQoRnJhbWUqIGNvcmVGcmFtZSkKK3sKKyAgICBOU0V2ZW50ICpl dmVudCA9IFtOU0FwcCBjdXJyZW50RXZlbnRdOworICAgIGlmICghZXZlbnQpCisgICAgICAgIHJl dHVybiAwOworCisgICAgc3dpdGNoIChbZXZlbnQgdHlwZV0pIHsKKyAgICBjYXNlIE5TS2V5RG93 bjogeworICAgICAgICBQbGF0Zm9ybUtleWJvYXJkRXZlbnQgcGxhdGZvcm1FdmVudChldmVudCk7 CisgICAgICAgIHBsYXRmb3JtRXZlbnQuZGlzYW1iaWd1YXRlS2V5RG93bkV2ZW50KFBsYXRmb3Jt S2V5Ym9hcmRFdmVudDo6UmF3S2V5RG93bik7CisgICAgICAgIHJldHVybiBLZXlib2FyZEV2ZW50 OjpjcmVhdGUocGxhdGZvcm1FdmVudCwgY29yZUZyYW1lLT5kb2N1bWVudCgpLT5kZWZhdWx0Vmll dygpKTsKKyAgICB9CisgICAgY2FzZSBOU0tleVVwOgorICAgICAgICByZXR1cm4gS2V5Ym9hcmRF dmVudDo6Y3JlYXRlKGV2ZW50LCBjb3JlRnJhbWUtPmRvY3VtZW50KCktPmRlZmF1bHRWaWV3KCkp OworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiAwOworICAgIH0KK30KKwogLSAoQk9PTCli ZWNvbWVGaXJzdFJlc3BvbmRlcgogewogICAgIE5TU2VsZWN0aW9uRGlyZWN0aW9uIGRpcmVjdGlv biA9IE5TRGlyZWN0U2VsZWN0aW9uOwpAQCAtMzcyMSw3ICszNzQwLDcgQEAgLSAoQk9PTCliZWNv bWVGaXJzdFJlc3BvbmRlcgogICAgIGlmIChEb2N1bWVudCogZG9jdW1lbnQgPSBmcmFtZS0+ZG9j dW1lbnQoKSkKICAgICAgICAgZG9jdW1lbnQtPnNldEZvY3VzZWROb2RlKDApOwogICAgIHBhZ2Ut PmZvY3VzQ29udHJvbGxlcigpLT5zZXRJbml0aWFsRm9jdXMoZGlyZWN0aW9uID09IE5TU2VsZWN0 aW5nTmV4dCA/IEZvY3VzRGlyZWN0aW9uRm9yd2FyZCA6IEZvY3VzRGlyZWN0aW9uQmFja3dhcmQs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmcmFtZS0+ZXZl bnRIYW5kbGVyKCktPmN1cnJlbnRLZXlib2FyZEV2ZW50KCkuZ2V0KCkpOworICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3VycmVudEtleWJvYXJkRXZlbnQoZnJh bWUpLmdldCgpKTsKICAgICByZXR1cm4gWUVTOwogfQogCg==