<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>59798</bug_id>
          
          <creation_ts>2011-04-29 09:09:56 -0700</creation_ts>
          <short_desc>Implement FULLSCREEN_API on Windows, Part 4: Enable it</short_desc>
          <delta_ts>2011-05-03 23:25:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>59785</dependson>
    
    <dependson>59845</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jer Noble">jer.noble</reporter>
          <assigned_to name="Jer Noble">jer.noble</assigned_to>
          <cc>aroben</cc>
    
    <cc>buildbot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>395291</commentid>
    <comment_count>0</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-29 09:09:56 -0700</bug_when>
    <thetext>Implement FULLSCREEN_API on Windows, Part 4: Enable it</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>395326</commentid>
    <comment_count>1</comment_count>
      <attachid>91694</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-29 10:15:40 -0700</bug_when>
    <thetext>Created attachment 91694
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>395512</commentid>
    <comment_count>2</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-04-29 14:23:25 -0700</bug_when>
    <thetext>Attachment 91694 did not build on win:
Build output: http://queues.webkit.org/results/8525190</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>395711</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-04-29 18:48:06 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Attachment 91694 [details] did not build on win:
&gt; Build output: http://queues.webkit.org/results/8525190

Uh-oh!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>395717</commentid>
    <comment_count>4</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-29 18:58:13 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; Attachment 91694 [details] [details] did not build on win:
&gt; &gt; Build output: http://queues.webkit.org/results/8525190
&gt; 
&gt; Uh-oh!

We may have to kick the builders when this patch goes in, if the scripts don&apos;t regenerate the UserAgentStyleSheetsData.cpp file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>395723</commentid>
    <comment_count>5</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-29 19:01:21 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; Attachment 91694 [details] [details] [details] did not build on win:
&gt; &gt; &gt; Build output: http://queues.webkit.org/results/8525190
&gt; &gt; 
&gt; &gt; Uh-oh!
&gt; 
&gt; We may have to kick the builders when this patch goes in, if the scripts don&apos;t regenerate the UserAgentStyleSheetsData.cpp file.

I&apos;ll make a inconsequential change to the fullscreen.css file; that should &quot;encourage&quot; the DerivedSources.make file that it needs to rebuild UserAgentStyleSheetsData.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>395927</commentid>
    <comment_count>6</comment_count>
      <attachid>91694</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-05-01 09:51:14 -0700</bug_when>
    <thetext>Comment on attachment 91694
Patch

Ok.  I assume this is dependent on earlier patches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>396019</commentid>
    <comment_count>7</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-05-01 13:28:03 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 91694 [details])
&gt; Ok.  I assume this is dependent on earlier patches.

It sure is. :)   Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397713</commentid>
    <comment_count>8</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-05-03 23:25:52 -0700</bug_when>
    <thetext>Committed r85719: &lt;http://trac.webkit.org/changeset/85719&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>91694</attachid>
            <date>2011-04-29 10:15:40 -0700</date>
            <delta_ts>2011-05-01 09:51:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-59798-20110429101540.patch</filename>
            <type>text/plain</type>
            <size>3595</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODUzMjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDI5
ZmEyNTFhZjNhYWU5OTkyZjU4OWNlNjFiM2FmMDA4NjEzYmQ0YzAuLmIwZjI2NjRmOTU2ODg0NjQ5
NGRlNjVlMTY4NWUyYTUwYzM1YmE3MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDEyIEBACisyMDExLTA0LTI5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVu
dCBGVUxMU0NSRUVOX0FQSSBvbiBXaW5kb3dzLCBQYXJ0IDQ6IEVuYWJsZSBpdAorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk3OTgKKworICAgICAgICAq
IHd0Zi9QbGF0Zm9ybS5oOiBTZXQgRU5BQkxFX0ZVTExTQ1JFRU5fQVBJIG9uIHdpbi4KKwogMjAx
MS0wNC0yOCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk
IGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxh
dGZvcm0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA0YTZi
YTlkNjg5Yjg4Y2Y4NzFjZmY5OTNkMWE2YjJlNjM4ODZlMDIxLi5jNWNmZTZlODJkNzdmZDNjOGY2
NGQ1NjQ5ZmI0ZmU5OTkxYzUxYzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
d3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o
CkBAIC03MDUsNiArNzA1LDEwIEBACiAjZGVmaW5lIEVOQUJMRV9XRUJfQVJDSElWRSAxCiAjZW5k
aWYKIAorI2lmIFBMQVRGT1JNKFdJTikgJiYgIU9TKFdJTkNFKSAmJiAhUExBVEZPUk0oQ0hST01J
VU0pICYmICFkZWZpbmVkKFdJTl9DQUlSTykgJiYgIVBMQVRGT1JNKFFUKQorI2RlZmluZSBFTkFC
TEVfRlVMTFNDUkVFTl9BUEkgMQorI2VuZGlmCisKICNpZiBQTEFURk9STShXWCkKICNkZWZpbmUg
RU5BQkxFX0FTU0VNQkxFUiAxCiAjZGVmaW5lIEVOQUJMRV9HTE9CQUxfRkFTVE1BTExPQ19ORVcg
MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv
Q2hhbmdlTG9nCmluZGV4IGI5ZWZkZGFkNTkzMjIxNzMyNzk4Mjc0ZTA1MDg0NDQ0MjJkNzI4ZDUu
LmI5Y2ZlYjE2ZTNkOTg1MjZjNGRkODg2ODI3ZjAyYTIyZjRmN2Y5ZjUgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxMyBAQAorMjAxMS0wNC0yOSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNv
bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBs
ZW1lbnQgRlVMTFNDUkVFTl9BUEkgb24gV2luZG93cywgUGFydCA0OiBFbmFibGUgaXQKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Nzk4CisKKyAgICAg
ICAgKiBXZWJDb3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvajogQWRkIG1pc3NpbmcgZnVsbCBzY3Jl
ZW4gcmVsYXRlZAorICAgICAgICAgICAgZmlsZXMgdG8gdGhlIHByb2plY3QuCisKIDIwMTEtMDQt
MjkgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll
d2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJD
b3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvaiBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9q
L1dlYkNvcmUudmNwcm9qCmluZGV4IGFmNTNhNTM5NjMyOGUzNDU2ODM5MDY0OTA3NTM0YzJkYzQy
MGE0NzQuLmJjNmMxZmVjZDBhOTRmMmU0ZDZkMGYzZjM3YmI1OTQ5ZDI3OGJlMTQgMTAwNzU1Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmUudmNwcm9qCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmUudmNwcm9qCkBAIC0zMzkzOCw2ICsz
MzkzOCwxNCBAQAogCQkJCT4KIAkJCTwvRmlsZT4KIAkJCTxGaWxlCisJCQkJUmVsYXRpdmVQYXRo
PSIuLlxyZW5kZXJpbmdcUmVuZGVyRnVsbFNjcmVlbi5jcHAiCisJCQkJPgorCQkJPC9GaWxlPgor
CQkJPEZpbGUKKwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXHJlbmRlcmluZ1xSZW5kZXJGdWxsU2NyZWVu
LmgiCisJCQkJPgorCQkJPC9GaWxlPgorCQkJPEZpbGUKIAkJCQlSZWxhdGl2ZVBhdGg9Ii4uXHJl
bmRlcmluZ1xSZW5kZXJIVE1MQ2FudmFzLmNwcCIKIAkJCQk+CiAJCQkJPEZpbGVDb25maWd1cmF0
aW9uCmRpZmYgLS1naXQgYS9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nIGIvV2ViS2l0TGlicmFy
aWVzL0NoYW5nZUxvZwppbmRleCA5Y2RkY2QwMmQ1MGQ1NDE5YzFjYzU2NDczOWRiOTk2ZjM1MjBk
NGY2Li4zYTAxOTIzYzNiNmQ5N2MxZTc5YzlkNTc2OGYyN2VjMDcxMzkxNmRhIDEwMDY0NAotLS0g
YS9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdExpYnJhcmllcy9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wNC0yOSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw
cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBJbXBsZW1lbnQgRlVMTFNDUkVFTl9BUEkgb24gV2luZG93cywgUGFydCA0OiBFbmFibGUgaXQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Nzk4CisK
KyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy52c3Byb3BzOiBTZXQg
RU5BQkxFX0ZVTExTQ1JFRU5fQVBJIHRvIHRydWUuCisKIDIwMTEtMDQtMjggIERhdmlkIExldmlu
ICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu
CmRpZmYgLS1naXQgYS9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURl
ZmluZXMudnNwcm9wcyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJl
RGVmaW5lcy52c3Byb3BzCmluZGV4IGE2NGZkMjk5NDY1MTU1MDc0MTk3YzU4NGNjYWY0NGEzMjRj
YjI3NTcuLjdmNjQ2MThhNTExMWQwMDg4OWI5NjA0ZTYxYTFhMDhiZjdjYWJhYzUgMTAwNjQ0Ci0t
LSBhL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy52c3By
b3BzCisrKyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5l
cy52c3Byb3BzCkBAIC05OCw3ICs5OCw3IEBACiAJLz4KICAgPFVzZXJNYWNybwogCQlOYW1lPSJF
TkFCTEVfRlVMTFNDUkVFTl9BUEkiCi0JCVZhbHVlPSIiCisJCVZhbHVlPSJFTkFCTEVfRlVMTFND
UkVFTl9BUEkiCiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKIAkvPgogICA8VXNlck1h
Y3JvCg==
</data>
<flag name="review"
          id="84558"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="84713"
          type_id="3"
          status="-"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>