59779 2011-04-28 22:35:07 -0700 Fix IR->SR typo in enum value (and resulting style fails) 2011-04-29 09:15:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mikelawther mikelawther commit-queue oldest_to_newest 395117 0 mikelawther 2011-04-28 22:35:07 -0700 Fix IR->SR typo in enum value (and resulting style fails) 395118 1 91638 mikelawther 2011-04-28 22:35:57 -0700 Created attachment 91638 Patch 395120 2 mikelawther 2011-04-28 22:37:10 -0700 The real fix here is the typo between the ImageRendering and ShapeRendering enum values. I also de-dented the case statements to fix the resulting style fails. 395280 3 91638 ojan 2011-04-29 08:45:16 -0700 Comment on attachment 91638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91638&action=review Code change looks fine. Please write a layout test if it's possible. If it's not possible, feel free to remark cq?. > Source/WebCore/css/CSSPrimitiveValueMappings.h:2918 > + case SR_AUTO: > + m_value.ident = CSSValueAuto; > + break; > + case SR_OPTIMIZESPEED: Is it not possible to write a layout test that tests these values? It would be nice to see a test go green here if possible. 395281 4 91638 ojan 2011-04-29 08:46:22 -0700 Comment on attachment 91638 Patch Oh. nm. I see now that the enum values are actually the same. 395293 5 91638 commit-queue 2011-04-29 09:15:47 -0700 Comment on attachment 91638 Patch Clearing flags on attachment: 91638 Committed r85327: <http://trac.webkit.org/changeset/85327> 395294 6 commit-queue 2011-04-29 09:15:52 -0700 All reviewed patches have been landed. Closing bug. 91638 2011-04-28 22:35:57 -0700 2011-04-29 09:15:47 -0700 Patch bug-59779-20110429153554.patch text/plain 2830 mikelawther U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYzgzZmFhYjE1M2ZiODg3 ODlmNWM0NzhmNDFjNjE3ZDJjMTNkZmZjLi5kOTM2MzllMGJmMzA2NmEyZDMwYWFkNDNmNzFiMDM1 NzJkN2MzZDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjggIE1pa2Ug TGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggSVItPlNSIHR5cG8gaW4gZW51bSB2YWx1 ZSAoYW5kIHJlc3VsdGluZyBzdHlsZSBmYWlscykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Nzc5CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSBj aGFuZ2UsIHNvIG5vIG5ldyB0ZXN0cworCisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVl TWFwcGluZ3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmlt aXRpdmVWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6b3BlcmF0 b3IgRVNoYXBlUmVuZGVyaW5nKToKKwogMjAxMS0wNC0yNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2Fy ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKaW5kZXggMzRmZjky NjMzOTdlOWY5ZGU5ZTczNTM4NzIyOGQ2ZTA4ZmJhNzEwMy4uNGNmYzUxZTQ1ODdiM2MyNGE5YWZi OWQ5MTgxZWZhYmI3YTA5MThmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1By aW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0 aXZlVmFsdWVNYXBwaW5ncy5oCkBAIC0yOTEyLDM1ICsyOTEyLDM1IEBAIHRlbXBsYXRlPD4gaW5s aW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZShFU2hhcGVSZW5kZXJpbmcg ZSkKICAgICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKIHsKICAgICBzd2l0Y2ggKGUpIHsK LSAgICAgICAgY2FzZSBJUl9BVVRPOgotICAgICAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1Zh bHVlQXV0bzsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIElSX09QVElNSVpFU1BF RUQ6Ci0gICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVPcHRpbWl6ZXNwZWVkOwot ICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgU1JfQ1JJU1BFREdFUzoKLSAgICAgICAg ICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZUNyaXNwZWRnZXM7Ci0gICAgICAgICAgICBicmVh azsKLSAgICAgICAgY2FzZSBTUl9HRU9NRVRSSUNQUkVDSVNJT046Ci0gICAgICAgICAgICBtX3Zh bHVlLmlkZW50ID0gQ1NTVmFsdWVHZW9tZXRyaWNwcmVjaXNpb247Ci0gICAgICAgICAgICBicmVh azsKKyAgICBjYXNlIFNSX0FVVE86CisgICAgICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZUF1 dG87CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgU1JfT1BUSU1JWkVTUEVFRDoKKyAgICAgICAg bV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlT3B0aW1pemVzcGVlZDsKKyAgICAgICAgYnJlYWs7Cisg ICAgY2FzZSBTUl9DUklTUEVER0VTOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVD cmlzcGVkZ2VzOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFNSX0dFT01FVFJJQ1BSRUNJU0lP TjoKKyAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlR2VvbWV0cmljcHJlY2lzaW9uOwor ICAgICAgICBicmVhazsKICAgICB9CiB9CiAKIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2 ZVZhbHVlOjpvcGVyYXRvciBFU2hhcGVSZW5kZXJpbmcoKSBjb25zdAogewogICAgIHN3aXRjaCAo bV92YWx1ZS5pZGVudCkgewotICAgICAgICBjYXNlIENTU1ZhbHVlQXV0bzoKLSAgICAgICAgICAg IHJldHVybiBTUl9BVVRPOwotICAgICAgICBjYXNlIENTU1ZhbHVlT3B0aW1pemVzcGVlZDoKLSAg ICAgICAgICAgIHJldHVybiBTUl9PUFRJTUlaRVNQRUVEOwotICAgICAgICBjYXNlIENTU1ZhbHVl Q3Jpc3BlZGdlczoKLSAgICAgICAgICAgIHJldHVybiBTUl9DUklTUEVER0VTOwotICAgICAgICBj YXNlIENTU1ZhbHVlR2VvbWV0cmljcHJlY2lzaW9uOgotICAgICAgICAgICAgcmV0dXJuIFNSX0dF T01FVFJJQ1BSRUNJU0lPTjsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOwotICAgICAgICAgICAgcmV0dXJuIFNSX0FVVE87CisgICAgY2FzZSBDU1NW YWx1ZUF1dG86CisgICAgICAgIHJldHVybiBTUl9BVVRPOworICAgIGNhc2UgQ1NTVmFsdWVPcHRp bWl6ZXNwZWVkOgorICAgICAgICByZXR1cm4gU1JfT1BUSU1JWkVTUEVFRDsKKyAgICBjYXNlIENT U1ZhbHVlQ3Jpc3BlZGdlczoKKyAgICAgICAgcmV0dXJuIFNSX0NSSVNQRURHRVM7CisgICAgY2Fz ZSBDU1NWYWx1ZUdlb21ldHJpY3ByZWNpc2lvbjoKKyAgICAgICAgcmV0dXJuIFNSX0dFT01FVFJJ Q1BSRUNJU0lPTjsKKyAgICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICAgICAgcmV0dXJuIFNSX0FVVE87CiAgICAgfQogfQogCg==