59776 2011-04-28 22:07:15 -0700 Sometimes WebKit2 pauses during launch due to waiting for the first render 2011-06-18 12:28:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED P2 Normal --- 1 slewis webkit-unassigned darin slewis webkit.review.bot oldest_to_newest 395102 0 slewis 2011-04-28 22:07:15 -0700 Since the WebProcess is just going to send us a blank page until they have rendered the first time we shouldn't pause and wait for their update. Instead we should continue to paint a blank window until the WebProcess has sent us the new bits. 395106 1 91635 slewis 2011-04-28 22:17:18 -0700 Created attachment 91635 first patch 395107 2 webkit.review.bot 2011-04-28 22:19:01 -0700 Attachment 91635 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:80: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 395300 3 91635 darin 2011-04-29 09:34:19 -0700 Comment on attachment 91635 first patch View in context: https://bugs.webkit.org/attachment.cgi?id=91635&action=review >> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:80 >> + if(!m_hasReceivedFirstUpdate) > > Missing space before ( in if( [whitespace/parens] [5] I agree with the style bot. > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:188 > + else if (!m_hasReceivedFirstUpdate) > + m_hasReceivedFirstUpdate = true; No need for the if statement here. You don’t have to check a boolean is false before setting it to true. > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:102 > + // For the first draw, don't draw anything until the WebProcess has sent over the bits. This comment says “for the first draw”, but the code affects more than just the first draw, right? 395525 4 slewis 2011-04-29 14:38:10 -0700 > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:102 > + // For the first draw, don't draw anything until the WebProcess has sent over the bits. This comment says “for the first draw”, but the code affects more than just the first draw, right? I should have said the first substantial draw or the first draw with content. 423173 5 darin 2011-06-18 12:28:52 -0700 http://trac.webkit.org/changeset/85359 91635 2011-04-28 22:17:18 -0700 2011-04-29 09:34:19 -0700 first patch PausedDrawing.txt text/plain 4052 slewis SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MzAyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMjggIFN0ZXBoYW5p ZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU5Nzc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85Mjg3MTEzPiBSRUdSRVNTSU9OOiBT YWZhcmkgY29sZC93YXJtIGxhdW5jaCB0aW1lIDE1JSB0byAyeCByZWdyZXNzaW9uCisgICAgICAg IE9uIHRoZSBmaXJzdCBkcmF3IHRoZSBXZWJQcm9jZXNzIGlzIGp1c3QgZ29pbmcgdG8gc2VuZCB1 cyBibGFuayBiaXRzIGFueXdheSBzbyBkb24ndCAKKyAgICAgICAgcGF1c2Ugd2FpdGluZyBmb3Ig dGhlIHVwZGF0ZS4gIENvbnRpbnVlIGRyYXdpbmcgYSBibGFuayB3aW5kb3cgdW50aWwgdGhlIFdl YlByb2Nlc3MKKyAgICAgICAgc2VuZHMgdXMgdGhlIHVwZGF0ZS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdB cmVhUHJveHlJbXBsOjpEcmF3aW5nQXJlYVByb3h5SW1wbCk6CisgICAgICAgIChXZWJLaXQ6OkRy YXdpbmdBcmVhUHJveHlJbXBsOjpwYWludCk6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVh UHJveHlJbXBsOjpkaWRVcGRhdGVCYWNraW5nU3RvcmVTdGF0ZSk6CisgICAgICAgIChXZWJLaXQ6 OkRyYXdpbmdBcmVhUHJveHlJbXBsOjpzZW5kVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5oOgorCiAyMDExLTA0LTI4ICBE YXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJv eHlJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2lu Z0FyZWFQcm94eUltcGwuY3BwCShyZXZpc2lvbiA4NDc4MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDYg KzQ4LDcgQEAgRHJhd2luZ0FyZWFQcm94eUltcGw6OkRyYXdpbmdBcmVhUHJveHlJbQogICAgICwg bV9jdXJyZW50QmFja2luZ1N0b3JlU3RhdGVJRCgwKQogICAgICwgbV9uZXh0QmFja2luZ1N0b3Jl U3RhdGVJRCgwKQogICAgICwgbV9pc1dhaXRpbmdGb3JEaWRVcGRhdGVCYWNraW5nU3RvcmVTdGF0 ZShmYWxzZSkKKyAgICAsIG1faGFzUmVjZWl2ZWRGaXJzdFVwZGF0ZShmYWxzZSkKICAgICAsIG1f aXNCYWNraW5nU3RvcmVEaXNjYXJkYWJsZSh0cnVlKQogICAgICwgbV9kaXNjYXJkQmFja2luZ1N0 b3JlVGltZXIoUnVuTG9vcDo6Y3VycmVudCgpLCB0aGlzLCAmRHJhd2luZ0FyZWFQcm94eUltcGw6 OmRpc2NhcmRCYWNraW5nU3RvcmUpCiB7CkBAIC03NSw2ICs3NiwxMCBAQCB2b2lkIERyYXdpbmdB cmVhUHJveHlJbXBsOjpwYWludChCYWNraW5nCiAgICAgICAgIC8vIGl0IGFib3V0IG91ciBuZXh0 IHN0YXRlIGJ1dCBkaWRuJ3QgcmVxdWVzdCBhbiBpbW1lZGlhdGUgdXBkYXRlLgogICAgICAgICBz ZW5kVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUoUmVzcG9uZEltbWVkaWF0ZWx5KTsKIAorICAgICAg ICAvLyBJZiB3ZSBoYXZlbid0IHlldCByZWNlaXZlZCBvdXIgZmlyc3QgYml0cyBmcm9tIHRoZSBX ZWJQcm9jZXNzIHRoZW4gZG9uJ3QgcGFpbnQgYW55dGhpbmcuCisgICAgICAgIGlmKCFtX2hhc1Jl Y2VpdmVkRmlyc3RVcGRhdGUpCisgICAgICAgICAgICByZXR1cm47ICAgICAgICAKKyAgICAgICAg CiAgICAgICAgIGlmIChtX2lzV2FpdGluZ0ZvckRpZFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlKSB7 CiAgICAgICAgICAgICAvLyBXYWl0IGZvciBhIERpZFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlIG1l c3NhZ2UgdGhhdCBjb250YWlucyB0aGUgbmV3IGJpdHMgYmVmb3JlIHdlIHBhaW50CiAgICAgICAg ICAgICAvLyB3aGF0J3MgY3VycmVudGx5IGluIHRoZSBiYWNraW5nIHN0b3JlLgpAQCAtMTc5LDYg KzE4NCw4IEBAIHZvaWQgRHJhd2luZ0FyZWFQcm94eUltcGw6OmRpZFVwZGF0ZUJhY2sKIAogICAg IGlmIChtX25leHRCYWNraW5nU3RvcmVTdGF0ZUlEICE9IG1fY3VycmVudEJhY2tpbmdTdG9yZVN0 YXRlSUQpCiAgICAgICAgIHNlbmRVcGRhdGVCYWNraW5nU3RvcmVTdGF0ZShSZXNwb25kSW1tZWRp YXRlbHkpOworICAgIGVsc2UgaWYgKCFtX2hhc1JlY2VpdmVkRmlyc3RVcGRhdGUpCisgICAgICAg IG1faGFzUmVjZWl2ZWRGaXJzdFVwZGF0ZSA9IHRydWU7CiAKICNpZiBVU0UoQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpCiAgICAgaWYgKGxheWVyVHJlZUNvbnRleHQgIT0gbV9sYXllclRyZWVDb250 ZXh0KSB7CkBAIC0yNzgsNyArMjg1LDcgQEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6c2Vu ZFVwZGF0ZUJhYwogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmICht X2lzV2FpdGluZ0ZvckRpZFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlICYmICFtX2xheWVyVHJlZUNv bnRleHQuaXNFbXB0eSgpKSB7Ci0gICAgICAgIC8vIFdhaXQgZm9yIHRoZSBEaWRVcGRhdGVCYWNr aW5nU3RvcmVTdGF0ZSBtZXNzYWdlLiBOb3JtYWxseSB3ZSBkb24gdGhpcyBpbiBEcmF3aW5nQXJl YVByb3h5SW1wbDo6cGFpbnQsIGJ1dCB0aGF0CisgICAgICAgIC8vIFdhaXQgZm9yIHRoZSBEaWRV cGRhdGVCYWNraW5nU3RvcmVTdGF0ZSBtZXNzYWdlLiBOb3JtYWxseSB3ZSBkbyB0aGlzIGluIERy YXdpbmdBcmVhUHJveHlJbXBsOjpwYWludCwgYnV0IHRoYXQKICAgICAgICAgLy8gZnVuY3Rpb24g aXMgbmV2ZXIgY2FsbGVkIHdoZW4gaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZS4KICAg ICAgICAgd2FpdEZvckFuZERpc3BhdGNoRGlkVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUoKTsKICAg ICB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eUltcGwuaAkocmV2aXNpb24gODQ3ODMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJh d2luZ0FyZWFQcm94eUltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtOTgsNiArOTgsOSBAQCBwcml2 YXRlOgogICAgIC8vIFdoZXRoZXIgd2UndmUgc2VudCBhIFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRl IG1lc3NhZ2UgYW5kIGFyZSBub3cgd2FpdGluZyBmb3IgYSBEaWRVcGRhdGVCYWNraW5nU3RvcmVT dGF0ZSBtZXNzYWdlLgogICAgIC8vIFVzZWQgdG8gdGhyb3R0bGUgVXBkYXRlQmFja2luZ1N0b3Jl U3RhdGUgbWVzc2FnZXMgc28gd2UgZG9uJ3Qgc2VuZCB0aGVtIGZhc3RlciB0aGFuIHRoZSBXZWIg cHJvY2VzcyBjYW4gaGFuZGxlLgogICAgIGJvb2wgbV9pc1dhaXRpbmdGb3JEaWRVcGRhdGVCYWNr aW5nU3RvcmVTdGF0ZTsKKyAgICAKKyAgICAvLyBGb3IgdGhlIGZpcnN0IGRyYXcsIGRvbid0IGRy YXcgYW55dGhpbmcgdW50aWwgdGhlIFdlYlByb2Nlc3MgaGFzIHNlbnQgb3ZlciB0aGUgYml0cy4K KyAgICBib29sIG1faGFzUmVjZWl2ZWRGaXJzdFVwZGF0ZTsKIAogICAgIGJvb2wgbV9pc0JhY2tp bmdTdG9yZURpc2NhcmRhYmxlOwogICAgIE93blB0cjxCYWNraW5nU3RvcmU+IG1fYmFja2luZ1N0 b3JlOwo=